Temporary dsiable Operation Too Large Exception 20/137720/1 master
authorToineSiebelink <toine.siebelink@est.tech>
Fri, 19 Apr 2024 09:25:01 +0000 (10:25 +0100)
committerToineSiebelink <toine.siebelink@est.tech>
Fri, 19 Apr 2024 09:25:01 +0000 (10:25 +0100)
- settign limit to 50000 to efftively disable it
- ericsson is not ready and wil infrom us when it can be enabled again

Issue-ID: CPS-2164
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ib1a8308a20bd77fcba9c4c9fc94739d5dd731b1f

cps-ncmp-rest/src/main/java/org/onap/cps/ncmp/rest/controller/handlers/NcmpPassthroughResourceRequestHandler.java
cps-ncmp-rest/src/test/groovy/org/onap/cps/ncmp/rest/controller/handlers/NcmpDatastoreRequestHandlerSpec.groovy

index eca7ebf..64497b9 100644 (file)
@@ -46,7 +46,7 @@ public class NcmpPassthroughResourceRequestHandler extends NcmpDatastoreRequestH
 
     private static final Object noReturn = null;
 
-    private static final int MAXIMUM_CM_HANDLES_PER_OPERATION = 50;
+    private static final int MAXIMUM_CM_HANDLES_PER_OPERATION = 50000;
 
     private static final String PAYLOAD_TOO_LARGE_TEMPLATE = "Operation '%s' affects too many (%d) cm handles";
 
index aef37c9..1585616 100644 (file)
@@ -143,14 +143,15 @@ class NcmpDatastoreRequestHandlerSpec extends Specification {
 
     def 'Attempt to execute async data operation request with too many cm handles.'() {
         given: 'a data operation definition with too many cm handles'
-            def cmHandleIds = new String[51]
+            def tooMany = objectUnderTest.MAXIMUM_CM_HANDLES_PER_OPERATION+1
+            def cmHandleIds = new String[tooMany]
             def dataOperationDefinition = new DataOperationDefinition(operationId: 'abc', operation: 'read', datastore: 'ncmp-datastore:passthrough-running', cmHandleIds: cmHandleIds)
         when: 'data operation request is executed'
             objectUnderTest.executeRequest('someTopic', new DataOperationRequest(dataOperationDefinitions:[dataOperationDefinition]), NO_AUTH_HEADER)
         then: 'a payload too large exception is thrown'
             def exceptionThrown = thrown(PayloadTooLargeException)
         and: 'the error message contains the offending number of cm handles'
-            assert exceptionThrown.message == "Operation 'abc' affects too many (51) cm handles"
+            assert exceptionThrown.message == "Operation 'abc' affects too many (${tooMany}) cm handles"
     }
 
 }