Reduce number of parameters in constructor

[portal.git] / ecomp-portal-BE-common / src / test / java / org / onap / portalapp / portal / transport / ExternalRoleDescriptionTest.java

diff --git a/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/transport/ExternalRoleDescriptionTest.java b/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/transport/ExternalRoleDescriptionTest.java
index 63d230f..41ee7fd 100644 (file)
--- a/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/transport/ExternalRoleDescriptionTest.java
+++ b/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/transport/ExternalRoleDescriptionTest.java
@@ -2,7 +2,7 @@
  * ============LICENSE_START==========================================
  * ONAP Portal
  * ===================================================================
- * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
@@ -38,35 +38,31 @@
 package org.onap.portalapp.portal.transport;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
 import org.junit.Test;
-import org.onap.portalapp.portal.transport.ExternalRoleDescription;
 
 public class ExternalRoleDescriptionTest {
 
-       public ExternalRoleDescription mockExternalRoleDescription(){
-               
-               ExternalRoleDescription externalRoleDescription = new ExternalRoleDescription();
-                           
-           externalRoleDescription.setId("test");
-           externalRoleDescription.setName("test");
-           externalRoleDescription.setActive("test");
-           externalRoleDescription.setPriority("test");
-           externalRoleDescription.setAppId("test");
-           externalRoleDescription.setAppRoleId("test");
-           
-               return externalRoleDescription;
-       }
+       private static final String TEST="test";
        
        @Test
        public void externalRoleDescriptionTest(){
-               ExternalRoleDescription externalRoleDescription = mockExternalRoleDescription();
-               
-               assertEquals(externalRoleDescription.getId(), "test");
-               assertEquals(externalRoleDescription.getName(), "test");
-               assertEquals(externalRoleDescription.getActive(), "test");
-               assertEquals(externalRoleDescription.getPriority(), "test");
-               assertEquals(externalRoleDescription.getAppId(), "test");
-               assertEquals(externalRoleDescription.getAppRoleId(), "test");
+               ExternalRoleDescription extRole=mockExternalRoleDescription();
+               ExternalRoleDescription externalRoleDescription = new ExternalRoleDescription();
+                   externalRoleDescription.setName(extRole.getName());
+               assertEquals(externalRoleDescription.getName(), TEST);
+               assertEquals(externalRoleDescription.hashCode(), extRole.hashCode());
+               assertTrue(externalRoleDescription.equals(extRole));
+               externalRoleDescription.setName(null);
+               assertFalse(externalRoleDescription.equals(extRole));
        }
+       private ExternalRoleDescription mockExternalRoleDescription(){
+               ExternalRoleDescription externalRoleDescription = new ExternalRoleDescription();
+           externalRoleDescription.setName(TEST);
+               return externalRoleDescription;
+       }
+       
+       
 }