Code Review
/
vvp
/
validation-scripts.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
[VVP] add decorators to test cases
[vvp/validation-scripts.git]
/
ice_validator
/
tests
/
test_unique_resources_across_all_templates.py
diff --git
a/ice_validator/tests/test_unique_resources_across_all_templates.py
b/ice_validator/tests/test_unique_resources_across_all_templates.py
index
13b4121
..
2d05147
100644
(file)
--- a/
ice_validator/tests/test_unique_resources_across_all_templates.py
+++ b/
ice_validator/tests/test_unique_resources_across_all_templates.py
@@
-37,10
+37,12
@@
#
# ECOMP is a trademark and service mark of AT&T Intellectual Property.
#
#
# ECOMP is a trademark and service mark of AT&T Intellectual Property.
#
-
+from .helpers import validates
import yaml
import yaml
+import collections
+@validates('R-16447')
def test_unique_resources_across_all_yaml_files(yaml_files):
'''
Check that all instance names are unique
def test_unique_resources_across_all_yaml_files(yaml_files):
'''
Check that all instance names are unique
@@
-54,4
+56,8
@@
def test_unique_resources_across_all_yaml_files(yaml_files):
continue
resources_ids.extend(yml['resources'].keys())
continue
resources_ids.extend(yml['resources'].keys())
- assert len(resources_ids) == len(set(resources_ids))
+ dup_ids = [item
+ for item, count in collections.Counter(resources_ids).items()
+ if count > 1]
+
+ assert not dup_ids