2 # ============LICENSE_START=======================================================
3 # org.onap.vvp/validation-scripts
4 # ===================================================================
5 # Copyright © 2019 AT&T Intellectual Property. All rights reserved.
6 # ===================================================================
8 # Unless otherwise specified, all software contained herein is licensed
9 # under the Apache License, Version 2.0 (the "License");
10 # you may not use this software except in compliance with the License.
11 # You may obtain a copy of the License at
13 # http://www.apache.org/licenses/LICENSE-2.0
15 # Unless required by applicable law or agreed to in writing, software
16 # distributed under the License is distributed on an "AS IS" BASIS,
17 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
18 # See the License for the specific language governing permissions and
19 # limitations under the License.
23 # Unless otherwise specified, all documentation contained herein is licensed
24 # under the Creative Commons License, Attribution 4.0 Intl. (the "License");
25 # you may not use this documentation except in compliance with the License.
26 # You may obtain a copy of the License at
28 # https://creativecommons.org/licenses/by/4.0/
30 # Unless required by applicable law or agreed to in writing, documentation
31 # distributed under the License is distributed on an "AS IS" BASIS,
32 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
33 # See the License for the specific language governing permissions and
34 # limitations under the License.
36 # ============LICENSE_END============================================
41 from tests import cached_yaml as yaml
42 from .utils.vm_types import get_vm_type_for_nova_server
45 def test_volume_resource_ids(heat_template):
47 Check that all resource ids for cinder volumes follow the right
48 naming convention to include the {vm_type} of the
49 nova server it is associated to
51 with open(heat_template) as fh:
54 # skip if resources are not defined
55 if "resources" not in yml:
56 pytest.skip("No resources specified in the heat template")
58 volume_pattern = re.compile(r"(.+?)_volume_id_\d+")
59 resources = yml["resources"]
62 for k, v in resources.items():
63 if not isinstance(v, dict):
67 if v["type"] not in ["OS::Nova::Server", "OS::Cinder::VolumeAttachment"]:
70 if v["type"] == "OS::Nova::Server":
71 # check block_device_mapping and make sure the right
73 if "properties" not in v:
75 if "block_device_mapping" not in v["properties"]:
78 vm_type = get_vm_type_for_nova_server(v)
81 vm_type = vm_type.lower()
83 # get the volume_id from the block_device_mapping
84 properties = v["properties"]
85 for v2 in properties["block_device_mapping"]:
86 for k3, v3 in v2.items():
89 if not isinstance(v3, dict):
92 volume_id = v3.get("get_param") or v3.get("get_resource")
95 if isinstance(volume_id, list):
96 volume_id = volume_id[0].lower()
98 volume_id = volume_id.lower()
100 if vm_type + "_" not in volume_id:
101 invalid_volumes.append(volume_id)
103 elif v["type"] == "OS::Cinder::VolumeAttachment":
104 # check the volume attachment and the {vm_type}
105 # of the corresponding nova server
106 if "properties" not in v:
108 if "volume_id" not in v["properties"]:
110 if "instance_uuid" not in v["properties"]:
113 properties = v["properties"]
115 # get the instance_uuid and when applicable
116 # the nova server instance
120 if "get_param" in properties["instance_uuid"]:
122 elif "get_resource" in properties["instance_uuid"]:
123 instance_uuid = properties["instance_uuid"]["get_resource"]
124 if not resources[instance_uuid]:
126 nova_server = resources[instance_uuid]
127 instance_uuid = instance_uuid.lower()
133 volume_id = properties["volume_id"].get("get_param") or properties[
135 ].get("get_resource")
138 if isinstance(volume_id, list):
139 volume_id = volume_id[0].lower()
141 volume_id = volume_id.lower()
143 # do not test the case when the instance_uuid and
144 # volume_id are not defined
145 if not instance_uuid and not volume_id:
149 vm_type = get_vm_type_for_nova_server(nova_server)
152 vm_type = vm_type.lower()
153 if vm_type + "_" not in volume_id:
154 invalid_volumes.append(volume_id)
156 # extract the assumed {vm_type} from volume_id
157 m = volume_pattern.match(volume_id)
159 vm_type = m.group(1).lower()
160 if vm_type + "_" not in instance_uuid:
161 invalid_volumes.append(volume_id)
165 msg = "The following volumes have invalid resource IDs: {}".format(
166 ", ".join(invalid_volumes)
168 assert not set(invalid_volumes), msg