2 # ============LICENSE_START=======================================================
3 # org.onap.vvp/validation-scripts
4 # ===================================================================
5 # Copyright © 2017 AT&T Intellectual Property. All rights reserved.
6 # ===================================================================
8 # Unless otherwise specified, all software contained herein is licensed
9 # under the Apache License, Version 2.0 (the "License");
10 # you may not use this software except in compliance with the License.
11 # You may obtain a copy of the License at
13 # http://www.apache.org/licenses/LICENSE-2.0
15 # Unless required by applicable law or agreed to in writing, software
16 # distributed under the License is distributed on an "AS IS" BASIS,
17 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
18 # See the License for the specific language governing permissions and
19 # limitations under the License.
23 # Unless otherwise specified, all documentation contained herein is licensed
24 # under the Creative Commons License, Attribution 4.0 Intl. (the "License");
25 # you may not use this documentation except in compliance with the License.
26 # You may obtain a copy of the License at
28 # https://creativecommons.org/licenses/by/4.0/
30 # Unless required by applicable law or agreed to in writing, documentation
31 # distributed under the License is distributed on an "AS IS" BASIS,
32 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
33 # See the License for the specific language governing permissions and
34 # limitations under the License.
36 # ============LICENSE_END============================================
38 # ECOMP is a trademark and service mark of AT&T Intellectual Property.
44 from tests import cached_yaml as yaml
46 from .utils.vm_types import get_vm_type_for_nova_server
49 def test_volume_resource_ids(heat_template):
51 Check that all resource ids for cinder volumes follow the right
52 naming convention to include the {vm_type} of the
53 nova server it is associated to
55 with open(heat_template) as fh:
58 # skip if resources are not defined
59 if "resources" not in yml:
60 pytest.skip("No resources specified in the heat template")
62 volume_pattern = re.compile(r"(.+?)_volume_id_\d+")
63 resources = yml["resources"]
66 for k, v in resources.items():
67 if not isinstance(v, dict):
71 if v["type"] not in ["OS::Nova::Server", "OS::Cinder::VolumeAttachment"]:
74 if v["type"] == "OS::Nova::Server":
75 # check block_device_mapping and make sure the right
77 if "properties" not in v:
79 if "block_device_mapping" not in v["properties"]:
82 vm_type = get_vm_type_for_nova_server(v)
85 vm_type = vm_type.lower()
87 # get the volume_id from the block_device_mapping
88 properties = v["properties"]
89 for v2 in properties["block_device_mapping"]:
90 for k3, v3 in v2.items():
93 if not isinstance(v3, dict):
96 volume_id = v3.get("get_param") or v3.get("get_resource")
99 if isinstance(volume_id, list):
100 volume_id = volume_id[0].lower()
102 volume_id = volume_id.lower()
104 if vm_type + "_" not in volume_id:
105 invalid_volumes.append(volume_id)
107 elif v["type"] == "OS::Cinder::VolumeAttachment":
108 # check the volume attachment and the {vm_type}
109 # of the corresponding nova server
110 if "properties" not in v:
112 if "volume_id" not in v["properties"]:
114 if "instance_uuid" not in v["properties"]:
117 properties = v["properties"]
119 # get the instance_uuid and when applicable
120 # the nova server instance
124 if "get_param" in properties["instance_uuid"]:
126 elif "get_resource" in properties["instance_uuid"]:
127 instance_uuid = properties["instance_uuid"]["get_resource"]
128 if not resources[instance_uuid]:
130 nova_server = resources[instance_uuid]
131 instance_uuid = instance_uuid.lower()
137 volume_id = properties["volume_id"].get("get_param") or properties[
139 ].get("get_resource")
142 if isinstance(volume_id, list):
143 volume_id = volume_id[0].lower()
145 volume_id = volume_id.lower()
147 # do not test the case when the instance_uuid and
148 # volume_id are not defined
149 if not instance_uuid and not volume_id:
153 vm_type = get_vm_type_for_nova_server(nova_server)
156 vm_type = vm_type.lower()
157 if vm_type + "_" not in volume_id:
158 invalid_volumes.append(volume_id)
160 # extract the assumed {vm_type} from volume_id
161 m = volume_pattern.match(volume_id)
163 vm_type = m.group(1).lower()
164 if vm_type + "_" not in instance_uuid:
165 invalid_volumes.append(volume_id)
169 msg = "The following volumes have invalid resource IDs: {}".format(
170 ", ".join(invalid_volumes)
172 assert not set(invalid_volumes), msg