2 # ============LICENSE_START=======================================================
3 # org.onap.vvp/validation-scripts
4 # ===================================================================
5 # Copyright © 2018 AT&T Intellectual Property. All rights reserved.
6 # ===================================================================
8 # Unless otherwise specified, all software contained herein is licensed
9 # under the Apache License, Version 2.0 (the "License");
10 # you may not use this software except in compliance with the License.
11 # You may obtain a copy of the License at
13 # http://www.apache.org/licenses/LICENSE-2.0
15 # Unless required by applicable law or agreed to in writing, software
16 # distributed under the License is distributed on an "AS IS" BASIS,
17 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
18 # See the License for the specific language governing permissions and
19 # limitations under the License.
23 # Unless otherwise specified, all documentation contained herein is licensed
24 # under the Creative Commons License, Attribution 4.0 Intl. (the "License");
25 # you may not use this documentation except in compliance with the License.
26 # You may obtain a copy of the License at
28 # https://creativecommons.org/licenses/by/4.0/
30 # Unless required by applicable law or agreed to in writing, documentation
31 # distributed under the License is distributed on an "AS IS" BASIS,
32 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
33 # See the License for the specific language governing permissions and
34 # limitations under the License.
36 # ============LICENSE_END============================================
38 # ECOMP is a trademark and service mark of AT&T Intellectual Property.
44 from .helpers import validates
45 from .utils.vm_types import get_vm_type_for_nova_server
46 from .utils.network_roles import (
47 get_network_role_from_port,
48 get_network_type_from_port,
49 property_uses_get_resource,
66 def test_port_resource_ids(heat_template):
68 Check that all resource ids for ports follow the right
69 naming convention to include the {vm_type} of the
70 nova server it is associated to and also contains the
71 {network_role} of the network it is associated with
73 with open(heat_template) as fh:
76 # skip if resources are not defined
77 if "resources" not in yml:
78 pytest.skip("No resources specified in the heat template")
81 "internal": re.compile(r"(.+?)_\d+_int_(.+?)_port_\d+"),
82 "external": re.compile(r"(.+?)_\d+_(.+?)_port_\d+"),
84 resources = yml["resources"]
87 for k, v in resources.items():
88 if not isinstance(v, dict):
92 if v["type"] not in "OS::Nova::Server":
94 if "properties" not in v:
96 if "networks" not in v["properties"]:
100 has_network_role = True
103 vm_type = get_vm_type_for_nova_server(v)
106 vm_type = vm_type.lower()
108 # get all ports associated with the nova server
109 properties = v["properties"]
110 for v2 in properties["networks"]:
111 for k3, v3 in v2.items():
114 if not isinstance(v3, dict):
117 if "get_param" in v3:
119 elif "get_resource" in v3:
120 port_id = v3["get_resource"]
121 if not resources[port_id]:
123 port_resource = resources[port_id]
124 port_id = port_id.lower()
128 has_vm_type = vm_type + "_" in port_id
129 has_network_role = False
132 if property_uses_get_resource(v, "network"):
134 network_role = get_network_role_from_port(port_resource)
137 network_role = network_role.lower()
139 network_type = get_network_type_from_port(port_resource)
143 if port_patterns[network_type].match(port_id):
144 has_network_role = True
146 # match the assumed naming convention for ports
147 # if the specified port is provided via get_param
148 network_type = "external"
149 if "int_" in port_id:
150 network_type = "internal"
151 if port_patterns[network_type].match(port_id):
152 has_network_role = True
154 if has_vm_type and has_network_role:
156 invalid_ports.append(port_id)
158 assert not set(invalid_ports)