From c66f5bcac351c595e94046cfe70fd982257b2db3 Mon Sep 17 00:00:00 2001 From: Ezhilarasi Date: Thu, 3 Oct 2019 19:50:11 +0530 Subject: [PATCH] Sonarfix in structures.py Reduced cognitive complexity Change-Id: I2f435ba1d5980405fed66bfb1e4f4ad543b0ba4e Issue-ID: VVP-286 Signed-off-by: Ezhilarasi --- ice_validator/tests/structures.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/ice_validator/tests/structures.py b/ice_validator/tests/structures.py index 0223bc3..a435246 100644 --- a/ice_validator/tests/structures.py +++ b/ice_validator/tests/structures.py @@ -252,15 +252,19 @@ class ContrailV2NetworkFlavorBaseProcessor(HeatProcessor): network_flavor = cls.network_flavor_internal else: p = param.get("get_param") - if isinstance(p, str): - if "_int_" in p or p.startswith("int_"): - network_flavor = cls.network_flavor_internal - elif "_subint_" in p: - network_flavor = cls.network_flavor_subint - else: - network_flavor = cls.network_flavor_external + network_flavor = cls.get_network_format(p) return network_flavor + @classmethod + def get_network_format(cls, param): + if isinstance(param, str): + if "_int_" in param or param.startswith("int_"): + return cls.network_flavor_internal + elif "_subint_" in param: + return cls.network_flavor_subint + else: + return cls.network_flavor_external + class ContrailV2InstanceIpProcessor(ContrailV2NetworkFlavorBaseProcessor): """ ContrailV2 InstanceIp -- 2.16.6