From 2d04106b17f879fb4318bd79fd40b3314090f843 Mon Sep 17 00:00:00 2001 From: "stark, steven" Date: Thu, 2 May 2019 08:26:54 -0700 Subject: [PATCH] [VVP] relaxing test_contrail_fqdn Test now only validates if using get_param. This allows connecting to internal networks via get_resource, get_attr, etc.. Change-Id: Ib0e9f014b62669aec48d8421a6de97a919126fd6 Issue-ID: VVP-191 Signed-off-by: stark, steven --- .../fixtures/test_contrail_fqdn/pass/pass0.yaml | 20 +++++++++++++++----- ice_validator/tests/test_contrail_fqdn.py | 5 +++++ 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/ice_validator/tests/fixtures/test_contrail_fqdn/pass/pass0.yaml b/ice_validator/tests/fixtures/test_contrail_fqdn/pass/pass0.yaml index 81faeb2..5d61de5 100644 --- a/ice_validator/tests/fixtures/test_contrail_fqdn/pass/pass0.yaml +++ b/ice_validator/tests/fixtures/test_contrail_fqdn/pass/pass0.yaml @@ -40,16 +40,26 @@ --- parameters: - bialy_net_fqdn: + oam_net_fqdn: + type: string + huey: + type: string + dewey: type: string resources: - vm_typeX_0_bialy_port_2: + fw_0_oam_vmi_0: + type: OS::ContrailV2::VirtualMachineInterface + properties: + virtual_network_refs: + - get_param: oam_net_fqdn + + fw_0_int_internal_vmi_0: type: OS::ContrailV2::VirtualMachineInterface properties: virtual_network_refs: - - get_param: huey - - get_param: dewey - - get_param: bialy_net_fqdn + - get_resource: { int_internal_network } + int_internal_network: + type: OS::Neutron::Net diff --git a/ice_validator/tests/test_contrail_fqdn.py b/ice_validator/tests/test_contrail_fqdn.py index f90553f..178ce8d 100644 --- a/ice_validator/tests/test_contrail_fqdn.py +++ b/ice_validator/tests/test_contrail_fqdn.py @@ -108,6 +108,11 @@ def validate_virtual_network_refs(heat, virtual_network_refs, network_role): expect = "%s_net_fqdn" % network_role for vn_ref in virtual_network_refs: param = heat.nested_get(vn_ref, "get_param") + + # skip if not connecting via get_param + if not param: + return None + if param == expect: param_type = heat.nested_get(heat.parameters, param, "type") if param_type != "string": -- 2.16.6