Remove unnecessary check for pytest.skip

Issue-ID: VVP-288
Change-Id: I1c099ce6450401d324a6beb16256e758d83dd44a
Signed-off-by: anushadasari <danush10@in.ibm.com>

change if bad to assert not bad, message

eliminates if statement

Issue-ID: VVP-295
Change-Id: Ifa4a6cbaf79bfcab089fe9da4893aac661d70230
Signed-off-by: anushadasari <danush10@in.ibm.com>

Merge "[VVP] Fix issue floating IP params for R-35666"

Merge "[VVP] Handle intrinsic functions in prop_iterator"

Merge "Remove unnecessary check for pytest.skip"

Merge "Skip unnecessary resource/pytest.skip check"

[VVP] Fix issue floating IP params for R-35666

Change-Id: I5071958a0709ad2d9606eea8ab90247b6a3283b8
Issue-ID: VVP-340
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Handle intrinsic functions in prop_iterator

Change-Id: I68131190f84b60276c56ad140d16a3792b764fdc
Issue-ID: VVP-336
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] updating oparent version to 2.1.0

Issue-ID: VVP-324
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: I0f661d015b6382b66b1e4658c27119cf67765e98

Remove unnecessary check for pytest.skip

Issue-ID: VVP-290
Change-Id: I81a67dc0a2574dd3bea2a1b86d4cc3f6644c28b2
Signed-off-by: anushadasari <danush10@in.ibm.com>

Skip unnecessary resource/pytest.skip check

Issue-ID: VVP-295
Change-Id: Ia8b367859f4bbf9bc4366d2574f082ace863ef15
Signed-off-by: anushadasari <danush10@in.ibm.com>

Sonar fix for vvp 291 and 292

Issue-ID: VVP-291

Change-Id: I4d2eebbb9d4d96b17cc09a5de34e95e41cb9ec7d
Signed-off-by: Mamtha <mamtha.sabesan@in.ibm.com>

[VVP] Make Preload Generation more reslient to failures

Ensure that errors during preload do not prevent validation
report creation

Issue-ID: VVP-335
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>
Change-Id: I0cfd411b6a034422e349b96c462e68a4f0ceb876

[VVP] Allow any_of and all_of in categories decorator

Change-Id: I76ff9ebd7108d2ef19a3f167c5a253a3ce5f07f7
Issue-ID: VVP-331
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Support any_of in categories decorator

If specified, then the test will be selected if any of the passed
categories from the command line are in the tests categories.  This
is different than the default behavior where all categories must
match

Change-Id: Iee08556d6c07eac2663ff2ff2e89bcd7a18cd392
Issue-ID: VVP-330
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Flag duplicate parameters in .env files

Also some minor tweaks to preload generation so it doesn't fail on
partial heat templates

Change-Id: If39288dde645b0b53a338e7672336807ffa1b6d7
Issue-ID: VVP-284
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Enforce R-35666 by ensuring a network exists for int_ parameters

Implements a basic sanity check that if parameters match the internal
network naming convention, then we ensure the network itself was
defined in a heat template.

Change-Id: I37c84e2c62745a51a90dd60f0aaeb213d784f003
Issue-ID: VVP-327
Signed-off-by: Lovett, Trevor (tl2972) <trevor.lovett@att.com>

[VVP] Bug fix if resource value is hardcoded

If the property value isn't a dictionary than the test run crashes

Issue-ID: VVP-313
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: I926bc233909db245d5a051035f26fefaa39b5ede

Merge "Refactor function to reduce Cognitive Complexity"

Merge "Sonarfix in structures.py"

Reduced coginitive compexity from 16 to 15

Change-Id: I416e39f80ede88365b748a2c5c4d46f439a79dd1
Issue-ID: VVP-313
Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>

Sonarfix in structures.py

Reduced cognitive complexity
Change-Id: I2f435ba1d5980405fed66bfb1e4f4ad543b0ba4e
Issue-ID: VVP-286
Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>

Refactor function to reduce Cognitive Complexity

Issue-ID: VVP-314
Change-Id: I0843dde3cc01ef2efbb08a282b93c5e3414a1cd2
Signed-off-by: anushadasari <danush10@in.ibm.com>

Merge "Sonarfix: Reduce cognitive complexity"

Merge "Sonarfix: Reduced cognitive compexity"

Merge "[VVP] updating release version to 5.0.1"

Merge "Reduce cognitive complexity"

Merge "Sonarfix: Reduce cognitive complexity"

Sonarfix: Reduce cognitive complexity

Reduced cognitive complexity in validate_metadata method
Change-Id: I195971985214f54a44c56a2e425825251a91c83b
Issue-ID: VVP-294
Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>

reduce cognitive complexity

Reduce cognitive complexity in test_network_format.py
Change-Id: I6f42192988f7b3361479b66740e287b8f9e6d887
Issue-ID: VVP-313
Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>

Sonarfix: Reduced cognitive compexity

Reduced cognitive compexity by replacing if conditions
Change-Id: If198c2b82dd132c343bbe9db8cd3064750998785
Issue-ID: VVP-287
Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>

[VVP] updating release version to 5.0.1

Issue-ID: VVP-305
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: I5c07583d9e1286f4f3ca2290e7ead6c11ade173d

[VVP] updating version, adding releases folder

Issue-ID: VVP-305
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: I818c14325a5bcc274eef6359730738b028d85b97

Sonarfix: Reduce cognitive complexity

Change-Id: I18a9802c643f778c2aedb658848c091ff8a1587c
Issue-ID: VVP-296
Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>

Reduce cognitive complexity

Sonar fix to reduce cognitive complexity in method test_vm_type_assignments_on_nova_servers_only_use_get_param
Change-Id: I52d78ee4252cee5a6406406bc60629583ac0bfa3
Issue-ID: VVP-293
Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>

Merge "added Is_nova_server method to helpers"

Merge "[VVP] Misc tweaks and fixes to preload generation"

[VVP] Misc tweaks and fixes to preload generation

* Use VALUE_FOR if value is still CHANGE me in .env file
* Fix issues with improper parameters being put in VNF parameters in
  the preload
* Fix issue where lists of parameter values pulled from env file could
  only be put in one template
* Exclude platform provided parameters from VNF parameters in preload
* Fixed issues with parameter validations
* Updated heat requirements
* implemented missing test for new requirement that all incremental
  modules must have a nova server

Issue-ID: VVP-312
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>
Change-Id: I1a1225097544b690fb9b854c8a3d9e036f694d6a

[VVP] Removed additional f-string for build-upload issue

Also made heat req't json and req't mapping optional in checks.py

Change-Id: I38367e768de704cca3727bccb8f8bcdb04f9b193
Issue-ID: VVP-311
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] removing Information.txt from test csar files

Issue-ID: VVP-311
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: I09275cb10ce59f0dcde506dc5594e586766e20d0

Merge "[VVP] Replaced test.csar in preload_tests"

[VVP] Replaced test.csar in preload_tests

Issue-ID: VVP-311
Change-Id: I8b669a31511348a70915ccc91be597b8df097ae2
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

added Is_nova_server method to helpers

Added is_nova_server check to helpers to remove coginitve complexity in
test files
Change-Id: I20e68730947cc6472d693eca782bbee36a3c9e1b
Issue-ID: VVP-285
Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>

[VVP] Only install black on py 3.6 and up

Issue-ID: VVP-310

Change-Id: I352773d923c0cd4a7a8cc146504520031ebb32e8
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Ensure Sonar coverage executes all tests

Today the Sonar coverage is only exercising the --self-tests which
excludes the tests written for other functionality such as GUIs,
helpers, and preload generation.  This change will ensure all tests
are executed by both verify jobs and Sonar coverage

Issue-ID: VVP-251

Change-Id: I291b578aef477bfaaa9d8d061c5b8a23614d514a
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

Enforce black code format via pre-commit hook

Issue-ID: VVP-203

Change-Id: If0de5b4bc1be0c9514decea1f4ff6f5ec79dc41b
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

Fixed GUI not saving users' prior settings

Change-Id: Id495e291ef6fe9f8ff024decfe27220a32e727ba
Issue-ID: VVP-298
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Preload Generation Enhancements and Fixes

- All values flow to preload env templates (availability
  zones were not)
- defaults.yaml should be in preload_env (includes vnf_name)
- Ensure SDC Model Identifiers are documented in VNF API format
  (ex: vnf-type, etc.)
- Ensure CSAR is used in VNF and GR API where appropriate and available
- Flag populated preload templates with _incomplete when they are not
  fully resolved
- If a value is still set to CHANGEME in the preload env, then revert
  to the original VALUE FOR from the blank preload template
- Ensure app_tests/preload_tests/sample_heat passes all vvp validations
- Added missing depedency (bandit) to requirements.txt

Change-Id: Idf1d5e6e5237debcf3e94bed5fcf7c15e41c9e82
Issue-ID: VVP-283
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

Sonar issue fix in helpers.py

Change-Id: Ief18c717974498ea9b5f1fd2e2987db0d013b732
Issue-ID: VVP-172
Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>

Sonarfix:Reduce coginitive complexity vmtype util

Change-Id: I4b82df8587b98a142e86031700f8c73e922184d5
Issue-ID: VVP-172
Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>

[VVP] Generated completed preload from env files

User can supply an optional directory containing .env files and/or
CSAR VSP which can be used to generate populated preloads in the
requested format.

The nested directories can be used to create sub-environments that
inherit their settings from the parent directories.

Optionally, values can be specified in a defaults.yaml and they will
be used if that value is not defined in the .env file.  This is useful
if the parameter name and value will be the same in all modules.

Issue-ID: VVP-278

Change-Id: Icd9846c63463537793db908be8ce5dba13c4bda3
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] test_environment_file_parameters violation fix

test_environment_file_parameters check for environment violation is checking the wrong variable.

Also doesn't handle environment files with no parameters gracefully.

Issue-ID: VVP-267
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: I9fbedbb5af4c045037131a7e7a7ca7f6c8febb14

Merge "[VVP] Adding preload generation functionality"

[VVP] Adding preload generation functionality

preload.py discovers and loads implementations of
AbstractPreloadGenerator from any module on sys.path prefixed with
preload_*

Initial support is provided for VNF-API and GR-API.  The templates
will provide a guide for users to provide their values.

Known limitations:
- No support for Contrail.  Preload will be created, but contrail
  parameters will be skipped. This will be addressed in the future.

Issue-ID: VVP-227
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: I081d50ac379062fbf1bffebd687e920220d32571
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>
Signed-off-by: Lovett, Trevor (tl2972) <tl2972@att.com>

VNFRQTS - Update the rst table content

Issue-ID: VNFRQTS-651

Signed-off-by: Hagop Bozawglanian <hagop.bozawglanian@att.com>
Change-Id: If4f535004e78cf3abaf0113eda3cbfa4e562fba1

Merge "[VVP] All http URLs in requirement link"

[VVP] All http URLs in requirement link

Issue-ID: VVP-249

Change-Id: Ibfb8ccf735a8eaa29a6f1b1f6b2fbfd72d562feb
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Fixed ParameterCollector nested get_param

Issue-ID: VVP-248

Change-Id: I27d95c763cafe6d262ea8f6c03fbb3a7ba0f64dc
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

Merge "[VVP] Fixed issue in unused parameter detection"

Merge "[VVP] Tox support for installing Win pre-built libraries"

[VVP] Fixed issue in unused parameter detection

Issue-ID: VVP-247

Change-Id: I02e2da52fdfa31a1d056b9839063373453c8ace7
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Updating dependencies (except pytest)

Bringing most dependencies to current except pytest which
will require changes to how self-test generates tests.

Will address that in a future release

Issue-ID: VVP-245

Change-Id: I20171ede15740087992b68e245dd9881d0bc5c78
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Tox support for installing Win pre-built libraries

Issue-ID: VVP-246

Change-Id: I4d416435423e69951e3c5d9154b60829984a9fb7
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

Merge "[VVP] updating oparent version"

Merge "[VVP] Adding bandit security scans and fixes"

[VVP] Adding bandit security scans and fixes

Issue-ID: VVP-244

Change-Id: Ia782f4cc7bf5a379ff8cdcce96cd2e7235998345
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] updating oparent version

Issue-ID: VVP-242
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: I206f0227a9602763bdfbebb04671d7644a408fd6

[VVP] Update AZ tests to not apply to nested templates

Issue-ID: VVP-226

Change-Id: I91e97b1b73daf6be83c227ff2deeeb4e72213ed5
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Properly escape error messages in HTML output

Issue-ID: VVP-159

Change-Id: I741e5abbc80fbcbbb5d7c0332e13217305532bfd
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Modifies uses_sr_iov function in structures.py to return sr_iov true when vnic_type=direct

Issue-ID: VVP-231

Signed-off-by: Lokur, Manish <manish.shivakumar.lokur@att.com>
Change-Id: I9b42d682f9cca0b8ae68746c5472cf7903933558

[VVP-230] Modified test_non_server_name_unique for non-server name uniqueness check
Used heat_template argument which loops through for each base template
Created a list of base and it's nested templates for the test

Issue-ID: VVP-230

Signed-off-by: Lokur, Manish <manish.shivakumar.lokur@att.com>
Change-Id: I84d14ed61ac79d83894a47a79954f4ce8ac1615e

[VVP] Bug fix in conftest.py
Relatived Path function failed if the value is an empty string.

Issue-ID: VVP-229

Signed-off-by: Lokur, Manish <manish.shivakumar.lokur@att.com>
Change-Id: I811234cfc7c3c438bd8934568a3ccbb02bac013a

Merge "[VVP] Added support to display terms and force acceptance if desired"

[VVP] Added support to display terms and force acceptance if desired

Issue-ID: VVP-195
Signed-off-by: Lovett, Trevor (tl2972) <tl2972@att.com>
Change-Id: Ia66e8deabdb5945a2acc7dc5a652ffdb2429945e

Merge "[VVP] Allow multi-line error messages on error reports"

[VVP] Allow multi-line error messages on error reports

Issue-ID: VVP-225
Signed-off-by: Lovett, Trevor (tl2972) <tl2972@att.com>
Change-Id: Iebee13d29f8025b3dd5c147f2024a484789464f7

Merge "[VVP] Fix redundant errors: missing base module or nested dirs"

Merge "[VVP] Improved readability of reports"

[VVP] Fix redundant errors: missing base module or nested dirs

Change-Id: I50f9f3f0bd627124a679248b2cf630e818755c59
Issue-ID: VVP-218
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Improved readability of reports

- Removed resolution steps from all reports
- Added error number to all reports
- Only show base file names
- Add auto-filter to excel reports
- Shift test ID to right-most column of Excel
- Removed raw output from Excel and CSV

Change-Id: Ic022b0a14d53fbeab591def631b8743228e1d5c0
Issue-ID: VVP-184
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Adding resource ID to error message

Issue-ID: VVP-224

Signed-off-by: Lokur, Manish <manish.shivakumar.lokur@att.com>
Change-Id: I36f5033220593ea574d96c991fb1a07994089ef4

Merge "[VVP] removed fixtures for the deleted tests"

Merge "[VVP] Removed yamllint library"

[VVP] Removed yamllint library

Change-Id: If2c26b8650e8aba0a183d0cf47b1b3744dbfaf95
Issue-ID: VVP-201
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] removed fixtures for the deleted tests

Issue-ID: VVP-223

Change-Id: I00def826ff322fa9ae6d308c1107e3cac659e061
Signed-off-by: Lokur, Manish <manish.shivakumar.lokur@att.com>

[VVP] removing duplicate test from vvp
Issue-ID: VVP-223

Signed-off-by: aarjvi,desai <aarjvi.desai@att.com>
Change-Id: Iee4c666085cbe6fbef3ab37d2d85c9984b88f1d8

Merge "[VVP] Performance Enhancements (report generation and test collection)"

[VVP] Performance Enhancements (report generation and test collection)

Issue-ID: VVP-222

Signed-off-by: Lovett, Trevor (tl2972) <tl2972@att.com>
Change-Id: I9dd3506097cb0d6e69bd1434b2d42f6d1965023b

[VVP] updating dockerfile for with heat dependencies

Issue-ID: VVP-221
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: Ie7cdcdbff0cf04d29808d8167b08f568b7d88e69

[VVP] Exempt output section from nested get_param check

Change-Id: Ib87b0fb1c70c5689fc7687a21a27ea60934096b1
Issue-ID: VVP-220
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

Merge "[VVP] Refine nested get_param test per R-10834 update"

[VVP] Refine nested get_param test per R-10834 update

R-10834 was updated via VNFRQTS-646 to better reflect SDC's level of
support

Change-Id: I5232e7dc88c8c20f076788abf368bf33f4f1e1cb
Issue-ID: VVP-219
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] adding heat template-validate test

Issue-ID: VVP-218
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: If88f9b4b620aaffe61ead3b6f7d5c74dcfd14cba

[VVP] updating version and pom for elalto release

Issue-ID: VVP-210
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: If9443595db21f229f9e52ff2e591fd7be979ac1e

[VVP] Update validations based on VNFRQTS-637

Update to the latest bundled requirements text
Update aap_exempt message to better reflect verbiage
Remove unneeded test: tests_neutron_port_addresses (requirement removed)
Map aap_exempt requirement to associated tests

Also adding new helper scripts to help detect divergences between
VNF Requirements and VVP as well as other VVP best practices:

checks.py - Pre-commit checks
- requirements are up-to-date with VNFRQTS
- all testable requirements have tests
- all non-testable requirements are *not* mapped to tests
- flake8 passes
- self-test passes

update_reqs.py - Updates the the contents of heat_requirements.json
with latest req'ts from VNFRQTS Nexus artifact

Change-Id: Ia197de3254a1a0369224939f66a5f98c601a314d
Issue-ID: VVP-216
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Add test for R-100260 and fix mapping

Re-arranged some helper and util functions to more logical locations.

Added test to verify than an internal subnet parameter used in an
incremental module is defined in the base module.

Change-Id: I20369396b18820f0e321c0e75bd47446b0a7a39f
Issue-ID: VVP-215
Signed-off-by: Lovett, Trevor (tl2972) <tl2972@att.com>

[VVP] R-100280, R-100290, and aap_exempt support

Change-Id: I732af13a22e8c1dadc5fbf622a6efd102146262b
Issue-ID: VVP-214
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Adding env file checks for contrail

* Introduced helper method get_param to handle extracting param
  names from both get_params with string and list arguments
* Moved test files for environment tests to independent directories
  to make it easier to isolate unit tests
* Added contrail tests related to env file usage related to VNFRQTS-630

Change-Id: I3b44f0ce2d5657e9ab5290cd77f1422b36052b6a
Issue-ID: VVP-213
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

[VVP] Adding tests for new reqs from VNFRQTS-630

Added tests for reqs:
R-100010, R-100030, R-100050, R-100070, R-100090, R-100110,
R-100130, R-100150, R-100200, R-100220, R-100240, R-100310,
R-100330, R-100360, R-100370, R-100260, R-100000, R-100190,
R-100350

Updated neutron param tests to re-use validation code for contrail tests

Change-Id: I84af725ca9de176dc690fffda01ffcad453213ea
Issue-ID: VVP-211
Signed-off-by: stark, steven <steven.stark@att.com>

[VVP] updating version in pom and versions.py

- version # is now representative of the official ONAP release version

Change-Id: I4dcf6190c427c5092b00a237fa6dc6b9f0fc73f8
Issue-ID: VVP-209
Signed-off-by: stark, steven <steven.stark@att.com>