From: Ezhilarasi <ezhrajam@in.ibm.com>
Date: Thu, 3 Oct 2019 14:52:47 +0000 (+0530)
Subject: Reduced coginitive compexity from 16 to 15
X-Git-Tag: 6.0.0~34
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=vvp%2Fvalidation-scripts.git;a=commitdiff_plain;h=98d86269d797a390b9e47d41383d0744ea858837

Reduced coginitive compexity from 16 to 15

Change-Id: I416e39f80ede88365b748a2c5c4d46f439a79dd1
Issue-ID: VVP-313
Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>
---

diff --git a/ice_validator/tests/test_network_format.py b/ice_validator/tests/test_network_format.py
index e360795..de8115d 100644
--- a/ice_validator/tests/test_network_format.py
+++ b/ice_validator/tests/test_network_format.py
@@ -112,11 +112,11 @@ def test_network_has_subnet(yaml_file):
         networks.append(k)
 
     for k, v in yml["resources"].items():
-        if not has_properties(v) and v.get("type") != "OS::Neutron::Subnet":
-            continue
         network_prop = v.get("properties", {}).get("network", {}).get("get_resource")
-
-        if not network_prop:
+        if (
+            not has_properties(v) and v.get("type") != "OS::Neutron::Subnet"
+            and not network_prop
+        ):
             continue
         x = 0
         for network in networks: