Reduced coginitive compexity from 16 to 15 82/96582/3
authorEzhilarasi <ezhrajam@in.ibm.com>
Thu, 3 Oct 2019 14:52:47 +0000 (20:22 +0530)
committerEzhilarasi R <ezhrajam@in.ibm.com>
Fri, 4 Oct 2019 10:04:43 +0000 (10:04 +0000)
Change-Id: I416e39f80ede88365b748a2c5c4d46f439a79dd1
Issue-ID: VVP-313
Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>
ice_validator/tests/test_network_format.py

index e360795..de8115d 100644 (file)
@@ -112,11 +112,11 @@ def test_network_has_subnet(yaml_file):
         networks.append(k)
 
     for k, v in yml["resources"].items():
-        if not has_properties(v) and v.get("type") != "OS::Neutron::Subnet":
-            continue
         network_prop = v.get("properties", {}).get("network", {}).get("get_resource")
-
-        if not network_prop:
+        if (
+            not has_properties(v) and v.get("type") != "OS::Neutron::Subnet"
+            and not network_prop
+        ):
             continue
         x = 0
         for network in networks: