X-Git-Url: https://gerrit.onap.org/r/gitweb?p=vvp%2Fvalidation-scripts.git;a=blobdiff_plain;f=ice_validator%2Ftests%2Ftest_port_resource_ids.py;h=d5877439395fbe8ad0ea52adaefa17c6e20ab1de;hp=6bd2a4e2fbeb41cf94b6b1a800335104b1a33567;hb=3b96f670aad978447056a379085206470e61af07;hpb=0b0495cf84c2972a5a5e9ecc1bc5f0cd7ee24fe1 diff --git a/ice_validator/tests/test_port_resource_ids.py b/ice_validator/tests/test_port_resource_ids.py index 6bd2a4e..d587743 100644 --- a/ice_validator/tests/test_port_resource_ids.py +++ b/ice_validator/tests/test_port_resource_ids.py @@ -108,14 +108,22 @@ def test_port_resource_ids(yaml_file): if property_uses_get_resource(v, "network"): continue + network_role = get_network_role_from_port(port_resource) if not network_role: + invalid_ports.append( + (port_id, "Unable to determine network role for port.") + ) continue network_role = network_role.lower() network_type = get_network_type_from_port(port_resource) if not network_type: + invalid_ports.append( + (port_id, "Unable to determine network type for port (internal or external).") + ) continue + if network_type == "external": expected_r_id = r"{}_\d+_{}_port_\d+".format(vm_type, network_role) else: