X-Git-Url: https://gerrit.onap.org/r/gitweb?p=vvp%2Fvalidation-scripts.git;a=blobdiff_plain;f=ice_validator%2Ftests%2Ftest_port_resource_ids.py;h=076c4796934414f93bbcdd6768b875687ecc7f12;hp=f8f55ed746bfe6eefdbae5472880a78387968791;hb=60d5ad7d00eadd6395eca186e6fa76a43df3c6cf;hpb=fb9c5e35e22f7fe4465ea33b4e2ac85ccfd33bee diff --git a/ice_validator/tests/test_port_resource_ids.py b/ice_validator/tests/test_port_resource_ids.py index f8f55ed..076c479 100644 --- a/ice_validator/tests/test_port_resource_ids.py +++ b/ice_validator/tests/test_port_resource_ids.py @@ -2,11 +2,11 @@ # ============LICENSE_START======================================================= # org.onap.vvp/validation-scripts # =================================================================== -# Copyright © 2017 AT&T Intellectual Property. All rights reserved. +# Copyright © 2018 AT&T Intellectual Property. All rights reserved. # =================================================================== # # Unless otherwise specified, all software contained herein is licensed -# under the Apache License, Version 2.0 (the “License”); +# under the Apache License, Version 2.0 (the "License"); # you may not use this software except in compliance with the License. # You may obtain a copy of the License at # @@ -21,7 +21,7 @@ # # # Unless otherwise specified, all documentation contained herein is licensed -# under the Creative Commons License, Attribution 4.0 Intl. (the “License”); +# under the Creative Commons License, Attribution 4.0 Intl. (the "License"); # you may not use this documentation except in compliance with the License. # You may obtain a copy of the License at # @@ -39,14 +39,27 @@ # import re + import pytest -import yaml +from tests import cached_yaml as yaml + +from .helpers import validates +from .utils.network_roles import get_network_role_from_port, \ + get_network_type_from_port, \ + property_uses_get_resource from .utils.vm_types import get_vm_type_for_nova_server -from .utils.network_roles import get_network_role_from_port,\ - get_network_type_from_port,\ - property_uses_get_resource +@validates('R-69014', + 'R-05201', + 'R-68936', + 'R-32025', + 'R-11168', + 'R-84322', + 'R-96983', + 'R-26506', + 'R-20453', + 'R-26351') def test_port_resource_ids(heat_template): ''' Check that all resource ids for ports follow the right @@ -61,10 +74,8 @@ def test_port_resource_ids(heat_template): if "resources" not in yml: pytest.skip("No resources specified in the heat template") - port_patterns = { - 'internal': re.compile(r'(.+?)_\d+_int_(.+?)_port_\d+'), - 'external': re.compile(r'(.+?)_\d+_(.+?)_port_\d+'), - } + port_patterns = {'internal': re.compile(r'(.+?)_\d+_int_(.+?)_port_\d+'), + 'external': re.compile(r'(.+?)_\d+_(.+?)_port_\d+')} resources = yml['resources'] invalid_ports = [] @@ -109,7 +120,7 @@ def test_port_resource_ids(heat_template): else: continue - has_vm_type = vm_type+"_" in port_id + has_vm_type = vm_type + "_" in port_id has_network_role = False if port_resource: