X-Git-Url: https://gerrit.onap.org/r/gitweb?p=vvp%2Fvalidation-scripts.git;a=blobdiff_plain;f=ice_validator%2Ftests%2Ftest_nova_servers_vm_types_use_get_param.py;fp=ice_validator%2Ftests%2Ftest_nova_servers_vm_types_use_get_param.py;h=2be7e6f1771388b7bb085fdd564c124bf1701d38;hp=0000000000000000000000000000000000000000;hb=cc21b8b08b6dbcec577bfb26ff397ac899da8002;hpb=6755f61e44870ff65de0630a403f7b4ddfea4071 diff --git a/ice_validator/tests/test_nova_servers_vm_types_use_get_param.py b/ice_validator/tests/test_nova_servers_vm_types_use_get_param.py new file mode 100644 index 0000000..2be7e6f --- /dev/null +++ b/ice_validator/tests/test_nova_servers_vm_types_use_get_param.py @@ -0,0 +1,76 @@ +# -*- coding: utf8 -*- +# ============LICENSE_START======================================================= +# org.onap.vvp/validation-scripts +# =================================================================== +# Copyright © 2017 AT&T Intellectual Property. All rights reserved. +# =================================================================== +# +# Unless otherwise specified, all software contained herein is licensed +# under the Apache License, Version 2.0 (the “License”); +# you may not use this software except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# +# +# Unless otherwise specified, all documentation contained herein is licensed +# under the Creative Commons License, Attribution 4.0 Intl. (the “License”); +# you may not use this documentation except in compliance with the License. +# You may obtain a copy of the License at +# +# https://creativecommons.org/licenses/by/4.0/ +# +# Unless required by applicable law or agreed to in writing, documentation +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# ============LICENSE_END============================================ +# +# ECOMP is a trademark and service mark of AT&T Intellectual Property. +# + +import pytest +import yaml + + +def test_vm_type_assignments_on_nova_servers_only_use_get_param(heat_template): + ''' + Make sure all nova servers only use get_param for their properties + ''' + with open(heat_template) as fh: + yml = yaml.load(fh) + + # skip if resources are not defined + if "resources" not in yml: + pytest.skip("No resources specified in the heat template") + + key_values = ["name", "flavor", "image"] + invalid_nova_servers = [] + + for k, v in yml["resources"].items(): + if not isinstance(v, dict): + continue + if "properties" not in v: + continue + if "type" not in v: + continue + if v["type"] != "OS::Nova::Server": + continue + + for k2, v2 in v["properties"].items(): + if k2 in key_values: + if not isinstance(v2, dict): + invalid_nova_servers.append(k) + elif "get_param" not in v2: + invalid_nova_servers.append(k) + + assert not set(invalid_nova_servers)