Add precheck to inst vnf

[vfc/gvnfm/vnflcm.git] / lcm / lcm / nf / views / instantiate_vnf_view.py

diff --git a/lcm/lcm/nf/views/instantiate_vnf_view.py b/lcm/lcm/nf/views/instantiate_vnf_view.py
index fec85d1..23a979a 100644 (file)
--- a/lcm/lcm/nf/views/instantiate_vnf_view.py
+++ b/lcm/lcm/nf/views/instantiate_vnf_view.py
@@ -13,7 +13,6 @@
 # limitations under the License.\r
 \r
 import logging\r
-import traceback\r
 \r
 from drf_yasg.utils import swagger_auto_schema\r
 from lcm.nf.biz.instantiate_vnf import InstantiateVnf\r
@@ -21,11 +20,14 @@ from rest_framework import status
 from rest_framework.response import Response\r
 from rest_framework.views import APIView\r
 \r
-# from lcm.nf.serializers.serializers import InstantiateVnfRequestSerializer, InstOrTeriVnfResponseSerializer\r
 from lcm.nf.serializers.instantiate_vnf_request import InstantiateVnfRequestSerializer\r
-from lcm.nf.serializers.inst_or_teri_vnf_response import InstOrTeriVnfResponseSerializer\r
+from lcm.nf.serializers.job_identifier import JobIdentifierSerializer\r
 from lcm.pub.exceptions import NFLCMException\r
+from lcm.pub.exceptions import NFLCMExceptionNotFound\r
+from lcm.pub.exceptions import NFLCMExceptionConflict\r
 from lcm.pub.utils.jobutil import JobUtil\r
+from lcm.pub.database.models import NfInstModel\r
+from .common import view_safe_call_with_log\r
 \r
 logger = logging.getLogger(__name__)\r
 \r
@@ -34,31 +36,31 @@ class InstantiateVnfView(APIView):
     @swagger_auto_schema(\r
         request_body=InstantiateVnfRequestSerializer(),\r
         responses={\r
-            status.HTTP_202_ACCEPTED: InstOrTeriVnfResponseSerializer(),\r
+            status.HTTP_202_ACCEPTED: JobIdentifierSerializer(),\r
             status.HTTP_500_INTERNAL_SERVER_ERROR: "Internal error"\r
         }\r
     )\r
+    @view_safe_call_with_log(logger=logger)\r
     def post(self, request, instanceid):\r
         logger.debug("InstantiateVnf--post::> %s" % request.data)\r
-        try:\r
-            instantiate_vnf_request_serializer = InstantiateVnfRequestSerializer(data=request.data)\r
-            if not instantiate_vnf_request_serializer.is_valid():\r
-                raise NFLCMException(instantiate_vnf_request_serializer.errors)\r
 \r
-            job_id = JobUtil.create_job('NF', 'INSTANTIATE', instanceid)\r
-            JobUtil.add_job_status(job_id, 0, "INST_VNF_READY")\r
-            InstantiateVnf(instantiate_vnf_request_serializer.data, instanceid, job_id).start()\r
+        instantiate_vnf_request_serializer = InstantiateVnfRequestSerializer(data=request.data)\r
+        if not instantiate_vnf_request_serializer.is_valid():\r
+            raise NFLCMException(instantiate_vnf_request_serializer.errors)\r
 \r
-            instantiate_vnf_response_serializer = InstOrTeriVnfResponseSerializer(data={"jobId": job_id})\r
-            resp_isvalid = instantiate_vnf_response_serializer.is_valid()\r
-            if not resp_isvalid:\r
-                raise NFLCMException(instantiate_vnf_response_serializer.errors)\r
+        vnf_insts = NfInstModel.objects.filter(nfinstid=instanceid)\r
+        if not vnf_insts.exists():\r
+            raise NFLCMExceptionNotFound("VNF instanceid(%s) does not exist." % instanceid)\r
+        if vnf_insts[0].status == 'INSTANTIATED':\r
+            raise NFLCMExceptionConflict('VNF(%s) is already INSTANTIATED.' % instanceid)\r
 \r
-            return Response(data=instantiate_vnf_response_serializer.data, status=status.HTTP_202_ACCEPTED)\r
-        except NFLCMException as e:\r
-            logger.error(e.message)\r
-            return Response(data={'error': '%s' % e.message}, status=status.HTTP_500_INTERNAL_SERVER_ERROR)\r
-        except Exception as e:\r
-            logger.error(e.message)\r
-            logger.error(traceback.format_exc())\r
-            return Response(data={'error': 'unexpected exception'}, status=status.HTTP_500_INTERNAL_SERVER_ERROR)\r
+        job_id = JobUtil.create_job('NF', 'INSTANTIATE', instanceid)\r
+        JobUtil.add_job_status(job_id, 0, "INST_VNF_READY")\r
+        InstantiateVnf(instantiate_vnf_request_serializer.data, instanceid, job_id).start()\r
+\r
+        job_identifier_serializer = JobIdentifierSerializer(data={"jobId": job_id})\r
+        resp_isvalid = job_identifier_serializer.is_valid()\r
+        if not resp_isvalid:\r
+            raise NFLCMException(job_identifier_serializer.errors)\r
+\r
+        return Response(data=job_identifier_serializer.data, status=status.HTTP_202_ACCEPTED)\r