From 4eb30b65fcf63b3bd13f3f10bbbfed85057ded4d Mon Sep 17 00:00:00 2001 From: Michael Pruss Date: Mon, 13 Sep 2021 09:06:49 -0400 Subject: [PATCH] Update error handling for mapInfraActiveRequestToRequest Malformed instantiation requests persisted in requestdb causing orchestrationRequests API to throw ValidateException error when returning status on malformed requests. This causes the endpoint to not return any entries. To fix this, request body of malformed requests is not returned in the payload. The request status is still returned. Issue-ID: SO-3762 Change-Id: I693a81020d4f3544c915d9f431913a02849805dd Signed-off-by: Jozsef Csongvai --- .../org/onap/so/apihandlerinfra/OrchestrationRequests.java | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/OrchestrationRequests.java b/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/OrchestrationRequests.java index 99c0fc23fa..5bf33b417a 100644 --- a/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/OrchestrationRequests.java +++ b/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/OrchestrationRequests.java @@ -369,16 +369,7 @@ public class OrchestrationRequests { } } catch (IOException e) { - logger.error("Exception occurred", e); - ErrorLoggerInfo errorLoggerInfo = - new ErrorLoggerInfo.Builder(MessageEnum.APIH_REQUEST_VALIDATION_ERROR, ErrorCode.SchemaError) - .build(); - ValidateException validateException = - new ValidateException.Builder("Mapping of request to JSON object failed : ", - HttpStatus.SC_BAD_REQUEST, ErrorNumbers.SVC_BAD_PARAMETER).cause(e) - .errorInfo(errorLoggerInfo).build(); - - throw validateException; + logger.error(String.format("Failed to parse request (id: %s) : ", request.getRequestId()), e); } } request.setRequestDetails(requestDetails); -- 2.16.6