From 204d841191f2ebbc0e661a7e0592cf2be61909ac Mon Sep 17 00:00:00 2001
From: "pawel.kadlubanski" <pawel.kadlubanski@nokia.com>
Date: Fri, 16 Feb 2018 13:54:57 +0100
Subject: [PATCH] Add tests to VnfApiProvider part 1

Write test for function vnfInstanceTopologyOperation in vnfapiProvider class.
Case when VnfInstanceTopologyOperationInput is null.
Case when VnfInstanceTopologyOperationInput is not null but VnfInstanceRequestInformation is null.
Case when VnfInstanceId in VnfInstanceRequestInformation is null.

Change-Id: Icc778544a9e7a80600e54a2dcd87b77d11a23121
Issue-ID: SDNC-267
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
---
 .../org/onap/sdnc/vnfapi/VnfApiProviderTest.java   | 64 +++++++++++++++++++++-
 1 file changed, 62 insertions(+), 2 deletions(-)

diff --git a/vnfapi/provider/src/test/java/org/onap/sdnc/vnfapi/VnfApiProviderTest.java b/vnfapi/provider/src/test/java/org/onap/sdnc/vnfapi/VnfApiProviderTest.java
index b5b85f6e..7a0d5185 100644
--- a/vnfapi/provider/src/test/java/org/onap/sdnc/vnfapi/VnfApiProviderTest.java
+++ b/vnfapi/provider/src/test/java/org/onap/sdnc/vnfapi/VnfApiProviderTest.java
@@ -21,8 +21,11 @@
 
 package org.onap.sdnc.vnfapi;
 
+import org.junit.Assert;
 import org.junit.Before;
+import org.junit.Test;
 import org.mockito.Mock;
+import org.mockito.Mockito;
 import org.onap.sdnc.vnfapi.util.DataBrokerUtil;
 import org.onap.sdnc.vnfapi.util.PropBuilder;
 import org.onap.sdnc.vnfapi.util.VNFSDNSvcLogicServiceClientMockUtil;
@@ -32,6 +35,14 @@ import org.opendaylight.controller.md.sal.binding.test.AbstractConcurrentDataBro
 import org.opendaylight.controller.sal.binding.api.RpcProviderRegistry;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+import org.opendaylight.yangtools.yang.common.RpcResult;
+import org.opendaylight.yang.gen.v1.org.onap.sdnctl.vnf.rev150720.VnfInstanceTopologyOperationInput;
+import org.opendaylight.yang.gen.v1.org.onap.sdnctl.vnf.rev150720.VnfInstanceTopologyOperationOutput;
+import org.opendaylight.yang.gen.v1.org.onap.sdnctl.vnf.rev150720.VnfInstanceTopologyOperationInputBuilder;
+import org.opendaylight.yang.gen.v1.org.onap.sdnctl.vnf.rev150720.vnf.instance.request.information.VnfInstanceRequestInformation;
+import org.opendaylight.yang.gen.v1.org.onap.sdnctl.vnf.rev150720.vnf.instance.request.information.VnfInstanceRequestInformationBuilder;
+
+import java.util.concurrent.Future;
 
 
 public class VnfApiProviderTest extends AbstractConcurrentDataBrokerTest {
@@ -43,7 +54,6 @@ public class VnfApiProviderTest extends AbstractConcurrentDataBrokerTest {
     protected @Mock VNFSDNSvcLogicServiceClient mockVNFSDNSvcLogicServiceClient;
     protected static final Logger LOG = LoggerFactory.getLogger(VnfApiProvider.class);
 
-
     protected DataBrokerUtil db;
     protected VNFSDNSvcLogicServiceClientMockUtil svcClient;
 
@@ -71,5 +81,55 @@ public class VnfApiProviderTest extends AbstractConcurrentDataBrokerTest {
         return (new PropBuilder());
     }
 
+    @Test
+    public void vnfInstanceTopologyOperationInputIsNull() throws Exception {
+        VnfInstanceTopologyOperationInput input = null;
+        VnfInstanceTopologyOperationOutput result = vnfapiProvider
+                .vnfInstanceTopologyOperation(input)
+                .get()
+                .getResult();
+
+        checkVnfInstanceTopologyOperationOutput(result);
+    }
+
+
+    @Test
+    public void vnfInstanceTopologyOperationInput_VnfInstanceRequestInformationIsNull() throws Exception {
+        VnfInstanceTopologyOperationInputBuilder builder = new VnfInstanceTopologyOperationInputBuilder();
+        builder.setVnfInstanceRequestInformation(null);
 
-}
+        VnfInstanceTopologyOperationInput input = builder.build();
+        VnfInstanceTopologyOperationOutput result = vnfapiProvider
+                .vnfInstanceTopologyOperation(input)
+                .get()
+                .getResult();
+
+        checkVnfInstanceTopologyOperationOutput(result);
+    }
+
+    @Test
+    public void vnfInstanceTopologyOperationInput_getVnfInstanceRequestInformationVnfInstanceIdIsNull() throws Exception {
+        VnfInstanceTopologyOperationInputBuilder builder = new VnfInstanceTopologyOperationInputBuilder();
+        builder.setVnfInstanceRequestInformation(new VnfInstanceRequestInformationBuilder()
+            .setVnfInstanceId(null)
+             .build());
+
+        VnfInstanceTopologyOperationInput input = builder.build();
+        VnfInstanceTopologyOperationOutput result = vnfapiProvider
+                .vnfInstanceTopologyOperation(input)
+                .get()
+                .getResult();
+
+        checkVnfInstanceTopologyOperationOutput(result);
+    }
+
+    private void checkVnfInstanceTopologyOperationOutput(VnfInstanceTopologyOperationOutput result) {
+        String expectedResponseCode = "403";
+        String expectedResponseMessage = "invalid input, null or empty vnf-instance-id";
+        String expectedAckFinalIndicator = "Y";
+
+        Assert.assertEquals(result.getResponseCode(), expectedResponseCode );
+        Assert.assertEquals(result.getResponseMessage(), expectedResponseMessage);
+        Assert.assertEquals(result.getAckFinalIndicator(), expectedAckFinalIndicator);
+    }
+ }
-- 
2.16.6