sdnc/northbound.git
5 years agoFixed vnfTopoOperation vnf-id return in response 47/63047/2
shashikanth.vh [Mon, 27 Aug 2018 11:11:22 +0000 (16:41 +0530)]
Fixed vnfTopoOperation vnf-id return in response

Fixed issue vnfTopologyOperation, vnf-id not returning in response when vnf-id
is not provided as part of input

Change-Id: Iaa3b1387a45c60c27e3fdf1120e127648323e352
Issue-ID: SDNC-434
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
5 years agoUpdate swagger documentation 79/61379/1
Timoney, Dan (dt5972) [Mon, 20 Aug 2018 20:47:44 +0000 (16:47 -0400)]
Update swagger documentation

Updated swagger documentation for SDNC northbound APIs.

Change-Id: Ic3c2cb6bd6cd1bb8a732f087ee614e7969d1757b
Issue-ID: SDNC-427
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
5 years agoFixed error in Yang model 61/60961/1
Timoney, Dan (dt5972) [Thu, 16 Aug 2018 18:54:25 +0000 (14:54 -0400)]
Fixed error in Yang model

Wrong prefix used in 2 places to refer to ietf-inet-types import (prefix
defined as ietf, but reference was using inet)

Change-Id: I8a125f3ea560499487ec08250bb46aae1f209347
Issue-ID: SDNC-422
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
5 years agoRename vlan-tags in connection-point 59/60059/1
Brandon, Bruce (bb2697) [Fri, 10 Aug 2018 18:42:49 +0000 (18:42 +0000)]
Rename vlan-tags in connection-point

Rename vlan-tags to vlan-data in connection-point.  Type in original requirements.

Change-Id: I73f31588df0c9d715c46bb8adb9161d506214211
Issue-ID: SDNC-410
Signed-off-by: Brandon, Bruce (bb2697) <bb2697@att.com>
5 years agoFixed issues for connectivity attachment provider 23/59823/1
shashikanth.vh [Thu, 9 Aug 2018 09:39:29 +0000 (15:09 +0530)]
Fixed issues for connectivity attachment provider

To tryGetProperties method properties is passed as parameter
instead of params

Change-Id: I70e73ed73a1d123cefffbefae3b05a0e0c294fa0
Issue-ID: SDNC-384
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
5 years agorestore sriov-parameters 75/58975/1
Smokowski, Kevin (ks6305) [Fri, 3 Aug 2018 16:29:42 +0000 (16:29 +0000)]
restore sriov-parameters

restore sriov-parameters in generic resource yang

Change-Id: I985e8f41511444ca435d3383ed18ab8bb2d1c414
Issue-ID: SDNC-414
Signed-off-by: Smokowski, Kevin (ks6305) <ks6305@att.com>
5 years agoMerge "Add the request-action types"
Dan Timoney [Thu, 2 Aug 2018 20:54:55 +0000 (20:54 +0000)]
Merge "Add the request-action types"

5 years agoAdd the request-action types 27/58027/1
shashikanth.vh [Mon, 30 Jul 2018 12:48:39 +0000 (18:18 +0530)]
Add the request-action types

Added new request action types for existing resources-type
for CCVPN use case.

Change-Id: I2a6406fc1a763b257abb4fd9143eaa728d54f120
Issue-ID: SDNC-384
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
5 years agoCorrections for northbound 73/57573/3
gaurav [Wed, 25 Jul 2018 17:33:00 +0000 (23:03 +0530)]
Corrections for northbound

Changes includes:
1. Correcting connection-attachment topology container name.
2. Make the vnf-topology-operation implementation flexible to allow
SDNC generate vnf-id for assign/create operation rather then mandating
SO to provide it.

Change-Id: I8958a72a4ca2064b781d246e9329436848f578ad
Issue-ID: SDNC-384
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
5 years agoMerge "Add connection point and related to GR-API"
Dan Timoney [Fri, 27 Jul 2018 20:54:26 +0000 (20:54 +0000)]
Merge "Add connection point and related to GR-API"

5 years agoAdd connection point and related to GR-API 05/57905/1
Brandon, Bruce (bb2697) [Fri, 27 Jul 2018 20:03:34 +0000 (20:03 +0000)]
Add connection point and related to GR-API

Add connection point and other new structures to generic resource API Yang

Change-Id: I6f116a89ecde866d6c8e2bcd0cd4f3912da9ecad
Issue-ID: SDNC-408
Signed-off-by: Brandon, Bruce (bb2697) <bb2697@att.com>
5 years agoAdd client code to generic-resource-api 73/57873/1
Timoney, Dan (dt5972) [Fri, 27 Jul 2018 14:07:10 +0000 (10:07 -0400)]
Add client code to generic-resource-api

Add code to generate generic-resource-api client which was contributed
to sdnc/apps repo to sdnc/northbound/generic-resource-api, so that it
will automatically be updated when yang model is updated.

Change-Id: I4d36073e9771e72a2ebc38cb45f2151a88699ae6
Issue-ID: SDNC-406
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
5 years agoGeneric resource API catch up 09/57709/2
Brandon, Bruce (bb2697) [Thu, 26 Jul 2018 13:14:54 +0000 (13:14 +0000)]
Generic resource API catch up

Adding several Generic Resource API capabilities to Yang, provider, and tests

Change-Id: I9d6a3e1494ba35b2e98370ca5b2c4ff8270981af
Issue-ID: SDNC-271
Signed-off-by: Brandon, Bruce (bb2697) <bb2697@att.com>
5 years agoMerge "Add the request-action types"
Dan Timoney [Wed, 25 Jul 2018 14:45:54 +0000 (14:45 +0000)]
Merge "Add the request-action types"

5 years agoAdd the request-action types 37/57037/3
gaurav [Fri, 20 Jul 2018 09:39:58 +0000 (15:09 +0530)]
Add the request-action types

Added new request action types for existing resources-type
for CCVPN use case.

Change-Id: Ife19aa69d90ebb347e07fc9314a92fb79129064d
Issue-ID: SDNC-384
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
5 years agoAdding testcases for new allotted resource 59/57059/1
gaurav [Fri, 20 Jul 2018 15:48:38 +0000 (21:18 +0530)]
Adding testcases for new allotted resource

Addition of a testcase for new allotted resource "connectivity
attachment" to generic-resource-api schema.

Change-Id: Ibf4164132c187ce26ab253290f9f85b56d4633fd
Issue-ID: SDNC-384
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
5 years agoProvider implementation of connectivity attachment 33/57033/1
gaurav [Fri, 20 Jul 2018 09:13:57 +0000 (14:43 +0530)]
Provider implementation of connectivity attachment

Addition of a implementation of new allotted resource "connectivity
attachment" to generic-resource-api schema. Connectivity attachment
will be provided by Connectivity service and will be allotted to Site
service as part of CCVPN use case. This new allotted-resource can serve
for both SOTNAttachment and SDWANAttachment.

Change-Id: I1823249b6ab9fe315e83862abcf05be65ceded5a
Issue-ID: SDNC-384
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
5 years agoMerge "Add classifier to repo zip"
David Stilwell [Thu, 19 Jul 2018 15:24:11 +0000 (15:24 +0000)]
Merge "Add classifier to repo zip"

5 years agoAdd classifier to repo zip 15/56915/1
Timoney, Dan (dt5972) [Thu, 19 Jul 2018 14:31:52 +0000 (10:31 -0400)]
Add classifier to repo zip

Add classifier repo to zip containing jars to be installed
in ODL maven repository

Change-Id: I3bd48439afa75cf8770eb09347a81bf83ddc610e
Issue-ID: SDNC-393
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
5 years agoNew allotted resource for connectivity attachment. 95/56695/3
gaurav [Wed, 18 Jul 2018 08:41:29 +0000 (14:11 +0530)]
New allotted resource for connectivity attachment.

Addition of a new allotted resource "connectivity attachment" to
generic-resource-api schema. Connectivity attachment will be provided
by Connectivity service and will be allotted to Site service as part
of CCVPN use case. This new allotted-resource can serve for both
SOTNAttachment and SDWANAttachment.

Change-Id: Iff5ad46a72d55bc83ca36e4703d439e43fe948ce
Issue-ID: SDNC-384
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
5 years agoAdd feature aggregator for sdnc-northbound 29/56629/2
Timoney, Dan (dt5972) [Tue, 17 Jul 2018 15:23:42 +0000 (11:23 -0400)]
Add feature aggregator for sdnc-northbound

Add feature aggregator sdnc-northbound-all to install all features
from SDNC northbound repo.

Change-Id: Ibe74a5d1880fb3c62d535a7367327a1bef610c19
Issue-ID: SDNC-393
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
5 years agoRoll version for Casablanca 69/50769/1
Timoney, Dan (dt5972) [Wed, 6 Jun 2018 18:31:42 +0000 (14:31 -0400)]
Roll version for Casablanca

Roll versions for Casablanca development

Change-Id: I36526a7b5b8f1471a1d73b86b3cf996524a68f1e
Issue-ID: SDNC-333
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
5 years agoUpdate to use CCSDK 0.2.4 05/49905/1 2.0.0-ONAP beijing 2.0.0-ONAP v1.3.4
Timoney, Dan (dt5972) [Fri, 1 Jun 2018 01:28:15 +0000 (21:28 -0400)]
Update to use CCSDK 0.2.4

Update to use CCSDK version 0.2.4

Change-Id: I2588021598deeb694db7751be7f38c7548a7c3cc
Issue-ID: CCSDK-291
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
5 years agoUpdate version.properties 83/48983/1
Timoney, Dan (dt5972) [Thu, 24 May 2018 16:09:31 +0000 (09:09 -0700)]
Update version.properties

Update version.properties to 1.3.3

Change-Id: Iacf184b81c07dc1192cdd20a92d7ecbb20225e57
Issue-ID: CCSDK-209
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
5 years agoRoll to version 1.3.3-SNAPSHOT 45/48845/1
Timoney, Dan (dt5972) [Thu, 24 May 2018 01:02:02 +0000 (18:02 -0700)]
Roll to version 1.3.3-SNAPSHOT

Update to next snapshot version

Change-Id: I400547435524e07b4b095b73d861ed08de424e4d
Issue-ID: CCSDK-290
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
5 years agoUpdate to release version parent 1.0.3 35/48835/1
Stilwell, David (stilwelld) [Wed, 23 May 2018 21:35:42 +0000 (17:35 -0400)]
Update to release version parent 1.0.3

Update parent version to remove -SNAPSHOT (1.0.3)

Change-Id: Iaba08985957d80875bec05099a618a2873ed801c
Issue-ID: CCSDK-290
Signed-off-by: Stilwell, David (stilwelld) <stilwelld@att.com>
5 years agoRoll versions step 7 : sdnc/northbound 21/45221/1
Timoney, Dan (dt5972) [Sun, 29 Apr 2018 23:43:15 +0000 (19:43 -0400)]
Roll versions step 7 : sdnc/northbound

Roll version for next release candidate.

Change-Id: Ib9a84ff6d5958876d7c4902673a1cc8c199ef64e
Issue-ID: SDNC-294
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
6 years agoMerge "Fix feature install for vnfapi" v1.3.1
David Stilwell [Wed, 18 Apr 2018 18:02:19 +0000 (18:02 +0000)]
Merge "Fix feature install for vnfapi"

6 years agoFix feature install for vnfapi 53/43553/1
Timoney, Dan (dt5972) [Wed, 18 Apr 2018 15:30:14 +0000 (11:30 -0400)]
Fix feature install for vnfapi

Fixed feature installer for vnfapi and vnftools to use client without -u
option.

Change-Id: Ic9b152965a6e70577d6e787f1e3b0a26852fcf54
Issue-ID: SDNC-283
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
6 years agoGenericResourceApiProvider unit tests part 8. 25/37825/1
Jakub Dudycz [Thu, 22 Mar 2018 16:53:19 +0000 (17:53 +0100)]
GenericResourceApiProvider unit tests part 8.

Added unit tests for preloadVnfTopologyOperation and preloadNetworkTopologyOperation methods

Change-Id: Iae0d3cbbaf27ee351eaf556fe7ad1a1ca54fbe91
Issue-ID: SDNC-275
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoGenericResourceApiProvider unit tests part 7. 11/37811/1
Jakub Dudycz [Thu, 22 Mar 2018 15:43:48 +0000 (16:43 +0100)]
GenericResourceApiProvider unit tests part 7.

Added unit tests for tunnelxconnTopologyOperation and brgTopologyOperation methods

Change-Id: I2172a62bddb3f394caf93c56ed2078efc153f3ea
Issue-ID: SDNC-275
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoGenericResourceApiProvider unit tests part 6. 83/37483/1
Jakub Dudycz [Wed, 21 Mar 2018 14:30:40 +0000 (15:30 +0100)]
GenericResourceApiProvider unit tests part 6.

Added unit tests for securityZoneTopologyOperation method and did some fixes in other test classes.

Change-Id: I61adeb21e4dca08b6cd668a6b0e70070d2f86730
Issue-ID: SDNC-275
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoGenericResourceApiProvider unit tests part 5. 55/37155/1
Jakub Dudycz [Tue, 20 Mar 2018 15:27:15 +0000 (16:27 +0100)]
GenericResourceApiProvider unit tests part 5.

Added unit tests for contrailRouteTopologyOperation method

Change-Id: I8519c5e1f3b8e076186f1965a8e316d0a35095ff
Issue-ID: SDNC-275
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoGenericResourceApiProvider unit tests part 4. 21/37121/1
Jakub Dudycz [Tue, 20 Mar 2018 14:02:30 +0000 (15:02 +0100)]
GenericResourceApiProvider unit tests part 4.

Created unit tests for vfModuleTopologyOperation method

Change-Id: I3bbd576ab85e95489c3df71e369cfe061dc4c2c3
Issue-ID: SDNC-275
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoGenericResourceApiProvider unit tests part 3. 09/37109/2
Jakub Dudycz [Tue, 20 Mar 2018 13:39:25 +0000 (14:39 +0100)]
GenericResourceApiProvider unit tests part 3.

Added some unit tests for networkTopologyOperation method

Change-Id: Iad137467fa367c9c6fb0050be1fe07a9019b213d
Issue-ID: SDNC-275
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoGenericResourceApiProvider unit tests part 2. 41/36741/1
Jakub Dudycz [Mon, 19 Mar 2018 14:40:51 +0000 (15:40 +0100)]
GenericResourceApiProvider unit tests part 2.

Unit tests for vnfTopologyOperation method

Change-Id: I60c73f31eb070cf554e55779d1d18631ce9b7147
Issue-ID: SDNC-275
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoGenericResourceApiProvider unit tests part 1. 01/36701/1
Jakub Dudycz [Mon, 19 Mar 2018 12:13:23 +0000 (13:13 +0100)]
GenericResourceApiProvider unit tests part 1.

Unit tests for serviceTopologyOperation method

Change-Id: I9a6f43fb6892b9b1d8f92544f7a90e203b0c9229
Issue-ID: SDNC-275
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoMerge "vnfapi yang model change"
Dan Timoney [Fri, 16 Mar 2018 19:15:16 +0000 (19:15 +0000)]
Merge "vnfapi yang model change"

6 years agovnfapi yang model change 93/34593/1
Cheung, Pat (kc1472) [Wed, 7 Mar 2018 23:29:21 +0000 (23:29 +0000)]
vnfapi yang model change

Enhance vnfapi yang model to support network-role-tag, and subnet-role

Change-Id: I8f0c7cb492df905881a9cb6747e8f7da6d07c82e
Issue-ID: CCSDK-200
Signed-off-by: Cheung, Pat (kc1472) <kc1472@att.com>
6 years agoNitrogen port : sdnc-northbound 03/33503/1
Timoney, Dan (dt5972) [Thu, 1 Mar 2018 02:13:09 +0000 (21:13 -0500)]
Nitrogen port : sdnc-northbound

Update sdnc/northbound to OpenDaylight Nitrogen release.

Change-Id: I6e299418a7ab441899b78b5d3df5f8ee96829222
Issue-ID: SDNC-269
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
6 years agoAdd tests to VnfApiProvider part 5 89/33189/1
pawel.kadlubanski [Tue, 27 Feb 2018 15:10:38 +0000 (16:10 +0100)]
Add tests to VnfApiProvider part 5

Write test for function vnfInstanceTopologyOperation in vnfapiProvider class.
Case when svcLogicClient svcLogicClient execute method returns null and
there is nor error during transaction writing.

Issue-ID: SDNC-267

Change-Id: I8058a2f38bea66fe1c7b6f5dbf24400fef5ab3b8
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
6 years agoAdd tests to VnfApiProvider part 4 75/32575/3
pawel.kadlubanski [Thu, 22 Feb 2018 15:07:01 +0000 (16:07 +0100)]
Add tests to VnfApiProvider part 4

Write test for function vnfInstanceTopologyOperation in vnfapiProvider class.
Case when svcLogicClient svcLogicClient execute method returns null but exception
is thrown during transaction writing.

Issue-ID: SDNC-267

Change-Id: I28c833938297032eaa717001cae8810ab007e9b7
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
6 years agoAdd tests to VnfApiProvider part 3 43/32243/1
pawel.kadlubanski [Tue, 20 Feb 2018 13:22:30 +0000 (14:22 +0100)]
Add tests to VnfApiProvider part 3

Write test for function vnfInstanceTopologyOperation in vnfapiProvider class.
Case when svcLogicClient svcLogicClient execute method returns not null.

Change-Id: Ia00b6d8ce2370920035424c6095e1d31611aaeb1
Issue-ID: SDNC-267
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
6 years agoAdd tests to VnfApiProvider part 2 09/32209/5
pawel.kadlubanski [Tue, 20 Feb 2018 07:19:57 +0000 (08:19 +0100)]
Add tests to VnfApiProvider part 2

Write test for function vnfInstanceTopologyOperation in vnfapiProvider class.
Case when svcLogicClient hasGraph return  false.
Case when svcLogicClient execute throw  SvcLogicException.
Case when svcLogicClient execute throw  SvcLogicException.

Change-Id: I6f65049e7567ae1d0fd9eccf7f8c1f35deb3c482
Issue-ID: SDNC-267
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
6 years agoRefactoring VnfApiProvider part 1 91/32091/5
pawel.kadlubanski [Mon, 19 Feb 2018 13:20:19 +0000 (14:20 +0100)]
Refactoring VnfApiProvider part 1

Move VnfInstanceTopologyOperationInput validation from vnfInstanceTopologyOperation
to seperate method.

Change-Id: I56e3999a92323c745f6d0aa8b4417b9e7acb277a
Issue-ID: SDNC-268
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
6 years agoAdd tests to VnfApiProvider part 1 57/31957/9
pawel.kadlubanski [Fri, 16 Feb 2018 12:54:57 +0000 (13:54 +0100)]
Add tests to VnfApiProvider part 1

Write test for function vnfInstanceTopologyOperation in vnfapiProvider class.
Case when VnfInstanceTopologyOperationInput is null.
Case when VnfInstanceTopologyOperationInput is not null but VnfInstanceRequestInformation is null.
Case when VnfInstanceId in VnfInstanceRequestInformation is null.

Change-Id: Icc778544a9e7a80600e54a2dcd87b77d11a23121
Issue-ID: SDNC-267
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
6 years agoMerge "Improve code metrics"
Dan Timoney [Thu, 15 Feb 2018 15:23:43 +0000 (15:23 +0000)]
Merge "Improve code metrics"

6 years agoImprove code metrics 97/29997/12
pawel.kadlubanski [Thu, 1 Feb 2018 09:57:32 +0000 (10:57 +0100)]
Improve code metrics

Resolve nested try block identified by Sonar as in class vnfapiProvider fixes
Define a constant instead of duplicating literals identified by Sonar
in class vnfapiProvider fixes

Change-Id: I584dfb104ee6f506ef063bb83d00beb11b1f971f
Issue-ID: SDNC-243
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
6 years agoGenericResourceApiProvider fixes part 6 93/30693/1
Jakub Dudycz [Wed, 7 Feb 2018 16:45:59 +0000 (17:45 +0100)]
GenericResourceApiProvider fixes part 6

Fixed most of cyclomatic complexity related sonar issues by method extraction

Change-Id: I539ed3db1a162e4e6c96917aa37faad035ff41fe
Issue-ID: SDNC-248
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoGenericResourceApiProvider fixes part 5 77/30677/2
Jakub Dudycz [Wed, 7 Feb 2018 15:20:21 +0000 (16:20 +0100)]
GenericResourceApiProvider fixes part 5

Code reformat only

Change-Id: Iee35caa38ab893f0f347a8d6d61072c88a585b9e
Issue-ID: SDNC-248
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoGenericResourceApiProvider fixes part 4 75/30675/1
Jakub Dudycz [Wed, 7 Feb 2018 15:08:24 +0000 (16:08 +0100)]
GenericResourceApiProvider fixes part 4

Handled code duplicates

Change-Id: I34621242eb68d1956b39e62a5b348a90ce3dfad5
Issue-ID: SDNC-248
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoGenericResourceApiProvider fixes part 3 71/30671/2
Jakub Dudycz [Wed, 7 Feb 2018 13:52:05 +0000 (14:52 +0100)]
GenericResourceApiProvider fixes part 3

Handled some of the issues identified by sonar

Change-Id: Iaddc1f86c6a0c54aa8d838b7608106bf1c2cbb09
Issue-ID: SDNC-248
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoGenericResourceApiProvider fixes part 2 69/30669/3
Jakub Dudycz [Wed, 7 Feb 2018 13:30:29 +0000 (14:30 +0100)]
GenericResourceApiProvider fixes part 2

Handled some of the issues identified by sonar

Change-Id: I29d36d41499f09a75af099d23948ed661e07aba3
Issue-ID: SDNC-248
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoGenericResourceApiProvider fixes part 1 59/30659/4
Jakub Dudycz [Wed, 7 Feb 2018 11:54:25 +0000 (12:54 +0100)]
GenericResourceApiProvider fixes part 1

Handled some of the issues identified by sonar

Change-Id: I1afc0cfd24594f96e0782e79f522d5bba1494881
Issue-ID: SDNC-248
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoFixed some sonar minors in VnfApiProvider 61/30261/2
Jakub Dudycz [Tue, 6 Feb 2018 12:25:19 +0000 (13:25 +0100)]
Fixed some sonar minors in VnfApiProvider

Change-Id: Ia9ed74f4c5dfab36c083b887191d9acca817eec8
Issue-ID: SDNC-247
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoImprove code metrics 93/29793/4
pawel.kadlubanski [Wed, 31 Jan 2018 10:48:57 +0000 (11:48 +0100)]
Improve code metrics

Change variable name identified by Sonar as issue in class vnfapiProvider fixes

Change-Id: I98965aeb8f64e06d7e2f5d5ff7eca7a9f2ddd22f
Issue-ID: SDNC-243
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
6 years agoImprove code metrics 53/29653/3
pawel.kadlubanski [Tue, 30 Jan 2018 13:45:19 +0000 (14:45 +0100)]
Improve code metrics

Improve code issued identified by Sonar in class vnfapiProvider fixes

Change-Id: I7a28380920385f5644eb41767f68d7ae1e176473
Issue-ID: SDNC-243
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
6 years agoFixed sonar errors to line 1224 63/29663/5
Jakub Dudycz [Tue, 30 Jan 2018 15:33:18 +0000 (16:33 +0100)]
Fixed sonar errors to line 1224

Change-Id: I973460d2a34818294280cae7b44a285448672bdf
Issue-ID: SDNC-242
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoFixed sonar errors to line 463 57/29657/1
Jakub Dudycz [Tue, 30 Jan 2018 14:04:47 +0000 (15:04 +0100)]
Fixed sonar errors to line 463

Change-Id: Ib3c5a2e872fd47585dca1df49237206e968760e0
Issue-ID: SDNC-242
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoResolve duplicate file name 57/26657/2
Dan Timoney [Wed, 20 Dec 2017 19:25:32 +0000 (14:25 -0500)]
Resolve duplicate file name

Renamed vnfapiProviderTest.java to VnfapiProviderTestBase.java to avoid
conflict with VnfapiProviderTest.java

Change-Id: I500785a038691c17b84faac427232da2f9fdee21
Issue-ID: SDNC-228
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoDeleting missing vnf-list entry cause infiniteLoop 27/24927/1
Joey Sullivan [Wed, 22 Nov 2017 21:22:02 +0000 (21:22 +0000)]
Deleting missing vnf-list entry cause infiniteLoop

Deleting a vnf-list entry that does not exist from
the databoker throws a
ModifiedNodeDoesNotExistException.  This
conflicted with the optimistic locking retry
mechanism causing a infinite loop.

Change-Id: I216a31eabf710ed365c8d928e4df0e866848eeca
Issue-ID: SDNC-156
Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
6 years agoBump minor version 75/24475/2
Jessica Wagantall [Mon, 20 Nov 2017 19:04:57 +0000 (11:04 -0800)]
Bump minor version

Bump minor version in preparation for Amsterdam
branching.

Change-Id: If5ef8fc3ffb6c819d1c3b8eed0922729997243ef
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
6 years agoUpdate version.properties 01/23701/1 1.0.0-Amsterdam 1.0.0-ONAP v1.2.2
Dan Timoney [Wed, 15 Nov 2017 22:13:53 +0000 (17:13 -0500)]
Update version.properties

Fix version in version.properties to 1.2.2

Change-Id: I8f2f71f3dac9dc462cff969b2c666c961d3e978a
Issue-ID: SDNC-79
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoRoll to next version 53/23653/1
Dan Timoney [Wed, 15 Nov 2017 17:06:42 +0000 (12:06 -0500)]
Roll to next version

Since release 1.2.1 has already been cut, need to bump version to
1.2.2-SNAPSHOT.

Change-Id: I97f293f264082d78d15984c231b67759c3e1006b
Issue-ID: SDNC-74
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoFix VoLTE service delete issue 37/23637/1
ramu.n [Wed, 15 Nov 2017 15:54:44 +0000 (21:24 +0530)]
Fix VoLTE service delete issue

In VoLTE use case underlay uses network-topology-operation with
svc-action create & delete, during underlay create operation
need to update MDSAL OPERATIONAL data store similar to
network-topology-operation with activate.

Change-Id: I312679244656b4bef514595d1ec724969d44d38f
Issue-Id: SDNC-193
Signed-off-by: Ramu N <ramu.n@huawei.com>
6 years agoRm docs in repo consolidated w/ sdnc/oam 13/23613/1
Rich Bennett [Wed, 15 Nov 2017 13:19:14 +0000 (08:19 -0500)]
Rm docs in repo consolidated w/ sdnc/oam

Change-Id: I3e6d9b04c3ce814597d1d3992f947b87d1757f61
Issue-ID: DOC-124
Signed-off-by: Rich Bennett <rb2745@att.com>
6 years agoFix preload-network-topology-operation err msgs 13/23513/4
Marcus G K Williams [Tue, 14 Nov 2017 21:31:01 +0000 (13:31 -0800)]
Fix preload-network-topology-operation err msgs

Issue-Id: SDNC-145
Change-Id: Ibf4fe3101b278ad3dee7632863eb10f4b4c88e48
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoRoll to version 1.2.1-SNAPSHOT 51/22951/1 v1.2.1
Dan Timoney [Thu, 9 Nov 2017 12:53:04 +0000 (07:53 -0500)]
Roll to version 1.2.1-SNAPSHOT

Roll to next release version

Change-Id: Id1d521317ca37583ed28b2bf60b0411120f13e00
Issue-ID: SDNC-74
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agofix doc8 error 13/22813/1
Morgan Richomme [Wed, 8 Nov 2017 16:20:49 +0000 (17:20 +0100)]
fix doc8 error

JIRA: SDNC-178

Change-Id: If5fe5ef8564eb8f673b95b058159c8259722c59f
Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>
6 years agoAdd DG actions to last-action in GenRes.API Yang 09/22109/2
Marcus G K Williams [Sat, 4 Nov 2017 19:22:35 +0000 (12:22 -0700)]
Add DG actions to last-action in GenRes.API Yang

Issue-Id: SDNC-171
Change-Id: I913a40c604f9cab4d9eb1be56c53b69aefc4a3bf
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoFix GENERIC-RESOURCE-API yang model 65/22065/2
Dan Timoney [Fri, 3 Nov 2017 21:24:19 +0000 (17:24 -0400)]
Fix GENERIC-RESOURCE-API yang model

Add missing enum values and container to yang model
Also, BRG and tunnelxconn's service instance parent
is VNF-API, not GENERIC-RESOURCE-API, so do not
try to retrieve service data.

Change-Id: I12c977a7e621ce654d0d5d38f8ac8f3ad95487bd
Issue-ID: SDNC-166
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoUpdate swagger doc for GENERIC-RESOURCE-API 57/22057/1
Dan Timoney [Fri, 3 Nov 2017 20:22:26 +0000 (16:22 -0400)]
Update swagger doc for GENERIC-RESOURCE-API

Update swagger v2.0 doc for GENERIC-RESOURCE-API to reflect changes made
for new tunnelxconn assignment

Change-Id: I3a298ff36a8eefc0a638dc40531f79137443cc56
Issue-ID: SDNC-160
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoNew tunnelxconn assignment 35/21735/1
Dan Timoney [Wed, 1 Nov 2017 23:09:40 +0000 (19:09 -0400)]
New tunnelxconn assignment

Add new assignment (vg-ip) to tunnelxconn assignments container

Change-Id: Ib9439ceb440b508007104b0a8452a9ae64255354
Issue-ID: SDNC-160
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoFix typos in GENERIC-RESOURCE-API 59/21359/1
Dan Timoney [Mon, 30 Oct 2017 18:53:49 +0000 (14:53 -0400)]
Fix typos in GENERIC-RESOURCE-API

Updated location of Yang-mapping properties file and fixed typo
in Yang model for GENERIC-RESOURCE-API.

Change-Id: I379274beefd5673cca5096ff3769b552e0475535
Issue-ID: SDNC-151
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoAdd offered apis to sdnc/northbound doc 09/21009/1
Dan Timoney [Fri, 27 Oct 2017 13:04:59 +0000 (09:04 -0400)]
Add offered apis to sdnc/northbound doc

Add links to swagger docs to SDNC Northbound offered APIs

Change-Id: I40def203f5748453e5fea6edfb3f2ec0e242f563
Issue-ID: SDNC-72
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoUse version 0.1.0 of parent 27/20627/1
Dan Timoney [Wed, 25 Oct 2017 21:07:57 +0000 (17:07 -0400)]
Use version 0.1.0 of parent

Update to use version 0.1.0 (released version) of parent pom

Change-Id: I3d03456167e0b9467ae068a91c22a95c58f0c4ee
Issue-ID: SDNC-74
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoCreate a Junit test for NetworkTopologyOperation 57/20157/1
Joey Sullivan [Mon, 23 Oct 2017 13:39:31 +0000 (13:39 +0000)]
Create a Junit test for NetworkTopologyOperation

This test verifies NetworkTopologyOperation RPC
executes a DG then produces the expected
NetworkTopologyOperationOutput and persisted the
expected Service in the DataBroker.  In addition
util classes were updated to make it easier to
write additional MDSAL test in the future.

Change-Id: Icf099c0dbf4445fb5d3e5b009a8cb6e8ca7200cb
Issue-ID: SDNC-101
Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
6 years agoCreate a Junit test for ServiceTopologyOperation 11/19811/1
Joey Sullivan [Thu, 19 Oct 2017 19:53:05 +0000 (19:53 +0000)]
Create a Junit test for ServiceTopologyOperation

This test verifies ServiceTopologyOperation RPC
executes a DG then produces the expected
ServiceTopologyOperationOutput and persisted the
expected Service in the DataBroker.  In addition
util classes were written to make it easier to
write additional MDSAL test in the future.

Change-Id: I2281099df767397b628ec2caff06f3dd49962b8b
Issue-ID: SDNC-101
Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
6 years agoIgnore ModifiedNodeDoesNotExistException on delete 03/19803/1
Dan Timoney [Thu, 19 Oct 2017 20:03:04 +0000 (16:03 -0400)]
Ignore ModifiedNodeDoesNotExistException on delete

When trying to deleteVnf from operational or config tree, if a
ModifiedNodeDoesNotExistException is cause for commit exception
it means that the data you are trying to delete does not exist.
So you wanted it gone, it's already gone ... log a message at
debug level but don't fail the transaction.

Change-Id: Iea0f4e78522cc2f437843e2b17080855cd314ea6
Issue-ID: SDNC-137
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoFix vnftools load issues 11/19311/1
Dan Timoney [Tue, 17 Oct 2017 15:14:39 +0000 (11:14 -0400)]
Fix vnftools load issues

Fixed 2 issues that prevented vnftools from loading:

1) Added org.onap.ccsdk.* to Import-Package in provider manifest (needed
to resolve path to SvcLogicJavaPlugin)
2) Removed useless Properties arg from VnfTools constructor

Change-Id: Iba8213710d012836a7a70fca07c7c232a3b7b539
Issue-ID: SDNC-132
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoAdd junit test for vnfapiProvider 07/19107/1
Hao Kuang [Mon, 16 Oct 2017 16:22:15 +0000 (12:22 -0400)]
Add junit test for vnfapiProvider

(1) added junit test for vnf apiProvider
(2) formatted vnfapiProvider via using ONAP java code formatter
(3) added license for VnfSdnUtilTest

Issue-Id: SDNC-123
Change-Id: Ia0a12003a97331ae790224df14012b48d99af7d5
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
6 years agoSonar coverage vnfapi -VNFSDNSvcLogicServiceClient 43/18843/1
beili.zhou [Fri, 13 Oct 2017 23:19:11 +0000 (19:19 -0400)]
Sonar coverage vnfapi -VNFSDNSvcLogicServiceClient

Add Junit test case for VNFSDNSvcLogicServiceClient
In VNFSDNSvcLogicServiceClient:
  - Fix sonarlint issues (remove un-used import and etc)
  - Changed tab to 4 spaces as per ONAP Java code style

Issue-Id: SDNC-123
Change-Id: Id176e915f17ef5fabc6805415f92d60b4c8e95b2
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoSonar coverage - GenericResourceApi provider 35/18835/1
beili.zhou [Fri, 13 Oct 2017 21:25:05 +0000 (17:25 -0400)]
Sonar coverage - GenericResourceApi provider

Add Junit test case for GenericResourceApiSvcLogicServiceClient
In GenericResourceApiSvcLogicServiceClient:
  - Fix sonarlint issues (remove un-used import and etc)
  - Changed tab to 4 spaces as per ONAP Java code style

Issue-Id: SDNC-101
Change-Id: I789d20a749f8daa4d6b626fedef6a9bb904bae2e
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoMerge "Add junit test for VnfSdnUtilTest"
Dan Timoney [Fri, 13 Oct 2017 18:10:16 +0000 (18:10 +0000)]
Merge "Add junit test for VnfSdnUtilTest"

6 years agoAdd junit test for VnfSdnUtilTest 87/18787/1
Hao Kuang [Fri, 13 Oct 2017 15:16:57 +0000 (11:16 -0400)]
Add junit test for VnfSdnUtilTest

(1) add junit test for vnfSdnUtilTest
(2) format VnfSdnUtil.java via using ONAP java code formatter
(3) fix some sonar lint issues

Issue-Id: SDNC-123
Change-Id: I0e1cd55f67b238d70514a2caf02f4ead7809de31
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
6 years agoMerge "Fix installation issues with generic-resource-api"
Marcus Williams [Fri, 13 Oct 2017 16:21:35 +0000 (16:21 +0000)]
Merge "Fix installation issues with generic-resource-api"

6 years agoFix installation issues with generic-resource-api 85/18785/1
Dan Timoney [Fri, 13 Oct 2017 16:07:01 +0000 (12:07 -0400)]
Fix installation issues with generic-resource-api

Updated generic-resource-api to use Aries blueprint to install and
resolved issues preventing it from installing properly in karaf.

Change-Id: Iaef8bdb7a9e6aaf149a8e8a0d847197cf3f704a9
Issue-ID: SDNC-109
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoSonar coverage vnftools - VnfTools 43/18643/1
beili.zhou [Thu, 12 Oct 2017 23:23:27 +0000 (19:23 -0400)]
Sonar coverage vnftools - VnfTools

Add junit test cases for VnfTools class
In VnfTools:
  - Fix sonarlint issues (remove un-used private method and etc)
  - Changed tab to 4 spaces as per ONAP Java code style

Issue-Id: SDNC-122
Change-Id: If216f53c8ffa7b646f6ebf18d4b9568cfdf4683b
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoFixed vnfapi install issue 17/18617/2
Dan Timoney [Thu, 12 Oct 2017 20:01:06 +0000 (16:01 -0400)]
Fixed vnfapi install issue

Fixed issues with vnfapi install:
 - Resolved issue installing vnftools by converting to blueprint
 - Resolved issue not finding RPC implementation of vnfapi by fixing
   dependency feature vnftools, and by converting vnfapi to blueprint.

The root cause in both cases was probably something wrong with the
provider configuration, but it was simpler (not to mention more
maintainable) to just convert from config to blueprint.

Change-Id: I7010a845687673c932457774f3103834d328ab84
Issue-ID: SDNC-119
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoAdd readthedocs for sdnc/northbound 39/18539/2
Dan Timoney [Thu, 12 Oct 2017 13:11:52 +0000 (09:11 -0400)]
Add readthedocs for sdnc/northbound

Add readthedocs documentation for sdnc/northbound.

Change-Id: Iad6b19f8194564807ac5e2b9772a554ab14c2cad
Issue-ID: SDNC-72
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoUse try-with-resource to close filestream 83/18483/1
surya-huawei [Thu, 12 Oct 2017 08:56:36 +0000 (14:26 +0530)]
Use try-with-resource to close filestream

*Using try-with-resource here makes sure that the resource is
automatically closed and increases code readability

Issue-Id: CCSDK-117
Change-Id: Ie923e4540d5be90324104593a1d5fcb1bd501f5c
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
6 years agoAdd missing info to swagger doc 37/18037/2
Dan Timoney [Tue, 10 Oct 2017 20:00:59 +0000 (16:00 -0400)]
Add missing info to swagger doc

Add missing required sections of info in swagger doc for
generic-resource-api

Change-Id: Iea25ce95d6bc0ae0d0edb7ad9a4f71be0669f231
Issue-ID: SDNC-72
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoConvert swagger docs to v 2 29/18029/1
Dan Timoney [Tue, 10 Oct 2017 18:41:12 +0000 (14:41 -0400)]
Convert swagger docs to v 2

Generate updated swagger specs and convert from swagger 1.2 to 2.0
format.

Change-Id: I2d357b903596b3f2341ed5d024465e967fdaa76c
Issue-ID: SDNC-72
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoAdded new request-actions for overlay 95/17195/1
Gaurav Agrawal [Wed, 4 Oct 2017 09:34:50 +0000 (15:04 +0530)]
Added new request-actions for overlay

Added new request-actions for dci overlay activation & deactivation. This
is required to differentiate dci activation/deactivation for VoLTE use case
from normal network activation/deactivation.

Change-Id: I865963b78ae8b8ba3a8173259179013997318e87
Issue-Id: SDNC-110
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
6 years agoFix url for swagger file 45/16645/1
Brian Freeman [Fri, 29 Sep 2017 13:08:30 +0000 (13:08 +0000)]
Fix url for swagger file

Issue-ID: SDNC-72
Change-Id: Ia0c1504393ea8d3af00a082e0d265ccaf4bfef82
Signed-off-by: Brian Freeman <bf1936@att.com>
6 years agoAdd VNF-API, GEN-RES SWAGGER doc 93/16493/1
Brian Freeman [Thu, 28 Sep 2017 18:37:24 +0000 (18:37 +0000)]
Add VNF-API, GEN-RES SWAGGER doc

Issue-ID: SDNC-72
Change-Id: I1a9fcf3fb99668acba6e89ce8b1db9500adb5670
Signed-off-by: Brian Freeman <bf1936@att.com>
6 years agoSetup ReadTheDocs 23/16323/1
Brian Freeman [Thu, 28 Sep 2017 10:22:15 +0000 (10:22 +0000)]
Setup ReadTheDocs

Issue-ID: SDNC-72
Change-Id: Iad42b847700c37d3f1099d6a8cc521141d66dfae
Signed-off-by: Brian Freeman <bf1936@att.com>
6 years agoMerge "Fix VNF-API yang validation issues"
Dan Timoney [Wed, 27 Sep 2017 07:50:34 +0000 (07:50 +0000)]
Merge "Fix VNF-API yang validation issues"

6 years agoMerge "Improve SDNC Sonar coverage"
Dan Timoney [Wed, 27 Sep 2017 07:49:39 +0000 (07:49 +0000)]
Merge "Improve SDNC Sonar coverage"

6 years agoImprove SDNC Sonar coverage 59/15059/3
ramu.n [Mon, 25 Sep 2017 12:46:12 +0000 (18:16 +0530)]
Improve SDNC Sonar coverage

Added initial test cases for GENERIC-RESOURCE-APIs

Change-Id: I84a0d44210f97b9378ad75cc55919d5d404be6a2
Issue-Id: SDNC-101
Signed-off-by: Ramu N <ramu.n@huawei.com>