Cheung, Pat (kc1472) [Wed, 7 Mar 2018 23:29:21 +0000 (23:29 +0000)]
vnfapi yang model change
Enhance vnfapi yang model to support network-role-tag, and subnet-role
Change-Id: I8f0c7cb492df905881a9cb6747e8f7da6d07c82e
Issue-ID: CCSDK-200
Signed-off-by: Cheung, Pat (kc1472) <kc1472@att.com>
pawel.kadlubanski [Tue, 27 Feb 2018 15:10:38 +0000 (16:10 +0100)]
Add tests to VnfApiProvider part 5
Write test for function vnfInstanceTopologyOperation in vnfapiProvider class.
Case when svcLogicClient svcLogicClient execute method returns null and
there is nor error during transaction writing.
Issue-ID: SDNC-267
Change-Id: I8058a2f38bea66fe1c7b6f5dbf24400fef5ab3b8
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
pawel.kadlubanski [Thu, 22 Feb 2018 15:07:01 +0000 (16:07 +0100)]
Add tests to VnfApiProvider part 4
Write test for function vnfInstanceTopologyOperation in vnfapiProvider class.
Case when svcLogicClient svcLogicClient execute method returns null but exception
is thrown during transaction writing.
Issue-ID: SDNC-267
Change-Id: I28c833938297032eaa717001cae8810ab007e9b7
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
pawel.kadlubanski [Tue, 20 Feb 2018 13:22:30 +0000 (14:22 +0100)]
Add tests to VnfApiProvider part 3
Write test for function vnfInstanceTopologyOperation in vnfapiProvider class.
Case when svcLogicClient svcLogicClient execute method returns not null.
Change-Id: Ia00b6d8ce2370920035424c6095e1d31611aaeb1
Issue-ID: SDNC-267
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
pawel.kadlubanski [Tue, 20 Feb 2018 07:19:57 +0000 (08:19 +0100)]
Add tests to VnfApiProvider part 2
Write test for function vnfInstanceTopologyOperation in vnfapiProvider class.
Case when svcLogicClient hasGraph return false.
Case when svcLogicClient execute throw SvcLogicException.
Case when svcLogicClient execute throw SvcLogicException.
Change-Id: I6f65049e7567ae1d0fd9eccf7f8c1f35deb3c482
Issue-ID: SDNC-267
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
pawel.kadlubanski [Mon, 19 Feb 2018 13:20:19 +0000 (14:20 +0100)]
Refactoring VnfApiProvider part 1
Move VnfInstanceTopologyOperationInput validation from vnfInstanceTopologyOperation
to seperate method.
Change-Id: I56e3999a92323c745f6d0aa8b4417b9e7acb277a
Issue-ID: SDNC-268
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
pawel.kadlubanski [Fri, 16 Feb 2018 12:54:57 +0000 (13:54 +0100)]
Add tests to VnfApiProvider part 1
Write test for function vnfInstanceTopologyOperation in vnfapiProvider class.
Case when VnfInstanceTopologyOperationInput is null.
Case when VnfInstanceTopologyOperationInput is not null but VnfInstanceRequestInformation is null.
Case when VnfInstanceId in VnfInstanceRequestInformation is null.
Change-Id: Icc778544a9e7a80600e54a2dcd87b77d11a23121
Issue-ID: SDNC-267
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
Dan Timoney [Thu, 15 Feb 2018 15:23:43 +0000 (15:23 +0000)]
Merge "Improve code metrics"
pawel.kadlubanski [Thu, 1 Feb 2018 09:57:32 +0000 (10:57 +0100)]
Improve code metrics
Resolve nested try block identified by Sonar as in class vnfapiProvider fixes
Define a constant instead of duplicating literals identified by Sonar
in class vnfapiProvider fixes
Change-Id: I584dfb104ee6f506ef063bb83d00beb11b1f971f
Issue-ID: SDNC-243
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
Jakub Dudycz [Wed, 7 Feb 2018 16:45:59 +0000 (17:45 +0100)]
GenericResourceApiProvider fixes part 6
Fixed most of cyclomatic complexity related sonar issues by method extraction
Change-Id: I539ed3db1a162e4e6c96917aa37faad035ff41fe
Issue-ID: SDNC-248
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Wed, 7 Feb 2018 15:20:21 +0000 (16:20 +0100)]
GenericResourceApiProvider fixes part 5
Code reformat only
Change-Id: Iee35caa38ab893f0f347a8d6d61072c88a585b9e
Issue-ID: SDNC-248
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Wed, 7 Feb 2018 15:08:24 +0000 (16:08 +0100)]
GenericResourceApiProvider fixes part 4
Handled code duplicates
Change-Id: I34621242eb68d1956b39e62a5b348a90ce3dfad5
Issue-ID: SDNC-248
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Wed, 7 Feb 2018 13:52:05 +0000 (14:52 +0100)]
GenericResourceApiProvider fixes part 3
Handled some of the issues identified by sonar
Change-Id: Iaddc1f86c6a0c54aa8d838b7608106bf1c2cbb09
Issue-ID: SDNC-248
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Wed, 7 Feb 2018 13:30:29 +0000 (14:30 +0100)]
GenericResourceApiProvider fixes part 2
Handled some of the issues identified by sonar
Change-Id: I29d36d41499f09a75af099d23948ed661e07aba3
Issue-ID: SDNC-248
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Wed, 7 Feb 2018 11:54:25 +0000 (12:54 +0100)]
GenericResourceApiProvider fixes part 1
Handled some of the issues identified by sonar
Change-Id: I1afc0cfd24594f96e0782e79f522d5bba1494881
Issue-ID: SDNC-248
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 6 Feb 2018 12:25:19 +0000 (13:25 +0100)]
Fixed some sonar minors in VnfApiProvider
Change-Id: Ia9ed74f4c5dfab36c083b887191d9acca817eec8
Issue-ID: SDNC-247
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
pawel.kadlubanski [Wed, 31 Jan 2018 10:48:57 +0000 (11:48 +0100)]
Improve code metrics
Change variable name identified by Sonar as issue in class vnfapiProvider fixes
Change-Id: I98965aeb8f64e06d7e2f5d5ff7eca7a9f2ddd22f
Issue-ID: SDNC-243
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
pawel.kadlubanski [Tue, 30 Jan 2018 13:45:19 +0000 (14:45 +0100)]
Improve code metrics
Improve code issued identified by Sonar in class vnfapiProvider fixes
Change-Id: I7a28380920385f5644eb41767f68d7ae1e176473
Issue-ID: SDNC-243
Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
Jakub Dudycz [Tue, 30 Jan 2018 15:33:18 +0000 (16:33 +0100)]
Fixed sonar errors to line 1224
Change-Id: I973460d2a34818294280cae7b44a285448672bdf
Issue-ID: SDNC-242
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 30 Jan 2018 14:04:47 +0000 (15:04 +0100)]
Fixed sonar errors to line 463
Change-Id: Ib3c5a2e872fd47585dca1df49237206e968760e0
Issue-ID: SDNC-242
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Dan Timoney [Wed, 20 Dec 2017 19:25:32 +0000 (14:25 -0500)]
Resolve duplicate file name
Renamed vnfapiProviderTest.java to VnfapiProviderTestBase.java to avoid
conflict with VnfapiProviderTest.java
Change-Id: I500785a038691c17b84faac427232da2f9fdee21
Issue-ID: SDNC-228
Signed-off-by: Dan Timoney <dtimoney@att.com>
Joey Sullivan [Wed, 22 Nov 2017 21:22:02 +0000 (21:22 +0000)]
Deleting missing vnf-list entry cause infiniteLoop
Deleting a vnf-list entry that does not exist from
the databoker throws a
ModifiedNodeDoesNotExistException. This
conflicted with the optimistic locking retry
mechanism causing a infinite loop.
Change-Id: I216a31eabf710ed365c8d928e4df0e866848eeca
Issue-ID: SDNC-156
Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
Jessica Wagantall [Mon, 20 Nov 2017 19:04:57 +0000 (11:04 -0800)]
Bump minor version
Bump minor version in preparation for Amsterdam
branching.
Change-Id: If5ef8fc3ffb6c819d1c3b8eed0922729997243ef
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Dan Timoney [Wed, 15 Nov 2017 22:13:53 +0000 (17:13 -0500)]
Update version.properties
Fix version in version.properties to 1.2.2
Change-Id: I8f2f71f3dac9dc462cff969b2c666c961d3e978a
Issue-ID: SDNC-79
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 15 Nov 2017 17:06:42 +0000 (12:06 -0500)]
Roll to next version
Since release 1.2.1 has already been cut, need to bump version to
1.2.2-SNAPSHOT.
Change-Id: I97f293f264082d78d15984c231b67759c3e1006b
Issue-ID: SDNC-74
Signed-off-by: Dan Timoney <dtimoney@att.com>
ramu.n [Wed, 15 Nov 2017 15:54:44 +0000 (21:24 +0530)]
Fix VoLTE service delete issue
In VoLTE use case underlay uses network-topology-operation with
svc-action create & delete, during underlay create operation
need to update MDSAL OPERATIONAL data store similar to
network-topology-operation with activate.
Change-Id: I312679244656b4bef514595d1ec724969d44d38f
Issue-Id: SDNC-193
Signed-off-by: Ramu N <ramu.n@huawei.com>
Rich Bennett [Wed, 15 Nov 2017 13:19:14 +0000 (08:19 -0500)]
Rm docs in repo consolidated w/ sdnc/oam
Change-Id: I3e6d9b04c3ce814597d1d3992f947b87d1757f61
Issue-ID: DOC-124
Signed-off-by: Rich Bennett <rb2745@att.com>
Marcus G K Williams [Tue, 14 Nov 2017 21:31:01 +0000 (13:31 -0800)]
Fix preload-network-topology-operation err msgs
Issue-Id: SDNC-145
Change-Id: Ibf4fe3101b278ad3dee7632863eb10f4b4c88e48
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Dan Timoney [Thu, 9 Nov 2017 12:53:04 +0000 (07:53 -0500)]
Roll to version 1.2.1-SNAPSHOT
Roll to next release version
Change-Id: Id1d521317ca37583ed28b2bf60b0411120f13e00
Issue-ID: SDNC-74
Signed-off-by: Dan Timoney <dtimoney@att.com>
Morgan Richomme [Wed, 8 Nov 2017 16:20:49 +0000 (17:20 +0100)]
fix doc8 error
JIRA: SDNC-178
Change-Id: If5fe5ef8564eb8f673b95b058159c8259722c59f
Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>
Marcus G K Williams [Sat, 4 Nov 2017 19:22:35 +0000 (12:22 -0700)]
Add DG actions to last-action in GenRes.API Yang
Issue-Id: SDNC-171
Change-Id: I913a40c604f9cab4d9eb1be56c53b69aefc4a3bf
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Dan Timoney [Fri, 3 Nov 2017 21:24:19 +0000 (17:24 -0400)]
Fix GENERIC-RESOURCE-API yang model
Add missing enum values and container to yang model
Also, BRG and tunnelxconn's service instance parent
is VNF-API, not GENERIC-RESOURCE-API, so do not
try to retrieve service data.
Change-Id: I12c977a7e621ce654d0d5d38f8ac8f3ad95487bd
Issue-ID: SDNC-166
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Fri, 3 Nov 2017 20:22:26 +0000 (16:22 -0400)]
Update swagger doc for GENERIC-RESOURCE-API
Update swagger v2.0 doc for GENERIC-RESOURCE-API to reflect changes made
for new tunnelxconn assignment
Change-Id: I3a298ff36a8eefc0a638dc40531f79137443cc56
Issue-ID: SDNC-160
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 1 Nov 2017 23:09:40 +0000 (19:09 -0400)]
New tunnelxconn assignment
Add new assignment (vg-ip) to tunnelxconn assignments container
Change-Id: Ib9439ceb440b508007104b0a8452a9ae64255354
Issue-ID: SDNC-160
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Mon, 30 Oct 2017 18:53:49 +0000 (14:53 -0400)]
Fix typos in GENERIC-RESOURCE-API
Updated location of Yang-mapping properties file and fixed typo
in Yang model for GENERIC-RESOURCE-API.
Change-Id: I379274beefd5673cca5096ff3769b552e0475535
Issue-ID: SDNC-151
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Fri, 27 Oct 2017 13:04:59 +0000 (09:04 -0400)]
Add offered apis to sdnc/northbound doc
Add links to swagger docs to SDNC Northbound offered APIs
Change-Id: I40def203f5748453e5fea6edfb3f2ec0e242f563
Issue-ID: SDNC-72
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 25 Oct 2017 21:07:57 +0000 (17:07 -0400)]
Use version 0.1.0 of parent
Update to use version 0.1.0 (released version) of parent pom
Change-Id: I3d03456167e0b9467ae068a91c22a95c58f0c4ee
Issue-ID: SDNC-74
Signed-off-by: Dan Timoney <dtimoney@att.com>
Joey Sullivan [Mon, 23 Oct 2017 13:39:31 +0000 (13:39 +0000)]
Create a Junit test for NetworkTopologyOperation
This test verifies NetworkTopologyOperation RPC
executes a DG then produces the expected
NetworkTopologyOperationOutput and persisted the
expected Service in the DataBroker. In addition
util classes were updated to make it easier to
write additional MDSAL test in the future.
Change-Id: Icf099c0dbf4445fb5d3e5b009a8cb6e8ca7200cb
Issue-ID: SDNC-101
Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
Joey Sullivan [Thu, 19 Oct 2017 19:53:05 +0000 (19:53 +0000)]
Create a Junit test for ServiceTopologyOperation
This test verifies ServiceTopologyOperation RPC
executes a DG then produces the expected
ServiceTopologyOperationOutput and persisted the
expected Service in the DataBroker. In addition
util classes were written to make it easier to
write additional MDSAL test in the future.
Change-Id: I2281099df767397b628ec2caff06f3dd49962b8b
Issue-ID: SDNC-101
Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
Dan Timoney [Thu, 19 Oct 2017 20:03:04 +0000 (16:03 -0400)]
Ignore ModifiedNodeDoesNotExistException on delete
When trying to deleteVnf from operational or config tree, if a
ModifiedNodeDoesNotExistException is cause for commit exception
it means that the data you are trying to delete does not exist.
So you wanted it gone, it's already gone ... log a message at
debug level but don't fail the transaction.
Change-Id: Iea0f4e78522cc2f437843e2b17080855cd314ea6
Issue-ID: SDNC-137
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 17 Oct 2017 15:14:39 +0000 (11:14 -0400)]
Fix vnftools load issues
Fixed 2 issues that prevented vnftools from loading:
1) Added org.onap.ccsdk.* to Import-Package in provider manifest (needed
to resolve path to SvcLogicJavaPlugin)
2) Removed useless Properties arg from VnfTools constructor
Change-Id: Iba8213710d012836a7a70fca07c7c232a3b7b539
Issue-ID: SDNC-132
Signed-off-by: Dan Timoney <dtimoney@att.com>
Hao Kuang [Mon, 16 Oct 2017 16:22:15 +0000 (12:22 -0400)]
Add junit test for vnfapiProvider
(1) added junit test for vnf apiProvider
(2) formatted vnfapiProvider via using ONAP java code formatter
(3) added license for VnfSdnUtilTest
Issue-Id: SDNC-123
Change-Id: Ia0a12003a97331ae790224df14012b48d99af7d5
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
beili.zhou [Fri, 13 Oct 2017 23:19:11 +0000 (19:19 -0400)]
Sonar coverage vnfapi -VNFSDNSvcLogicServiceClient
Add Junit test case for VNFSDNSvcLogicServiceClient
In VNFSDNSvcLogicServiceClient:
- Fix sonarlint issues (remove un-used import and etc)
- Changed tab to 4 spaces as per ONAP Java code style
Issue-Id: SDNC-123
Change-Id: Id176e915f17ef5fabc6805415f92d60b4c8e95b2
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
beili.zhou [Fri, 13 Oct 2017 21:25:05 +0000 (17:25 -0400)]
Sonar coverage - GenericResourceApi provider
Add Junit test case for GenericResourceApiSvcLogicServiceClient
In GenericResourceApiSvcLogicServiceClient:
- Fix sonarlint issues (remove un-used import and etc)
- Changed tab to 4 spaces as per ONAP Java code style
Issue-Id: SDNC-101
Change-Id: I789d20a749f8daa4d6b626fedef6a9bb904bae2e
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
Dan Timoney [Fri, 13 Oct 2017 18:10:16 +0000 (18:10 +0000)]
Merge "Add junit test for VnfSdnUtilTest"
Hao Kuang [Fri, 13 Oct 2017 15:16:57 +0000 (11:16 -0400)]
Add junit test for VnfSdnUtilTest
(1) add junit test for vnfSdnUtilTest
(2) format VnfSdnUtil.java via using ONAP java code formatter
(3) fix some sonar lint issues
Issue-Id: SDNC-123
Change-Id: I0e1cd55f67b238d70514a2caf02f4ead7809de31
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
Marcus Williams [Fri, 13 Oct 2017 16:21:35 +0000 (16:21 +0000)]
Merge "Fix installation issues with generic-resource-api"
Dan Timoney [Fri, 13 Oct 2017 16:07:01 +0000 (12:07 -0400)]
Fix installation issues with generic-resource-api
Updated generic-resource-api to use Aries blueprint to install and
resolved issues preventing it from installing properly in karaf.
Change-Id: Iaef8bdb7a9e6aaf149a8e8a0d847197cf3f704a9
Issue-ID: SDNC-109
Signed-off-by: Dan Timoney <dtimoney@att.com>
beili.zhou [Thu, 12 Oct 2017 23:23:27 +0000 (19:23 -0400)]
Sonar coverage vnftools - VnfTools
Add junit test cases for VnfTools class
In VnfTools:
- Fix sonarlint issues (remove un-used private method and etc)
- Changed tab to 4 spaces as per ONAP Java code style
Issue-Id: SDNC-122
Change-Id: If216f53c8ffa7b646f6ebf18d4b9568cfdf4683b
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
Dan Timoney [Thu, 12 Oct 2017 20:01:06 +0000 (16:01 -0400)]
Fixed vnfapi install issue
Fixed issues with vnfapi install:
- Resolved issue installing vnftools by converting to blueprint
- Resolved issue not finding RPC implementation of vnfapi by fixing
dependency feature vnftools, and by converting vnfapi to blueprint.
The root cause in both cases was probably something wrong with the
provider configuration, but it was simpler (not to mention more
maintainable) to just convert from config to blueprint.
Change-Id: I7010a845687673c932457774f3103834d328ab84
Issue-ID: SDNC-119
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Thu, 12 Oct 2017 13:11:52 +0000 (09:11 -0400)]
Add readthedocs for sdnc/northbound
Add readthedocs documentation for sdnc/northbound.
Change-Id: Iad6b19f8194564807ac5e2b9772a554ab14c2cad
Issue-ID: SDNC-72
Signed-off-by: Dan Timoney <dtimoney@att.com>
surya-huawei [Thu, 12 Oct 2017 08:56:36 +0000 (14:26 +0530)]
Use try-with-resource to close filestream
*Using try-with-resource here makes sure that the resource is
automatically closed and increases code readability
Issue-Id: CCSDK-117
Change-Id: Ie923e4540d5be90324104593a1d5fcb1bd501f5c
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Tue, 10 Oct 2017 20:00:59 +0000 (16:00 -0400)]
Add missing info to swagger doc
Add missing required sections of info in swagger doc for
generic-resource-api
Change-Id: Iea25ce95d6bc0ae0d0edb7ad9a4f71be0669f231
Issue-ID: SDNC-72
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 10 Oct 2017 18:41:12 +0000 (14:41 -0400)]
Convert swagger docs to v 2
Generate updated swagger specs and convert from swagger 1.2 to 2.0
format.
Change-Id: I2d357b903596b3f2341ed5d024465e967fdaa76c
Issue-ID: SDNC-72
Signed-off-by: Dan Timoney <dtimoney@att.com>
Gaurav Agrawal [Wed, 4 Oct 2017 09:34:50 +0000 (15:04 +0530)]
Added new request-actions for overlay
Added new request-actions for dci overlay activation & deactivation. This
is required to differentiate dci activation/deactivation for VoLTE use case
from normal network activation/deactivation.
Change-Id: I865963b78ae8b8ba3a8173259179013997318e87
Issue-Id: SDNC-110
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Brian Freeman [Fri, 29 Sep 2017 13:08:30 +0000 (13:08 +0000)]
Fix url for swagger file
Issue-ID: SDNC-72
Change-Id: Ia0c1504393ea8d3af00a082e0d265ccaf4bfef82
Signed-off-by: Brian Freeman <bf1936@att.com>
Brian Freeman [Thu, 28 Sep 2017 18:37:24 +0000 (18:37 +0000)]
Add VNF-API, GEN-RES SWAGGER doc
Issue-ID: SDNC-72
Change-Id: I1a9fcf3fb99668acba6e89ce8b1db9500adb5670
Signed-off-by: Brian Freeman <bf1936@att.com>
Brian Freeman [Thu, 28 Sep 2017 10:22:15 +0000 (10:22 +0000)]
Setup ReadTheDocs
Issue-ID: SDNC-72
Change-Id: Iad42b847700c37d3f1099d6a8cc521141d66dfae
Signed-off-by: Brian Freeman <bf1936@att.com>
Dan Timoney [Wed, 27 Sep 2017 07:50:34 +0000 (07:50 +0000)]
Merge "Fix VNF-API yang validation issues"
Dan Timoney [Wed, 27 Sep 2017 07:49:39 +0000 (07:49 +0000)]
Merge "Improve SDNC Sonar coverage"
ramu.n [Mon, 25 Sep 2017 12:46:12 +0000 (18:16 +0530)]
Improve SDNC Sonar coverage
Added initial test cases for GENERIC-RESOURCE-APIs
Change-Id: I84a0d44210f97b9378ad75cc55919d5d404be6a2
Issue-Id: SDNC-101
Signed-off-by: Ramu N <ramu.n@huawei.com>
surya-huawei [Fri, 22 Sep 2017 13:44:49 +0000 (19:14 +0530)]
Change "try" to try-with-resources
One major issue in sdnc/northbound module
*This is done for a guaranteed closing of resource
and avoiding the finally block
Issue-Id: CCSDK-87
Change-Id: I3ab9119f0b10f47d16864aa3619cc54e069bb9de
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Fri, 22 Sep 2017 19:44:47 +0000 (19:44 +0000)]
Merge "Remove sdnc-sli version dependency"
Dan Timoney [Fri, 22 Sep 2017 12:03:51 +0000 (12:03 +0000)]
Merge "Fix GENERIC-RESOURCE-API yang validation issues"
Marcus Williams [Thu, 21 Sep 2017 18:27:37 +0000 (18:27 +0000)]
Merge "Refer JUNIT version of parent pom."
Dan Timoney [Thu, 21 Sep 2017 17:42:35 +0000 (17:42 +0000)]
Merge "Add RPCs for vCPE"
ramu.n [Thu, 21 Sep 2017 16:39:22 +0000 (22:09 +0530)]
Fix VNF-API yang validation issues
when validate VNF-API.yang with "pyang" has some issues
Change-Id: I908a6bee90b24614f66df61afccf617a599b58db
Issue-Id: SDNC-99
Signed-off-by: Ramu N <ramu.n@huawei.com>
ramu.n [Thu, 21 Sep 2017 14:48:18 +0000 (20:18 +0530)]
Fix GENERIC-RESOURCE-API yang validation issues
when validate GENERIC-RESOURCE-API.yang with "pyang" has some issues
Change-Id: Ibdc71e5a369a6815766e42667beacc4a262dc196
Issue-Id: SDNC-99
Signed-off-by: Ramu N <ramu.n@huawei.com>
Dan Timoney [Thu, 21 Sep 2017 14:34:32 +0000 (10:34 -0400)]
Add RPCs for vCPE
Added new RPCs for tunnelxconn and brg RPCs.
Change-Id: I036beaad10a8ac1f4c088dffa9a589b7b6bae227
Issue-ID: SDNC-98
Signed-off-by: Dan Timoney <dtimoney@att.com>
Gaurav Agrawal [Thu, 21 Sep 2017 13:12:52 +0000 (18:42 +0530)]
Refer JUNIT version of parent pom.
Remove the hardcoded version and rather take from parent pom.
Change-Id: Ia146f738af2b447b6164bcf8a6ed7a5700d767d9
Issue-Id: SDNC-97
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
surya-huawei [Thu, 21 Sep 2017 06:13:59 +0000 (11:43 +0530)]
Change "try" to try-with-resources
One major issue in sdnc/northbound module
*This is done for a guaranteed closing of resource
and not worrying about finally block to close it
Issue-Id: CCSDK-87
Change-Id: Ic6ea871cb9fb61cbce24b61d7c434d3404570ae7
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Brian Freeman [Tue, 19 Sep 2017 15:13:32 +0000 (15:13 +0000)]
Remove sdnc-sli version dependency
Issue-ID: SDNC-86
Change-Id: Iae6f03e1d69840f0c0d2dab97d502eb61b65b149
Signed-off-by: Brian Freeman <bf1936@att.com>
Dan Timoney [Mon, 18 Sep 2017 20:03:11 +0000 (20:03 +0000)]
Merge "Replace deprecated APIs with newer one"
Gaurav Agrawal [Mon, 18 Sep 2017 11:57:12 +0000 (17:27 +0530)]
Some minor refinements to generic-resource-api
Minor refinements to generic-resource-api including:
1) Replace printStackTrace() with log
2) Use built-in string formatting instead of string concatenation
3) Removed redundant ';' after switch statement
4) Change the private method names to follow guidelines to start with lower case
5) Removed redundant null assignment
Change-Id: I48eb08f7305aa549b952715615201a13c3458ca4
Issue-Id: SDNC-45
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Gaurav Agrawal [Mon, 18 Sep 2017 05:22:15 +0000 (10:52 +0530)]
Replace deprecated APIs with newer one
Replace following deprecated API
1) NotificationProviderService replaced with NotificationPublishService
2) InstanceIdentifier<T> toInstance() replace with build()
3) setProperties replaced with setYangMappingProperties
Change-Id: I89fba42e88363c5e1e5b23fe272d2754361aee25
Issue-Id: SDNC-89
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Dan Timoney [Fri, 15 Sep 2017 18:06:42 +0000 (14:06 -0400)]
Inherit from oparent-odlparent
Update version of root pom to 0.0.2-SNAPSHOT to inherit from oparent-odlparent
Change-Id: I5f06b2f0f7d1d78246579f157a589a2886b76c38
Issue-ID: SDNC-32
Signed-off-by: Dan Timoney <dtimoney@att.com>
Marcus Williams [Fri, 15 Sep 2017 07:28:07 +0000 (07:28 +0000)]
Merge "Set RequestId as MDC in SDNC"
vaibhav.jain1 [Wed, 13 Sep 2017 05:02:02 +0000 (10:32 +0530)]
Set RequestId as MDC in SDNC
SDNC dosen't set RequestId as MDC whereas it logs it into the log message
as svcRequestId. A change has been made to set RequestId as MDC so that
it propagates throughout the flow.
Change-Id: I0b66958f3ece2a90e11d2986cfd5bbd0858d27ce
Issue-ID: SO-87
Signed-off-by: vaibhav.jain1 <vaibhav.jain1@amdocs.com>
Marcus G K Williams [Wed, 13 Sep 2017 18:52:07 +0000 (11:52 -0700)]
Change openecomp to onap in pom.xml
Update components to onap. This change should fix
sdnc-northbound-master-release-version-java-daily
and allow sonar updates.
Issue-Id: SDNC-65
Change-Id: Id6ccb9b3d39cddc64f95eb89efb0de6a10b58485
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Jessica Wagantall [Fri, 8 Sep 2017 18:51:39 +0000 (11:51 -0700)]
Cleanup project's name in Sonar
The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.
Change-Id: I29c6363a2ee4fc65f85a25709aa219ee16897d07
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
ramu.n [Fri, 8 Sep 2017 09:15:31 +0000 (14:45 +0530)]
Fix few Blocker/Critical sonar issues
Fix few Blocker/Critical sonar issues in sdnc northbound modules
https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.northbound%3Asdnc-northbound#resolved=false|severities=BLOCKER%2CCRITICAL
Change-Id: I277dd72784a2186acffdd2a7045fecbef528f56b
Issue-Id: SDNC-65
Signed-off-by: Ramu N <ramu.n@huawei.com>
Dan Timoney [Thu, 7 Sep 2017 20:04:08 +0000 (20:04 +0000)]
Merge "Enable surefire unit tests"
Gaurav Agrawal [Thu, 7 Sep 2017 15:02:21 +0000 (20:32 +0530)]
Some minor refinements/fixes
Minor refinements to generic-resource-api like sonar issue fix, removal of redundant typecast etc.
Change-Id: Ibb52f280847478e589640afb428088f379fab5b3
Issue-Id: SDNC-45
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Gaurav Agrawal [Thu, 7 Sep 2017 14:00:58 +0000 (19:30 +0530)]
Replace deprecated APIs with newer one
Replace following deprecated API
1) NotificationProviderService replaced with NotificationPublishService
2) InstanceIdentifier<T> toInstance() replace with build()
3) setProperties replaced with setYangMappingProperties
Change-Id: Id3e9f116cb825187bf65cc5ac9d6f49484ab0846
Issue-Id: SDNC-45
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Dan Timoney [Thu, 7 Sep 2017 13:13:43 +0000 (13:13 +0000)]
Merge "Fix Blocker/Critical sonar issues"
Gaurav Agrawal [Thu, 7 Sep 2017 10:37:36 +0000 (16:07 +0530)]
Update revision no of generic-resource-api.yang
Update the generic-resource-api-provider.yang revision to fall in-line with generic-resource-api.yang, also depicting actual initial version addition date.
Issue-Id: SDNC-45
Change-Id: I3193d997fb7261ca1c61eaa61acf949c806e56a4
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Ramu N [Thu, 7 Sep 2017 09:39:16 +0000 (15:09 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in vnfapi module
https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.northbound%3Asdnc-northbound#resolved=false|severities=BLOCKER%2CCRITICAL
Issue-Id: SDNC-65
Change-Id: Ie5617b7f40ed1d05eb9657a9686fef4b4c9bec35
Signed-off-by: Ramu N <ramu.n@huawei.com>
Marcus G K Williams [Wed, 6 Sep 2017 21:59:20 +0000 (14:59 -0700)]
Enable surefire unit tests
Issue-Id: SDNC-65
Change-Id: I6bd2a5e1fe8aac68c160c1e481106aa507dc67e1
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Dan Timoney [Wed, 6 Sep 2017 00:33:51 +0000 (20:33 -0400)]
Seed code submit of generic-resource-api
Final seed code submit of generic-resource-api. This version is ready
to submit if it verifies clean.
Change-Id: Id5d5cec97a5deccfbda478c0dd7e1967900d76a1
Issue-ID: SDNC-45
Signed-off-by: Dan Timoney <dtimoney@att.com>
Marcus G K Williams [Thu, 31 Aug 2017 02:32:32 +0000 (19:32 -0700)]
Update SDNC NB to depend on CCSDK
Refactor code to use CCSDK
Issue-Id: SDNC-50
Change-Id: If637d1a0609ec5ae9df60939f72eb64888e61e71
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Dan Timoney [Wed, 30 Aug 2017 14:28:08 +0000 (10:28 -0400)]
Prune migrated components from sdnc/northbound
Prune components that were migrated from sdnc/northbound to ccsdk by
removing code and replacing with a README.md that redirects the reader
to the appropriate CCSDK repo
Change-Id: I317b1d0093a1dd4647feaf6b852826a2230f4879
Issue-ID: SDNC-59
Signed-off-by: Dan Timoney <dtimoney@att.com>
Brian Freeman [Thu, 24 Aug 2017 12:51:40 +0000 (12:51 +0000)]
fix dmaap-listener startup and library
Change-Id: Ice802b7c415f622e161d0ade2daf933064ac8edd
Signed-off-by: Brian Freeman <bf1936@att.com>
Issue-Id: SDNC-67
Dan Timoney [Mon, 7 Aug 2017 20:41:48 +0000 (16:41 -0400)]
Update root pom
Update to use root-boron-sr1 artifactId for root pom. There is only one
version of this artifact, so should avoid missing version problem.
Change-Id: I4dc81744acf2b47b987544a3e90ac96cfadd3cb2
Issue-ID: SDNC-42
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Thu, 22 Jun 2017 21:24:56 +0000 (17:24 -0400)]
[ROOTPOM FIX] Use version 1.1.0 of root pom
To avoid 'disappearing' root poms, change root pom version to 1.1.0. If later version is used, Jenkins build will look for earlier versions as part of build and if they disappear, build will fail. If root pom stays frozen at 1.1.0, it will be recreated daily as part of daily build.
Change-Id: Ifedf465048d63d35226a27244491eceaec17223b
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Mon, 5 Jun 2017 20:16:27 +0000 (16:16 -0400)]
[SDNC-14] Roll northbound to version 1.1.2
Roll northbound to use version 1.1.2 of rootpom, to ensure latest version is being used
Change-Id: I44f45531212bf4bb7eb3bffdc25f34bd1ad8e592
Signed-off-by: Dan Timoney <dtimoney@att.com>
Guo Ruijing [Tue, 23 May 2017 07:14:07 +0000 (07:14 +0000)]
fix some build issues
1. use 1.1.1 rootpom
2. add verson for opendaylight-karaf-empty
3. use parameter for dblib-provider
Change-Id: Ia68a765011c70eae4a7275b33bc2906ed95ba5fb
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
David Stilwell [Thu, 18 May 2017 19:54:05 +0000 (19:54 +0000)]
Merge "[BLACKDUCK] Fix blackduck config"
Dan Timoney [Thu, 18 May 2017 19:45:26 +0000 (19:45 +0000)]
Merge "fix maven local build issue"
Dan Timoney [Thu, 18 May 2017 16:40:06 +0000 (12:40 -0400)]
[BLACKDUCK] Fix blackduck config
Fix blackduck configuration so that BOM file can be generated via mvn install -P blackduck
Change-Id: Ia59ca1d94aedfa849a3784d9063c4243798f0a2b
Signed-off-by: Dan Timoney <dtimoney@att.com>
Guo Ruijing [Wed, 3 May 2017 23:55:30 +0000 (23:55 +0000)]
fix maven local build issue
onap jenkins use maven-assembly-plugin 2.2-beta-5. without fix, local build use
maven-assembly-plugin 2.4.1 and build fails as:
Assembly is incorrectly configured: null.
to fix local build issue:
1. update to maven-assembly-plugin 2.6
2. add AssemblyId configuration which is needed for assembly >= 2.2
Change-Id: Id929f6ff31beb64e9025346c0bf636d44a5eaa47
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
Code Review / sdnc / northbound.git / log