GenericResourceApiProvider unit tests part 6.

[sdnc/northbound.git] / generic-resource-api / provider / src / test / java / org / onap / sdnc / northbound / VnfTopologyOperationRPCTest.java

diff --git a/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/VnfTopologyOperationRPCTest.java b/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/VnfTopologyOperationRPCTest.java
index a39146b..645cbf2 100644 (file)
--- a/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/VnfTopologyOperationRPCTest.java
+++ b/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/VnfTopologyOperationRPCTest.java
@@ -13,6 +13,7 @@ import static org.onap.sdnc.northbound.util.MDSALUtil.sdncRequestHeader;
 import static org.onap.sdnc.northbound.util.MDSALUtil.serviceInformationBuilder;
 import static org.onap.sdnc.northbound.util.MDSALUtil.serviceResponseInformation;
 import static org.onap.sdnc.northbound.util.MDSALUtil.vnfInformationBuilder;
+import static org.onap.sdnc.northbound.util.MDSALUtil.vnfResponseInformation;
 import static org.onap.sdnc.northbound.util.MDSALUtil.vnfTopologyOperationInput;
 import static org.onap.sdnc.northbound.util.MDSALUtil.vnfTopologyOperationOutput;
 
@@ -61,7 +62,8 @@ public class VnfTopologyOperationRPCTest extends GenericResourceApiProviderTest
 
         VnfTopologyOperationInput input = build(vnfTopologyOperationInput()
             .setServiceInformation(build(serviceInformationBuilder().
-                setServiceInstanceId("test-service-instance-id")))
+                setServiceInstanceId("test-service-instance-id")
+            ))
         );
 
         VnfTopologyOperationOutput output =
@@ -81,9 +83,11 @@ public class VnfTopologyOperationRPCTest extends GenericResourceApiProviderTest
 
         VnfTopologyOperationInput input = build(vnfTopologyOperationInput()
             .setServiceInformation(build(serviceInformationBuilder()
-                .setServiceInstanceId("test-service-instance-id")))
+                .setServiceInstanceId("test-service-instance-id")
+            ))
             .setVnfInformation(build(vnfInformationBuilder()
-                .setVnfId("test-vnf-id")))
+                .setVnfId("test-vnf-id")
+            ))
         );
 
         VnfTopologyOperationOutput output =
@@ -101,9 +105,11 @@ public class VnfTopologyOperationRPCTest extends GenericResourceApiProviderTest
 
         VnfTopologyOperationInput input = build(vnfTopologyOperationInput()
             .setServiceInformation(build(serviceInformationBuilder()
-                .setServiceInstanceId("test-service-instance-id")))
+                .setServiceInstanceId("test-service-instance-id")
+            ))
             .setVnfInformation(build(vnfInformationBuilder()
-                .setVnfId("test-vnf-id")))
+                .setVnfId("test-vnf-id")
+            ))
         );
 
         VnfTopologyOperationOutput output =
@@ -129,9 +135,11 @@ public class VnfTopologyOperationRPCTest extends GenericResourceApiProviderTest
 
         VnfTopologyOperationInput input = build(vnfTopologyOperationInput()
             .setServiceInformation(build(serviceInformationBuilder()
-                .setServiceInstanceId("test-service-instance-id")))
+                .setServiceInstanceId("test-service-instance-id")
+            ))
             .setVnfInformation(build(vnfInformationBuilder()
-                .setVnfId("test-vnf-id")))
+                .setVnfId("test-vnf-id")
+            ))
         );
 
         VnfTopologyOperationOutput output =
@@ -159,10 +167,11 @@ public class VnfTopologyOperationRPCTest extends GenericResourceApiProviderTest
                 .setRequestAction(RequestInformation.RequestAction.CreateServiceInstance)
             ))
             .setServiceInformation(build(serviceInformationBuilder()
-                .setServiceInstanceId("test-service-instance-id")))
+                .setServiceInstanceId("test-service-instance-id")
+            ))
             .setVnfInformation(build(vnfInformationBuilder()
-                .setVnfId("test-vnf-id")))
-
+                .setVnfId("test-vnf-id")
+            ))
         );
 
         VnfTopologyOperationOutput output =
@@ -172,22 +181,22 @@ public class VnfTopologyOperationRPCTest extends GenericResourceApiProviderTest
         assertEquals("OK", output.getResponseMessage());
         assertEquals("Y", output.getAckFinalIndicator());
 
-        VnfTopologyOperationOutput expectedVnfTopologyOperationOutput = createExpectedVTOO(svcResultProp,
+        VnfTopologyOperationOutput expectedVnfTopologyOperationOutput = createExpectedOutput(svcResultProp,
             input);
         assertEquals(expectedVnfTopologyOperationOutput, output);
     }
 
-    private VnfTopologyOperationOutput createExpectedVTOO(PropBuilder expectedSvcResultProp,
+    private VnfTopologyOperationOutput createExpectedOutput(PropBuilder svcResultProp,
         VnfTopologyOperationInput vnfTopologyOperationInput) {
         return build(
             vnfTopologyOperationOutput()
                 .setSvcRequestId(vnfTopologyOperationInput.getSdncRequestHeader().getSvcRequestId())
-                .setResponseCode(expectedSvcResultProp.get(svcClient.errorCode))
-                .setAckFinalIndicator(expectedSvcResultProp.get(svcClient.ackFinal))
-                .setResponseMessage(expectedSvcResultProp.get(svcClient.errorMessage))
+                .setResponseCode(svcResultProp.get(svcClient.errorCode))
+                .setAckFinalIndicator(svcResultProp.get(svcClient.ackFinal))
+                .setResponseMessage(svcResultProp.get(svcClient.errorMessage))
                 .setServiceResponseInformation(build(serviceResponseInformation()
                     .setInstanceId(vnfTopologyOperationInput.getServiceInformation().getServiceInstanceId())
-                    .setObjectPath(expectedSvcResultProp.get("vnf-object-path"))
+                    .setObjectPath(svcResultProp.get(svcClient.serviceObjectPath))
                 ))
         );
     }