sdc.git
3 years agoUpdate Release Note 73/110273/1 1.7.0
ChrisC [Thu, 23 Jul 2020 15:00:16 +0000 (17:00 +0200)]
Update Release Note

Update Release note for Frankfurt Maintenance release

Issue-ID: SDC-3189
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I5b0fb24938646b1ef4344449301caf056bd8cac4

3 years agoFix CRITICAL BUG 09/110409/2
vasraz [Tue, 21 Jul 2020 11:10:39 +0000 (12:10 +0100)]
Fix CRITICAL BUG

https://sonarcloud.io/project/issues?fileUuids=AXF_8JZ3aPDFCRVJURGa&id=onap_sdc&resolved=false&types=BUG

Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3204
Change-Id: I55f1c6c95c4de59d9ca5493d99c7fd3569379622

3 years agoUpdate INFO.yaml 22/110322/3
ChrisC [Fri, 17 Jul 2020 13:21:12 +0000 (15:21 +0200)]
Update INFO.yaml

Update committer list as per : https://lists.onap.org/g/onap-tsc/topic/75373026#6714

Issue-ID: SDC-3203
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: Ida7f9a6a36fe0cbc8f3c3f7fae0693e9e0bc9320

3 years agoAlign onap/base_sdc-xyz versions 70/110170/2
vasraz [Tue, 14 Jul 2020 18:24:24 +0000 (19:24 +0100)]
Align onap/base_sdc-xyz versions

Change-Id: Ic2e53bb76b0b6bc54de3336f5e5916eba189fe18
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3201

3 years agoFix missing referenced node_types 68/110168/2
KrupaNagabhushan [Tue, 7 Jul 2020 16:36:11 +0000 (17:36 +0100)]
Fix missing referenced node_types

Issue-ID: SDC-3153
Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech>
Change-Id: I0b17ac92a49e1f006f5708b20af82a62ee769a9e

3 years agoRefactor CsarUtils::addInnerComponentsToCSAR 07/110007/6
Francis Toth [Wed, 8 Jul 2020 12:28:25 +0000 (08:28 -0400)]
Refactor CsarUtils::addInnerComponentsToCSAR

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I4f9a52950d4d6ffadf9a5cb170c99d229ac83a35
Issue-ID: SDC-2812

3 years agoAdd substitution_filter endpoints unit tests 48/109748/3
aribeiro [Tue, 30 Jun 2020 10:59:57 +0000 (11:59 +0100)]
Add substitution_filter endpoints unit tests

Issue-ID: SDC-3166
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: Ie01f7abc5eccc36e8f1159cbece329a7fadeacd5

3 years agoAdd endpoints for supporting substitution_filter 20/109720/4
aribeiro [Fri, 26 Jun 2020 15:33:22 +0000 (16:33 +0100)]
Add endpoints for supporting substitution_filter

Issue-ID: SDC-3160
Change-Id: Ibc722f283451fecde7655e867654880ae50cc645
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
3 years agoAdd substitution_filter business logic unit tests 47/109747/2
aribeiro [Mon, 29 Jun 2020 16:12:19 +0000 (17:12 +0100)]
Add substitution_filter business logic unit tests

Issue-ID: SDC-3165
Change-Id: I91f3075c43d04add450c16614b07f08219ad743d
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
3 years agoClean ValidatorExecutor hierarchy 62/109962/4
Francis Toth [Tue, 7 Jul 2020 13:10:33 +0000 (09:10 -0400)]
Clean ValidatorExecutor hierarchy

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I9d919b1d57eac1d25c8b3874366c2cb9e906923a
Issue-ID: SDC-2499

3 years agoAdd support for substitution_filter business logic 19/109719/4
aribeiro [Wed, 24 Jun 2020 07:34:22 +0000 (08:34 +0100)]
Add support for substitution_filter business logic

Tosca simple YAML profile allows for
substitution_filter to be specified for
a topology template to provide processing
instructions to the orchestrator.

Issue-ID: SDC-3147
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: Ia94b8c447d3157e614f9d1524ad4520b3980ba4d

3 years agoAdd test contracts for ValidatorExecutor and TopologyTemplateValidatorExecutor 92/109892/3
Francis Toth [Tue, 7 Jul 2020 11:24:48 +0000 (07:24 -0400)]
Add test contracts for ValidatorExecutor and TopologyTemplateValidatorExecutor

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I10f0de565588e0bc7cd0f47ba7f714eab3f1f7f7
Issue-ID: SDC-2499

3 years agoFix sonar issues 00/109500/3
sebdet [Wed, 24 Jun 2020 12:10:34 +0000 (14:10 +0200)]
Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3158
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: I33638b39d39b7e918437cb9f3e0f15d52fa92218

3 years agoFix sonar issues 84/109484/3
sebdet [Wed, 24 Jun 2020 10:14:57 +0000 (12:14 +0200)]
Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3158
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: I004b0f579ff1f273f39a155217972f5efcdcf5cb

3 years agoFix sonar issues 83/109483/3
sebdet [Wed, 24 Jun 2020 10:14:27 +0000 (12:14 +0200)]
Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3158
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: Ib6ee78fd5756d615c2a103ac0d7d26070fd24206

3 years agoFix sonar issues 81/109481/10
sebdet [Wed, 24 Jun 2020 09:32:27 +0000 (11:32 +0200)]
Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3158
Change-Id: Ic29f9233838e25c195d2b349bfac8e6d56888609
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
3 years agoFix sonar issues 57/109357/10
sebdet [Fri, 19 Jun 2020 15:27:03 +0000 (17:27 +0200)]
Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3158
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: I0ae188c5f0e2d96fd94de66fe0dcd0c47bcd9af5

3 years agoFix sonar issues 50/109350/14
sebdet [Fri, 19 Jun 2020 12:40:16 +0000 (14:40 +0200)]
Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3116
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: Ic29f9233838e15b195d1a339bfac8e6d56888609

3 years agoClean CsarUtils::MainYamlWithDependencies 21/109621/4
Francis Toth [Fri, 26 Jun 2020 23:53:26 +0000 (19:53 -0400)]
Clean CsarUtils::MainYamlWithDependencies

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I593dd7bb6a20445899a14da793e8c550e1e14e09
Issue-ID: SDC-2812

3 years agoRefactor MapDataDefinitionTest 95/109495/3
xuegao [Wed, 24 Jun 2020 11:52:13 +0000 (13:52 +0200)]
Refactor MapDataDefinitionTest

Adding more tests and adding assert for old tests.

Issue-ID: SDC-3146
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I0b3ebb3d46b26ecdf52c78ee29b2777f6ecc73e5
Signed-off-by: xuegao <xg353y@intl.att.com>
3 years agoFix typo in package name and classes 47/109547/2
Francis Toth [Thu, 25 Jun 2020 11:45:19 +0000 (07:45 -0400)]
Fix typo in package name and classes

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I55a6efeb4a0c2b4734dc3a091afbc6295599c74b
Issue-ID: SDC-2499

3 years agoFix issue introduced by #109494 81/109581/2
vasraz [Thu, 25 Jun 2020 16:40:11 +0000 (17:40 +0100)]
Fix issue introduced by #109494

use maven checkstyle.skip
remove duplicated dependency

Change-Id: I942a9612df7093206d0019d69a8f28c6dff7bcf6
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3148

3 years agoFix test coverage drop introduced by #109510 34/109634/2
vasraz [Sun, 28 Jun 2020 18:55:01 +0000 (19:55 +0100)]
Fix test coverage drop introduced by #109510

Change-Id: Ic74f11f60ff7673330a8c3521da49a92f70ae0fb
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3149

3 years agoFix for NullPointerException while onboarding VF 44/109644/1
KrupaNagabhushan [Fri, 26 Jun 2020 16:59:54 +0000 (17:59 +0100)]
Fix for NullPointerException while onboarding VF

Issue-ID: SDC-3161
Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech>
Change-Id: I6eefcb86c6ef97fb19449e1fc45cee3cb91b3a2a

3 years agoRationalize maven dependencies 10/109510/2
JulienBe [Wed, 24 Jun 2020 15:31:27 +0000 (17:31 +0200)]
Rationalize maven dependencies

Issue-ID: SDC-3149
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
Change-Id: I1ee42494a4cc5b185b6dfcbee44399d2960cf880

3 years agoCleaned up ArtifactValidatorExecuter and IArtifactValidatorExecutor 09/109509/7
Francis Toth [Wed, 24 Jun 2020 13:28:06 +0000 (09:28 -0400)]
Cleaned up ArtifactValidatorExecuter and IArtifactValidatorExecutor

This commit intends to clean the tests related to ArtifactValidatorExecuter and IArtifactValidatorExecutor by introducing the concept of test contract. Some renaming have to be done to fix the typo in Executer (it should be named Executor), hence the number of changes.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I5cd4512c425ae01f4f1118c9d61e6fce3df94f1d
Issue-ID: SDC-2499

3 years agoadd a new profil for fast build 94/109494/2
JulienBe [Wed, 24 Jun 2020 13:35:23 +0000 (15:35 +0200)]
add a new profil for fast build

Issue-ID: SDC-3148
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
Change-Id: Ie98194fe6d136f57491a0590ab2afc9db59fbfbd

3 years agoFix Security Vulnerability 53/109453/2
ChrisC [Tue, 23 Jun 2020 11:50:01 +0000 (13:50 +0200)]
Fix Security Vulnerability

Fix Sonar Major by switching to better protocol

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I9f5d8640c991ae895a41dadf67a11872952fe38a

3 years agoFix Assert 55/109455/2
ChrisC [Tue, 23 Jun 2020 13:08:09 +0000 (15:08 +0200)]
Fix Assert

Fix Sonar Asserts

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I92dcd21a3cec903792c20275be8b955c5910e566

3 years agoFix for name clash in csar generation 15/109415/2
KrupaNagabhushan [Mon, 22 Jun 2020 11:55:04 +0000 (12:55 +0100)]
Fix for name clash in csar generation

Issue-ID: SDC-3144
Change-Id: Ia9b66bb14bbff3add70eed8dfe41acc55c72b35b
Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech>
3 years agoImprovement sdc-BE-init python scripts 23/108823/4
k.kedron [Fri, 5 Jun 2020 12:51:01 +0000 (14:51 +0200)]
Improvement sdc-BE-init python scripts

- Implemented retries when request fail
- Moved configuration variables to the Properties file
- Extended sdcBeProxy
- Implemented script to run import/update (should fix deployment glitch)
- Updated the import_Normatives recipes to use new script

Issue-ID: SDC-2784
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I83fab898783ad8d3b3d532af43d75bc54d033c33

3 years agoRefactoring the check backend, create consumers 62/108762/6
k.kedron [Thu, 4 Jun 2020 08:46:47 +0000 (10:46 +0200)]
Refactoring the check backend, create consumers

Continue refactoring:
- added script for healthCheck, create new consumers
- also update chef recipes to use new script

Issue-ID: SDC-2784
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I158d816362f91f74b217fe85112cf7c14da8f1ec

3 years agoAdd Node Filter Business Logic Unit Tests 53/109353/4
aribeiro [Wed, 17 Jun 2020 13:20:46 +0000 (14:20 +0100)]
Add Node Filter Business Logic Unit Tests

Issue-ID: SDC-3125
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: I80c755f4fffa813396ceb85c6aa7fde5b32590cd

3 years agoRefactoring the sdc-BE-init python scripts 87/103287/6
k.kedron [Thu, 5 Mar 2020 12:12:27 +0000 (13:12 +0100)]
Refactoring the sdc-BE-init python scripts

Deeper refactoring of python script:
- create the python package with init script
- support for python 3.x
- reuse code
- new design
- support for .json conf file
- update the docker chef script

Issue-ID: SDC-2784
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I02169eb7d0e3e90851ba1811536d1712c3b4145f

3 years agoDecouple TXT Report file writing and formatting logic (6/6) 57/109457/2
Francis Toth [Thu, 18 Jun 2020 20:06:01 +0000 (16:06 -0400)]
Decouple TXT Report file writing and formatting logic (6/6)

This commit moves the writeReportLineToFile from ReportManager to ReportFile, deletes ReportManager (as it's not longer used), and finalizes the decoupling between the writing and the formatting logic of the TXT Report file.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Ia5cce71535ea808e6e24807ed62ae9b262eab6ad
Issue-ID: SDC-2499

3 years agoDecouple TXT Report file writing and formatting logic (5/6) 16/109416/2
Francis Toth [Thu, 18 Jun 2020 19:46:31 +0000 (15:46 -0400)]
Decouple TXT Report file writing and formatting logic (5/6)

This commit aims to move the reportEndOfToolRun function from ReportManager (deprecated) to ReportFile.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I17731864c34ed9a70b1b1e91b89bad835dc72449
Issue-ID: SDC-2499

3 years agoImprove test coverage 94/109294/8
xuegao [Thu, 18 Jun 2020 09:59:43 +0000 (11:59 +0200)]
Improve test coverage

Adding more tests to improve test coverage.

Issue-ID: SDC-3129
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I23a717bfb6a0004e58ff3ca37d6dd877a956931e
Signed-off-by: xuegao <xg353y@intl.att.com>
3 years agoRefactor ToscaTypeTest 02/109402/6
xuegao [Mon, 22 Jun 2020 10:15:06 +0000 (12:15 +0200)]
Refactor ToscaTypeTest

Adding more tests and adding assert for old tests.

Issue-ID: SDC-3143
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: Id7cf5ec763b0d43dece9493613e336a4b3df9b72
Signed-off-by: xuegao <xg353y@intl.att.com>
3 years agoDecouple TXT Report file writing and formatting logic (4/6) 04/109404/2
Francis Toth [Thu, 18 Jun 2020 19:35:05 +0000 (15:35 -0400)]
Decouple TXT Report file writing and formatting logic (4/6)

This commit aims to move the reportValidatorTypeSummary function from ReportManager (deprecated) to ReportFile.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I30898d69bbcdb129a2dac917c4dee3c276556e91
Issue-ID: SDC-2499

3 years agoDecouple TXT Report file writing and formatting logic (3/6) 87/109387/1
Francis Toth [Thu, 18 Jun 2020 19:30:26 +0000 (15:30 -0400)]
Decouple TXT Report file writing and formatting logic (3/6)

This commit aims to move the printValidationTaskStatus function's logic from ReportManager (deprecated) to ReportFile.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Ic33a519f4c70276d404a83bf7de8a27f0007b285
Issue-ID: SDC-2499

3 years agoImprove ActionUtil coverage and improve Sonar score 51/109351/4
JulienBe [Fri, 19 Jun 2020 14:54:22 +0000 (16:54 +0200)]
Improve ActionUtil coverage and improve Sonar score

Issue-ID: SDC-3133
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
Change-Id: I5e6f927599520efa5bfa5856863ca173ecdfb553
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
3 years agoToggle 58/109258/5
talio [Wed, 17 Jun 2020 12:57:06 +0000 (15:57 +0300)]
Toggle

Add toggling mechanism to catalog side.
The first toggleable feature is healing - this was added to healing flow, in healJanusGraphDao

Issue-ID: SDC-2874
Signed-off-by: talio <talio@amdocs.com>
Change-Id: If386651cab8304ebaf13497ded3a7a50bd60e477
Signed-off-by: talio <talio@amdocs.com>
3 years agoAdd Node Filter Servlets Unit Tests 52/109352/2
aribeiro [Mon, 15 Jun 2020 16:23:42 +0000 (17:23 +0100)]
Add Node Filter Servlets Unit Tests

Issue-ID: SDC-3117
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: I84e728f21290a59c7674f97d5977b945b93ef546

3 years agoAdd Support for node_filters 57/109157/2
aribeiro [Mon, 25 May 2020 10:33:22 +0000 (11:33 +0100)]
Add Support for node_filters

Allows for node_filter to be specified for a node template
to provide processing instructions to the orchestrator

Issue-ID: SDC-3095
Change-Id: I4e496e300552049d9bfd00df878b86d9fb97312b
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
3 years agoFix sonar issues 40/109340/3
sebdet [Fri, 19 Jun 2020 09:39:50 +0000 (11:39 +0200)]
Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3116
Change-Id: I87802cc9edb378bdbe456c3ca4f10d8c6ebe9425
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
3 years agoFix sonar issues 96/109296/4
sebdet [Thu, 18 Jun 2020 10:42:41 +0000 (12:42 +0200)]
Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3116
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: I87802bb9edb378bdbe456c3ca4f10d8c6dae9437

3 years agoDecouple TXT Report file writing and formatting logic (2/6) 67/109367/3
Francis Toth [Thu, 18 Jun 2020 19:23:12 +0000 (15:23 -0400)]
Decouple TXT Report file writing and formatting logic (2/6)

This commit aims to move the reportStartValidatorRun function's logic from ReportManager (deprecated) to ReportFile.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I93c2e8f98cdef598094647d734d0deec0f1941db
Issue-ID: SDC-2499

3 years agoFix Assert usage 63/109363/3
ChrisC [Fri, 19 Jun 2020 16:05:20 +0000 (18:05 +0200)]
Fix Assert usage

Sonar Fix, fix assert usage in this file

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I292649e84e589a35eb69139de53b3ee95223be26

3 years agofix sonar issues related to MessageContainer.java 91/109291/3
JulienBe [Thu, 18 Jun 2020 11:33:05 +0000 (13:33 +0200)]
fix sonar issues related to MessageContainer.java

Issue-ID: SDC-3127
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
Change-Id: I02357fa3cbf7afd7845737ba01c72dc202401882
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
3 years agoRemove duplicate code 34/109334/3
xuegao [Fri, 19 Jun 2020 07:23:42 +0000 (09:23 +0200)]
Remove duplicate code

Removing duplicate code.

Issue-ID: SDC-3132
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I595a791ebd7cb160d7149ea92a6434d52cfc9f48

3 years agoRemove unused method 95/109295/7
xuegao [Thu, 18 Jun 2020 10:00:35 +0000 (12:00 +0200)]
Remove unused method

Removing unused method in Constraint and use lombok annotations instead.

Issue-ID: SDC-3130
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: Ia718d184c55d40503f42830966bb11675b7c3f85
Signed-off-by: xuegao <xg353y@intl.att.com>
3 years agoFix Vulnerabilities 98/109098/6
xuegao [Fri, 12 Jun 2020 11:01:57 +0000 (13:01 +0200)]
Fix Vulnerabilities

Fix the vulnerabilities reported by Sonar.

Issue-ID: SDC-3114
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: Icf97e427ef0c192b2f279380d7ee9eb570949d1f
Signed-off-by: xuegao <xg353y@intl.att.com>
3 years agoFix Sonar issues 35/109335/2
ChrisC [Fri, 19 Jun 2020 08:26:12 +0000 (10:26 +0200)]
Fix Sonar issues

Assert params updated to be in correct order

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I8be2dec4a1d5ec9ab59ea8fddab540958fe25511

3 years agoFix Sonar issues 37/109337/3
ChrisC [Fri, 19 Jun 2020 09:15:07 +0000 (11:15 +0200)]
Fix Sonar issues

Assert params updated to be in correct order

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I10168defa289e45102f7f8aa436db8ca7176fe6a

3 years agoFix Sonar issues 42/109342/3
ChrisC [Fri, 19 Jun 2020 10:08:04 +0000 (12:08 +0200)]
Fix Sonar issues

Fix assertThat usage and tests

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: Ife533a479096047c4ccb7ae46dfaaa6e2ece974d

3 years agoimprove test coverage 02/109202/2
JulienBe [Tue, 16 Jun 2020 17:18:16 +0000 (19:18 +0200)]
improve test coverage

Issue-ID: SDC-3120
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
Change-Id: I8e02fcb3f495d70c14e6e9cf0304085d77918805

3 years agoDecouple TXT Report file writing and formatting logic (1/6) 02/109302/6
Francis Toth [Thu, 18 Jun 2020 11:37:20 +0000 (07:37 -0400)]
Decouple TXT Report file writing and formatting logic (1/6)

This commit is the first of a series aiming to decouple the writing and formatting logic of text report files in the asdc tool. Unfortunately because of a significant amount of technical debt, a small hack had to be done so that the header of the file is not written twice. This will be removed in a future change.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I8d2a7c1353d59562d8026088824c26ae0daa36e9
Issue-ID: SDC-2499

3 years agoFix more doc warnings 13/109313/2
ChrisC [Thu, 18 Jun 2020 14:50:39 +0000 (16:50 +0200)]
Fix more doc warnings

Fix couple of doc warnings

Issue-ID: SDC-1357
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I3c195ab8d9caacce7dde5d8e9631a0fb7c2ea25a

3 years agodatatypes.Constants: 73/109273/2
JulienBe [Wed, 17 Jun 2020 20:27:45 +0000 (22:27 +0200)]
datatypes.Constants:
  - adhere to naming conventions
  - remove unused

Issue-ID: SDC-3126
Change-Id: I4ea23a8c69aaaf8fcc404868d3c59c47d09ba442
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
3 years agoImporting VSP with node_type in separate file 33/108333/5
MichaelMorris [Wed, 27 May 2020 17:09:40 +0000 (18:09 +0100)]
Importing VSP with node_type in separate file

Import fails when a node_type referenced in the main template is defined in a separate yaml file in the csar even when that separate file is correctly imported in the main template

Change-Id: I6abe074585c2ce592fe9bed7abe76f0856bcfe93
Issue-ID: SDC-2850
Signed-off-by: MichaelMorris <michael.morris@est.tech>
3 years agocreate tests for ScalarUnitValidator.java 46/109246/3
JulienBe [Wed, 17 Jun 2020 12:22:53 +0000 (14:22 +0200)]
create tests for ScalarUnitValidator.java

Issue-ID: SDC-3123
Change-Id: Iaa60ce2df46ee7a4d9138a56cf4d4c115a059240
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
3 years agocreate tests for PropertyTypeExt.java and remove unsused method 56/109256/2
JulienBe [Wed, 17 Jun 2020 14:53:55 +0000 (16:53 +0200)]
create tests for PropertyTypeExt.java and remove unsused method

Issue-ID: SDC-3124
Change-Id: I5d3baeeff23c0003952eabc39a5f9dd296dd7c39
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
3 years agoDecouple CSV Report file writing and formatting logic 29/108429/9
Francis Toth [Mon, 20 Apr 2020 23:16:47 +0000 (19:16 -0400)]
Decouple CSV Report file writing and formatting logic

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I6168b71bb54192a806ff6aa437788bedad933c76
Issue-ID: SDC-2499

3 years agoFix Java Code Conventions non-compliance issues 44/109244/3
xuegao [Wed, 17 Jun 2020 07:58:36 +0000 (09:58 +0200)]
Fix Java Code Conventions non-compliance issues

Update locations of the constructor and private variable to comply with the Java Code Conventions.

Issue-ID: SDC-3121
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I0114c880e389f0ed167262c9cd513583be35ba56
Signed-off-by: xuegao <xg353y@intl.att.com>
3 years agoReduce nest statement levels 91/109191/3
xuegao [Tue, 16 Jun 2020 11:15:39 +0000 (13:15 +0200)]
Reduce nest statement levels

Reduce the if/for/switch/try nest statement levels to less than 3.

Issue-ID: SDC-3119
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I60f0c0203db4495c6e10127114acdb8586867b14
Signed-off-by: xuegao <xg353y@intl.att.com>
3 years agoRefactor ArtifactsBusinessLogic::getUpdatedGroupInstances 02/108602/7
Francis Toth [Sun, 31 May 2020 12:42:14 +0000 (08:42 -0400)]
Refactor ArtifactsBusinessLogic::getUpdatedGroupInstances

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I6d62c1f916aa820f84328d25d2afbc7470397b0d
Issue-ID: SDC-2961

3 years agoReduce nest statement levels 86/109186/2
xuegao [Tue, 16 Jun 2020 09:38:34 +0000 (11:38 +0200)]
Reduce nest statement levels

Reduce the if/for/switch/try nest statement levels to less than 3.

Issue-ID: SDC-3118
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I490e66a807a0a8508b7e3c1da332546f2ced3005

3 years agoExtract ComponentCache from CsarUtils 96/108596/7
Francis Toth [Fri, 29 May 2020 14:12:10 +0000 (10:12 -0400)]
Extract ComponentCache from CsarUtils

This commit aims to decouple the component caching logic from CsarUtils to its own class.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Ia7e9284639ec8cd87ca5107e12f295e2eb599768
Issue-ID: SDC-2812

3 years agoSupport the substitution_mappings in the VNFD 61/108261/2
MichaelMorris [Mon, 25 May 2020 16:08:23 +0000 (17:08 +0100)]
Support the substitution_mappings in the VNFD

Signed-off-by: MichaelMorris <michael.morris@est.tech>
Issue-ID: SDC-2957
Change-Id: I8a385b02568b3bf3d83a250cbe36a7e7f61e710c

3 years agoFix Sonar issues 50/109150/3
ChrisC [Mon, 15 Jun 2020 09:28:14 +0000 (11:28 +0200)]
Fix Sonar issues

Hide implicit public constructor in utility class

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I4edd2ac37aab2fd587b5d46391dd669181385748

3 years agoadd information on the containers based on what is available in the wiki 35/109035/4
JulienBe [Thu, 11 Jun 2020 10:06:09 +0000 (12:06 +0200)]
add information on the containers based on what is available in the wiki

Issue-ID: SDC-2449
Change-Id: I740a14623161e051399f03d1788ae8a2605c1076
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
3 years agoManifest is optional in ETSI SOL004 manifest 37/107537/2
MichaelMorris [Tue, 12 May 2020 10:19:47 +0000 (11:19 +0100)]
Manifest is optional in ETSI SOL004 manifest

SOL004MetaDirectoryValidtor enforces all files contained in an ETSI SOL004 CSAR are included in the manifest file, however the manifest itself is not mandatory to include in the manifest

Signed-off-by: MichaelMorris <michael.morris@est.tech>
Issue-ID: SDC-3057
Change-Id: I460071ecbd21578edb0603f600da0ac1ea877539

3 years agoAdd some unit tests 94/105494/5
Satoshi Fujii [Wed, 8 Apr 2020 09:11:41 +0000 (18:11 +0900)]
Add some unit tests

This change added some unit tests for ComponentInstanceBusinessLogic
to increase test coverage and removed unused variables for better
readability.
Also the test class was rewritten to use JUnit 5.

Change-Id: I519976d00d8eccc194f8f1168d45f95392808652
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
Issue-ID: SDC-2885

3 years agoOnboard TOSCA data_types defined in package 90/101490/5
andre.schmid [Wed, 5 Feb 2020 12:13:57 +0000 (12:13 +0000)]
Onboard TOSCA data_types defined in package

Onboard TOSCA data_types defined in a CSAR package
that does not exists in the SDC default data_types
library. Those data_types were being lost.
All data_types declared in the package will be
included in the "GlobalSubstitutionServiceTemplate".
This includes the data_types declared in the main
topology template and in its imported definition
files.
Defines a maven profile to compile the catalog-be
in the main SDC pom.

Change-Id: I39445b0f42e924dc1015945b7e605e804c1d505b
Issue-ID: SDC-2763
Signed-off-by: André Schmid <andre.schmid@est.tech>
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
3 years agoFix 'not running Junit5 tests'-issue 61/109061/2
vasraz [Thu, 11 Jun 2020 11:57:25 +0000 (12:57 +0100)]
Fix 'not running Junit5 tests'-issue

Change-Id: Iee67a4af7262e554a86252b411264f55ff1baa88
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3109

3 years agoFix Critical security vulnerability 69/109069/2
vasraz [Thu, 11 Jun 2020 16:05:29 +0000 (17:05 +0100)]
Fix Critical security vulnerability

com.fasterxml.jackson.core : jackson-databind : 2.9.9

Change-Id: I81af7879cb1fbcd158177a3dc220b704ff2f3388
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3111

3 years agoFix bug in UpdateIsVnfMenu 90/109090/2
xuegao [Fri, 12 Jun 2020 08:39:07 +0000 (10:39 +0200)]
Fix bug in UpdateIsVnfMenu

Fix the unboxing bug reported by Sonar.

Issue-ID: SDC-3112
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I4ed3f9a48ad21af2f9f67872791df2796c4e4ad1

3 years agoUse dummy info for distribution-engine 35/109135/2
Ofir Sonsino [Sun, 14 Jun 2020 15:18:14 +0000 (18:18 +0300)]
Use dummy info for distribution-engine

Change-Id: I7679e0ed8ce4c4217cf6c5f4a646fe06cf32372d
Issue-ID: SDC-3115
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
3 years agoFix Doc warnings 30/109130/2
ChrisC [Sat, 13 Jun 2020 07:26:13 +0000 (09:26 +0200)]
Fix Doc warnings

Fix some RST warnings and rendering issues

Issue-ID: SDC-1357
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I142085dcdbbaf8f1a3de27680548e2c37d0a099e

3 years agoAdd support for directives on VFC 84/107984/6
aribeiro [Wed, 13 May 2020 12:49:31 +0000 (13:49 +0100)]
Add support for directives on VFC

This change also updates the directives values according to Tosca 1.3 spec

Issue-ID: SDC-3074
Change-Id: Ia6a68c9a23a71a2c17ba2c006990342811aa7b4e
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
3 years agoRewrite of `updateArtifactOnInterfaceOperationByResourceUUID` to remove NPE 46/108746/2
Chris André [Wed, 3 Jun 2020 17:23:40 +0000 (13:23 -0400)]
Rewrite of `updateArtifactOnInterfaceOperationByResourceUUID` to remove NPE

Issue-ID: SDC-2978
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I60942ab1767bf65c806ce796ca62365396b20d93

3 years agoSet properties on XML parsers to prevent XXE attack 35/108935/2
Neil Derraugh [Mon, 8 Jun 2020 19:45:58 +0000 (15:45 -0400)]
Set properties on XML parsers to prevent XXE attack

- Set ACCESS_EXTERNAL_DTD and ACCESS_EXTERNAL_SCHEMA properties on XML
parsers to prevent XXE attacks

Issue-ID: SDC-3106
Signed-off-by: Neil Derraugh <neil.derraugh@yoppworks.com>
Change-Id: If4e835858dd3d718d37b3ee41fb2fd0c94574c24

3 years agoFix security issue in SecurityUtil 23/108923/3
Neil Derraugh [Mon, 8 Jun 2020 14:40:10 +0000 (10:40 -0400)]
Fix security issue in SecurityUtil

- Specified mode and padding to address risky algorithm
- Corrected unit test for different exception message
- Moved tests to package

Issue-ID: SDC-3105
Signed-off-by: Neil Derraugh <neil.derraugh@yoppworks.com>
Change-Id: I5773ab555a5468362c775cf99795df4eb8c52136

3 years agoJava 11 migration - 'test-apis-ci' 34/108834/3
Rodrigo Lima [Fri, 5 Jun 2020 18:02:15 +0000 (14:02 -0400)]
Java 11 migration - 'test-apis-ci'

- Removed references to protected packages (sun.net.*)

Issue-ID: SDC-3037
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: Ibbf25af390e624e15fb2bc8ea17777056fe5f3b5

3 years agoFix sonar bugs 29/108829/4
sebdet [Fri, 5 Jun 2020 14:04:28 +0000 (16:04 +0200)]
Fix sonar bugs

Fix all sonar bugs reported in SwitchoverDetector class + fix all checkstyle issues

Issue-ID: SDC-2931
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: Ic86a3526fc7030e10a61b150058c04a391c40c7b

3 years agoclass passed to MdcLogger() is compared by name 78/108778/3
JulienBe [Thu, 4 Jun 2020 17:06:51 +0000 (19:06 +0200)]
class passed to MdcLogger() is compared by name

Issue-ID: SDC-3098
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
Change-Id: I8b61218d1164a0ebff7f290ac82f1cdd67a5152a

3 years agoSupport setting SDC-BE configuration at deployment time 25/108425/2
vasraz [Thu, 28 May 2020 10:44:09 +0000 (11:44 +0100)]
Support setting SDC-BE configuration at deployment time

Change-Id: I4b384bc911630d6041a0c5c235d3aaf3ac148090
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3076

3 years agoAdd build config in README 20/108820/2
sebdet [Fri, 5 Jun 2020 10:55:28 +0000 (12:55 +0200)]
Add build config in README

Add a required step to build the project, the oparent settings.xml must be installed first in .m2

Issue-ID: SDC-2871
Change-Id: Id69582582849a8937f4e76d24d6a6bfdc8f0a957
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
3 years agoMake Directive values Tosca compliant 81/108081/3
aribeiro [Wed, 20 May 2020 09:05:48 +0000 (10:05 +0100)]
Make Directive values Tosca compliant

Issue-ID: SDC-3079
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: Ie711c61244a4e2d68a96e2814ba2db52e067c6e4

3 years agoRewrite of `certifyToscaElement` to remove NPE 28/108728/2
Chris André [Tue, 2 Jun 2020 18:18:43 +0000 (14:18 -0400)]
Rewrite of `certifyToscaElement` to remove NPE

- Modularized `certifyToscaElement` in smaller, less complex methods (`handleRelationsBeforeCertifyingAndProcessClone`, `cloneToscaElementAndHandleRelations`, `handleRelationsOfNewestCertifiedToscaElementAndReturn` & `logDebugMessageAndReturnStorageOperationStatus`)
- Removed potential NPE flagged by Sonar in `certifyToscaElement`

Issue-ID: SDC-2966
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: Id65871cbfd611abdcc878e61c1541f01ff972828

3 years agoRefactor method 'undoCheckout' to simplify it and remove potential NPE 08/108208/3
Chris André [Mon, 25 May 2020 16:51:38 +0000 (12:51 -0400)]
Refactor method 'undoCheckout' to simplify it and remove potential NPE

- Extracted methods 'retrieveAndUpdatePreviousVersion' and 'updateEdgeToCatalogRootAndReturnPreVersionElement' from 'undoCheckout'

Issue-ID: SDC-2965
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I52faffdaf2e99a9de8c2e566da26a5be6e7fd667

3 years agoArtifactsBusinessLogic refactor to remove NullPointerException 01/106301/4
Chris André [Tue, 2 Jun 2020 15:37:03 +0000 (11:37 -0400)]
ArtifactsBusinessLogic refactor to remove NullPointerException

- Reformatted `downloadResourceInstanceArtifactByUUIDs`
- Fixed Sonar-related warning regarding a NPE in `validateInput`

Issue-ID: SDC-2979
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I5a62daabcc436f28fba1f09317c5723281df15bf

3 years agoAdd constraints structure to ToscaProperty 17/108317/2
andre.schmid [Mon, 25 May 2020 13:54:30 +0000 (14:54 +0100)]
Add constraints structure to ToscaProperty

Add constraints structure to ToscaProperty and implements
the valid_values property.

Change-Id: Id69581582839a8937f0c76c24d6a6bfcc7f0a957
Issue-ID: SDC-3084
Signed-off-by: andre.schmid <andre.schmid@est.tech>
3 years agoRefactor CsarUtils::writeComponentInterface 40/108540/3
Francis Toth [Wed, 20 May 2020 16:19:26 +0000 (12:19 -0400)]
Refactor CsarUtils::writeComponentInterface

This commit aims to decouple the zip file writing logic from the CsarUtils::writeComponentInterface function. This should provide a higher level of testability and maintenance thanks to inversion of control. An extra helper has also been added to help the migration from the FJ library to VAVR.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I4f2df4749cae3082906a80acc39045ac8887ec39
Issue-ID: SDC-2812

3 years agoRemove boolean entries in TOSCA Metadata 48/105148/3
MichaelMorris [Mon, 6 Apr 2020 13:00:13 +0000 (14:00 +0100)]
Remove boolean entries in TOSCA Metadata

Change-Id: I0101bbe35656b4c7d7405429d95939b892e85402
Issue-ID: SDC-2876
Signed-off-by: MichaelMorris <michael.morris@est.tech>
3 years agoAdd interface inputs handling 94/107994/4
vasraz [Wed, 20 May 2020 16:27:25 +0000 (17:27 +0100)]
Add interface inputs handling

Enables interface inputs specified in a node_type to be imported and included in the generated csar

Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Change-Id: Ia3acaad50b4091831d0c0471b07ba2b2e9bd380d
Issue-ID: SDC-3077

3 years agoPlugin to customize prop. during Service creation 31/107731/5
andre.schmid [Wed, 13 May 2020 18:11:38 +0000 (19:11 +0100)]
Plugin to customize prop. during Service creation

Creates an entry point to customize properties of a Service
Component before its creation.

Change-Id: I102a70b37eec498dd9c6df009c38da57d0e5b17f
Issue-ID: SDC-3062
Signed-off-by: andre.schmid <andre.schmid@est.tech>
3 years agoFinalize Documentation R6 80/108380/1
Ofir Sonsino [Wed, 27 May 2020 12:08:59 +0000 (15:08 +0300)]
Finalize Documentation R6

Change-Id: I66837d0b314c1a529bd6ca2e29c9527899286c6f
Issue-ID: SDC-2949
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
3 years agoFix interface types creation 90/108190/2
andre.schmid [Wed, 20 May 2020 13:24:40 +0000 (14:24 +0100)]
Fix interface types creation

Interface types creation logic was not interpreting some allowed TOSCA
entries, that, when declared, were breaking the interface type
creation. Every entry under the interface type was being considered
as an interface operation, but it is possible to have "derived_from",
"version", "metadata" and "description". Also it is not considering
the Interface Type entries "inputs", "operations" and "notifications".
Another thing is that TOSCA 1.3 changes the way operations should be
declared, deprecating the previous way. Now there should be an entry
"operations" with the operations entries under it, instead of having
the operations entries direct under the interface type. The change
allows both types, following the TOSCA rule: if operations entry is
not present, then the deprecated way is considered.

Change-Id: I13218bda60b29d19b9c5565cbfd63ae3250a78bf
Issue-ID: SDC-3075
Signed-off-by: andre.schmid <andre.schmid@est.tech>
3 years agoEntry points in ToscaExportHandler for plugin use 01/108301/2
andre.schmid [Mon, 25 May 2020 16:47:47 +0000 (17:47 +0100)]
Entry points in ToscaExportHandler for plugin use

Open the access for two methods in ToscaExportHandler so they
can be called in a CsarEntryGenerator plugin.

Change-Id: I0ee1daab348c0fc85db56428369a5ec190cb0101
Issue-ID: SDC-3083
Signed-off-by: andre.schmid <andre.schmid@est.tech>