Merge "EpNotificationItem class DB constraints"

Merge "EpRoleNotificationItem class DB constraints"

Merge "ExtractJar sonar issues fix"

Merge "CommonWidget class DB constraints"

Merge "XSS Vulnerability fix in PortalAdminController"

Merge "Fix sql injection vulnerability"

Merge "Fix sql injection vulnerability"

Merge "Fix sql injection vulnerability"

Merge "Fix sql injection vulnerability"

Merge "Fix sql injection vulnerability"

XSS Vulnerability fix in PortalAdminController

Custom data validator used to fix this issue.

Issue-ID: OJSI-15
Change-Id: I224887d31e4e2d7301544194ef44ba38e66e047d
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

AuthUtil method isAccessAllowed() argument change

Change argument length to match argument length from to sdk version.

Issue-ID: PORTAL-656
Change-Id: I6fe28800e0baccaab43419d3aa0d8c43b1ebe771
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

LanguageServiceImpl logging vulnerability fix

Sonar issue: "Use a logger to log this exception" fix
This patch also minor code issues

Issue-ID: PORTAL-622
Change-Id: I304285ca7837bcf929249f7c6b93b6de9cf8fae5
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

EPAppServiceImpl class fix.

Sonar issues fix:
Remove this unused "logger" private field.
Remove this unused "syncRests" private field.

unused imports delete and unneeded fields initialization fix.
StringBuilder performance fix.

Issue-ID: PORTAL-620
Change-Id: Ibd1cf732b216594b47801767d0a98e59b0aba200
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

Fix sql injection vulnerability

Use a variable binding instead of concatenation.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: Ia655ccf79800c132b3ac466016b8fdfd9f9c27bd

Fix sql injection vulnerability

Use a variable binding instead of concatenation.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I9dcec677ee9edd0d274a486af37eb950d8e828cf

Fix sql injection vulnerability

Use a variable binding instead of concatenation.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I8d72c819004f05fbbf464cde73b405f2028c7bb6

PeerBroadcastSocket sonar issues fix and code refactor

Sonar issues fix and code refactor.
Session data save moved to another method.
Rest of code don't really do anything.

Issue-ID: PORTAL-624
Change-Id: I53b36377f2d2645d8c24ad2384959f0599e07303
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

ONAPWelcomeController sonar issue fix

String viewName and getter/setter can be romoved from his class.
ONAPWelcomeController Overrides this field 1 to 1.

Issue-ID: PORTAL-652
Change-Id: Idbb41f52a63c6ea681f6ba7753991d766849e3a2
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

ONAPLoginController sonar issues fix.

Sonar issues fix plus @Autowired in constructor not in fields.

Issue-ID: PORTAL-651
Change-Id: I99329b986877d040c6fdda9daf42a5c501a39605
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

SimpleLoginStrategy sonar issues fix

"Either remove or fill this block of code."
"Move the "" string literal on the left side of this string comparison."
"Define and throw a dedicated exception instead of using a generic one."

Issue-ID: PORTAL-650
Change-Id: I92018287a6f585020f0ae6f042b1bb1de84a5e14
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

OpenIdConnectLoginStrategy sonar issues fix

Redundant suppression("rawtypes") removed.
Sonar issue:
Move the "" string literal on the left side of this string comparison.
Define and throw a dedicated exception instead of using a generic one.

Issue-ID: PORTAL-649
Change-Id: Ia2c80ad4848c22c94a2db731425250784d382841
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

Fix sql injection vulnerability

Use a variable binding instead of concatenation.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I0574e882e4d500408b6a6bab8986822669cba5d4

Fix sql injection vulnerability

Use a variable binding instead of concatenation.
Change test 'getAppRolesForNonCentralizedPartnerAppTest'.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: Ia75da49ed582836a47b5fdcddab62fbe02e36e72

Merge "Fix sql injection vulnerability"

Merge "Fix sql injection vulnerability"

Merge "Fix sql injection vulnerability"

WebAnalyticsExtAppController sonar issues

- Rename this local variable to match the regular expression
- Make this anonymous inner class a lambda.
- Immediately return this expression instead of assigning it to
the temporary variable "response".
- Move the "" string literal on the left side of this string comparison.
- Replace the type specification in this constructor call
with the diamond operator ("<>").

Issue-ID: PORTAL-648
Change-Id: I1666d94dccbbe8aa835ea9a443a9973a245353f4
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

HealthMonitor sonar issues

Remove this unused "numIntervalsClusterNotHealthy" local variable.
Use "Long.parseLong" for this string-to-long conversion.
Make the enclosing method "static" or remove this set.
Change this instance-reference to a static reference.
Remove the literal "false" boolean value.
This block of commented-out lines of code should be removed.
Add the "@Override" annotation above this method signature

Issue-ID: PORTAL-647
Change-Id: I1880177f0906e6267807bbb9c0b7a81651e3c020
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

EPLdapService sonar issue fix

Annotate the interface with the @FunctionalInterface annotation.

Issue-ID: PORTAL-646
Change-Id: Idc6c70b9edaed73024721a3bc8c91796a0df9183
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

AppWithRolesForUser sonar security issue

I used Lombok annotation to provide accessors.

Issue-ID: PORTAL-645
Change-Id: Iad852434f30b81535398913df162fa8f4bd1ecff
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

SharedContext class DB constraints

Java Bean Validation SR 380 annotations added to classes
Getter, Setter changed to lombok annotation

Issue-ID: PORTAL-643
Change-Id: I690665b97e431de50750d5a497afcf0cc2efa065
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

FunctionalMenuRole class DB constraints

Java Bean Validation SR 380 annotations added to classes
Getter, Setter, hashCode, equals changed to lombok annotation

Issue-ID: PORTAL-642
Change-Id: I666b0245add8e97f490d991701f548c0cd128cb6
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

PortalAdmin class DB constraints

Java Bean Validation SR 380 annotations added to classes
Getter/Setter changed into lombok annotation

Issue-ID: PORTAL-641
Change-Id: I98909f4a82372f110aa42452476fb85c9bccbf3a
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

FavoritesFunctionalMenuItemJson class DB constraints

Java Bean Validation SR 380 annotations added to classes

Issue-ID: PORTAL-640
Change-Id: I5080e848de12669db9cdd24afe86510dcd82c3e2
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

EpNotificationItem class DB constraints

Java Bean Validation SR 380 annotations added to classes
Unnecessary getter/setter, hashCode/equals changed to lombok annotation

Issue-ID: PORTAL-639
Change-Id: I58a6c734446fa10499feb7e4f1cef57dfd9e66b0
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

EpRoleNotificationItem class DB constraints

Java Bean Validation SR 380 annotations added to classes

Issue-ID: PORTAL-638
Change-Id: I035ad9703f25cc87567700f66c3649ca53aee2df
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

CommonWidget class DB constraints

Java Bean Validation SR 380 annotations added to classes

Issue-ID: PORTAL-637
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: I64741f835deb8aed14ad8d716d21bb4c1901b55f

Merge "PortalAdminUserRole class DB constraints"

Merge "MicroserviceParameter class DB constraints"

Merge "MicroserviceDataApp class DB constraints"

Merge "Application Onboarding page changes "

Application Onboarding page changes

Issue-ID: PORTAL-644

Application Onboarding page changes , DB scripts

Change-Id: Id689e15f5abd56192420e6761440659531108ab4
Signed-off-by: Kotta, Shireesha (sk434m) <sk434m@att.com>

Merge "Sonar: Reduce cyclomatic complexity"

Fix sql injection vulnerability

Use a variable binding instead of concatenation.
Change test 'getAppRolesForNonCentralizedPartnerAppTest'.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I676ed349746cdabf320027dd27a0c16949fff6d8

Fix sql injection vulnerability

Use a variable binding instead of concatenation.
Change test 'getAppRolesForNonCentralizedPartnerAppTest'.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I45895dc7665ff17394e602cbccf875e4e91b5ce1

Fix sql injection vulnerability

Use a variable binding instead of concatenation.
Change test 'getAppRolesForNonCentralizedPartnerAppTest'.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I5cb7561e4b2b781834bd4f2ec36dee58b4738bf2

Merge "WidgetFileApp class DB constraints"

Merge "FavoritesFunctionalMenuItem class DB constraints"

Merge "WidgetCatalog class DB constraints"

Merge "Change default character to utf8 for portal db"

Merge "Sonar critical fixes in MicroserviceServiceImpl"

Merge "Sonar fix: make "dateFormat" an instance variable"

Merge "Sonar critical fixes in EPAppCommonServiceImpl"

Merge "RoleApp class DB constraints"

Merge "App class DB constraints"

Merge "FunctionalMenuItem DB constraints fix"

Merge "FunctionalMenuItem DB constraints add"

Merge "XSS Vulnerability fix in DashboardSearchResultController"

Merge "Custom data validator"

Merge "XSS Vulnerability fix in TicketEventController"

Merge "XSS Vulnerability fix in RoleManageController"

Merge "Fix sql injection vulnerability"

Merge "XSS Vulnerability fix in AppsOSController"

Merge "XSS Vulnerability fix in AppsControllerExternalRequest"

Merge "Sonar issue: Correct this "&" to "&&" in MicroserviceServiceImpl"

Merge "XSS Vulnerability fix in MicroserviceController"

Merge "XSS Vulnerability fix in DashboardSearchResultController"

PortalAdminUserRole class DB constraints

Java Bean Validation SR 380 annotations added to classes

Issue-ID: PORTAL-636
Change-Id: I8fb4f50e672e17b9e169303eb09255fe57288b45
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

MicroserviceParameter class DB constraints

Java Bean Validation SR 380 annotations added to classes

Issue-ID: PORTAL-635
Change-Id: Idcca0d46d1779d5fae874aff38cfd7f59f73c9b0
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

MicroserviceDataApp class DB constraints

Java Bean Validation SR 380 annotations added to classes

Issue-ID: PORTAL-634
Change-Id: Ife3b0116b986d52fd17612937b2a74fa76062ed9
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

WidgetFileApp class DB constraints

Java Bean Validation SR 380 annotations added to classes

Issue-ID: PORTAL-633
Change-Id: Id7b45dedafe2e5f9e799a93d219baef46c88d124
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

FavoritesFunctionalMenuItem class DB constraints

Java Bean Validation SR 380 annotations added to classes

Issue-ID: PORTAL-632
Change-Id: Ia7c2f4ad0aa5cc85db73142d0fecd46da535c3d9
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

Merge "Fix sonar issue: Override "equals(Object obj)""

WidgetCatalog class DB constraints

Java Bean Validation SR 380 annotations added to classes
Plains getter/setter converted to lombok annotation

Issue-ID: PORTAL-630
Change-Id: Id866ec4bc0dc428adfbb7cdc64fe15f7faf837f7
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

RoleApp class DB constraints

Java Bean Validation SR 380 annotations added to classes
Lombod added to widget-ms
Plains getter/setter converted to lombok annotation

Issue-ID: PORTAL-629
Change-Id: I31639672510994412149ed8be92cb8e1b022f646
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

App class DB constraints

Java Bean Validation SR 380 annotations added to classes

Issue-ID: PORTAL-627
Change-Id: I827f99ef75c6af3f9881fe68f1cb245795ba2734
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

FunctionalMenuItem DB constraints fix

Add @Digits to secure Long type fields

Issue-ID: PORTAL-626
Change-Id: I59080c9103369d96a42c574356f0635265335d0a
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

FunctionalMenuItem DB constraints add

Java Bean Validation SR 380 annotations added to classes
Unnecessary boxing removed.

Issue-ID: PORTAL-626
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: Ic1c20870fd781d46061077fd14b81a65dea93e6e

ExtractJar sonar issues fix

This path try resolve some sonar issues.
More details on jira

Issue-ID: PORTAL-623
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: I085390f4b7841fd3e4c7f218cc68bf67960e5598

Updated Dublin Release Notes

Issue-ID: PORTAL-592

Signed-off-by: Welch, Lorraine (lb2391) <lb2391@att.com>
Change-Id: I4d1e7e8bd83ed2adb7df25ccf4c694b1c81ef879

Sonar critical fixes in MicroserviceServiceImpl

Fixed critical issues according to the Sonar analysis:
-Fixed imports.
-Fixed logical comparisons.

Issue-ID: PORTAL-591
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Icc2b6fb45777582486e1060245cdf94e4f6d685d

Sonar fix: make "dateFormat" an instance variable

Fixed critical Sonar issue. SimpleDateFormat was declared as a static
but it is not tread-safe and it keeps an internal state.
Compliant solution has been applied with additional DateUtil class.

Issue-ID: PORTAL-590
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ic6243052804a410cb750c6c219c702469c86ff78

Sonar critical fixes in EPAppCommonServiceImpl

Fixed issues according to the Sonar analysis:
-Fixed imports.
-Fixed logical comparisons.
-Fixed comparisons between unrelated types.

Issue-ID: PORTAL-588
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ibc204e0218788bb82f947c668d68fb6e88db7043

Added lorraineawelch to INFO.yaml

Issue-ID: PORTAL-618

Signed-off-by: Welch, Lorraine (lb2391) <lb2391@att.com>
Change-Id: I3d7f57c8cc20347f8adeefbada2eaffde0940262

XSS Vulnerability fix in DashboardSearchResultController

Custom Validator is used to secure this endpoints.

Issue-ID: OJSI-15
Change-Id: Idf523a53bc5fe9e1df8110526d56336953759c86
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

Custom data validator

By creating custom data validator we can reduce code duplications.

Issue-ID: OJSI-15
Change-Id: I39decf1d6ded559322c4445f0956fad2a159878d
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

XSS Vulnerability fix in TicketEventController

@SafeHtml and SecureString used to fix this issue;

Issue-ID: OJSI-209
Change-Id: I588872839696c824135bab88c100b31c23d960ba
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

XSS Vulnerability fix in RoleManageController

@SafeHtml and SecureString used to secure this class

Issue-ID: OJSI-208
Change-Id: Ie01799933add3419cacf0fc716ce2da6da0a2853
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

XSS Vulnerability fix in AppsOSController

SecureString class used to secure PathVariable.

Issue-ID: OJSI-207
Change-Id: I6275c5db4d8d97dc60ef1676b651e3d8802ad9f7
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

Merge changes I1c586793,I47249407,Idad22dea,I5c3bee06,I5cb96956

* changes:
  Document OJSI-190 vulnerability
  Document OJSI-174 (CVE-2019-12318) vulnerability
  Document OJSI-92 (CVE-2019-12121) vulnerability
  Document OJSI-65 (CVE-2019-1212) vulnerability
  Document OJSI-15 (CVE-2019-12317) vulnerability

Merge "Don't give the user the exact stack trace of the exception"

Merge "Don't give user the exact exception description"

Document OJSI-190 vulnerability

Issue-ID: OJSI-190
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I1c586793b744a5807e7b1a7a1d416dfd43409ab0

Document OJSI-174 (CVE-2019-12318) vulnerability

Issue-ID: OJSI-174
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I47249407ccb62ca7ffd1d8edc9ada8793f4c53c9

Document OJSI-92 (CVE-2019-12121) vulnerability

Issue-ID: OJSI-92
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Idad22deafb262da539c52fa8733e7ea098fd1361

Document OJSI-65 (CVE-2019-1212) vulnerability

Issue-ID: OJSI-65
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I5c3bee06c2b1da3eca2bb583c57decb35b0f32c0

Document OJSI-15 (CVE-2019-12317) vulnerability

Issue-ID: OJSI-15
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I5cb96956f25e09a390ef24a52f6222c0cc7b9e94

XSS Vulnerability fix in AppsControllerExternalRequest

@SafeHtml annotation is used to fix this problem.

This patch also fix some minor issues:
* isAuxRESTfulCall() method delete. Method was nowhere used.
* '.length() == 0' changed to '.isEmpty()'

Issue-ID: PORTAL-604
Change-Id: Ib7091622081f507812654b50275ad7ac4c97bfc3
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

Sonar issue: Correct this "&" to "&&" in MicroserviceServiceImpl

This patch also fix some minor issues:
* 'fori' loop replaced with 'foreach'
* Sonar issue: Replace the type specification in this constructor call
with the diamond operator ("<>").
* redundant 'throws'. Exception will never throw
* unnecessary temporary local variable

Issue-ID: PORTAL-603
Change-Id: If23afb9f4a10f0ad06c712cb95a38b54dc5cd089
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>