From: Dominik Mizyn <d.mizyn@samsung.com>
Date: Fri, 21 Jun 2019 10:27:38 +0000 (+0200)
Subject: ONAPWelcomeController sonar issue fix
X-Git-Tag: 3.2.0~267
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=portal.git;a=commitdiff_plain;h=6a9580d025114106e82fc49da895bbc857a3e91b

ONAPWelcomeController sonar issue fix

String viewName and getter/setter can be romoved from his class.
ONAPWelcomeController Overrides this field 1 to 1.

Issue-ID: PORTAL-652
Change-Id: Idbb41f52a63c6ea681f6ba7753991d766849e3a2
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
---

diff --git a/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/controller/ONAPWelcomeController.java b/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/controller/ONAPWelcomeController.java
index 26564a04..4d3c82a2 100644
--- a/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/controller/ONAPWelcomeController.java
+++ b/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/controller/ONAPWelcomeController.java
@@ -44,9 +44,11 @@ import javax.annotation.Resource;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
+import lombok.NoArgsConstructor;
 import org.mitre.openid.connect.client.SubjectIssuerGrantedAuthority;
 import org.onap.portalapp.controller.EPRestrictedBaseController;
 import org.onap.portalapp.portal.logging.aop.EPAuditLog;
+import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.EnableAspectJAutoProxy;
 import org.springframework.stereotype.Controller;
 import org.springframework.ui.Model;
@@ -56,12 +58,11 @@ import org.springframework.web.servlet.ModelAndView;
 
 @Controller
 @RequestMapping("/")
-@org.springframework.context.annotation.Configuration
+@Configuration
 @EnableAspectJAutoProxy
 @EPAuditLog
+@NoArgsConstructor
 public class ONAPWelcomeController extends EPRestrictedBaseController{
-	String viewName;
-		
 	@RequestMapping(value = "/index.htm", method = RequestMethod.GET)
     public String getIndexPage(HttpServletRequest request) {
 		return "/index";
@@ -72,14 +73,6 @@ public class ONAPWelcomeController extends EPRestrictedBaseController{
 		return "forward:/index.html";
     }
 	
-	protected String getViewName() {
-		return viewName;
-	}
-	
-	protected void setViewName(String viewName) {
-		this.viewName = viewName;
-	}
-	
 	// TODO Need to revisit this as its conflicting with Spring Security; check web.xml's oid-context.xml config
 	//@Resource(name = "namedAdmins")
 	private Set<SubjectIssuerGrantedAuthority> admins;