From: Arundathi Patil Date: Tue, 21 Aug 2018 17:02:37 +0000 (+0530) Subject: TicketEventServiceImpl : Fixed sonar issue X-Git-Tag: 2.3.0~19^2 X-Git-Url: https://gerrit.onap.org/r/gitweb?p=portal.git;a=commitdiff_plain;h=08def403ebf02ac7dc7b5565c46423e3cc994026 TicketEventServiceImpl : Fixed sonar issue Fixed below sonar issue at line 52, Immediately return this expression instead of assigning it to the temporary variable 'hyperlink' Issue-ID: PORTAL-364 Change-Id: I33b854b15e163146415040bf98dbd7e992d04b61 Signed-off-by: Arundathi Patil --- diff --git a/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/portal/service/TicketEventServiceImpl.java b/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/portal/service/TicketEventServiceImpl.java index 5dba0b21..71c2b1ea 100644 --- a/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/portal/service/TicketEventServiceImpl.java +++ b/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/portal/service/TicketEventServiceImpl.java @@ -3,6 +3,8 @@ * ONAP Portal * =================================================================== * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved. + * + * Modifications Copyright (C) 2018 IBM. * =================================================================== * * Unless otherwise specified, all software contained herein is licensed @@ -49,8 +51,6 @@ public class TicketEventServiceImpl implements TicketEventService{ @Override public String getNotificationHyperLink(JsonNode application, String ticket, String eventSource) { - String hyperlink = SystemProperties.getProperty(EPCommonSystemProperties.EXTERNAL_SYSTEM_NOTIFICATION_URL)+ticket; - return hyperlink; + return (SystemProperties.getProperty(EPCommonSystemProperties.EXTERNAL_SYSTEM_NOTIFICATION_URL)+ticket); } - }