policy/pap.git
4 years agoEnabling logback file to be loaded using oom configmap 88/100088/3
a.sreekumar [Wed, 8 Jan 2020 13:03:27 +0000 (13:03 +0000)]
Enabling logback file to be loaded using oom configmap

Change-Id: Iabde1c4b63844f46d5c9a4db23c070b744bf67e5
Issue-ID: POLICY-2308
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
4 years agoChanges related to persisiting data type of policy in db 23/100123/1
a.sreekumar [Thu, 9 Jan 2020 11:36:39 +0000 (11:36 +0000)]
Changes related to persisiting data type of policy in db

Change-Id: I09b373a511eaa20603d4d2de71a2a5a6bf652b3b
Issue-ID: POLICY-2315
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
4 years agoCreate PAP Client Mornitoring Model 93/99793/1
Hengye [Thu, 19 Dec 2019 07:58:06 +0000 (15:58 +0800)]
Create PAP Client Mornitoring Model

Issue-ID: POLICY-2311
Signed-off-by: Hengye <yehui.wang@est.tech>
Change-Id: Ibdea465b955a61c3bae26662ab7cb2762da133e1

4 years agoconsolidate Policy Health Check into PAP 93/99193/5
Hengye [Wed, 27 Nov 2019 05:43:42 +0000 (13:43 +0800)]
consolidate Policy Health Check into PAP

Issue-ID: POLICY-1689
Change-Id: I3b84094e217c8cda115efdbf3444e92f08013a7c
Signed-off-by: Hengye <yehui.wang@est.tech>
4 years agoMerge "Only update policies in PAP REST API"
Pamela Dragosh [Tue, 10 Dec 2019 14:28:33 +0000 (14:28 +0000)]
Merge "Only update policies in PAP REST API"

4 years agoOnly update policies in PAP REST API 19/99119/4
Jim Hahn [Tue, 3 Dec 2019 18:07:57 +0000 (13:07 -0500)]
Only update policies in PAP REST API

Modified the deploy controller and provider to only update the
policies within a group, while leaving the other fields unchanged.
Added delta operations so that only additions or deletions need
be included instead of providing the complete list of policies.

Change-Id: Id2b69dac15f97b8a898f459f8d3f09216fc3618e
Issue-ID: POLICY-2274
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoChange optimization types due to refactoring 04/99304/1
Pamela Dragosh [Mon, 9 Dec 2019 00:48:49 +0000 (19:48 -0500)]
Change optimization types due to refactoring

Companion review to https://gerrit.onap.org/r/c/policy/models/+/99288
which changes the types for optimization.

Issue-ID: POLICY-2066
Change-Id: I754a52a3971f0ad4d4e4118213a13123c44086cf
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoMerge "Adding native policy types to defaultGroup"
Pamela Dragosh [Fri, 6 Dec 2019 21:57:08 +0000 (21:57 +0000)]
Merge "Adding native policy types to defaultGroup"

4 years agoMerge "Create PAP API to only create/update PdpGroups"
Pamela Dragosh [Fri, 6 Dec 2019 21:55:02 +0000 (21:55 +0000)]
Merge "Create PAP API to only create/update PdpGroups"

4 years agoPoint to release versions of policy/parent and policy/common 20/99220/4
HOCKLA [Thu, 5 Dec 2019 17:56:24 +0000 (11:56 -0600)]
Point to release versions of policy/parent and policy/common

Issue-ID: POLICY-1583
Change-Id: I30557440310c3e43e662d463017ecfa6269b394b
Signed-off-by: HOCKLA <ah999m@att.com>
4 years agoAdding native policy types to defaultGroup 53/99253/1
ramverma [Fri, 6 Dec 2019 11:46:42 +0000 (11:46 +0000)]
Adding native policy types to defaultGroup

Adding the native policy types for drools, apex & xacml to the
supportedPolicyTypes of the individual subGroups in the defaultGroup. So
that native policies can be deployed in the pdps belonging to
defaultGroup.

Issue-ID: POLICY-2279
Change-Id: I8707dfd3a9af055e02d29752386160631d022d08
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
4 years agoCreate PAP API to only create/update PdpGroups 79/99079/6
a.sreekumar [Tue, 3 Dec 2019 19:10:47 +0000 (19:10 +0000)]
Create PAP API to only create/update PdpGroups

Create an API to create/update PdpGroups.
Policies are not allowed to be deployed as part of PDPGroup
create/update operation. There will be a separate API as part of
POLICY-2274 to deploy policies into individual group/subgroups.

Change-Id: I4e2cb43fefe08b22d6f70a1db7c026e83f0ebde0
Issue-ID: POLICY-2273
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
4 years agoMove deploy/undeploy REST classes 51/99051/3
Jim Hahn [Tue, 3 Dec 2019 15:15:31 +0000 (10:15 -0500)]
Move deploy/undeploy REST classes

Moved classes from rest.depundep to rest, as they will no longer be
specific to deploy/undeploy.

Change-Id: Iea7c4e35fcd00ed83e678f7cd980e0aa9659f18e
Issue-ID: POLICY-1866
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoUpdate Pdp Group state per PAP API 77/98777/1
Jim Hahn [Fri, 22 Nov 2019 19:57:22 +0000 (14:57 -0500)]
Update Pdp Group state per PAP API

The PAP API can be used to update the state of a Pdp Group.  However,
the state wasn't being updated - fixed.

Issue-ID: POLICY-2269
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I67fa3409424cfdb4b53b17e86f4cf354732d87e8

4 years agoRe-register pdp if not found in DB 67/98767/1
ramverma [Fri, 22 Nov 2019 16:42:03 +0000 (16:42 +0000)]
Re-register pdp if not found in DB

During heartbeat processing, if the pdp instance is not found in the DB
then registering the pdp again. So that it doesn't go out of sync.
Added related test cases.

Issue-ID: POLICY-2158
Change-Id: I557e2397536fd5b3a2783ec89d75ca0e43dcf9d0
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
4 years agoMerge "Undeploy policies when deploy fails"
Jim Hahn [Thu, 21 Nov 2019 18:18:11 +0000 (18:18 +0000)]
Merge "Undeploy policies when deploy fails"

4 years agoMerge "Adding pdpGroup to PdpRegistrationHandler"
Jorge Hernandez [Thu, 21 Nov 2019 18:04:33 +0000 (18:04 +0000)]
Merge "Adding pdpGroup to PdpRegistrationHandler"

4 years agoAdding pdpGroup to PdpRegistrationHandler 18/98718/2
ramverma [Thu, 21 Nov 2019 14:54:43 +0000 (14:54 +0000)]
Adding pdpGroup to PdpRegistrationHandler

Adding pdpGroup as the matching condition for registration of Pdps.
Removing the check of supported policy types in pdp heartbeat.
Adding check of policies in pdp heartbeat.
Adding comprehensive unit test coverage (98%) for the heartbeat
listener.

Issue-ID: POLICY-2231
Change-Id: I0fb961717c74656c5f1b6937b6c3a1410382a76e
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
4 years agoUndeploy policies when deploy fails 89/98689/4
Jim Hahn [Wed, 20 Nov 2019 18:48:16 +0000 (13:48 -0500)]
Undeploy policies when deploy fails

Modified the code so that if a PDP fails to deploy one or more policies
specified in a PDP-UPDATE message, PAP will undeploy those policies that
failed to deploy to the PDP.  This entails removing the policies from
the Pdp Group(s), issuing new PDP-UPDATE requests, and updating the
notification tracking data.

Issue-ID: POLICY-2155
Change-Id: I1740282385b0fa804254ebdf57537ef0f3a7a4c8
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoMerge "Preload wildcard supported type in PAP"
Jim Hahn [Wed, 20 Nov 2019 23:39:44 +0000 (23:39 +0000)]
Merge "Preload wildcard supported type in PAP"

4 years agoMerge "Fixing issue where PdpRegistration message is treated as Heartbeat by PAP"
Ram Krishna Verma [Wed, 20 Nov 2019 09:57:22 +0000 (09:57 +0000)]
Merge "Fixing issue where PdpRegistration message is treated as Heartbeat by PAP"

4 years agoFixing issue where PdpRegistration message is treated as Heartbeat by PAP 16/98616/1
a.sreekumar [Tue, 19 Nov 2019 17:11:10 +0000 (17:11 +0000)]
Fixing issue where PdpRegistration message is treated as Heartbeat by PAP

PDPs now sends PdpGroup also during registration. So, PAP treats them as
normal hearbeat and not registration message, causing errors.
Fixing this. This change will be updated by POLICY-2231

This should also fix the csit failures in the PDPs.

Change-Id: Idf62839d175c6e392101e9c58627217a76473de9
Issue-ID: POLICY-2234
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
4 years agoBuild tar.gz without requiring docker image build 14/98614/1
jhh [Tue, 19 Nov 2019 16:04:57 +0000 (10:04 -0600)]
Build tar.gz without requiring docker image build

This allows the tar.gz to be released by LF jobs.

Issue-ID: POLICY-2250
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I601afea6c3c5c0df76685e91c0604b7a972ac552

4 years agoPreload wildcard supported type in PAP 34/98434/1
Jim Hahn [Thu, 14 Nov 2019 22:24:26 +0000 (17:24 -0500)]
Preload wildcard supported type in PAP

Removed the specific monitoring policy types and added the
wild-card flavor to the list of policy types to be pre-loaded
into the Default PDP Group.

Issue-ID: POLICY-2224
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I108fe72c28bd20495e72bdaa517f7c7f80de3071

4 years agoMerge "PAP should not deactivate PDPs"
Ram Krishna Verma [Tue, 12 Nov 2019 09:28:33 +0000 (09:28 +0000)]
Merge "PAP should not deactivate PDPs"

4 years agoMerge "Do not hardcode io.fabric8 plugin"
Pamela Dragosh [Mon, 11 Nov 2019 16:10:19 +0000 (16:10 +0000)]
Merge "Do not hardcode io.fabric8 plugin"

4 years agoDo not hardcode io.fabric8 plugin 03/98203/1
Pamela Dragosh [Fri, 8 Nov 2019 19:50:54 +0000 (14:50 -0500)]
Do not hardcode io.fabric8 plugin

policy/parent now has this plugin defined

Issue-ID: POLICY-2222
Change-Id: I8458ecc830308e6d1b627ea47518d0a58b3ceca1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoPAP should not deactivate PDPs 62/98162/1
Jim Hahn [Thu, 7 Nov 2019 21:37:18 +0000 (16:37 -0500)]
PAP should not deactivate PDPs

Modified the code so that it does not send a PASSIVE request to
PDPs when they are fail, whether due to an inability to deploy a
policy or due to a timeout.  However, it still removes the PDP from
the PDP Group, if a timeout occurs (but not due to a deployment
failure).

This review does not include any changes to undeploy failed policies;
that will come in a later review.

Issue-ID: POLICY-2155
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I15821d299bc3261478fd7fbb9ee62ea4a90123a4

4 years agoSupport policy types with wild-cards 75/98075/1
Jim Hahn [Wed, 6 Nov 2019 17:19:33 +0000 (12:19 -0500)]
Support policy types with wild-cards

Allow supported policy types to end with ".*", which causes the prefix
to be matched when new policies are deployed.  This entailed updates
in three areas:
- when a subgroup is added via the group api
- when a subgroup is updated via the group api
- when a policy is deployed via the simple api

Issue-ID: POLICY-1636
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I4ae15971481ce5b2042b5d6fdfd16e11ad099c50
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoSimplify request handling in PAP 87/97987/2
Jim Hahn [Tue, 5 Nov 2019 16:51:04 +0000 (11:51 -0500)]
Simplify request handling in PAP

PAP handles outgoing requests using a complicated priority queue.
Simplified it significantly.

Change-Id: I9f49dfebd7bf323c5e81bc8ca3459913fa95c43d
Issue-ID: POLICY-2155
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoMerge "Add REST api to query policy status from PAP"
Jorge Hernandez [Tue, 5 Nov 2019 14:41:32 +0000 (14:41 +0000)]
Merge "Add REST api to query policy status from PAP"

4 years agoFix CSITs 29/97929/3
Jim Hahn [Mon, 4 Nov 2019 22:22:03 +0000 (17:22 -0500)]
Fix CSITs

Added dmaap notification topic to PAP config file.
Fixed server IP per review comment.

Change-Id: I982123f2a49ca8f28b7ada275db000826e7baef5
Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoAdd REST api to query policy status from PAP 75/97875/4
Jim Hahn [Fri, 1 Nov 2019 19:13:10 +0000 (15:13 -0400)]
Add REST api to query policy status from PAP

As part of this, added code to pre-load the deployed policy tracker
by reading the policies and groups from the DB.

Change-Id: Ifc6c787d114a3a7add4ea54acc1cc969d6c3ca1c
Issue-ID: POLICY-2024
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoMerge "Add tests for policy type in notifications"
Jorge Hernandez [Fri, 1 Nov 2019 13:21:41 +0000 (13:21 +0000)]
Merge "Add tests for policy type in notifications"

4 years agoMerge "Add common Jersey version"
Jim Hahn [Fri, 1 Nov 2019 12:51:08 +0000 (12:51 +0000)]
Merge "Add common Jersey version"

4 years agoAdd common Jersey version 46/97846/1
liamfallon [Fri, 1 Nov 2019 11:45:21 +0000 (11:45 +0000)]
Add common Jersey version

Add a common version of Jersey for all Policy Framework components.

Issue-ID: POLICY-2209
Change-Id: I18134fa72710db9abe045b07013162a7a1002553
Signed-off-by: liamfallon <liam.fallon@est.tech>
4 years agoAdd tests for policy type in notifications 33/97833/1
Jim Hahn [Thu, 31 Oct 2019 21:58:45 +0000 (17:58 -0400)]
Add tests for policy type in notifications

The junit tests verified that the policy specified in the notifications,
but did not verify the policy type.  Added additional tests.

Issue-ID: POLICY-2190
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Iad2a06163f9dce3dff3753cddef98db9e9ad2eea

4 years agoGenerate notifications when policies change 83/97683/1
jh7358 [Wed, 16 Oct 2019 15:51:46 +0000 (11:51 -0400)]
Generate notifications when policies change

Updated existing PAP code to make use of new notification classes.

Change-Id: I4637ad92ac4f432f215cfc837e672c75074d88b5
Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoAdd notifier for generating notifications 16/97616/1
Jim Hahn [Fri, 25 Oct 2019 13:25:59 +0000 (09:25 -0400)]
Add notifier for generating notifications

Also modified the Publisher class to make it generic so that it
could be used to publish PdpMessage AND PolicyNotification.

Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I305de21a4ef84730f163af63446bafadab11a809

4 years agoAdd trackers for generating notifications 61/97561/2
Jim Hahn [Thu, 24 Oct 2019 15:17:14 +0000 (11:17 -0400)]
Add trackers for generating notifications

Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I7d6fe29707685e4711120b6a1e8448f25870a0ef
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoMerge "Add PolicyPdpNotificationData for generating notifications"
Jim Hahn [Thu, 24 Oct 2019 13:05:09 +0000 (13:05 +0000)]
Merge "Add PolicyPdpNotificationData for generating notifications"

4 years agoAdd PolicyPdpNotificationData for generating notifications 87/97487/1
Jim Hahn [Wed, 23 Oct 2019 14:43:45 +0000 (10:43 -0400)]
Add PolicyPdpNotificationData for generating notifications

Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Icf5616190a8c3da38e2a1e33122b47a78e729d08

4 years agoAdd PolicyTrackerData for generating notifications 73/97473/2
Jim Hahn [Tue, 22 Oct 2019 22:05:42 +0000 (18:05 -0400)]
Add PolicyTrackerData for generating notifications

Change-Id: Ife3ab77c0664101bbf32def5fb4d1a5ac194f459
Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agooverride cert stores 26/97226/2
jhh [Thu, 17 Oct 2019 00:39:55 +0000 (19:39 -0500)]
override cert stores

Issue-ID: POLICY-2064
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I9a6077b51c1684b7c34a1cec827288cfb7dc58bc

4 years agoUse snapshot version of models in pap 27/96027/1
jrh3 [Thu, 19 Sep 2019 19:09:45 +0000 (15:09 -0400)]
Use snapshot version of models in pap

Issue-ID: POLICY-2065
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: I0c4b764dff548599fccb6ea9ef977b2f54e32bcd

4 years agoAdd yaml support to pap rest server 14/95614/1
jrh3 [Thu, 12 Sep 2019 18:34:30 +0000 (14:34 -0400)]
Add yaml support to pap rest server

Change-Id: I3e3d5c46bfa4f1d093e64b8be9a9720570e6000c
Issue-ID: POLICY-2085
Signed-off-by: jrh3 <jrh3@att.com>
4 years agoBump versions for pap master 89/95389/1
jrh3 [Tue, 10 Sep 2019 15:04:50 +0000 (11:04 -0400)]
Bump versions for pap master

Issue-ID: POLICY-2045
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: I31bb75b39a3232ef7448fadcd79941d5191f61c2

4 years agoRelease pap 2.1.2 89/95289/1 5.0.0-ONAP
Pamela Dragosh [Tue, 10 Sep 2019 00:28:00 +0000 (20:28 -0400)]
Release pap 2.1.2

Releasing 2.1.2

Issue-ID: POLICY-2045
Change-Id: I0d0a0297be062fb15b8adc9eda0d6f43f4a7a7bf
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoUpgrade to released artifacts 82/95282/1
Pamela Dragosh [Mon, 9 Sep 2019 23:35:51 +0000 (19:35 -0400)]
Upgrade to released artifacts

Upgrade to released parent, common and models.

Issue-ID: POLICY-2045
Change-Id: Ib6690c27d4b7d01385f0d2ad5ddc79c270d8bd0d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoKnock on of changing policy types to map 62/94962/1
liamfallon [Wed, 4 Sep 2019 17:37:18 +0000 (17:37 +0000)]
Knock on of changing policy types to map

This review adapts policy-pap for the change in the structure
of the toasca service template from a list of maps to a plain map.

There is only a change to one test file.

Issue-ID: POLICY-2047

Change-Id: Ieeeeb43d8f0300d075b3072b67f8d459def27ee7
Signed-off-by: liamfallon <liam.fallon@est.tech>
4 years agoupdate keystore 76/94176/2
jhh [Fri, 23 Aug 2019 03:41:26 +0000 (22:41 -0500)]
update keystore

Issue-ID: POLICY-1988
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I3e7d08621b6ac529f3517de8c2b910d2fa7c5151
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
4 years agoUpgrade to snapshot integration parent artifact 97/92897/2
Bruno Sakoto [Wed, 7 Aug 2019 12:41:14 +0000 (08:41 -0400)]
Upgrade to snapshot integration parent artifact

Issue-ID: POLICY-1603
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I18d3914e227d09cbb440c31779c21b9e8ab3eb24

4 years agoBump version of policy/pap 24/92924/1
jrh3 [Wed, 7 Aug 2019 16:31:00 +0000 (12:31 -0400)]
Bump version of policy/pap

Issue-ID: POLICY-1965
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: I23b13145a769055bdfef97d6a7deca1ccf710337

4 years agoAdd release 2.1.1 file 32/92832/1
jhh [Tue, 6 Aug 2019 16:36:54 +0000 (11:36 -0500)]
Add release 2.1.1 file

Issue-ID: POLICY-1953
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I3ee82a9736a5d69286f978d1d0f39f304a3834d6

4 years agoUpdate to latest common/models released versions 83/92683/3
jhh [Mon, 5 Aug 2019 13:42:22 +0000 (08:42 -0500)]
Update to latest common/models released versions

policy/models: 2.1.2
policy/common: 1.5.1

Issue-ID: POLICY-1953
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: If4cb2c63e8880d2fc921cbcecdabe7c02e30b13f

4 years agoMerge "Remove hardcoded ip in PAP testsuites"
Jorge Hernandez [Thu, 1 Aug 2019 12:42:43 +0000 (12:42 +0000)]
Merge "Remove hardcoded ip in PAP testsuites"

4 years agoAdjust timer manager logging 23/92423/1
jrh3 [Wed, 31 Jul 2019 19:31:06 +0000 (15:31 -0400)]
Adjust timer manager logging

Add a few more logging statements to the timer manager.  Also
changed logger.debug() to logger.info().
Replaced map.computeIfPresent() with map.remove(), as it simplified
the relevant code block significantly.

Change-Id: I211e9f07bd6df6a01532b1ecabdde5ae1585cc18
Issue-ID: POLICY-1960
Signed-off-by: jrh3 <jrh3@att.com>
4 years agoRemove hardcoded ip in PAP testsuites 91/92391/2
Chenfei Gao [Wed, 31 Jul 2019 17:46:40 +0000 (13:46 -0400)]
Remove hardcoded ip in PAP testsuites

Removed and parametrized hardcoded ip in stability test scripts

Issue-ID: POLICY-1958
Change-Id: I8f8f6efdf481179ecbc308284b041287b3fbf861
Signed-off-by: Chenfei Gao <cgao@research.att.com>
4 years agoRemove remaining ParameterUtils from PAP 79/92379/1
jrh3 [Wed, 31 Jul 2019 15:46:43 +0000 (11:46 -0400)]
Remove remaining ParameterUtils from PAP

Issue-ID: POLICY-1953
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: I2bc56dfe2d5982d7dadb54311a94d6c6f95fa595

4 years agoUse new addTopic(TopicParameterGroup) method in PAP 75/92275/2
jrh3 [Mon, 29 Jul 2019 16:11:34 +0000 (12:11 -0400)]
Use new addTopic(TopicParameterGroup) method in PAP

Issue-ID: POLICY-1953
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: I225dc5f03d867efe6167fd20781c9959af34e0e9
Signed-off-by: jrh3 <jrh3@att.com>
4 years agoAdd lombok.config to PAP 07/92107/1
jrh3 [Fri, 26 Jul 2019 12:57:43 +0000 (08:57 -0400)]
Add lombok.config to PAP

This prevents sonar from checking lombok annotations for code
coverage.

Issue-ID: POLICY-1938
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: Ibd2613cf7e8e9c49cb60b93bdb44416efe6245e2

4 years agoModify pap to use RestServer from common 95/91695/1
jrh3 [Wed, 17 Jul 2019 13:45:45 +0000 (09:45 -0400)]
Modify pap to use RestServer from common

Issue-ID: POLICY-1652
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: If97c5667f52811cfb3bdf1f7c8caf763e6bfa3b6
Signed-off-by: jrh3 <jrh3@att.com>
4 years agoFix pap due to sonar changes in common 41/91041/1
jrh3 [Mon, 8 Jul 2019 19:30:51 +0000 (15:30 -0400)]
Fix pap due to sonar changes in common

Fixed breakages due to changes made in policy/common to satisfy
sonar.

Issue-ID: POLICY-1791
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: If8685462e1dd5cbbe58c329defff74ff2accf559

4 years agoRemove topic.properties and incorporate into overall config file 45/90845/1
a.sreekumar [Wed, 3 Jul 2019 15:55:17 +0000 (15:55 +0000)]
Remove topic.properties and incorporate into overall config file

Changes in the scripts to accomodate the removal of topic.properties.

Change-Id: I0be390a6124248a4e9d3bf38437290b89cf36170
Issue-ID: POLICY-1744
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
4 years agoRemove topic.properties and incorporate into overall config file 34/90734/1
a.sreekumar [Mon, 1 Jul 2019 14:50:01 +0000 (14:50 +0000)]
Remove topic.properties and incorporate into overall config file

1) The properties in the topic.properties file is moved into overall
config json file and the topic.properties file is removed.
2) Common parameters such as RestServer and Topic related parameters
from policy-common is used.

Change-Id: I390bbe3cda101a69e7ce614404ecdfbf98598dd2
Issue-ID: POLICY-1744
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
4 years agoRemove POLICY_PAP_HOME in Dockerfile 61/89961/4
shaoqiu [Fri, 28 Jun 2019 05:02:39 +0000 (05:02 +0000)]
Remove POLICY_PAP_HOME in Dockerfile

To use POLICY_HOME not POLICY_XX_HOME

Issue-ID: POLICY-1702
Change-Id: I87db84593c2fec3071571b1a0e09552c764a3474
Signed-off-by: shaoqiu <tim.huang@est.tech>
4 years agoBump up models to 2.1.1-SNAPSHOT 85/90585/1
ramverma [Thu, 27 Jun 2019 11:17:15 +0000 (11:17 +0000)]
Bump up models to 2.1.1-SNAPSHOT

Change-Id: I6c030da968407edb23be6aa6d5092e1aac7c21b3
Issue-ID: POLICY-1746
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
4 years agoUse ToStringTester from utils-test 26/90526/2
ramverma [Wed, 26 Jun 2019 14:50:53 +0000 (14:50 +0000)]
Use ToStringTester from utils-test

Changing ToStringTester from utils to utils-test.
Correcting the policy/common & policy/models version.

Change-Id: Ib0a14da17227f0f65004dc525a47f17519e25110
Issue-ID: POLICY-1746
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
4 years agoBump pap patch to 2.1.1 16/90516/1
Pamela Dragosh [Wed, 26 Jun 2019 12:42:30 +0000 (08:42 -0400)]
Bump pap patch to 2.1.1

Released 2.1.0

Issue-ID: POLICY-1737
Change-Id: Id5cd42e6685f5745152526fab9f2d8947b27eade
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoUpgrade to released common & models 33/90333/1 2.1.0
Pamela Dragosh [Fri, 21 Jun 2019 20:18:29 +0000 (16:18 -0400)]
Upgrade to released common & models

Released common 1.5.0 and models 2.1.0

Issue-ID: POLICY-1737
Change-Id: I1ffdbbddeb52a0730e279ca2b09b28cbe925de50
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoMerge "Allow integer version when using PDP Group Deploy"
Jorge Hernandez [Fri, 21 Jun 2019 16:31:55 +0000 (16:31 +0000)]
Merge "Allow integer version when using PDP Group Deploy"

4 years agoAdding PdpGroup healthcheck REST API in PAP 29/90229/5
ramverma [Fri, 21 Jun 2019 12:53:27 +0000 (12:53 +0000)]
Adding PdpGroup healthcheck REST API in PAP

Adding PdpGroup healthcheck REST API in PAP to return the health status
of all the Pdps registered with this PAP instance. The healthcheck
status will be based on the regular heartbeat coming from the pdps.

Change-Id: Ia0f1603b513bf62ce1df3058427dc6ccaf179cb3
Issue-ID: POLICY-1770
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
4 years agoUpgrade to release 3.0.0 parent 58/90258/1
Pamela Dragosh [Thu, 20 Jun 2019 20:30:49 +0000 (16:30 -0400)]
Upgrade to release 3.0.0 parent

Policy/parent released

Issue-ID: POLICY-1737
Change-Id: I80a50c1a9a8b16cc7a53da2dec81843e03b6fc91
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoAllow integer version when using PDP Group Deploy 56/90256/1
jrh3 [Thu, 20 Jun 2019 18:57:50 +0000 (14:57 -0400)]
Allow integer version when using PDP Group Deploy

The policies listed in a "PDP Group Deploy" request may not have
fully qualified versions.  Modified the code to replace the versions
in the request with fully qualified versions.
Also improved performance by avoiding look-ups of policies that
are already in the subgroup.

Change-Id: I37899c2b45228b97a80b7ef44f69694ba57e8f4a
Issue-ID: POLICY-1784
Signed-off-by: jrh3 <jrh3@att.com>
4 years agoFix sonar issues in PAP 05/89905/2
jrh3 [Fri, 14 Jun 2019 14:31:40 +0000 (10:31 -0400)]
Fix sonar issues in PAP

Replace string concatenation with "{}" place-holders in logging
statements.
Refactored PdpStatusMessageHandler and PdpGroupStateChangeProvider
to extract common/duplicate code block into PdpMessageGenerator.
Refactored selectPdpGroupsForRegistration() to reduce "cyclomatic complexity";
extracted selectPdpSubGroupsForRegistration from it.

Issue-ID: POLICY-1791
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: Ia0ebc1cf41cd2fa288130b4a58614a4983f47f8b
Signed-off-by: jrh3 <jrh3@att.com>
4 years agoAdd PDP heart beat expiration timer 12/89612/7
jrh3 [Tue, 11 Jun 2019 14:56:25 +0000 (10:56 -0400)]
Add PDP heart beat expiration timer

Added heart beat interval to the PDP-UPDATE message sent in response
to a heart beat message received from a PDP.
Added timers to detect missing heart beats and remove the PDP from
the DB - PdpTracker.
Modified current heart beat listener to update PdpTracker when a
heart beat is received.
Allow 3 missed heart beats instead of 2.

Change-Id: I81621fefbe494e0c4d6f0b9767b00b2a9dd398d8
Issue-ID: POLICY-1795
Signed-off-by: jrh3 <jrh3@att.com>
4 years agoMerge "policy/pap must publish docker images with tag X.Y-SNAPSHOT-latest"
Pamela Dragosh [Tue, 11 Jun 2019 12:51:35 +0000 (12:51 +0000)]
Merge "policy/pap must publish docker images with tag X.Y-SNAPSHOT-latest"

4 years agopolicy/pap must publish docker images with tag X.Y-SNAPSHOT-latest 06/89606/1
Rashmi Pujar [Fri, 7 Jun 2019 19:53:59 +0000 (15:53 -0400)]
policy/pap must publish docker images with tag X.Y-SNAPSHOT-latest

Issue-ID: POLICY-1808
Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
Change-Id: I372de55eca0208df4bb059221ceae76d05737a10

4 years agoUndeploy all versions of a policy 93/89593/1
Jim Hahn [Fri, 7 Jun 2019 15:33:59 +0000 (11:33 -0400)]
Undeploy all versions of a policy

Modified the code to undeploy all versions of a policy if the
version is not specified.

Change-Id: Ic3815733b918e1cff8f381d54bceb710a35319b7
Issue-ID: POLICY-1782
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoReject policy deployment with version mismatch 97/89397/2
Jim Hahn [Wed, 5 Jun 2019 15:00:21 +0000 (11:00 -0400)]
Reject policy deployment with version mismatch

PAP should not allow multiple versions of a policy to be deployed
to the same PDP.  Modified the code to reject deployment requests
where a different version of the policy is already deployed.  This
impacts both the PDP-Group-Deploy and the Simple-Deploy REST APIs.

Change-Id: I586b764951c20228d0d80ec8326869215e970fdf
Issue-ID: POLICY-1785
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoMerge "Undeploy policies when subgroup is deleted"
Jorge Hernandez [Wed, 5 Jun 2019 12:46:29 +0000 (12:46 +0000)]
Merge "Undeploy policies when subgroup is deleted"

4 years agoUndeploy policies when subgroup is deleted 92/89292/3
Jim Hahn [Tue, 4 Jun 2019 21:27:31 +0000 (17:27 -0400)]
Undeploy policies when subgroup is deleted

When a subgroup is deleted via the PDP Group create/update API,
any PDPs in the subgroup should have all of its policies undeployed.
In the process, refactored addOrUpdateSubGroups() out of updateGroup().

Change-Id: I0750802bfb133a655e38493a868744b512ca3fb4
Issue-ID: POLICY-1803
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoFix pap docker chmod 72/89272/2
Jim Hahn [Tue, 4 Jun 2019 18:37:48 +0000 (14:37 -0400)]
Fix pap docker chmod

The chmod in the docker builder for my local VM does not appear to
support the "+x" style options. Modified the pap docker
file to use "755" instead.

Change-Id: Iac98ab903862e4d32ef9f86595e01a13929f8de8
Issue-ID: POLICY-1829
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoBump pap to version 2.1.0 11/88911/2
Jim Hahn [Thu, 30 May 2019 14:30:12 +0000 (10:30 -0400)]
Bump pap to version 2.1.0

Change-Id: I964d26a2812ae3e638f87587540b6881e1e6fa58
Issue-ID: POLICY-1747
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoUpdate pap stability testsuite 09/88709/2
ramverma [Wed, 29 May 2019 10:54:01 +0000 (10:54 +0000)]
Update pap stability testsuite

1) Adding test cases to the stability test plan.
2) Adding script & related files for setup of pap for testing
3) Adding script & related files for setup of simulator and dependencies
like dmaap simulator, pdp simulator, mariadb & policy/api.

Change-Id: Ib7a1e95dee108e9d8757ee18cbf5fb8c2b877274
Issue-ID: POLICY-1799
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
4 years agoBump to 2.0.2-SNAPSHOT 22/88422/1
Pamela Dragosh [Thu, 23 May 2019 23:01:24 +0000 (19:01 -0400)]
Bump to 2.0.2-SNAPSHOT

Released 2.0.1

Issue-ID: POLICY-1700
Change-Id: I6c1e328ff0ccbdfd59856ee14a56990ae36df56c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoUpgrade to released policy/models 90/88390/1 2.0.1 4.0.0-ONAP
Pamela Dragosh [Thu, 23 May 2019 17:13:54 +0000 (13:13 -0400)]
Upgrade to released policy/models

Released 2.0.1

Issue-ID: POLICY-1700
Change-Id: Ic03e49b17a4a2174e065afa7b852b73741ff59a8
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoUpdate INFO.yaml to add Jim and Ram 61/88261/1
liamfallon [Wed, 22 May 2019 14:42:30 +0000 (14:42 +0000)]
Update INFO.yaml to add Jim and Ram

Issue-ID: POLICY-1775
Change-Id: I08ece82243e8109f0442001dfc8c2fa395e6dc3f
Signed-off-by: liamfallon <liam.fallon@est.tech>
4 years agoUpgrade models version 46/88246/1
Jim Hahn [Wed, 22 May 2019 13:38:24 +0000 (09:38 -0400)]
Upgrade models version

Switch to the policy/models version containing the fix for
the latest-version query.

Change-Id: Iaaa81aebc3a03283813903e64b9049e2e7f23ecd
Issue-ID: POLICY-1777
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdd son handler to xacml pdp group 95/87995/1
Pamela Dragosh [Fri, 17 May 2019 13:34:58 +0000 (09:34 -0400)]
Add son handler to xacml pdp group

Need this for the 5G OOF PCI Use Case.

Issue-ID: POLICY-1776
Change-Id: I86758174840d376d6003f5200f0deeb72c3e01d9
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoStep snapshot version of policy-pap 52/87852/1
liamfallon [Thu, 16 May 2019 08:59:55 +0000 (08:59 +0000)]
Step snapshot version of policy-pap

Issue-ID: POLICY-1630
Change-Id: Ie38ed0cc191dcd657b7558102b77b0912170568d
Signed-off-by: liamfallon <liam.fallon@est.tech>
5 years agoUpgrade to policy/models release 24/87724/1 2.0.0
Pamela Dragosh [Wed, 15 May 2019 00:16:42 +0000 (20:16 -0400)]
Upgrade to policy/models release

Release 2.0.0

Issue-ID: POLICY-1630
Change-Id: Ib4f24732a62c1cfc6464283fb3af4d0b0cc1735f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoUpgrade policy/parent & policy/common in pap 32/87532/3
ramverma [Mon, 13 May 2019 10:14:42 +0000 (10:14 +0000)]
Upgrade policy/parent & policy/common in pap

Change-Id: I44938584e1ec6e65f8a08f42c3632bc912e2df18
Issue-ID: POLICY-1630
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoReturn 200 when policy successfully undeployed 64/87464/2
Jim Hahn [Fri, 10 May 2019 14:19:43 +0000 (10:19 -0400)]
Return 200 when policy successfully undeployed

The PAP Undeploy CSIT was failing, because it was returning 400.
The code was counting PDP UPDATE requests to determine whether or
not the policy had been found.  However, if a subgroup currently
has no PDPs assigned (as is the case with the CSIT), then there
will be no PDP UPDATEs, thus it will think that the policy was
not found and return 400.  Modified the code to count updates to
the DB instead.

Change-Id: I80cdcc738e07c418e0a7184284e7a228e3a6014d
Issue-ID: POLICY-1758
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoUse group from cache even with new policy type 00/87400/1
Jim Hahn [Thu, 9 May 2019 19:43:53 +0000 (15:43 -0400)]
Use group from cache even with new policy type

When multiple policies are deployed to the same group in a single
request, and the policies have different policy types, only the
changes associated with the last policy are kept.  Updated the
policy type lookup to use cached groups, when available.
This still needs a junit to verify the fix, but that can come
later.
Also added more logging.

Change-Id: Ieaf866da504b167c884bf53f88aa8cb9e9b5e32a
Issue-ID: POLICY-1761
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoReturn error when deleting non-existent policy 75/87375/2
Jim Hahn [Thu, 9 May 2019 15:28:28 +0000 (11:28 -0400)]
Return error when deleting non-existent policy

When undeploying a policy, if a policy's type is found in
a group, but the policy is not, then PAP returns 200.  It
should return an error instead.

Change-Id: I88273fdbd5d49095e8248ab9267cccc529af0ae0
Issue-ID: POLICY-1758
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoChanging the PAP initial db data 13/86813/1
ramverma [Thu, 2 May 2019 12:58:30 +0000 (12:58 +0000)]
Changing the PAP initial db data

Changing PAP initial db data to bring all the xacml supportedPolicyTypes
in one PdpGroup.

Change-Id: I9a0788c788bab470109b0f09fb631e7fbb90042e
Issue-ID: POLICY-1723
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoCancel PDP timers in PAP 67/86667/1
Jim Hahn [Tue, 30 Apr 2019 18:39:43 +0000 (14:39 -0400)]
Cancel PDP timers in PAP

When a response is received by PAP from a PDP, the associated timer
(and listener) are not being cancelled.  As a result, when the timer
later expired, PAP was re-sending the request.  Modified the code to fix
this.

Change-Id: Id63f76622c01d286c169b618f8369b849ff31085
Issue-ID: POLICY-1715
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdding algorithm for Pdp registration 45/86545/5
ramverma [Tue, 30 Apr 2019 08:53:31 +0000 (08:53 +0000)]
Adding algorithm for Pdp registration

1) Adding algorithm for improving Pdp registration. The flow is:
When a new Pdp comes for registration, PAP will shortlist a list of
PdpGroups based on the supportedPolicyTypes reported by PdpStatus
message and the supportedPolicyTypes in the PdpSubGroup.
Then PAP will find the PdpGroup which needs the Pdp most in two ways:
1) If there is a subgroup with no Pdp's then that takes the priority.
2) Otherwise the Pdp is allocated to the PdpGroup with highest
difference value of desiredInstanceCount - currentInstanceCount.

2) Changing the preconfigured TosaPolicyType for apex to avoid
interference with legacy operational policies of drools.

Change-Id: I77584c3c030bc27903c11689acaca33148e27e3c
Issue-ID: POLICY-1630
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoSonar fixes for PAP "duplicate code" 63/86563/1
Jim Hahn [Mon, 29 Apr 2019 17:02:35 +0000 (13:02 -0400)]
Sonar fixes for PAP "duplicate code"

Extracted common code from "delete" controller.
Extracted common code from "deploy" controller.
Not sure if this will actually fix the sonar issue or not.  If it's
really complaining about the code, then this should fix it.  On
the other hand, if it's complaining about the annotations, then
I don't think there's a way around it.

Change-Id: I7c68393f3fc1b9719987d850582bd8ed335b9663
Issue-ID: POLICY-1711
Signed-off-by: Jim Hahn <jrh3@att.com>