Code Review / policy / pap.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: a7bf744) | patch
Fix sonars in policy-pap 48/121148/2
authorJim Hahn <jrh3@att.com>
Thu, 6 May 2021 21:32:21 +0000 (17:32 -0400)
committerJim Hahn <jrh3@att.com>
Thu, 6 May 2021 21:53:00 +0000 (17:53 -0400)
commitccca53bbd25af1230e135587163bcb53e381058c
tree921e378cdce276092a11261d9d094e8c96f3f5cftree | snapshot
parenta7bf744a50dcb660818a6bc6f265191b3389c13bcommit | diff
Fix sonars in policy-pap

Fixed:
- use "var" instead of actual type
- remove unused parameter
- remove un-thrown exception from method declaration
- call isPresent() before Optional.get()
- check empty list before invoking doesNotContain()

Issue-ID: POLICY-3285
Change-Id: Ic90dccfd591c102ce29f14084f025b3ca69587dc
Signed-off-by: Jim Hahn <jrh3@att.com>
33 files changed:
main/src/main/java/org/onap/policy/pap/main/comm/PdpHeartbeatListener.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/comm/PdpMessageGenerator.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/comm/PdpModifyRequestMap.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/comm/PdpRequests.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/comm/PdpStatusMessageHandler.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/comm/PdpTracker.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/comm/Publisher.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/comm/TimerManager.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/notification/DeploymentStatus.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/notification/DeploymentTracker.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/notification/PolicyNotifier.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/parameters/PapParameterHandler.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/HealthCheckProvider.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupCreateOrUpdateControllerV1.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupCreateOrUpdateProvider.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupDeleteControllerV1.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupDeleteProvider.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupDeployControllerV1.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupDeployProvider.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupHealthCheckProvider.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupQueryProvider.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupStateChangeProvider.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PolicyComponentsHealthCheckProvider.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PolicyStatusProvider.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PolicyUndeployerImpl.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/ProviderBase.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/SessionData.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/StatisticsRestProvider.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/startstop/Main.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/startstop/PapActivator.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/startstop/PapDatabaseInitializer.java diff | blob | history
main/src/test/java/org/onap/policy/pap/main/comm/PdpHeartbeatListenerTest.java diff | blob | history
main/src/test/java/org/onap/policy/pap/main/comm/msgdata/UpdateReqTest.java diff | blob | history
Policy Administration (Backend)