Fix issue with GeneratedValue in PfGeneratedIdKey 29/127129/5
authora.sreekumar <ajith.sreekumar@bell.ca>
Tue, 15 Feb 2022 12:16:30 +0000 (12:16 +0000)
committera.sreekumar <ajith.sreekumar@bell.ca>
Wed, 16 Feb 2022 11:49:27 +0000 (11:49 +0000)
commit676194789a8b880e2416f9d3bf2484a9fc6be1bc
tree71617241837026c53dec1f76b9c0b3ae7a584dff
parent45b653fc5a8d641452247eca5c80cf580609e9bf
Fix issue with  GeneratedValue in PfGeneratedIdKey

PfGeneratedIdKey class (which is used as a composite key
in JpaPolicyAudit and JpaPdpStatistics) uses GeneratedValue
in a wrong way and not according to the specification.
This review fixes it. PfGeneratedIdKey class is removed, and the
generatedId is directly specified in the JpaPolicyAudit and
JpaPdpStatistics classes.

Note: These classes are only used by PAP, so the related methods for db
interaction is removed as PAP directly talks to DB using spring
repository layer. Also the only end result this change brings is that the
'generatedId' alone will be used as the primary key instead of
'generatedId, name and version' together.

Corresponding changes in
DB Migrator: https://gerrit.onap.org/r/c/policy/docker/+/127139
PAP: https://gerrit.onap.org/r/c/policy/pap/+/127130

Change-Id: Ib4ea8b60ffe5c2480746569c0354bf474a6b7006
Issue-ID: POLICY-3897
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
22 files changed:
models-base/src/main/java/org/onap/policy/models/base/PfGeneratedIdKey.java [deleted file]
models-base/src/test/java/org/onap/policy/models/base/PfGeneratedIdKeyTest.java [deleted file]
models-dao/src/main/java/org/onap/policy/models/dao/PfDao.java
models-dao/src/main/java/org/onap/policy/models/dao/impl/DefaultPfDao.java
models-dao/src/main/java/org/onap/policy/models/dao/impl/ProxyDao.java
models-dao/src/test/java/org/onap/policy/models/dao/DummyGeneratedIdEntity.java [deleted file]
models-dao/src/test/java/org/onap/policy/models/dao/EntityTest.java
models-pap/src/main/java/org/onap/policy/models/pap/persistence/concepts/JpaPolicyAudit.java
models-pap/src/main/java/org/onap/policy/models/pap/persistence/provider/PolicyAuditProvider.java [deleted file]
models-pap/src/test/java/org/onap/policy/models/pap/persistence/provider/PolicyAuditProviderTest.java [deleted file]
models-pdp/src/main/java/org/onap/policy/models/pdp/persistence/concepts/JpaPdpStatistics.java
models-pdp/src/main/java/org/onap/policy/models/pdp/persistence/provider/PdpStatisticsProvider.java [deleted file]
models-pdp/src/test/java/org/onap/policy/models/pdp/persistence/concepts/JpaPdpStatisticsTest.java
models-pdp/src/test/java/org/onap/policy/models/pdp/persistence/provider/PdpStatisticsProviderTest.java [deleted file]
models-provider/src/main/java/org/onap/policy/models/provider/PolicyModelsProvider.java
models-provider/src/main/java/org/onap/policy/models/provider/impl/AbstractPolicyModelsProvider.java
models-provider/src/main/java/org/onap/policy/models/provider/impl/DatabasePolicyModelsProviderImpl.java
models-provider/src/test/java/org/onap/policy/models/provider/impl/DatabasePolicyModelsProviderTest.java
models-provider/src/test/java/org/onap/policy/models/provider/impl/DummyBadProviderImpl.java
models-provider/src/test/java/org/onap/policy/models/provider/impl/DummyPolicyModelsProviderImpl.java
models-provider/src/test/java/org/onap/policy/models/provider/impl/DummyPolicyModelsProviderTest.java
models-provider/src/test/java/org/onap/policy/models/provider/impl/PolicyStatisticsPersistenceTest.java [deleted file]