policy/engine.git
5 years agoUpdate Release Notes 07/49407/1 2.0.0-ONAP 2.0.0-ONAP v1.2.3
Saryu Shah [Tue, 29 May 2018 19:13:04 +0000 (19:13 +0000)]
Update Release Notes

Update Release Notes
-------------------------------------------------------------

Change-Id: I6283bc08bb95d49a343047968049e1cca5f53bf7
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoSonar fixes for TOSCA Parser 75/49175/3
Michael Mokry [Fri, 25 May 2018 18:25:26 +0000 (13:25 -0500)]
Sonar fixes for TOSCA Parser

I fixed the sonar blocker in regards to nullPointerException and few
other majors that I found and were easy to fix.  I ran my local sonar
and the blocker was removed after the changes.

Change-Id: I7dcd7584fc955e1b520235a8e1376cf871761d21
Issue-ID: POLICY-776
Signed-off-by: Michael Mokry <mm117s@att.com>
5 years agoMerge "Replace LOGPATH with LOGSUFFIX"
Pamela Dragosh [Thu, 24 May 2018 11:04:37 +0000 (11:04 +0000)]
Merge "Replace LOGPATH with LOGSUFFIX"

5 years agoMerge "Fix Issues in TOSCA Parser"
Pamela Dragosh [Thu, 24 May 2018 11:02:59 +0000 (11:02 +0000)]
Merge "Fix Issues in TOSCA Parser"

5 years agoFix Issues in TOSCA Parser 63/48563/7
Wang,Frank(gw1218) [Tue, 22 May 2018 19:50:33 +0000 (14:50 -0500)]
Fix Issues in TOSCA Parser

Fixed a bug and added some new validations in TOSCA Parser

Issue-ID: POLICY-776
Change-Id: I2dc1b5b38cd137efc5c24ccf55b19de9f47c44da
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
5 years agoReplace LOGPATH with LOGSUFFIX 83/48383/7
Jim Hahn [Mon, 21 May 2018 19:02:40 +0000 (15:02 -0400)]
Replace LOGPATH with LOGSUFFIX

docker-install.sh does not expand ${{xxx}} values in .conf
files before using them to update target files.  Consequently,
replaced LOGPATH with LOGSUFFIX in .conf files and updated
target files to use ${{POLICY_LOGS}}${{LOGSUFFIX}} instead.
Replace "${POLICY_HOME}/logs" in auxiliary files (e.g., logrotate)
with "${POLICY_LOGS}/policy".
Update license dates.
In .sh files, changed ${{POLICY_LOGS}} to ${POLICY_LOGS}, and
ensured that env.sh is sourced.
Use hard-coded paths in conf files instead of replacing
LOGPATH with LOGSUFFIX.
Update license dates.
Repoint path for IntegrityMonitor.log, as we cannot easily move
since it's in common.
Replace hard-coded log path in docker-install.sh.
Undo hard-coded log paths where possible, and modify scripts to
pass $POLICY_LOGS to JVM.

Change-Id: I027d8d2173ae97fef73b0daff1d6a87452857f93
Issue-ID: POLICY-759
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoUpdated version/date in release notes 55/48555/2
Saryu Shah [Tue, 22 May 2018 19:05:51 +0000 (19:05 +0000)]
Updated version/date in release notes

Updated version/date in release notes
-------------------------------------------------------------

Change-Id: I3d2fa0f7641074251e97e9f7b75772e9c8abe9f7
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoMerge "Update yml to use $POLICY_LOGS"
Pamela Dragosh [Tue, 22 May 2018 19:17:17 +0000 (19:17 +0000)]
Merge "Update yml to use $POLICY_LOGS"

5 years agoMerge "Update Policy Engine to 1.2.3-SNAPSHOT"
Jorge Hernandez [Tue, 22 May 2018 19:15:05 +0000 (19:15 +0000)]
Merge "Update Policy Engine to 1.2.3-SNAPSHOT"

5 years agoUpdate yml to use $POLICY_LOGS 49/48549/1
Jim Hahn [Tue, 22 May 2018 18:28:08 +0000 (14:28 -0400)]
Update yml to use $POLICY_LOGS

Change-Id: I4fec68b7bd50f8e71e36510bf595126435726677
Issue-ID: POLICY-759
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoUpdated release notes 99/48399/1
Saryu Shah [Mon, 21 May 2018 23:57:12 +0000 (23:57 +0000)]
Updated release notes

Updated release notes
-------------------------------------------------------------

Change-Id: I4f6282d25d177078306954be852a28301eb26c2d
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoUpdate Policy Engine to 1.2.3-SNAPSHOT 43/48343/1
liamfallon [Mon, 21 May 2018 15:49:26 +0000 (16:49 +0100)]
Update Policy Engine to 1.2.3-SNAPSHOT

These reviews must be merged in order because of layering.

This review should be merged FOURTH.

Change-Id: Ifca8e33b79085a4032164b44dae3401f8179f5f6
Issue-ID: POLICY-844
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
5 years agoAdd braces around property name 09/48209/1
Jim Hahn [Fri, 18 May 2018 17:20:52 +0000 (13:20 -0400)]
Add braces around property name

In pdplp.conf, changed ${POLICY_LOGS} to ${{POLICY_LOGS}}.

Change-Id: Id952dee7a38b868fea5650f4e54bfccb612bb56c
Issue-ID: POLICY-759
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoMerge "Upgrade SNAPSHOT to 1.2.2" v1.2.2
Pamela Dragosh [Wed, 16 May 2018 23:01:34 +0000 (23:01 +0000)]
Merge "Upgrade SNAPSHOT to 1.2.2"

5 years agoMerge "Added Release Notes - Known Issues"
Pamela Dragosh [Wed, 16 May 2018 23:00:47 +0000 (23:00 +0000)]
Merge "Added Release Notes - Known Issues"

5 years agoAdded Release Notes - Known Issues 19/47919/1
Saryu Shah [Wed, 16 May 2018 21:39:15 +0000 (21:39 +0000)]
Added Release Notes - Known Issues

Added Release Notes - Known Issues
-------------------------------------------------------------

Change-Id: Ie5b1e9499114e09aedb72a95d389f2e07b4f5514
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoUpgrade SNAPSHOT to 1.2.2 19/47819/6
liamfallon [Wed, 16 May 2018 12:59:46 +0000 (13:59 +0100)]
Upgrade SNAPSHOT to 1.2.2

These reviews must be merged in order because of layering.

This review should be merged SECOND

Note: In order to get past the following layering problems, there
are temporary chages to the following POMs to temporarily use 1.2.1-SNAPSHOT
for those dependencies. They are
ONAP-PAP-REST/pom.xml
 org.onap.policy.drools-applications.controlloop.common.policy-yaml
ONAP-PDP/pom.xml
 org.onap.policy.drools-pdp.policy-endpoints

A separate review will be used to restore these dependencies to 1.2.2-SNAPSHOT
once the drools-pdp and drools-applications reviews are submitted and merged

PLD added version.properties

Issue-ID: POLICY-798
Change-Id: Id7e83f2ba12181c63cc8845b7eeccf2004d2bab9
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
5 years agoMerge "policy documentation - release notes"
Jorge Hernandez [Wed, 16 May 2018 16:30:44 +0000 (16:30 +0000)]
Merge "policy documentation - release notes"

5 years agopolicy documentation - release notes 51/47851/1
Saryu Shah [Wed, 16 May 2018 15:54:15 +0000 (15:54 +0000)]
policy documentation - release notes

policy documentation - release notes
-------------------------------------------------------------

Change-Id: Ie480002003725fe6949c631c2a9c50fa7d1665c2
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoMerge "Documentation edits for pooling"
Pamela Dragosh [Wed, 16 May 2018 00:34:16 +0000 (00:34 +0000)]
Merge "Documentation edits for pooling"

5 years agoDocumentation edits for pooling 15/47715/1
Saryu Shah [Tue, 15 May 2018 20:30:13 +0000 (20:30 +0000)]
Documentation edits for pooling

Documentation edits for pooling and locks
-------------------------------------------------------------

Change-Id: I1b594db33437f9c9d43902ec448bcd205093beaf
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoMerge "SRM, Locking, Pooling documentation"
Jorge Hernandez [Tue, 15 May 2018 19:05:29 +0000 (19:05 +0000)]
Merge "SRM, Locking, Pooling  documentation"

5 years agoMerge "Documentation edits for OOF"
Jorge Hernandez [Tue, 15 May 2018 19:05:19 +0000 (19:05 +0000)]
Merge "Documentation edits for OOF"

5 years agoSRM, Locking, Pooling documentation 73/47673/1
Saryu Shah [Tue, 15 May 2018 18:07:54 +0000 (18:07 +0000)]
SRM, Locking, Pooling  documentation

SRM, Locking, Pooling  documentation
-------------------------------------------------------------

Change-Id: Id66463fc89f2c2c466ad92936816be878cfd77b7
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoFix BRMS Gateway version on properties 57/47657/1
liamfallon [Tue, 15 May 2018 16:47:11 +0000 (17:47 +0100)]
Fix BRMS Gateway version on properties

Incorrect snapshot version showed up on scan of source code for snapshots

Issue-ID: POLICY-780
Change-Id: I7fb838a88fc50ce8b566aa9b9ad0b4b7e3188b3a
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
5 years agoDocumentation edits for OOF 19/47419/1
Saryu Shah [Mon, 14 May 2018 14:55:27 +0000 (14:55 +0000)]
Documentation edits for OOF

Documentation edits for OOF
-------------------------------------------------------------

Change-Id: I84f9992bd61e10ef9f263b68a28cca100a515437
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoMerge "Documentation OOF Spec"
Pamela Dragosh [Sat, 12 May 2018 15:32:28 +0000 (15:32 +0000)]
Merge "Documentation OOF Spec"

5 years agoDocumentation OOF Spec 95/47295/1
Saryu Shah [Sat, 12 May 2018 00:31:24 +0000 (00:31 +0000)]
Documentation OOF Spec

Documentation for Policy Specification and Retrieval for OOF
-------------------------------------------------------------

Change-Id: Idb063b85c8bc3ff45b04d522563cffe33b4224c9
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoMerge "Fix POLICY_LOGS property in paplp.conf" v1.2.1
Jorge Hernandez [Fri, 11 May 2018 03:10:35 +0000 (03:10 +0000)]
Merge "Fix POLICY_LOGS property in paplp.conf"

5 years agoMerge "Change error to warning"
Jorge Hernandez [Fri, 11 May 2018 03:09:50 +0000 (03:09 +0000)]
Merge "Change error to warning"

5 years agoPolicy OOF-HPA documentation 53/47153/1
Saryu Shah [Thu, 10 May 2018 23:46:56 +0000 (23:46 +0000)]
Policy OOF-HPA documentation

Policy OOF-HPA documentation
-------------------------------------------------------------

Change-Id: I1015b21cb6b5599a48e7914a6fcb97ee4cb63ccd
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoFix POLICY_LOGS property in paplp.conf 47/47147/2
Jim Hahn [Thu, 10 May 2018 21:58:28 +0000 (17:58 -0400)]
Fix POLICY_LOGS property in paplp.conf

Added extra braces around POLICY_LOGS property.

Change-Id: I4022d00a74971be70dc5b3c2cb435be31d91386c
Issue-ID: POLICY-758
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoChange error to warning 41/47141/1
Jim Hahn [Thu, 10 May 2018 21:38:25 +0000 (17:38 -0400)]
Change error to warning

Changed ERROR about decryption to WARNING.
Added POLICY_LOGS to base.conf (for non-docker).

Change-Id: If32965f1c37b36102c12371e739e1a155bb255f0
Issue-ID: POLICY-758
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoMerge "fixing NullPointException incase of db exception"
Jorge Hernandez [Tue, 8 May 2018 18:11:20 +0000 (18:11 +0000)]
Merge "fixing NullPointException incase of db exception"

5 years agoMerge "Convert license header to SQL comment"
Jorge Hernandez [Tue, 8 May 2018 17:00:47 +0000 (17:00 +0000)]
Merge "Convert license header to SQL comment"

5 years agofixing NullPointException incase of db exception 59/46659/2
waqas.ikram [Tue, 8 May 2018 16:46:40 +0000 (17:46 +0100)]
fixing NullPointException incase of db exception

Making changes for NullPointerException
it was triggered by
- SQL Query Failed in PAP return unhandled reponse code  >  activeVersion variable is set to null > if statement in DeletePolicyService (!activeVersion.equalsIgnoreCase("0") result into NullPointerException

Change-Id: Iad9de0d31b6cf16d1eafd6175d1c355b07481db9
Issue-ID: POLICY-773
Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
5 years agoRemove eclipse toolbuilder file 57/46657/1
Pamela Dragosh [Tue, 8 May 2018 16:30:45 +0000 (12:30 -0400)]
Remove eclipse toolbuilder file

This file should not be in gerrit. Removing prior to release
of artifacts.

Issue-ID: POLICY-780
Change-Id: Ib950a6033ec3069263e9fd44628fb9d2181c9c44
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoConvert license header to SQL comment 39/46639/1
liamfallon [Tue, 8 May 2018 15:40:03 +0000 (16:40 +0100)]
Convert license header to SQL comment

Changed comment from Java style to SQL style

Change-Id: Ia0ac3991cd58939f5efc0c752148b11931136a4f
Issue-ID: POLICY-773
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
5 years agoMerge "Configuration as argument to BRMS Gateway"
Pamela Dragosh [Tue, 8 May 2018 14:56:31 +0000 (14:56 +0000)]
Merge "Configuration as argument to BRMS Gateway"

5 years agoConfiguration as argument to BRMS Gateway 77/46577/2
liamfallon [Tue, 8 May 2018 10:28:40 +0000 (11:28 +0100)]
Configuration as argument to BRMS Gateway

Added the ability specify the parameter file for the BRMS Gateway
as a argument to allow different configurations to be used during
unit test. This will allow more thorought unit tests to be written.

Replaced System.exit() calls with exeception throws becasue
System.exit() call bring down the entire JVM during testing, terminating
the test at that point.

Changed the package path on four unit test files to the correct path for
unit tests for the BRMS gateway.

Added a unit test for sanity test of the configuraiton file argument.

Issue-ID: POLICY-773
Change-Id: Ic095a5131ddb846eaf3b11157853fab71908c629
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
5 years agofix PE DB lock timeout problems 19/46519/1
Jorge Hernandez [Tue, 8 May 2018 01:26:19 +0000 (20:26 -0500)]
fix PE DB lock timeout problems

see companion docker review.

The failOverReadOnly .. flags should only be used when a DB high
availability environment is used, such as a master/slave
configuration.

As they are the jdbc parameters have caused bad interactions
with the underlying persistence libraries rendering the PAP
useless.

It is thought that this may perhaps solve
POLICY-773, POLICY-775, POLICY-779, and perhaps POLICY-776.

Change-Id: Icb69a3afc0a19969a34af40d960fa8e1b94aabc0
Issue-ID: POLICY-777
Signed-off-by: Jorge Hernandez <jh1730@att.com>
5 years agoautomate dependency.json version population 07/46507/1
Jorge Hernandez [Mon, 7 May 2018 23:22:12 +0000 (18:22 -0500)]
automate dependency.json version population

This avoids error-prone manual version changes
to configuration files.

Change-Id: I1a991ef9a8eb4cc7dd5fe26d9952286d8b5c0115
Issue-ID: POLICY-766
Signed-off-by: Jorge Hernandez <jh1730@att.com>
5 years agoAdding rollback for transaction handling 45/46245/3
waqas.ikram [Fri, 4 May 2018 15:50:35 +0000 (16:50 +0100)]
Adding rollback for transaction handling

Change-Id: I90887aafdd3cc49940bb4ed4b9283ec8a25aa205
Issue-ID: POLICY-773
Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
5 years agoUpdated policy documentation 31/45931/1
Saryu Shah [Thu, 3 May 2018 17:50:48 +0000 (17:50 +0000)]
Updated policy documentation

Updated policy documentation
-------------------------------------------------------------

Change-Id: I840d17df857bb14fdc7e96e3c5f984037944c889
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoMerge "Ignore directories created"
Jorge Hernandez [Wed, 2 May 2018 16:19:28 +0000 (16:19 +0000)]
Merge "Ignore directories created"

5 years agoAdd INFO.yaml file 65/45365/6
Jessica Wagantall [Tue, 1 May 2018 03:08:17 +0000 (20:08 -0700)]
Add INFO.yaml file

Add INFO.yaml to list:
- Project description
- Properties
- PTL information
- Meeting information
- Committer information

Change-Id: Iab302b1e24c08980e3073d3fa34d53e4e81cabad
Issue-ID: CIMAN-134
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoIgnore directories created 77/45477/2
Pamela Dragosh [Tue, 1 May 2018 17:20:05 +0000 (13:20 -0400)]
Ignore directories created

Clean up some outstanding logging side effects in .gitignore

Issue-ID: POLICY-708
Change-Id: Ia3f268f0adf5615a11a109cb0d7d029a069b4520
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoFix Test fail with variable length memory address 75/45475/1
liamfallon [Tue, 1 May 2018 17:13:12 +0000 (18:13 +0100)]
Fix Test fail with variable length memory address

The unit test class PIPConfigurationTest.java has a test that checks a
configuration string for length. However, the length of the "piptype"
field in that string can vary, causing the test to intermittently fail.

Field that passes:
piptype=org.onap.policy.rest.jpa.PIPType@71b3bc45

Field that fails:
piptype=org.onap.policy.rest.jpa.PIPType@a8c1f44

This fix removes the memory address from the "piptype" field, so that the configuration string will
now always be 323 characters in length.

Change-Id: Ib3640ec6f69ac7d691dcc989c44a7822bcc9b7f7
Issue-ID: POLICY-765
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
5 years agoUpdated installation documentation 45/45345/2
Saryu Shah [Tue, 1 May 2018 01:12:23 +0000 (01:12 +0000)]
Updated installation documentation

Updated installation documentation
-------------------------------------------------------------

Change-Id: I71d24c0806fc5d53691c505f87425c71e2f0a04f
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoMerge "Remove sysout from junit and disable assert."
Pamela Dragosh [Tue, 1 May 2018 13:52:30 +0000 (13:52 +0000)]
Merge "Remove sysout from junit and disable assert."

5 years agoRemove sysout from junit and disable assert. 83/45183/4
pa834y [Sat, 28 Apr 2018 00:13:24 +0000 (20:13 -0400)]
Remove sysout from junit and disable assert.

Updated BRMS Gateway junit tests to be less strict on hit counts
on queries to Nexus.

Draft version passed build son now submitting as full submission.

Change-Id: Iab81d14be69835faefbb96fb0af17b3f3759575b
Issue-ID: POLICY-756
Signed-off-by: pa834y <pa834y@att.com>
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
5 years agoUpdated policy documentation 67/45167/1
Saryu Shah [Fri, 27 Apr 2018 20:45:25 +0000 (20:45 +0000)]
Updated policy documentation

Fixed typos, Updated release notes, Deleted old release files
-------------------------------------------------------------

Change-Id: I43bb64b7d1829e92b30bfd45ec3f3608a59672cf
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoIncorporate Liam code review 63/44963/1
pa834y [Thu, 26 Apr 2018 19:26:26 +0000 (15:26 -0400)]
Incorporate Liam code review

Change-Id: I387a54b8bd8c619c521c512258928669a8c1b791
Issue-ID: POLICY-756
Signed-off-by: pa834y <pa834y@att.com>
5 years agoMerge "Fix typo in documentation"
Pamela Dragosh [Thu, 26 Apr 2018 18:32:15 +0000 (18:32 +0000)]
Merge "Fix typo in documentation"

5 years agoFix typo in documentation 47/44947/1
Saryu Shah [Thu, 26 Apr 2018 18:04:45 +0000 (18:04 +0000)]
Fix typo in documentation

Fix typo in documentation
-------------------------------------------------------------

Change-Id: I01b8849c97645e9e5ed81f99768088f2fa439e45
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
6 years agoMerge "Remove unit test Java version dependency"
Pamela Dragosh [Thu, 26 Apr 2018 11:20:50 +0000 (11:20 +0000)]
Merge "Remove unit test Java version dependency"

6 years agoRemove unit test Java version dependency 47/44747/1
liamfallon [Wed, 25 Apr 2018 19:11:54 +0000 (20:11 +0100)]
Remove unit test Java version dependency

In the unit tests for the direct Sona Nexus Rest Interface, one
of the unit tests only passed on an Oracle Java specific string.

This test is fixed to now work on both Oracle and OpenJDK java

Issue-ID: POLICY-700
Change-Id: Idae1aaf612a10ac003f2a91c0b5a80540152ac95
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agocook policy-keystore into pe image 15/44715/1
Jorge Hernandez [Wed, 25 Apr 2018 17:53:23 +0000 (12:53 -0500)]
cook policy-keystore into pe image

OOM team reported issues with ONAP installation in
terms of config map sizes.   After discussion with
OOM team, one solution is to cook it in the docker
image itself.   This will solve the size issue on
the OOM side.

Change-Id: I2ca20bdc3aa8ee959c5e4c1d07483fe5f0c14607
Issue-ID: POLICY-747
Signed-off-by: Jorge Hernandez <jh1730@att.com>
6 years agoMerge "Add JUnit for direct Sonar Nexus REST interface"
Jorge Hernandez [Wed, 25 Apr 2018 14:34:54 +0000 (14:34 +0000)]
Merge "Add JUnit for direct Sonar Nexus REST interface"

6 years agoAdd websocket client code. 41/44541/1
pa834y [Wed, 25 Apr 2018 00:25:22 +0000 (20:25 -0400)]
Add websocket client code.

Change-Id: I2d3939c698a0df6bec068063f08566226f65bfd3
Issue-ID: POLICY-756
Signed-off-by: pa834y <pa834y@att.com>
6 years agoAdd JUnit for direct Sonar Nexus REST interface 35/44535/1
liamfallon [Tue, 24 Apr 2018 22:47:45 +0000 (23:47 +0100)]
Add JUnit for direct Sonar Nexus REST interface

JUnit tests and changes to the source code to fix issues that were
identified in JUnit testing.

JUnit testing runs tests towards the Nexus server at
https://nexus.onap.org
If that server does not exist then the unit tests will fail
but as the nexus serveir is required for the build to work then
it should be OK to use that server for unit testing. This removes
the need to write complex (and less effective) Mockito type
unit tests.

Issue-ID: POLICY-700
Change-Id: I4aa33a1022033b42bb1fd1fa36785a8e0216b887
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoImplement Sonar Nexus REST interface directly 85/44385/1
liamfallon [Tue, 24 Apr 2018 14:29:41 +0000 (15:29 +0100)]
Implement Sonar Nexus REST interface directly

The BRMS gateway used the obsolete nexus-rest-client-java library
to query the Nexus repository. This change removes that dependency and
implements an interface directly to Nexus servers using the Nexus
REST interface.

This change is being submitted to ensure that the security issues with the
plugin are resolved. The unit test for the new code will be implemented
in a later submission.

Issue-ID: POLICY-700
Change-Id: Ia1044e432d370034fe13f42cf7ed55d75e21187a
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoRemove cookbook gif 59/44259/1
Saryu Shah [Mon, 23 Apr 2018 21:54:37 +0000 (21:54 +0000)]
Remove cookbook gif

Remove cookbook picture from page
-------------------------------------------------------------

Change-Id: I61edd0e4f336b19237421f05d6d36b61bb63170f
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
6 years agoAdd license to policy/engine image files 17/44217/2
Jim Hahn [Mon, 23 Apr 2018 16:31:28 +0000 (12:31 -0400)]
Add license to policy/engine image files

Added license to gif, jpg, and png files.
Removed changes from gif files in POLICY-SDK-APP.

Change-Id: Ief0c4be74cbdb844dd503040832be6c89bcc7ef9
Issue-ID: POLICY-741
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoBuild fails when build host running web server 07/44007/1
liamfallon [Fri, 20 Apr 2018 20:08:12 +0000 (21:08 +0100)]
Build fails when build host running web server

If the host on which the policy engine is running a web server that
respoonds with a HTTP response on the URL "http://localhost", the build
fails because one of the tests in ONAP-XACML expects a ConnectException
on this URL. When the URL returns a valid respose the test fails causing
the buld to fail.

This fix changes the URL to "http://localhost:54287", which I guess could
also exist but is much less liekly to exist.

Change-Id: I2f80d12a80d29a9bc7b2067f35c286f01c4d9550
Issue-ID: POLICY-700
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoAdd license to policy-engine files 47/43747/1
Jim Hahn [Thu, 19 Apr 2018 15:28:41 +0000 (11:28 -0400)]
Add license to policy-engine files

Added license to various files.
Updated XACMLPolicyScanner to work even when license comment
is added to the Policy.xml file.
Moved DOCTYPE before license in html files.
Removed license from css files, as many are generated or
come from third-party software.
Removed license from other generated files.

Change-Id: I9d98ca9f552a6eae17e80ef27fc7045cc4f27b8e
Issue-ID: POLICY-741
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoMerge "Remove insecure dependency on PolicyEngineAPI"
Pamela Dragosh [Thu, 19 Apr 2018 14:38:09 +0000 (14:38 +0000)]
Merge "Remove insecure dependency on PolicyEngineAPI"

6 years agoRemove insecure dependency on PolicyEngineAPI 11/43611/1
liamfallon [Wed, 18 Apr 2018 20:16:52 +0000 (21:16 +0100)]
Remove insecure dependency on PolicyEngineAPI

The insecure dependency tyrus-container-grizzly-client is
part of Tyrus, a Java web socket implementation library.

A direct substitution of this library is not available so
the code in AutoClientEnd.java and ManualClientEnd.java
was adapted to work with the library
org.java-websocket.Java-WebSocket
that does not seem to have any vulnerabilities when tested
with the org.owasp.dependency-check-maven plugin.

The purpose of this submission is to see if the new library
does indeed remove the vulnerability. If so, the implementation
in AutoClientEnd and ManualClientEnd must be cleaned up.

Change-Id: I961635aaea42c2f847edf11ee77e2961cdfb097b
Issue-ID: POLICY-744
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoUpgrade poi to clear CLM 21/43521/1
Pamela Dragosh [Wed, 18 Apr 2018 13:55:48 +0000 (09:55 -0400)]
Upgrade poi to clear CLM

https://nvd.nist.gov/vuln/detail/CVE-2017-12626

Issue-ID: POLICY-722
Change-Id: I016d2d357858729b402ad010d47a31af053d2799
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoUpgrade hibernator and netty 13/43413/1
Pamela Dragosh [Tue, 17 Apr 2018 18:16:32 +0000 (14:16 -0400)]
Upgrade hibernator and netty

Forgot one place for hibernator and need to upgrade netty to
clear CLM issue.

http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-2156

Issue-ID: POLICY-722
Change-Id: I741c47110af916c222f92329791217b0c3bc07df
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoUpgrade hibernator to clear clm 69/43369/1
Pamela Dragosh [Tue, 17 Apr 2018 14:30:19 +0000 (10:30 -0400)]
Upgrade hibernator to clear clm

Upgrade hibernator to clear clm issue.

https://nvd.nist.gov/vuln/detail/CVE-2017-7536

Issue-ID: POLICY-722
Change-Id: I1a4d9aa8ad3b477db0c91bd5a53a67932554213d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoUpgrade spring 4.3.15-RELEASE 37/43337/1
Pamela Dragosh [Tue, 17 Apr 2018 12:54:15 +0000 (08:54 -0400)]
Upgrade spring 4.3.15-RELEASE

Forgot this reference to spring.

Issue-ID: POLICY-722
Change-Id: I4335d860a883f925f1a6ba7bf28f6b59ed52511f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoMerge "Upgrade Spring to 4.3.15-RELEASE"
Jorge Hernandez [Mon, 16 Apr 2018 23:09:40 +0000 (23:09 +0000)]
Merge "Upgrade Spring to 4.3.15-RELEASE"

6 years agoUpgrade Spring to 4.3.15-RELEASE 09/43109/1
Pamela Dragosh [Mon, 16 Apr 2018 17:30:06 +0000 (13:30 -0400)]
Upgrade Spring to 4.3.15-RELEASE

Upgrade to fix 3 security issues:

https://nvd.nist.gov/vuln/detail/CVE-2018-1270
https://nvd.nist.gov/vuln/detail/CVE-2016-9878
https://nvd.nist.gov/vuln/detail/CVE-2018-1271

Issue-ID: POLICY-722
Change-Id: Icfa5775905ad091dbe55eadfb4414c67abebc13a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoFix wrong data name 97/43097/1
Wang,Frank(gw1218) [Mon, 16 Apr 2018 16:46:07 +0000 (11:46 -0500)]
Fix wrong data name

Since MS configure name was changed in server side, its name needs to be
updated in the JS file also.

Issue-ID: POLICY-743
Change-Id: Iaed37a8d2b4dcfc5fb5ccd746b9aeb2270289338
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
6 years agoMerge "Upgrade to SNAPSHOT 1.2.1"
Jorge Hernandez [Sat, 14 Apr 2018 00:22:08 +0000 (00:22 +0000)]
Merge "Upgrade to SNAPSHOT 1.2.1"

6 years agoUpgrade to SNAPSHOT 1.2.1 09/42809/1
Pamela Dragosh [Fri, 13 Apr 2018 19:55:51 +0000 (15:55 -0400)]
Upgrade to SNAPSHOT 1.2.1

Issue-ID: POLICY-736
Change-Id: If5c959aa1c0a123c7fd9eee281e39e1d646b6b03
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoFix Wrong Data Names 53/42553/1
Wang,Frank(gw1218) [Thu, 12 Apr 2018 16:59:00 +0000 (11:59 -0500)]
Fix Wrong Data Names

Fix wrong data names due to reponse changes

Issue-ID: POLICY-740
Change-Id: I28db745f88ccecd67f3daa30adf70cc69645b496
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
6 years agoMerge "OOF Policy Config File Creation Issue" v1.2.0
Jorge Hernandez [Thu, 12 Apr 2018 16:04:49 +0000 (16:04 +0000)]
Merge "OOF Policy Config File Creation Issue"

6 years agoOOF Policy Config File Creation Issue 27/42527/1
Michael Mokry [Thu, 12 Apr 2018 14:45:06 +0000 (09:45 -0500)]
OOF Policy Config File Creation Issue

Fixed the issue with creating the config file with the wrong file name
so that the PDP can pick it up when pushing the policy and getCOnfig
will return the Config retrieved rather than a CONFIG_NOT_FOUND 400
status.

I found this issue in the new CSIT tests for HPA policies and this
should also resolve the failed test in Integration as well.

Change-Id: I617133a188f3ba915feafd79da4f3e9d0b0eb4a6
Issue-ID: POLICY-738
Signed-off-by: Michael Mokry <mm117s@att.com>
6 years agoMerge "Fix Fortify Header Manipulation Issue"
Pamela Dragosh [Thu, 12 Apr 2018 13:54:22 +0000 (13:54 +0000)]
Merge "Fix Fortify Header Manipulation Issue"

6 years agoUpdate Release Notes 97/41797/2
Saryu Shah [Mon, 9 Apr 2018 19:43:51 +0000 (19:43 +0000)]
Update Release Notes

Update Release Notes
-------------------------------------------------------------

Change-Id: I3119427562112969afac284576b3fe799eac0887
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
6 years agoFix Fortify Header Manipulation Issue 03/41203/4
Wang,Frank(gw1218) [Thu, 5 Apr 2018 14:22:50 +0000 (09:22 -0500)]
Fix Fortify Header Manipulation Issue

Fix Forfity issue on group Id by adding a validation on this input
value.

Issue-ID: POLICY-734
Change-Id: I83321a5ffd1ddca84f985b5fd8659e502ca967d7
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
6 years agoModified DB Upgrade script for OptimizationModels 95/41195/2
Michael Mokry [Thu, 5 Apr 2018 14:08:44 +0000 (09:08 -0500)]
Modified DB Upgrade script for OptimizationModels

Changed the incorrect column 'dataorder' to 'dataorderinfo'

Made changes to pom and AAF client code per AAF API changes in new
depedency.

Change-Id: Ic9bf0edec8282cc0f96d6fedd62fa9253d52070f
Issue-ID: POLICY-731
Signed-off-by: Michael Mokry <mm117s@att.com>
6 years agoONAP log files consolidation 01/41001/2
Chou, Joseph (JC2555) [Mon, 2 Apr 2018 18:11:34 +0000 (14:11 -0400)]
ONAP log files consolidation

Check in changes for pap,pdp,console,brmsgw,paplp and pdplp

Change-Id: I5b51368f8fed2d0ede848f1aa7f2f70c866dfe8b
Issue-ID: POLICY-562
Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
6 years agoMerge "Add More Validations on TOSCA Model Format"
Jorge Hernandez [Wed, 4 Apr 2018 15:56:29 +0000 (15:56 +0000)]
Merge "Add More Validations on TOSCA Model Format"

6 years agoAdd More Validations on TOSCA Model Format 13/40813/3
Wang,Frank(gw1218) [Tue, 3 Apr 2018 21:17:54 +0000 (16:17 -0500)]
Add More Validations on TOSCA Model Format

Add more validations on TOSCA MS model file name and content format

Issue-ID: POLICY-721
Change-Id: Ic3dfe1887791be1e11bca5695866a77909334536
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
6 years agoMerge "ONAP log files consolidation"
Jorge Hernandez [Tue, 3 Apr 2018 21:34:01 +0000 (21:34 +0000)]
Merge "ONAP log files consolidation"

6 years agoMerge "Update docker script for tomcat install"
Jorge Hernandez [Tue, 3 Apr 2018 18:22:08 +0000 (18:22 +0000)]
Merge "Update docker script for tomcat install"

6 years agoMerge "Documentation links"
Pamela Dragosh [Tue, 3 Apr 2018 18:14:38 +0000 (18:14 +0000)]
Merge "Documentation links"

6 years agoDocumentation links 67/40767/1
Saryu Shah [Tue, 3 Apr 2018 17:52:11 +0000 (17:52 +0000)]
Documentation links

Updated swarch_pdp.rst to include links.
-------------------------------------------------------------

Change-Id: I6db8fc4200ef31883496c25736158c57da4e28b4
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>
6 years agoUpdate docker script for tomcat install 37/40737/1
Pamela Dragosh [Tue, 3 Apr 2018 16:15:16 +0000 (12:15 -0400)]
Update docker script for tomcat install

Issue-ID: POLICY-507
Change-Id: I14278865429dc0ccd0515ef5c84012b43b366c9a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoMerge "Fix BRMSGW Executable Jar Class Path"
Jorge Hernandez [Tue, 3 Apr 2018 14:34:28 +0000 (14:34 +0000)]
Merge "Fix BRMSGW Executable Jar Class Path"

6 years agoONAP log files consolidation 43/40543/4
Chou, Joseph (JC2555) [Mon, 2 Apr 2018 18:11:34 +0000 (14:11 -0400)]
ONAP log files consolidation

Check in changes for pap,pdp,console,brmsgw,paplp and pdplp

Change-Id: I23525a44e0f269d04d9870c3eed18b6b8daacb2c
Issue-ID: POLICY-562
Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
6 years agoFix BRMSGW Executable Jar Class Path 93/40693/2
Daniel Cruz [Tue, 3 Apr 2018 13:08:19 +0000 (08:08 -0500)]
Fix BRMSGW Executable Jar Class Path

The BRMSGW is no longer able to start up
in windriver due to recent changes to the
package names. The class path to generate
the executable jar now reflects the recent
changes.

Issue-ID: POLICY-681
Change-Id: I032e516e082defd6a7ad0daae559f8c3e60ae531
Signed-off-by: Daniel Cruz <dc443y@att.com>
6 years agoMerge "JUnit additions for PDP,PDP-REST,SDK,XACML"
Pamela Dragosh [Tue, 3 Apr 2018 12:32:48 +0000 (12:32 +0000)]
Merge "JUnit additions for PDP,PDP-REST,SDK,XACML"

6 years agoMerge "Fix a Bug on Checking Required Fields"
Jorge Hernandez [Tue, 3 Apr 2018 01:27:47 +0000 (01:27 +0000)]
Merge "Fix a Bug on Checking Required Fields"

6 years agoFix a Bug on Checking Required Fields 41/40541/4
Wang,Frank(gw1218) [Mon, 2 Apr 2018 17:52:28 +0000 (12:52 -0500)]
Fix a Bug on Checking Required Fields

Fix a bug in checking required fields if the object has include function

Issue-ID: POLICY-717
Change-Id: I766da50c9ac02081dd4e711b8c78be0f3c25e5bd
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
6 years agoDocumentation edits 59/40559/2
Saryu Shah [Mon, 2 Apr 2018 19:44:56 +0000 (19:44 +0000)]
Documentation edits

Fixing typos in modifying Release Template Page
-------------------------------------------------------------

Issue-ID: POLICY-536

Change-Id: I8334afe77761ae3fe5fbee35719957ec10af1c8f
Signed-off-by: Saryu Shah <ss3917@att.com>
6 years agoMerge "Support CSIT tests for OOF Policy"
Pamela Dragosh [Mon, 2 Apr 2018 19:59:53 +0000 (19:59 +0000)]
Merge "Support CSIT tests for OOF Policy"