Pamela Dragosh [Wed, 15 Apr 2020 00:34:21 +0000 (20:34 -0400)]
Point to released common,models,drools-apps
Issue-ID: POLICY-2378
Change-Id: I4aa81585e154c1e7ee131db9cf5194530a212e67
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
uj426b [Tue, 14 Apr 2020 21:17:36 +0000 (17:17 -0400)]
Fix for Policy editor GUI issue.
Issue-ID: POLICY-2492
Change-Id: Ic436a72d321c9aeed1a7eeec57c6dfc44819d6cc
Signed-off-by: uj426b <uj426b@att.com>
Pamela Dragosh [Mon, 13 Apr 2020 20:54:37 +0000 (16:54 -0400)]
Point to parent, common, models
Released parent, fixes in model and commons.
Issue-ID: POLICY-2486
Change-Id: I5c939dade1024dc6c606250ec8f55ece74614b36
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
jhh [Thu, 9 Apr 2020 18:24:02 +0000 (13:24 -0500)]
manual revert of jpa dependency on brmsgw
The review https://gerrit.onap.org/r/c/policy/engine/+/105439
introduced an additional dependency that did not solve the
underlying issue per testing. Reverting back the change,
as other repos seem to be working without needing it.
Issue-ID: POLICY-2471
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ibb2318e768b8fbb0fc4107757b80ca18cc89dcfb
LF Jenkins CI [Wed, 8 Apr 2020 20:22:03 +0000 (20:22 +0000)]
Automation adds policy-engine-architecture.rst
Issue-ID: CIMAN-376
Change-Id: I8079f4dee4b5b1e9ffd643f1c97eb01c8c675055
Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>
Jessica Wagantall [Wed, 8 Apr 2020 16:57:15 +0000 (16:57 +0000)]
Merge "Automation adds index.rst"
uj426b [Tue, 7 Apr 2020 18:29:42 +0000 (14:29 -0400)]
Fix for healthcheck issue with brmsgw
Issue-ID: POLICY-2471
Change-Id: Ic0acc8889639a7346486797550a6bcb127e1291b
Signed-off-by: uj426b <uj426b@att.com>
LF Jenkins CI [Tue, 7 Apr 2020 17:43:11 +0000 (17:43 +0000)]
Automation adds index.rst
Issue-ID: CIMAN-376
Change-Id: Iccb0fe8931fb22447e1d4983adf74d4be7fc92e2
Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>
Pamela Dragosh [Tue, 7 Apr 2020 12:44:16 +0000 (08:44 -0400)]
Point to parent SNAPSHOT
Issue-ID: POLICY-2378
Change-Id: I4522be8ab99a9d5dde6b1df731cf6135011c58d5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Fri, 27 Mar 2020 17:01:51 +0000 (13:01 -0400)]
Point to released snapshots
Issue-ID: POLICY-2378
Change-Id: I6213bdf4a5c3a83312f0bb2926474e4f3acaa681
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Thu, 26 Mar 2020 01:06:19 +0000 (21:06 -0400)]
Bump engine 1.6.2 patch
I'm not going to bother with the other non-pom changes.
Until we really need to.
Issue-ID: POLICY-2378
Change-Id: Ib06ae950cd37d75fb34f49fd5cb207deca998c11
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Thu, 26 Mar 2020 00:31:52 +0000 (20:31 -0400)]
Release engine 1.6.1 docker
Issue-ID: POLICY-2378
Change-Id: I81ecd9eb4e26d4e51b52b4fd4dc7663555468444
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 25 Mar 2020 23:04:59 +0000 (19:04 -0400)]
Release engine 1.6.1 artifacts
Issue-ID: POLICY-2378
Change-Id: Ib18bd384cd600492c7de0bd03d4738721e15f560
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 25 Mar 2020 20:44:40 +0000 (16:44 -0400)]
Point to released artifacts
1.6.0 is drools-app
2.2.2 is models
Issue-ID: POLICY-2378
Change-Id: I4329d433104e814ae023ee624442c79eb5eed3df
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Tue, 24 Mar 2020 20:47:52 +0000 (16:47 -0400)]
Ignore JUnit that fails intermittently
Issue-ID: POLICY-2378
Change-Id: Iaa2e804af63d4ce1232326bd2dcca96083e5f087
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Tue, 24 Mar 2020 18:45:24 +0000 (14:45 -0400)]
Bump patch 1.6.1 to fix JUnit issue
The docker stage job is not succeeded, nor is the sonar
job. Logging doesn't produce anything useful, so the best
bet is to fix the order of the tests and hope that fixes the
problem.
Regardless must bump the patch to release it again.
Issue-ID: POLICY-2378
Change-Id: I01ff47c8deb124e9fd6ffcb37407dc580ecd6b03
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Tue, 24 Mar 2020 15:23:19 +0000 (11:23 -0400)]
Release engine 1.6.0 artifacts
Issue-ID: POLICY-2378
Change-Id: I1f4a7adfdd35cf01faa943d33d4d8093c0f3ceb9
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Mon, 23 Mar 2020 23:49:37 +0000 (19:49 -0400)]
Point to released artifacts
There are many other changes for when drools-applications gets
released.
Issue-ID: POLICY-2378
Change-Id: If652a44d9486563f4f5ceb01f58e71d15e5fa75c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
jhh [Wed, 18 Mar 2020 15:53:54 +0000 (10:53 -0500)]
renew policy certs till 03/17/2021
Issue-ID: POLICY-2402
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0c1c7be414b81cb423ee6d9b3781bb75ec927c6c
Pamela Dragosh [Tue, 3 Mar 2020 14:33:02 +0000 (09:33 -0500)]
use policy/parent awaitility
use common version
Issue-ID: POLICY-2381
Change-Id: I2463363beda83aa7ffb584a1f2b487389320c549
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Sun, 1 Mar 2020 21:58:33 +0000 (16:58 -0500)]
Point to docker 2.0.1
docker is released
Issue-ID: POLICY-2378
Change-Id: Ide4c8898c21a4ddb7b845f15f66b7ff2b9ac3fb7
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Mon, 24 Feb 2020 15:04:47 +0000 (15:04 +0000)]
Merge "Migrate policy-engine docs"
Peyton Puckett [Fri, 21 Feb 2020 16:25:28 +0000 (10:25 -0600)]
Add pom.xml dependencies and exclusions needed for policy-engine gui
Update powermockignore annotation to fix junit failure
Issue-ID: POLICY-1590
Change-Id: Iadd0855565c05d02af034a5ad02ea7b8e386fadc
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
Pamela Dragosh [Fri, 21 Feb 2020 17:48:49 +0000 (12:48 -0500)]
Fix policycreation test
This test was only performing code coverage, it should have revealed
that IllegalArgument exceptions were incorrect.
Fixed bug in savePolicy when an exception being thrown has a null
message.
Added warning and error messages for debugging in the future.
Issue-ID: POLICY-1590
Change-Id: Ie32a73adbaf944f96e411a2c612cd8293382911c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Peyton Puckett [Tue, 18 Feb 2020 21:59:17 +0000 (15:59 -0600)]
Update policy-engine to fix failing jUnit tests after jdk11 upgrade
Issue-ID: POLICY-1590
Change-Id: I9f5a05112d943d7f3b6b0e807bf6ae4f2b993e55
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
Signed-off-by: Peyton Puckett <pp5762@att.com>
Jim Hahn [Tue, 18 Feb 2020 16:50:09 +0000 (16:50 +0000)]
Merge "Allow storing database password in environment variables"
Dominik Mizyn [Tue, 18 Feb 2020 08:57:40 +0000 (09:57 +0100)]
Allow storing database password in environment variables
This patch allows to store and get database password from
environment variables. This is needed if we want to send those
variables by helm secrets.
Issue-ID: OOM-2287
Change-Id: I041c3e4dd3b9042b2b6c2b34afc22867bab81b22
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
jhh [Mon, 17 Feb 2020 01:20:15 +0000 (19:20 -0600)]
Remove deletion of POLICY_HOME/etc/ssl
To match work from:
https://gerrit.onap.org/r/#/c/policy/docker/+/101758/
Issue-ID: POLICY-2181
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I1f83508d7edd97337ee746cc09aff94bee684817
Jessica Wagantall [Thu, 6 Feb 2020 22:53:30 +0000 (14:53 -0800)]
Migrate policy-engine docs
Merging this will create
https://onap-policy-engine.readthedocs.io
This build will run in parallel
to the current docs generation method
until we are ready to cut over.
Issue-ID: CIMAN-364
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: I3582e1840308baf26778cbbbecfe53ad388ed2a6
Bruno Sakoto [Fri, 7 Feb 2020 19:31:35 +0000 (14:31 -0500)]
Review intellij git ignored files
Issue-ID: POLICY-2359
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Iee0846d913798e33d5f745c2d4fc7c3a89304cd0
Jim Hahn [Tue, 4 Feb 2020 21:36:37 +0000 (16:36 -0500)]
Include jaxb in runtime
The jaxb implementation was included with scope=test. As a result,
it was not found when trying to run the engine within docker.
Issue-ID: POLICY-1590
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I2e6e23929448b7c27bf6f6a1d2ea40c0c1cace97
Pamela Dragosh [Tue, 4 Feb 2020 11:29:29 +0000 (11:29 +0000)]
Merge "policy/engine jdk11 junit and compilation error fixes"
HOCKLA [Thu, 23 Jan 2020 21:28:35 +0000 (15:28 -0600)]
policy/engine jdk11 junit and compilation error fixes
Issue-ID: POLICY-1590
Change-Id: I0bbc6f7310705c20924812efc5be2b0f91cf71a2
Signed-off-by: HOCKLA <ah999m@att.com>
Bilal A [Tue, 28 Jan 2020 21:15:46 +0000 (21:15 +0000)]
Updating docker image with new tools.
Issue-ID: POLICY-2325
Signed-off-by: Bilal A <bilal@research.att.com>
Change-Id: I352038ab7b3bfcf5a25d6d50b90c55b2536bcda9
Pamela Dragosh [Tue, 21 Jan 2020 19:17:15 +0000 (19:17 +0000)]
Merge "policy/engine jdk11 upgrades"
HOCKLA [Fri, 17 Jan 2020 22:20:01 +0000 (16:20 -0600)]
policy/engine jdk11 upgrades
Issue-ID: POLICY-1590
Change-Id: I4da8324a065ac9babe16368e69b76a4cbe9504ef
Signed-off-by: HOCKLA <ah999m@att.com>
Pamela Dragosh [Mon, 20 Jan 2020 12:55:10 +0000 (07:55 -0500)]
First update sonar
This is still pointing to old oparent, so only making the
minor change. Note, I could not test this locally because
the JUnits fail.
Once Ali's review is merged I will make the final cleanup.
Issue-ID: POLICY-2321
Change-Id: Idcd7633fc2fdbeaede8b24aab5dcd5437632da2f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
HOCKLA [Fri, 10 Jan 2020 22:01:30 +0000 (16:01 -0600)]
Point to policy/models release version
Issue-ID: POLICY-1592
Change-Id: Ic8f5f5829b757578d0d5b32bf273cc9799faef71
Signed-off-by: HOCKLA <ah999m@att.com>
Peyton Puckett [Fri, 3 Jan 2020 23:35:50 +0000 (17:35 -0600)]
Add and modify jUnits for code coverage (continue admin)
Issue-ID: POLICY-2133
Change-Id: I4848e18c3ff638d6b659464b7c9293228dcc36d5
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
Peyton Puckett [Tue, 17 Dec 2019 16:23:14 +0000 (10:23 -0600)]
Add and modify jUnits for code coverage (continue components, admin)
Issue-ID: POLICY-2133
Change-Id: I6b308ad8e9dcd54a260312bbee8deeaec3af2cf1
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
Peyton Puckett [Tue, 10 Dec 2019 17:45:44 +0000 (11:45 -0600)]
Add and modify jUnits for code coverage (components)
Issue-ID: POLICY-2133
Change-Id: I0ded200797c112c1da4e50bd0721bb87c2d124ac
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
Pamela Dragosh [Fri, 6 Dec 2019 21:55:24 +0000 (21:55 +0000)]
Merge "Add and Modify jUnits for code coverage (model, admin)"
HOCKLA [Thu, 5 Dec 2019 20:20:46 +0000 (14:20 -0600)]
Point to release versions of policy/parent and policy/common
Issue-ID: POLICY-1583
Change-Id: I6d7ec1ccf00110d0f84998c05492b6d59a12cdf1
Signed-off-by: HOCKLA <ah999m@att.com>
Peyton Puckett [Wed, 4 Dec 2019 21:55:30 +0000 (15:55 -0600)]
Add and Modify jUnits for code coverage (model, admin)
Add tests to model after viewing sonarcloud coverage
Start adding tests for admin
Issue-ID: POLICY-2133
Change-Id: I690c612357fe3390c7904c6ba4c941dcefcc7640
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
Pamela Dragosh [Thu, 5 Dec 2019 16:20:08 +0000 (16:20 +0000)]
Merge "Add and Modify JUnits for Code Coverage (components, controller)"
Peyton Puckett [Tue, 26 Nov 2019 17:57:57 +0000 (11:57 -0600)]
Add and Modify JUnits for Code Coverage (components, controller)
Issue-ID: POLICY-2133
Change-Id: I9d8cecc7e9b1c280a0296a4e160f42e41264c1b6
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
Pamela Dragosh [Wed, 4 Dec 2019 00:38:43 +0000 (00:38 +0000)]
Merge "Couple of JUnit additions for PAP-REST"
Jorge Hernandez [Tue, 3 Dec 2019 15:23:37 +0000 (15:23 +0000)]
Merge "Add and Modify JUnits for Code Coverage (daoImpl)"
Peyton Puckett [Mon, 25 Nov 2019 17:44:19 +0000 (11:44 -0600)]
Add and Modify JUnits for Code Coverage (daoImpl)
Issue-ID: POLICY-2133
Change-Id: I1b16aa63394da0715dc50b5f0ac037b64d020a41
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
liamfallon [Sun, 1 Dec 2019 21:44:47 +0000 (21:44 +0000)]
Unit/SONAR/Checkstyle in ONAP-REST
Util package of ONAP-REST, with JUnit added and
SONAR/Checkstyle issues addressed. Coverage increased from 51% to 73% in
large PolicyValidation class.
Issue-ID: POLICY-2131
Change-Id: Iffa90e2dfa155d3e9cac114032fb9ca0df2cbab0
Signed-off-by: liamfallon <liam.fallon@est.tech>
Liam Fallon [Sun, 1 Dec 2019 11:33:44 +0000 (11:33 +0000)]
Merge "Unit/SONAR/Checkstyle in ONAP-REST"
Jorge Hernandez [Sat, 30 Nov 2019 17:58:01 +0000 (17:58 +0000)]
Merge "Add and Modify JUnits for Code Coverage"
liamfallon [Thu, 28 Nov 2019 16:28:27 +0000 (16:28 +0000)]
Unit/SONAR/Checkstyle in ONAP-REST
Util package of ONAP-REST, with JUnit added and
SONAR/Checkstyle issues addressed. Coverage increased from 31% to 51% in
large PolicyValidation class.
Issue-ID: POLICY-2131
Change-Id: Ic88dd0d47bc9c09ed294ea62c37c683297b590c0
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 27 Nov 2019 11:10:04 +0000 (11:10 +0000)]
Unit/SONAR/Checkstyle in ONAP-REST
Util package of ONAP-REST, with JUnit added and
SONAR/Checkstyle issues addressed. Coverage increased from 18% to 31% in
large PolicyValidation class.
Issue-ID: POLICY-2131
Change-Id: Ie059db312918021683fe27cc2aaeed86b04046f2
Signed-off-by: liamfallon <liam.fallon@est.tech>
bobbymander [Mon, 25 Nov 2019 19:56:57 +0000 (14:56 -0500)]
Couple of JUnit additions for PAP-REST
Issue-ID: POLICY-2130
Change-Id: Id7252df4a244e579d599a5d2631c60ddb9ccfab3
Signed-off-by: bobbymander <bobby.mander@att.com>
Peyton Puckett [Wed, 20 Nov 2019 20:46:28 +0000 (14:46 -0600)]
Add and Modify JUnits for Code Coverage
Modify license
Issue-ID: POLICY-2133
Change-Id: I1b58fcc1636a9bf8d45595480bc5e027d93bb277
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
Pamela Dragosh [Thu, 21 Nov 2019 15:50:07 +0000 (10:50 -0500)]
Sonar cleanup and remove duplicate code
Removed some duplicate code and cleaned up some sonar issues.
Issue-ID: POLICY-2242
Change-Id: I374c263516d87bda66442ed65cae9cc056e68e56
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Thu, 21 Nov 2019 12:56:04 +0000 (12:56 +0000)]
Merge "Add ONAP-XACML StdEngine tests"
Pamela Dragosh [Tue, 19 Nov 2019 19:54:11 +0000 (14:54 -0500)]
Add ONAP-XACML StdEngine tests
Re-worked some JUnits to ensure they really are testing correctly.
added coverage to the factory and std engine for easy exception
conditions.
Issue-ID: POLICY-2242
Change-Id: Iff6a390bff871fea2836336b77567f4a35720dfd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 20 Nov 2019 12:26:08 +0000 (12:26 +0000)]
Merge "Build tar.gz without requiring docker image build"
Ram Krishna Verma [Wed, 20 Nov 2019 09:54:59 +0000 (09:54 +0000)]
Merge "Unit/SONAR/Checkstyle in ONAP-REST"
jhh [Tue, 19 Nov 2019 22:50:31 +0000 (16:50 -0600)]
Build tar.gz without requiring docker image build
This allows the tar.gz to be released by LF jobs.
Issue-ID: POLICY-2250
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I7a6a2fa109328f9e479af019198877fd6421ede5
liamfallon [Tue, 19 Nov 2019 12:17:44 +0000 (12:17 +0000)]
Unit/SONAR/Checkstyle in ONAP-REST
Refactor of the PolicyValidationRequestWrapper class to make it
testable and unit tests for the class.
Issue-ID: POLICY-2131
Change-Id: Ie6b0b20aafd6a823fa778bb8070d057f27b28603
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jorge Hernandez [Tue, 19 Nov 2019 16:37:11 +0000 (16:37 +0000)]
Merge "Format ONAP-XACML and add JUnit"
Pamela Dragosh [Tue, 12 Nov 2019 19:48:30 +0000 (14:48 -0500)]
Format ONAP-XACML and add JUnit
Formatting and sonar issues.
Cleaned up JUnit tests.
Added more JUnit test coverage.
Issue-ID: POLICY-2242
Change-Id: Ife0921971c6eb97de2a64b2f303cd16f992b4bd3
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
liamfallon [Mon, 18 Nov 2019 12:36:28 +0000 (12:36 +0000)]
Unit/SONAR/Checkstyle in ONAP-REST
Util package of ONAP-REST, with JUnit added and
SONAR/Checkstyle issues addressed. In cases where a class name change
caused an update in another package, the license header on files for
those knock on changes are not updated.
Issue-ID: POLICY-2131
Change-Id: Ic134408efe76b9838f5607a07f1735d12bd41032
Signed-off-by: liamfallon <liam.fallon@est.tech>
Liam Fallon [Mon, 18 Nov 2019 10:24:15 +0000 (10:24 +0000)]
Merge "Unit/SONAR/Checkstyle in ONAP-REST"
bobbymander [Fri, 15 Nov 2019 18:59:18 +0000 (13:59 -0500)]
More JUnit additions for PAP-REST
Issue-ID: POLICY-2130
Change-Id: Ia111e5fd6dfba1e03f157ff95f91ef65df293043
Signed-off-by: bobbymander <bobby.mander@att.com>
Jorge Hernandez [Fri, 15 Nov 2019 15:37:59 +0000 (15:37 +0000)]
Merge "Cleanup drl files in policy/engine test modules"
liamfallon [Fri, 15 Nov 2019 13:35:42 +0000 (13:35 +0000)]
Unit/SONAR/Checkstyle in ONAP-REST
Fifth and final batch of JPA pojos (Q-Z), with JUnit added and
SONAR/Checkstyle issues addressed. In cases where a class name change
caused an update in another package, the license header on files for
those knock on changes are not updated.
Issue-ID: POLICY-2131
Change-Id: I1cc536a5b8a0cd3c6beff068dd72381f7ae10d12
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Fri, 15 Nov 2019 13:33:39 +0000 (13:33 +0000)]
Merge "Unit/SONAR/Checkstyle in ONAP-REST"
liamfallon [Wed, 13 Nov 2019 14:08:14 +0000 (14:08 +0000)]
Unit/SONAR/Checkstyle in ONAP-REST
Fourth batch of JPA pojos (N-P), with JUnit added and SONAR/Checkstyle
issues addressed. In cases where a class name change caused an update in
another package, the license header on files for those knock on changes
are not updated.
Issue-ID: POLICY-2131
Change-Id: I9319b514b5c19e6837c34566dde770673d16bca3
Signed-off-by: liamfallon <liam.fallon@est.tech>
Rashmi Pujar [Fri, 8 Nov 2019 20:59:08 +0000 (15:59 -0500)]
Cleanup drl files in policy/engine test modules
Issue-ID: POLICY-1895
Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
Change-Id: Ice15aadbafd999b20594c3b6488e115063c985ce
bobbymander [Wed, 13 Nov 2019 15:30:56 +0000 (10:30 -0500)]
Few JUnit additions for PAP-REST
Issue-ID: POLICY-2130
Change-Id: Ie9972bc0014def93acf04c4a2386585fb4accdef
Signed-off-by: bobbymander <bobby.mander@att.com>
liamfallon [Fri, 8 Nov 2019 16:11:50 +0000 (16:11 +0000)]
JUnit/SONAR/Checkstyle in ONAP-REST
Third batch of JPA pojos (E-M), with JUnit added and SONAR/Checkstyle
issues addressed. In cases where a class name change caused an update in
another package, the license header on files for those knock on changes
are not updated.
Issue-ID: POLICY-2131
Change-Id: I4fee1e9fb9c8a69dd6f2f15d3e3a8844473b857b
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jim Hahn [Mon, 11 Nov 2019 19:32:15 +0000 (14:32 -0500)]
Fix table names for CSIT issue
Changed the table name in multiple files.
Backed out some changes per review comments.
Change-Id: I31f75ebdef4aa70aff841c8a52185f6ab8a4e329
Issue-ID: POLICY-2131
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Fri, 8 Nov 2019 19:54:46 +0000 (14:54 -0500)]
Do not hardcode io.fabric8 plugin
policy/parent now has this plugin defined
Issue-ID: POLICY-2222
Change-Id: I855c7b2bbd65e93695f7bfe5242be6f474f416fc
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Fri, 8 Nov 2019 12:53:20 +0000 (12:53 +0000)]
Merge "JUnit/SONAR/Checkstyle in ONAP-REST"
Jim Hahn [Thu, 7 Nov 2019 14:22:11 +0000 (09:22 -0500)]
Turn on lombok code coverage for policy-engine
If this backfires, we can turn it back off again.
Issue-ID: POLICY-2131
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I7375bf4a3fa63a7791c30b3a73813bff1a69055e
liamfallon [Thu, 7 Nov 2019 10:38:07 +0000 (10:38 +0000)]
JUnit/SONAR/Checkstyle in ONAP-REST
Second batch of JPA pojos (B-D), with JUnit added and SONAR/Checkstyle
issues addressed. In cases where a class name change caused an update in
another package, the license header on files for those knock on changes
are not updated.
Issue-ID: POLICY-2131
Change-Id: I9466f27ffa606001209ed978be592ae95d1b32c4
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 6 Nov 2019 12:43:25 +0000 (12:43 +0000)]
JUnit/SONAR/Checkstyle in ONAP-REST
First batch of JPA pojos Lombok'd and some missing coverage updated
I'll be interested to see how Lomboking code shows up in SONAR, I have
not added much JUnit here but I have reduced a good bit of source code,
let's see what happens.
Issue-ID: POLICY-2131
Change-Id: I8f270ef57282f63821c1eb94dd6b50f8ae541028
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Tue, 5 Nov 2019 16:19:17 +0000 (16:19 +0000)]
Merge "More JUnit additions for PAP-REST"
bobbymander [Thu, 31 Oct 2019 19:08:36 +0000 (15:08 -0400)]
More JUnit additions for PAP-REST
Issue-ID: POLICY-2130
Change-Id: Ia64bdbb377d26ba209b2d3fc51bc95f5769a7729
Signed-off-by: bobbymander <bobby.mander@att.com>
Pamela Dragosh [Tue, 5 Nov 2019 12:22:44 +0000 (12:22 +0000)]
Merge "Fixed Sonar issues for Console Logs"
liamfallon [Mon, 4 Nov 2019 17:20:37 +0000 (17:20 +0000)]
JUnit/SONAR/Checkstyle in ONAP-REST
Cleanup of the dao-impl package in ONAP-REST
All enclosing try/catch blocks removed.
Issue-ID: POLICY-2131
Change-Id: Iec73fc5a85b891a00ba8c029e9904051c51284c2
Signed-off-by: liamfallon <liam.fallon@est.tech>
uj426b [Fri, 1 Nov 2019 18:42:28 +0000 (14:42 -0400)]
Fixed Sonar issues for Console Logs
Issue-ID: POLICY-2153
Change-Id: Id21a9dd4910ff0c831e49a1539f130ade1779577
Signed-off-by: utkarshJ <uj426b@att.com>
liamfallon [Fri, 1 Nov 2019 12:09:52 +0000 (12:09 +0000)]
Add common Jersey version
Add a common version of Jersey for all Policy Framework components.
Issue-ID: POLICY-2209
Change-Id: If376b0d1c1cb11c20a176c4ea9a5b674cb8c66da
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Thu, 31 Oct 2019 16:39:37 +0000 (16:39 +0000)]
ONAP-REST DAO Sonar/Checkstyle clean and knock-on
Clean up the ONAP-REST DAO package and also deal with knock-on chages in
other packages.
Issue-ID: POLICY-2131
Change-Id: I381d514d37ffbddb7a91b8f8a018c7354fc437b3
Signed-off-by: liamfallon <liam.fallon@est.tech>
jhh [Thu, 31 Oct 2019 18:52:31 +0000 (13:52 -0500)]
Upgrade to drools 7.28.0.Final
Issue-ID: POLICY-1407
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia934906cb9f5b7a3f8aac59bb204d9426e994e1f
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Pamela Dragosh [Thu, 31 Oct 2019 15:49:29 +0000 (15:49 +0000)]
Merge "Fixed SonarIssues Alerts to Bootstrap Notification"
Jorge Hernandez [Thu, 31 Oct 2019 15:12:34 +0000 (15:12 +0000)]
Merge "Fix unit test failure in ONAP-PDP-REST"
uj426b [Tue, 29 Oct 2019 21:02:59 +0000 (17:02 -0400)]
Fixed SonarIssues Alerts to Bootstrap Notification
Issue-ID: POLICY-2153
Change-Id: I0778ac8a35cc4677e86f93319818d0980fec365b
Signed-off-by: utkarshJ <uj426b@att.com>
bobbymander [Tue, 29 Oct 2019 18:25:50 +0000 (14:25 -0400)]
JUnit additions for PAP-REST, checkstyle fixes
Issue-ID: POLICY-2130
Change-Id: Ia9fb294090a27ee86321249bc6b1cbdf20f33d06
Signed-off-by: bobbymander <bobby.mander@att.com>
liamfallon [Tue, 29 Oct 2019 17:46:54 +0000 (17:46 +0000)]
Fix unit test failure in ONAP-PDP-REST
Unit test parameters were cleared by earlier tests, test setup changed
to initiate paramters required by the test.
Issue-ID: POLICY-2205
Change-Id: Ia460226ae5fb6e0c42ba9840bd4fe3952dbd1a13
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 29 Oct 2019 15:07:40 +0000 (15:07 +0000)]
Fix knock on tabs/SONAR/Checkstyle issues
Changes in the last ONAP-REST review caused knock on changes in
ONAP-PDP-REST. Those changes identified issues in two classes with tabs.
While changing the tabs to spaces, some other easy to fix
SONAR/Checkstyle issues were addressed.
Issue-ID: POLICY-2132
Change-Id: I4e32089ada7b5095da0751993458cf7173cef064
Signed-off-by: liamfallon <liam.fallon@est.tech>
Liam Fallon [Tue, 29 Oct 2019 09:25:54 +0000 (09:25 +0000)]
Merge "CHeckstyle and JUnit for base package in ONAP-REST"
bobbymander [Tue, 22 Oct 2019 14:40:09 +0000 (10:40 -0400)]
junit addition and update for PAP.
Issue-ID: POLICY-2130
Change-Id: I33f25588c34fe72b12855a2486ba892afc04693c
Signed-off-by: bobbymander <bobby.mander@att.com>
liamfallon [Fri, 25 Oct 2019 01:33:45 +0000 (21:33 -0400)]
CHeckstyle and JUnit for base package in ONAP-REST
Added unit tests and fixed checkstyle and SONAR issues in the base
package of ONAPE-REST
There was a lot of knock-on automatic changes done by Eclipse when I
renamed the class XACMLRestProperties to XacmlRestProperties so ignore
the changes in all but the ONAP-REST package. I also didn't update the
licenses on files on those classes because the changes were automatic.
Issue-ID: POLICY-2131
Change-Id: I28823c844b5192f8d56de76a727996b13e7ea4a6
Signed-off-by: liamfallon <liam.fallon@est.tech>
Liam Fallon [Thu, 24 Oct 2019 20:37:43 +0000 (20:37 +0000)]
Merge "Fixed the Policy GUI Editor tab right click issue."
uj426b [Wed, 23 Oct 2019 04:33:06 +0000 (00:33 -0400)]
Fixed the Policy GUI Editor tab right click issue.
Issue-ID: POLICY-2159
Change-Id: Id659c56167613beb1dd28bcfd71d478209091647
Signed-off-by: utkarshJ <uj426b@att.com>
Code Review / policy / engine.git / log