policy/engine.git
5 years agotutorial_cl, vCPE documentation 54/70854/1
Saryu Shah [Fri, 19 Oct 2018 23:06:49 +0000 (23:06 +0000)]
tutorial_cl, vCPE documentation

tutorial_cl, vCPE documentation
-------------------------------------------------------------

Change-Id: Ibed905fd8f8a27af5e7bae2024b15f5c02fff390
Issue-ID: POLICY-1169
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoMerge "Documentation: Eclipse, vCPE, VoLTE, ModTemplate"
Jorge Hernandez [Thu, 18 Oct 2018 16:09:12 +0000 (16:09 +0000)]
Merge "Documentation: Eclipse, vCPE, VoLTE, ModTemplate"

5 years agoMerge "Updated vDNS documentation"
Jorge Hernandez [Thu, 18 Oct 2018 16:08:32 +0000 (16:08 +0000)]
Merge "Updated vDNS documentation"

5 years agoDocumentation: Eclipse, vCPE, VoLTE, ModTemplate 98/70698/1
Saryu Shah [Thu, 18 Oct 2018 01:19:03 +0000 (01:19 +0000)]
Documentation: Eclipse, vCPE, VoLTE, ModTemplate

Documentation: Eclipse, vCPE, VoLTE, ModTemplate
-------------------------------------------------------------

Issue-ID: POLICY-1169

Change-Id: Id501913db5be23f97e5ea5a635e27511546a042a
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoFix exceptions related to invalid db schema 79/70679/1
Michael Mokry [Wed, 17 Oct 2018 18:54:24 +0000 (13:54 -0500)]
Fix exceptions related to invalid db schema

Modified db upgrade script to alter systemlogdb table to allow null values for "remote" column.

Change-Id: Ib1bba59a38084bef8f89245d3725d18a02b303dc
Issue-ID: POLICY-1204
Signed-off-by: Michael Mokry <michael.mokry@att.com>
5 years agoXACML PDP Performance Test 61/70661/2
Michael Mokry [Wed, 17 Oct 2018 14:51:06 +0000 (09:51 -0500)]
XACML PDP Performance Test

Added TestSuite module and performance test plan and stability test plan
that I received from Michael Morris

Added License headers to files per Jim's comment

Change-Id: I9d7a2740218a946ea031fdeae57dcb58d4ddd886
Issue-ID: POLICY-887
Signed-off-by: Michael Mokry <michael.mokry@att.com>
5 years agoUpdated vDNS documentation 14/70614/1
Saryu Shah [Wed, 17 Oct 2018 00:27:13 +0000 (00:27 +0000)]
Updated vDNS documentation

Updated vDNS documentation
-------------------------------------------------------------

Change-Id: I763996f48ae3665dddd8836994f77bed283806ee
Issue-ID: POLICY-1169
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoMerge "Policy Doc: Removed Beijing Controller"
Pamela Dragosh [Thu, 11 Oct 2018 23:46:56 +0000 (23:46 +0000)]
Merge "Policy Doc: Removed Beijing Controller"

5 years agoMerge "Updated the keystore to include pdp wildcard."
Pamela Dragosh [Thu, 11 Oct 2018 23:46:13 +0000 (23:46 +0000)]
Merge "Updated the keystore to include pdp wildcard."

5 years agoUpdated the keystore to include pdp wildcard. 20/70320/1
Jorge Hernandez [Thu, 11 Oct 2018 22:40:14 +0000 (17:40 -0500)]
Updated the keystore to include pdp wildcard.

This allows to talk directly to OOM PDP-X pods
without going through the service.

Change-Id: I09bd5253a79142f6566806b97be4bb6c223826f4
Issue-ID: POLICY-1198
Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
5 years agoPolicy Doc: Removed Beijing Controller 17/70317/1
Saryu Shah [Thu, 11 Oct 2018 21:58:35 +0000 (21:58 +0000)]
Policy Doc: Removed Beijing Controller

Removed "Installation of Beijing Controller and Policies" from index
-------------------------------------------------------------

Issue-ID: POLICY-1196  (remove Beijing controller doc)

Change-Id: I7531e3a9074792542799fdc92179cca41592875f
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoUpdated rst doc for clsimulation.rst 13/70313/1
Saryu Shah [Thu, 11 Oct 2018 21:12:30 +0000 (21:12 +0000)]
Updated rst doc for clsimulation.rst

A short description eg. Updated policy documentation
-------------------------------------------------------------

Change-Id: Ibc2426f9b6befc2c750290f2685427a47318e012
Issue-ID: POLICY-1169
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoRegenerate policy keystore 20/70120/1 1.3.0
Jorge Hernandez [Wed, 10 Oct 2018 00:55:36 +0000 (19:55 -0500)]
Regenerate policy keystore

The keystore has been regenerated using the latest tooling
from AAF.

Previous versions seem to add a bogus " fqdn" which makes
the particular policy.api.simpledemo.onap.org invalid.
The latest version does not append it.

Change-Id: I96e4d272e8f0ab6eb84a12384645bf9a49dbbd09
Issue-ID: POLICY-1193
Signed-off-by: Jorge Hernandez <jh1730@att.com>
5 years agoModify portal properties in PE 91/70091/2
Michael Mokry [Tue, 9 Oct 2018 16:38:07 +0000 (11:38 -0500)]
Modify portal properties in PE

Modified the portal.properties with new role_access_centralized
property.

Modified the conf file with updated values for the ONAP redirect and
REST URL properties

Made changes for comments

Change-Id: Id2624cbb440ea5830520c5e82436d112989b62c4
Issue-ID: POLICY-1192
Signed-off-by: Michael Mokry <michael.mokry@att.com>
5 years agoUpdate local dependency json 87/70087/1
Pamela Dragosh [Tue, 9 Oct 2018 16:27:12 +0000 (12:27 -0400)]
Update local dependency json

For local testing these need to be added.

Issue-ID: POLICY-1190
Change-Id: I2827aebe9faf04ff38e0781376b4553d34c88930
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoInitial Draft of Release Notes 52/69952/2
Saryu Shah [Sat, 6 Oct 2018 22:28:03 +0000 (22:28 +0000)]
Initial Draft of Release Notes

Initial Draft of Release Notes
-------------------------------------------------------------

Change-Id: I76d9c4cdd4cef570a4e4bf6fc149cf28dd447297
Issue-ID: POLICY-1162
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoFix sonar bug 26/69926/3
Pamela Dragosh [Fri, 5 Oct 2018 16:16:24 +0000 (12:16 -0400)]
Fix sonar bug

Somehow this creeped into sonar. Not sure why it wasn't
flagged before.

Fixed tabs and indentation.

Removed unnecessary close() statement for a try-with-
resources statement.

Issue-ID: POLICY-1186
Change-Id: I5499279fe7adf642a7f7dc8a53c1a27c24a0dcb3
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoAdd SDNC actor to dependency 19/69919/1
Pamela Dragosh [Fri, 5 Oct 2018 15:04:32 +0000 (11:04 -0400)]
Add SDNC actor to dependency

So BRMS gateway can add this dependency during runtime.

Issue-ID: POLICY-1183
Change-Id: I82127fca5e0d644463e82d543b6331dde8c32042
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoFixed issue with springframework dependencies 61/69861/1
Michael Mokry [Thu, 4 Oct 2018 20:50:05 +0000 (15:50 -0500)]
Fixed issue with springframework dependencies

Added exclusions to epsdk dependencies and added dependencies for
springframework jars that were needed to the ONAP-SDK-APP

Change-Id: I037ffa76d3d32b2db5ea2c439f40e8a86e1665f5
Issue-ID: POLICY-1154
Signed-off-by: Michael Mokry <michael.mokry@att.com>
5 years agoRecreate latest keystore. 73/69673/1
Jorge Hernandez [Tue, 2 Oct 2018 15:06:12 +0000 (10:06 -0500)]
Recreate latest keystore.

Some changes have been made since the first set of
stores were generated from the cert manager tooling
in the windriver test instance used for this purpose.

Change-Id: I976333df7e020bda76c5cbdc9c0be752e5a88778
Issue-ID: POLICY-1156
Signed-off-by: Jorge Hernandez <jh1730@att.com>
5 years agoAdd Sdnr Actor code 99/69399/1
Pamela Dragosh [Thu, 27 Sep 2018 19:03:03 +0000 (15:03 -0400)]
Add Sdnr Actor code

These need to be defined for BRMS Gateway to re-created the
artifacts.

Issue-ID: POLICY-1155
Change-Id: I424be9976fa129a42e0020870af01ba30e0c0d47
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoCADI AAF changes for policy/engine 95/68495/4
Michael Mokry [Fri, 21 Sep 2018 20:56:43 +0000 (15:56 -0500)]
CADI AAF changes for policy/engine

Added cadi properties and modified policy aaf client code.

Fixed issue with namespace and modified code to reverse it for
structuring the username sent in AAF API call

Added properties for keystore and keystore password after getting error
response from AAF when setting up the connection to AAF

Missed a fix for one of Jorge's comments in last patch, here it is.

Change-Id: Ic164ade8aa34da95a560c1592656e0caf990a595
Issue-ID: POLICY-913
Signed-off-by: Michael Mokry <mm117s@att.com>
5 years agoBRMSGW HTTPS support for DMaaP/UEB interfaces 03/68203/1
Michael Mokry [Thu, 20 Sep 2018 16:41:09 +0000 (11:41 -0500)]
BRMSGW HTTPS support for DMaaP/UEB interfaces

Modified BrmsPush UEB interface implementation to use HTTPS

Change-Id: Id8ae68f23ee371142da3f9d8aa0a2b2e7988ff36
Issue-ID: POLICY-942
Signed-off-by: Michael Mokry <mm117s@att.com>
5 years agoUpgrade javax.mail to 1.6.2 77/68077/1
Pamela Dragosh [Thu, 20 Sep 2018 11:58:32 +0000 (07:58 -0400)]
Upgrade javax.mail to 1.6.2

The former version was frozen in github. It looks like they
moved to another website and the changes were transparent codewise.

So let's see what the CLM results are for this. I believe this
does remove the security vulnerability.

Issue-ID: POLICY-1127
Change-Id: Ib659eddc2808131c8dded3782fcf1d382060fc29
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoFixes for oparent upgrade 19/67519/1
Pamela Dragosh [Tue, 18 Sep 2018 23:22:30 +0000 (19:22 -0400)]
Fixes for oparent upgrade

Clean up mariadb so that it is consistent, allow jetty to be
defined by oparent, and fixes to fully support google guava
upgrade.

Issue-ID: POLICY-1126
Change-Id: Ic0c2fba5f6f5f1a41e53770b95861606a5b4bbe6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoMerge "Fixing issue with validation errors"
Pamela Dragosh [Tue, 18 Sep 2018 22:30:11 +0000 (22:30 +0000)]
Merge "Fixing issue with validation errors"

5 years agoMerge "Remove override of parent aaf version"
Liam Fallon [Tue, 18 Sep 2018 19:19:39 +0000 (19:19 +0000)]
Merge "Remove override of parent aaf version"

5 years agoMerge "Fix Policy GUI Template Issue"
Pamela Dragosh [Tue, 18 Sep 2018 18:55:51 +0000 (18:55 +0000)]
Merge "Fix Policy GUI Template Issue"

5 years agoFixing issue with validation errors 77/67377/3
Michael Mokry [Tue, 18 Sep 2018 16:27:58 +0000 (11:27 -0500)]
Fixing issue with validation errors

I found this change internally that was committed to fix an issue with validating required
fields when creating some Config MS policies.  This should fix the CSIT tests
and the pre-loaded policies for SDNC Naming policies

Change-Id: I04406b8efbef173a6ab967a32cfbd86e17b7c59e
Issue-ID: POLICY-983
Signed-off-by: Michael Mokry <mm117s@att.com>
5 years agoFix Policy GUI Template Issue 05/67405/1
Wang, Frank(gw1218) [Tue, 18 Sep 2018 16:24:49 +0000 (11:24 -0500)]
Fix Policy GUI Template Issue

Fix the a bug in this html file by adding msPolicyloader

Issue-ID: POLICY-1118
Change-Id: I7a45b232ed0680f1c8233b8ed71fdde685fbb9c9
Signed-off-by: Wang, Frank(gw1218) <gw1218@att.com>
5 years agoRemove override of parent aaf version 13/67313/2
Pamela Dragosh [Tue, 18 Sep 2018 13:55:30 +0000 (09:55 -0400)]
Remove override of parent aaf version

policy/parent now declares the aaf dependency so consistency
is maintained in all the repositories. Removing the version
declaration in order to pull in the declared version.

The constructor changes to add a namespace. A null value is
still possible to be used. If we are given a namespace then we
will have to add that in. Preferrably via a properties file.

I also noticed there is a hard-coded URL in here in the
setupAAF() method on line 212. That should be moved to a property
file.

Issue-ID: POLICY-1119
Change-Id: I97dcd7d669d3d05db7c6597be6f3038183fa4e17
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoMerge "Added validation on matching required fields"
Jorge Hernandez [Tue, 18 Sep 2018 13:39:57 +0000 (13:39 +0000)]
Merge "Added validation on matching required fields"

5 years agoMerge "AAF integration in Policy SDK"
Pamela Dragosh [Tue, 18 Sep 2018 00:48:59 +0000 (00:48 +0000)]
Merge "AAF integration in Policy SDK"

5 years agoAdded validation on matching required fields 03/66503/7
Wang,Frank(gw1218) [Fri, 14 Sep 2018 02:09:47 +0000 (21:09 -0500)]
Added validation on matching required fields

Import policy should report to end users if there are missing required
matching fields in policy template.

Issue-ID: POLICY-1117
Change-Id: Iac4485259b73784e641f42a22d5a12c524f4b8e2
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
Signed-off-by: Wang, Frank(gw1218) <gw1218@att.com>
5 years agoAAF integration in Policy SDK 11/65911/3
rb7147 [Tue, 11 Sep 2018 18:32:39 +0000 (14:32 -0400)]
AAF integration in Policy SDK

Upgraded SDK version.
Added SQL script with encrypt key.
Added a function to save role on reading from session in
PolicyController.java
Addressed Check Style warnings in PolicyController.java

Issue-ID: POLICY-1088
Change-Id: I446b6c1a0db2a989ad3f4e982e5cdba845f81045
Signed-off-by: rb7147 <rb7147@att.com>
5 years agoUpgrade elasticsearch v6.3.0 93/66693/3
Pamela Dragosh [Fri, 14 Sep 2018 15:23:32 +0000 (11:23 -0400)]
Upgrade elasticsearch v6.3.0

Resolves a security issue around information disclosure. The
recommendation is to upgrade to this version for the fix.

Issue-ID: POLICY-1063
Change-Id: Idebb19d2c530b716a25aa91832c053e6b2d0ffce
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoMerge "Upgrade commons-compress v1.18"
Liam Fallon [Mon, 17 Sep 2018 12:33:16 +0000 (12:33 +0000)]
Merge "Upgrade commons-compress v1.18"

5 years agoFixed incorrect model name 55/66755/2
Michael Mokry [Fri, 14 Sep 2018 21:09:10 +0000 (16:09 -0500)]
Fixed incorrect model name

Changed the model name of the script to be the correct SDNC-GenerateName
version CSIT to fix the failed CSIT test cases

Change-Id: I8974202cfc8cea3a19e102813fbf2a4f449cd11b
Issue-ID: POLICY-983
Signed-off-by: Michael Mokry <mm117s@att.com>
5 years agoUpgrade commons-compress v1.18 01/66701/1
Pamela Dragosh [Fri, 14 Sep 2018 15:46:08 +0000 (11:46 -0400)]
Upgrade commons-compress v1.18

Fixes 2 security issues and brings the common property
value to the root pom.xml for easier management.

Issue-ID: POLICY-1063
Change-Id: I56e3318bdfae2d205c61a5ad7af70a79bd70dada
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoUpgrade springframework 4.3.18.RELEASE 73/66673/1
Pamela Dragosh [Fri, 14 Sep 2018 14:34:25 +0000 (10:34 -0400)]
Upgrade springframework 4.3.18.RELEASE

To resolve security issue for 4.3.15.RELEASE and also
have a single place where the dependency is defined for
the sub-modules.

NOTE: 4.2.0.RELEASE is left alone in Policy SDK App
due to Portal SDK dependency.

Issue-ID: POLICY-1063
Change-Id: Ibdc464b16b4771faccb2c8c472efa7fbcbf3352c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoMerge "Upgrade dmaap client"
Jorge Hernandez [Wed, 12 Sep 2018 19:35:52 +0000 (19:35 +0000)]
Merge "Upgrade dmaap client"

5 years agoUpgrade dmaap client 89/66189/1
Pamela Dragosh [Wed, 12 Sep 2018 18:02:56 +0000 (14:02 -0400)]
Upgrade dmaap client

Upgrading to dmaap 1.1.8 for Casablanca. Hoping they have
removed some license issues.

Also, policy/parent has the version property definition
now because this dependency is shared across multiple repos.

Issue-ID: POLICY-1116
Change-Id: I6ffe7b7cf4b46b12b3ec8d534a58f0be40bb97b9
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoAdded SQL to import SDNC naming model 75/66175/1
Michael Mokry [Wed, 12 Sep 2018 15:32:42 +0000 (10:32 -0500)]
Added SQL to import SDNC naming model

Modified the script to inlcude an insert statement to add the
SDNCGenerate Naming model to the microservicemodels table during
installation

This will need to be merged before I add the CSIT test to Integration

Change-Id: I1620ce3f1097d45111bddb08c12b5b8c12bb1b2e
Issue-ID: POLICY-983
Signed-off-by: Michael Mokry <mm117s@att.com>
5 years agoModified Min Max Guard xacml template 39/65939/1
Michael Mokry [Tue, 11 Sep 2018 20:25:58 +0000 (15:25 -0500)]
Modified Min Max Guard xacml template

Changed the condition to remove not from permit and have only one not
for deny

Change-Id: Ie4563aba000fa5366095fe23d23c37019b5224d4
Issue-ID: POLICY-1038
Signed-off-by: Michael Mokry <mm117s@att.com>
5 years agoMerge "New min/max Guard Policy"
Pamela Dragosh [Tue, 11 Sep 2018 16:10:03 +0000 (16:10 +0000)]
Merge "New min/max Guard Policy"

5 years agoNew min/max Guard Policy 15/65615/4
Michael Mokry [Mon, 10 Sep 2018 20:23:15 +0000 (15:23 -0500)]
New min/max Guard Policy

Made changes to support Guard policy create/update and other policy manager
functions including deletePolicy and pushPolicy.

Includes changes for new Guard policy support using GUI and API (Rest and Java Client)

Made changes to address Jim's comments

Made changes to address Liam's comments

Change-Id: I133fe1fd9287ea77ea41a2788de90c7642c36b6a
Issue-ID: POLICY-1038
Signed-off-by: Mike Mokry <mm117s@att.com>
5 years agoChange websockets to managed version 55/65855/1
liamfallon [Tue, 11 Sep 2018 13:56:34 +0000 (14:56 +0100)]
Change websockets to managed version

Change-Id: Iff8f9053640752f86e6f5aa94c1f16f6d3e01d6a
Issue-ID: POLICY-884
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
5 years agoResolved XACML Platform Sonar issues 79/65079/3
rb7147 [Thu, 6 Sep 2018 20:36:22 +0000 (16:36 -0400)]
Resolved XACML Platform Sonar issues

Issue-ID: POLICY-902
Change-Id: If22627dfe7df993b5c725ddf3a66c10ebbaa73ca
Signed-off-by: rb7147 <rb7147@att.com>
5 years agoMerge "XACML Platform Enhancements"
Jorge Hernandez [Thu, 6 Sep 2018 12:53:21 +0000 (12:53 +0000)]
Merge "XACML Platform Enhancements"

5 years agoMerge "TOSCA model enhancements"
Pamela Dragosh [Thu, 6 Sep 2018 00:26:31 +0000 (00:26 +0000)]
Merge "TOSCA model enhancements"

5 years agoXACML Platform Enhancements 99/64499/9
rb7147 [Tue, 4 Sep 2018 18:16:04 +0000 (14:16 -0400)]
XACML Platform Enhancements

To Support Raw Policy Creation from GUI and API.
GetDecision on combining algorithim with Policy Set.

Issue-ID: POLICY-902
Change-Id: Ie3189f8ded2e03366bc7d65d15b95b88c89b0acd
Signed-off-by: rb7147 <rb7147@att.com>
5 years agoTOSCA model enhancements 67/63867/4
Wang,Frank(gw1218) [Thu, 30 Aug 2018 16:16:37 +0000 (11:16 -0500)]
TOSCA model enhancements

Add those features below to existing TOSCA Policy model:
1. Set default value to HTML element
2. Set description of a property as a tooltip
3. Support Boolean type
4. User defined object can be re-used by different properties in the same yaml file

Issue-ID: POLICY-900
Change-Id: I337107828ce8130b9a68a2ba000ee719bbcb923e
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
5 years agoUpgrade to policy/parent 93/63793/4
Pamela Dragosh [Thu, 30 Aug 2018 11:51:13 +0000 (07:51 -0400)]
Upgrade to policy/parent

Change from oparent to policy/parent which inherit from
the latest oparent. The latest oparent has dependencyManagement
recommendations from the ONAP Security sub committee that
the policy team is adhering as part of the effort to consolidate
security work across projects.

Change-Id: I1a43fc5a04dbc8c4cb2b7bedbca67ad3e9dd120b
Issue-ID: INT-619
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoMerge "Enhancement on Dashboard"
Pamela Dragosh [Tue, 28 Aug 2018 19:32:09 +0000 (19:32 +0000)]
Merge "Enhancement on Dashboard"

5 years agoModified Blacklist documentation 53/63153/1
Saryu Shah [Mon, 27 Aug 2018 23:12:01 +0000 (23:12 +0000)]
Modified Blacklist documentation

Modified Blacklist documentation
-------------------------------------------------------------

Issue-ID: POLICY-947

Change-Id: Ie31d45c302c51abc09705df8e714fb42d9ced1a6
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agoEnhancement on Dashboard 97/61897/8
Wang,Frank(gw1218) [Wed, 22 Aug 2018 18:44:09 +0000 (13:44 -0500)]
Enhancement on Dashboard

Enhancement on dashboard by including more info related to CRUD actions
on policies and also providing an advanced search feature.

Issue-ID: POLICY-1042
Change-Id: I987e0ca13824413f90299a366fb4464fca7de06a
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
5 years agopolicy/engine changes to support PE https 73/61873/1
Michael Mokry [Wed, 22 Aug 2018 16:07:09 +0000 (11:07 -0500)]
policy/engine changes to support PE https

Enabled https connector in server.xml and modified the docker-install.sh
to fix the default variable name for policy truststore

Change-Id: I6db6a6d2353130c91c1f344ea7927d187150adca
Issue-ID: POLICY-781
Signed-off-by: Michael Mokry <mm117s@att.com>
5 years agoMerge "Use builder for std pap policy"
Pamela Dragosh [Wed, 22 Aug 2018 12:02:52 +0000 (12:02 +0000)]
Merge "Use builder for std pap policy"

5 years agoMerge "Updated guard blacklist documentation"
Pamela Dragosh [Mon, 20 Aug 2018 16:33:29 +0000 (16:33 +0000)]
Merge "Updated guard blacklist documentation"

5 years agoUse builder for std pap policy 09/61209/1
Krishnajinka [Mon, 20 Aug 2018 05:18:14 +0000 (14:18 +0900)]
Use builder for std pap policy

Modify constructor in stdpappolicy to use builder
this will fix the sonar issue related with more than
7 parameters method parameters

Issue-ID: POLICY-1016
Change-Id: Id736a66e5ea48f0f233cffb640cdce8aaa8f2c0d
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoUpdated guard blacklist documentation 57/61157/1
Saryu Shah [Sat, 18 Aug 2018 01:06:37 +0000 (01:06 +0000)]
Updated guard blacklist documentation

Updated guard blacklist documentation
-------------------------------------------------------------

Change-Id: Ib99fd83119994a59e9708e3585d0eafdababc8d5
Issue-ID: POLICY-947
Signed-off-by: Saryu Shah <ss3917@att.com>
5 years agohttps certs with aaf+pe containers compatibility 43/61143/1
Jorge Hernandez [Fri, 17 Aug 2018 21:23:07 +0000 (16:23 -0500)]
https certs with aaf+pe containers compatibility

Change-Id: I21ed7a0fea5ea7d62857a077fa2568da4af99d26
Issue-ID: POLICY-1057
Signed-off-by: Jorge Hernandez <jh1730@att.com>
5 years agoMerge "Junit Coverage for Import Black List Entries"
Jorge Hernandez [Wed, 15 Aug 2018 13:22:08 +0000 (13:22 +0000)]
Merge "Junit Coverage for Import Black List Entries"

5 years agoJunit Coverage for Import Black List Entries 71/60571/3
rb7147 [Tue, 14 Aug 2018 15:37:14 +0000 (11:37 -0400)]
Junit Coverage for Import Black List Entries

Issue-ID: POLICY-901
Change-Id: I3776d3c4ed01bb27ed930c074c370361e33b100a
Signed-off-by: rb7147 <rb7147@att.com>
5 years agoMerge "Resolved the Sonar issues"
Jorge Hernandez [Tue, 14 Aug 2018 19:32:52 +0000 (19:32 +0000)]
Merge "Resolved the Sonar issues"

5 years agoResolved the Sonar issues 33/60033/4
rb7147 [Fri, 10 Aug 2018 15:53:48 +0000 (11:53 -0400)]
Resolved the Sonar issues

Issue-ID: POLICY-901
Change-Id: I30e1d075dd8eb4739bcb5aa1f2503a016900ff75
Signed-off-by: rb7147 <rb7147@att.com>
5 years agoOptimize PAP policy constructor with builder 23/60423/2
Krishnajinka [Tue, 14 Aug 2018 05:09:59 +0000 (14:09 +0900)]
Optimize PAP policy constructor with builder

Fix sonar issue about constructor using more than 7 params.
Use builder parameters object for setting the attributes of
std pap policy.Recommit1

Issue-ID: POLICY-1016
Change-Id: Id9631a42813960baa78df4ab0c0f6706244c3180
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoMerge "Modify std pap policy to use builder in constr"
Pamela Dragosh [Mon, 13 Aug 2018 17:20:21 +0000 (17:20 +0000)]
Merge "Modify std pap policy to use builder in constr"

5 years agoMerge "Fix comparison issues in onap pap rest"
Pamela Dragosh [Mon, 13 Aug 2018 17:18:45 +0000 (17:18 +0000)]
Merge "Fix comparison issues in onap pap rest"

5 years agoModify std pap policy to use builder in constr 05/60205/3
Krishnajinka [Mon, 13 Aug 2018 06:44:55 +0000 (15:44 +0900)]
Modify std pap policy to use builder in constr

Fix sonar issue about constructor using more than 7 params.
Use builder parameters object for setting the attributes of
std pap policy.Rework2

Issue-ID: POLICY-1016
Change-Id: If26f7daa8d5b5d387238aad74daeddd49a8b95bb
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoFix comparison issues in onap pap rest 99/59999/2
krishnajinka [Fri, 10 Aug 2018 11:27:53 +0000 (20:27 +0900)]
Fix comparison issues in onap pap rest

Fix issues about incorrect comparison in pap rest modules
indicated by analysis tools.Rework to fix review
comments1

Issue-ID: POLICY-1016
Change-Id: I7a0ee45a721307fc3ba89ab65e807613a3df2542
Signed-off-by: krisjinka <kris.jinka@samsung.com>
5 years agoAdd PAP Policy parameter builder xacml policy 53/59753/6
krishnajinka [Wed, 8 Aug 2018 22:35:57 +0000 (07:35 +0900)]
Add PAP Policy parameter builder xacml policy

Fix Sonar flagged major issue about 14 params instead of 9
in the constructor of std pap policy class. Commit5 for
modify constrctor.fix test

Issue-ID: POLICY-1016
Change-Id: I79c8482b7fc4e203cb18402ba2b5a68a120c57b1
Signed-off-by: krisjinka <kris.jinka@samsung.com>
5 years agoFix sonar issue with constrctr in xacml comp 29/59529/3
krishnajinka [Tue, 7 Aug 2018 21:42:50 +0000 (06:42 +0900)]
Fix sonar issue with constrctr in xacml comp

Fix sonar issue of Method has 9 parameters, which is
greater than 7 authorized in StdPDPPolicy. Make the
actual sonar fix

Issue-ID: POLICY-1016
Change-Id: Ibc79ddce81a6209ec190c7f393557e9c569df453
Signed-off-by: krisjinka <kris.jinka@samsung.com>
5 years agoResolve sonar issue in Policy parameters 93/59293/4
Krishnajinka [Tue, 7 Aug 2018 00:07:47 +0000 (09:07 +0900)]
Resolve sonar issue in Policy parameters

Fix sonar issue of Method has 9 parameters, which is
greater than 7 authorized in PolicyParameters class
and related test class.Rework2

Issue-ID: POLICY-1016
Change-Id: I3096566d958e093439bcc95d92f1fe92e0ac57be
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoModify Policy manager servlet for sonar issues 55/59055/1
Krishnajinka [Mon, 6 Aug 2018 01:41:09 +0000 (10:41 +0900)]
Modify Policy manager servlet for sonar issues

Fix basic sonar issues in policy manager servlet
major and minor issues reported by sonar
Basic refactoring

Issue-ID: POLICY-1016
Change-Id: If3c19943c04d9af43807090b6340547d69ca6a19
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoMerge "Modify ONAP PAP REST classes basic checkstyle"
Pamela Dragosh [Fri, 3 Aug 2018 14:06:29 +0000 (14:06 +0000)]
Merge "Modify ONAP PAP REST classes basic checkstyle"

5 years agoMerge "Fix major sonar issues in SDK APP admin mod"
Jorge Hernandez [Fri, 3 Aug 2018 13:56:08 +0000 (13:56 +0000)]
Merge "Fix major sonar issues in SDK APP admin mod"

5 years agoModify ONAP PAP REST classes basic checkstyle 19/58819/1
Krishnajinka [Fri, 3 Aug 2018 01:36:19 +0000 (10:36 +0900)]
Modify ONAP PAP REST classes basic checkstyle

Modify tabs to space for checkstyle issue fix in ONAP PAP REST
module. It helps future reviews and refactoring. Remaining classes

Issue-ID: POLICY-1014
Change-Id: I677eadac9e8364b388be922024528c27fd1e2545
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoFix major sonar issues in SDK APP admin mod 75/58575/4
Krishnajinka [Thu, 2 Aug 2018 05:58:28 +0000 (14:58 +0900)]
Fix major sonar issues in SDK APP admin mod

Fix Sonar reported major issues regarding extracting constants,
method complexity, duplicated code blocks, more than 3 nested
control blocks. Rework3 after self review.

Issue-ID: POLICY-1016
Change-Id: Icbf940c966c51a8ef4319a94a3832cb1e8c360ba
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoConvert tabs to space in ONAP PAP REST1 99/58699/1
Krishnajinka [Thu, 2 Aug 2018 11:55:10 +0000 (20:55 +0900)]
Convert tabs to space in ONAP PAP REST1

Modify tabs to space for checkstyle issue fix in ONAP PAP REST
module. It helps future reviews and refactoring

Issue-ID: POLICY-1014
Change-Id: Idcf45689565f039c76a3ef0f40ad9a46b41bd8d6
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoMerge "Copy policy-endpoints from drools-pdp to common"
Pamela Dragosh [Tue, 31 Jul 2018 19:36:26 +0000 (19:36 +0000)]
Merge "Copy policy-endpoints from drools-pdp to common"

5 years agoMerge "Convert tabs to spaces basic refactoring"
Jorge Hernandez [Tue, 31 Jul 2018 15:13:29 +0000 (15:13 +0000)]
Merge "Convert tabs to spaces basic refactoring"

5 years agoMerge "Fix major sonar issues in SDK APP"
Pamela Dragosh [Tue, 31 Jul 2018 14:37:15 +0000 (14:37 +0000)]
Merge "Fix major sonar issues in SDK APP"

5 years agoConvert tabs to spaces basic refactoring 33/58133/1
Krishnajinka [Mon, 30 Jul 2018 04:18:06 +0000 (13:18 +0900)]
Convert tabs to spaces basic refactoring

Change tabs into spaces for checkstyle fixes in ONAP REST module of
policy engine. These changes come in way for review. Hence doing them
before refactoring is better.

Issue-ID: POLICY-1014
Change-Id: I31a372ae527946927157bc23b576f3066679b0ae
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoFix major sonar issues in SDK APP 75/57975/3
Krishnajinka [Mon, 30 Jul 2018 08:26:16 +0000 (17:26 +0900)]
Fix major sonar issues in SDK APP

Fix major issues reported by sonar in POLICY SDK APP files such as
CreateBRMSParamController, PolicyManagerServlet. Also modify tabs to
space. Rework2 based on review comments

Issue-ID: POLICY-1016
Change-Id: I5407ade1ce9f597fa91d9ca18506f5ac2d8b1411
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoCopy policy-endpoints from drools-pdp to common 93/58093/1
mmis [Mon, 30 Jul 2018 20:54:59 +0000 (21:54 +0100)]
Copy policy-endpoints from drools-pdp to common

Issue-ID: POLICY-967
Change-Id: I84eba5c06d129cb2a7ef27ed78b63a8ada37805c
Signed-off-by: mmis <michael.morris@ericsson.com>
5 years agoFix Sonar issues in utils PDP ParseLog rework 97/57697/5
Krishnajinka [Thu, 26 Jul 2018 11:58:24 +0000 (20:58 +0900)]
Fix Sonar issues in utils PDP ParseLog rework

Fix Major Sonar issues in ParseLog BackupMonitor and ONAP-PDP component.
Issues related to nested control statements. Rework2 based on review comments

Issue-ID: POLICY-1013
Change-Id: I10edb242b45a649df902a4e7c1aba0a285b8b7fb
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoMerge "Copy policy-endpoints from drools-pdp to common"
Pamela Dragosh [Fri, 27 Jul 2018 16:16:22 +0000 (16:16 +0000)]
Merge "Copy policy-endpoints from drools-pdp to common"

5 years agoMerge "Fix nested stmts issue of Sonar"
Jorge Hernandez [Thu, 26 Jul 2018 18:05:23 +0000 (18:05 +0000)]
Merge "Fix nested stmts issue of Sonar"

5 years agoMerge "Refactor code for nested stmts in policy std"
Jorge Hernandez [Thu, 26 Jul 2018 18:00:23 +0000 (18:00 +0000)]
Merge "Refactor code for nested stmts in policy std"

5 years agoCopy policy-endpoints from drools-pdp to common 25/57725/1
mmis [Thu, 26 Jul 2018 16:45:55 +0000 (17:45 +0100)]
Copy policy-endpoints from drools-pdp to common

Replaced references to classes deleted from drools-pdp with references to
the corresponding classes in polcy-common

Issue-ID: POLICY-967
Change-Id: I7bb580af3b3b2eb0ddcab9421c595237fa37282b
Signed-off-by: mmis <michael.morris@ericsson.com>
5 years agoRefactor code for nested stmts in policy std 55/57655/2
Krishnajinka [Thu, 26 Jul 2018 07:33:11 +0000 (16:33 +0900)]
Refactor code for nested stmts in policy std

Refactor code for nested control statements in PolicyEngineAPI policy.std
package. These issues are flagged by Sonar as Major issues. Rework based on
review comments

Issue-ID: POLICY-1012
Change-Id: I6925dd5d56b653ef4cefe5ae64686a49f9741125
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoFix nested stmts issue of Sonar 33/57633/2
Krishnajinka [Thu, 26 Jul 2018 04:06:15 +0000 (13:06 +0900)]
Fix nested stmts issue of Sonar

Policy rest util MSModeUtils have Sonar flagged issues about nesting
more than 3 control stmts. Fix these. Also a minor change from prev
commit about BrmsPush.java. Rework based on review

Issue-ID: POLICY-1009
Change-Id: Ibd3cebcdebf9cf26233e810033793a5315b93272
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoMerge "Fix issues reported by sonar"
Liam Fallon [Thu, 26 Jul 2018 08:30:01 +0000 (08:30 +0000)]
Merge "Fix issues reported by sonar"

5 years agoFix issues reported by sonar 21/57421/3
Krishnajinka [Wed, 25 Jul 2018 06:05:28 +0000 (15:05 +0900)]
Fix issues reported by sonar

Fix issues related to unused method variables, extract constants,
not nest more than 3 control stmts, use try with res in policy
engine project. Rework for comments

Issue-ID: POLICY-1008
Change-Id: If0953de9e802110df14862707f3b525652cdf112
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoMerge "Decision BlackList Guard Enhancements"
Jorge Hernandez [Wed, 25 Jul 2018 14:12:20 +0000 (14:12 +0000)]
Merge "Decision BlackList Guard Enhancements"

5 years agoMerge "Fix sonar issue about nested stmts"
Jorge Hernandez [Wed, 25 Jul 2018 14:11:16 +0000 (14:11 +0000)]
Merge "Fix sonar issue about nested stmts"

5 years agoFix sonar issue about nested stmts 51/57251/3
Krishnajinka [Tue, 24 Jul 2018 05:23:06 +0000 (14:23 +0900)]
Fix sonar issue about nested stmts

Refactor code to not nest more than 3 condition or loop stmts
in policy PolicyEngineUtils. Rework based on review comments

Issue-ID: POLICY-1003
Change-Id: I95fcfa0f99c517c02357c85ca39cd2f934e8da4d
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
5 years agoDecision BlackList Guard Enhancements 63/56763/8
rb7147 [Wed, 18 Jul 2018 16:50:06 +0000 (12:50 -0400)]
Decision BlackList Guard Enhancements

While creating a decision Bl Guard Policy we are allowing to add
Blacklist entries through file upload for bulk from GUI.

Issue-ID: POLICY-901
Change-Id: I4031fd4a96937b9facc330cecf72777d701d4678
Signed-off-by: rb7147 <rb7147@att.com>
5 years agoMerge "Refactor PolicyNotificationMail for sonar issues"
Pamela Dragosh [Tue, 24 Jul 2018 11:39:18 +0000 (11:39 +0000)]
Merge "Refactor PolicyNotificationMail for sonar issues"