policy/engine.git
6 years agoAdded Junits for POLICY-SDK-APP 07/34207/2
rb7147 [Tue, 6 Mar 2018 03:59:30 +0000 (22:59 -0500)]
Added Junits for POLICY-SDK-APP

Issue-ID: POLICY-600
Change-Id: Ib96b7ccede0fa09e71f02ff073c89682e9aa7089
Signed-off-by: rb7147 <rb7147@att.com>
6 years agoMerge "Remove auto generated rule to the drl"
Jorge Hernandez [Tue, 6 Mar 2018 02:37:08 +0000 (02:37 +0000)]
Merge "Remove auto generated rule to the drl"

6 years agoMerge "JUnit additions for PAP-REST"
Pamela Dragosh [Tue, 6 Mar 2018 01:36:59 +0000 (01:36 +0000)]
Merge "JUnit additions for PAP-REST"

6 years agoJUnit additions for PAP-REST 19/34119/1
bobbymander [Mon, 5 Mar 2018 19:56:44 +0000 (14:56 -0500)]
JUnit additions for PAP-REST

Issue-ID: POLICY-600
Change-Id: I59117fff52a2cd37c1260aafaae4ebe922053202
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoMerge "Upgrade commons-collection for security fix"
Jorge Hernandez [Mon, 5 Mar 2018 19:52:50 +0000 (19:52 +0000)]
Merge "Upgrade commons-collection for security fix"

6 years agoMerge "Upgrade dmaap client with security fix"
Jorge Hernandez [Mon, 5 Mar 2018 19:52:18 +0000 (19:52 +0000)]
Merge "Upgrade dmaap client with security fix"

6 years agoMerge "Update Dockerfile and docker_*.sh"
Jorge Hernandez [Mon, 5 Mar 2018 18:23:34 +0000 (18:23 +0000)]
Merge "Update Dockerfile and docker_*.sh"

6 years agoUpdate Dockerfile and docker_*.sh 63/34063/2
mmis [Mon, 5 Mar 2018 13:45:40 +0000 (13:45 +0000)]
Update Dockerfile and docker_*.sh

Correction to previous commit "Move docker_*.sh scripts into
policy/engine" as attempt to build docker image will result in failure to
pull the policy-base image from nexus
The policy-base and policy-os images are removed in favour of including
the contents of those images directly in the policy-pe image

Issue-ID: POLICY-624
Change-Id: Ie4a12407d4cb5a1d663cd11136c282a53f496ca3
Signed-off-by: mmis <michael.morris@ericsson.com>
6 years agoRemove auto generated rule to the drl 65/33865/4
pa834y [Fri, 2 Mar 2018 22:14:47 +0000 (17:14 -0500)]
Remove auto generated rule to the drl

Issue-ID: POLICY-488
Change-Id: Id6915407a6f030b77ae2d18ad3665af9d0feb34b
Signed-off-by: pa834y <pa834y@att.com>
6 years agoUpgrade commons-collection for security fix 79/34079/2
Pamela Dragosh [Mon, 5 Mar 2018 15:25:41 +0000 (10:25 -0500)]
Upgrade commons-collection for security fix

Force use of 3.2.2 to clear security issue for commons
collections.

Issue-ID: POLICY-507
Change-Id: Id9ac1e07b90dfb6594cde5ba4cec4e3867f43a76
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoJUnit addition/fix for PAP-REST 65/34065/1
bobbymander [Mon, 5 Mar 2018 14:05:13 +0000 (09:05 -0500)]
JUnit addition/fix for PAP-REST

Issue-ID: POLICY-600
Change-Id: I342bc97f85739f73b0dac6aaea19f6f4b2ded470
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoUpgrade dmaap client with security fix 47/33847/2
Pamela Dragosh [Fri, 2 Mar 2018 20:28:58 +0000 (15:28 -0500)]
Upgrade dmaap client with security fix

Dmaap removed security issues.

Issue-ID: POLICY-618
Change-Id: Ied6051dd5eaec204a6d7806460410c3a3083c462
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoMerge "JUnit additions for SDK-APP"
Pamela Dragosh [Mon, 5 Mar 2018 01:59:45 +0000 (01:59 +0000)]
Merge "JUnit additions for SDK-APP"

6 years agoJUnit additions for SDK-APP 39/33839/4
bobbymander [Fri, 2 Mar 2018 19:29:37 +0000 (14:29 -0500)]
JUnit additions for SDK-APP

Issue-ID: POLICY-604
Change-Id: Ide34e02942a473c626b4f074113d235a3fdfccba
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoMerge "Move docker_*.sh scripts into policy/engine"
Jorge Hernandez [Fri, 2 Mar 2018 19:17:18 +0000 (19:17 +0000)]
Merge "Move docker_*.sh scripts into policy/engine"

6 years agoMove docker_*.sh scripts into policy/engine 41/33641/3
mmis [Thu, 1 Mar 2018 16:50:11 +0000 (16:50 +0000)]
Move docker_*.sh scripts into policy/engine

Add files for building policy-pe docker image

Issue-ID: POLICY-614
Change-Id: Id3e999e652c7c7c6092eb9bde76709cfa1c06c7b
Signed-off-by: mmis <michael.morris@ericsson.com>
6 years agoJUnit remove one flaky test for now 13/33813/1
bobbymander [Fri, 2 Mar 2018 15:17:28 +0000 (10:17 -0500)]
JUnit remove one flaky test for now

Issue-ID: POLICY-600
Change-Id: I8b32cb3658e9a145a6493639787abc0145a04991
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoMerge "Remove CLM issues with commons-collections"
Jorge Hernandez [Fri, 2 Mar 2018 14:11:01 +0000 (14:11 +0000)]
Merge "Remove CLM issues with commons-collections"

6 years agoMerge "JUnit additions for PAP-REST,API"
Jorge Hernandez [Fri, 2 Mar 2018 01:47:18 +0000 (01:47 +0000)]
Merge "JUnit additions for PAP-REST,API"

6 years agoMerge "Added Junits for ONAP-SDK-APP"
Jorge Hernandez [Fri, 2 Mar 2018 01:46:48 +0000 (01:46 +0000)]
Merge "Added Junits for ONAP-SDK-APP"

6 years agoRemove CLM issues with commons-collections 97/33697/1
Pamela Dragosh [Thu, 1 Mar 2018 23:00:06 +0000 (18:00 -0500)]
Remove CLM issues with commons-collections

We know that we are not configuring an LDAP PIP in our
use of the XACML open source. The LDAP implementation
uses Apache Velocity, which uses a very old version
of commons-collections that has security issues. So
we can exclude commons-collections from the build.

Issue-ID: POLICY-507
Change-Id: I735eae4fe507ad016d9b0b49e67536415edb9820
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoMerge "Added Junits for Policy PAP-REST"
Jorge Hernandez [Thu, 1 Mar 2018 20:12:03 +0000 (20:12 +0000)]
Merge "Added Junits for Policy PAP-REST"

6 years agoJUnit additions for PAP-REST,API 69/33669/1
bobbymander [Thu, 1 Mar 2018 19:59:12 +0000 (14:59 -0500)]
JUnit additions for PAP-REST,API

Issue-ID: POLICY-600
Change-Id: I68020230d370950c0323a544910ad54015e1a08a
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoAdded Junits for ONAP-SDK-APP 67/33667/3
rb7147 [Thu, 1 Mar 2018 19:51:58 +0000 (14:51 -0500)]
Added Junits for ONAP-SDK-APP

Issue-ID: POLICY-604
Change-Id: Ice9264ff38d51c5801cfeedcf7169cc26ca780f5
Signed-off-by: rb7147 <rb7147@att.com>
6 years agoAdding fix for BRMSGW issue 63/33663/1
Michael Mokry [Thu, 1 Mar 2018 19:35:37 +0000 (13:35 -0600)]
Adding fix for BRMSGW issue

This should fix the issue with the BRMSGW getting notification to create
the rules jar

Change-Id: Ie575a0b4717c999b8ab9deecc667ceaba99e7327
Issue-ID: POLICY-660
Signed-off-by: Michael Mokry <mm117s@att.com>
6 years agoAdded Junits for Policy PAP-REST 63/33463/5
rb7147 [Wed, 28 Feb 2018 19:23:12 +0000 (14:23 -0500)]
Added Junits for Policy PAP-REST

Issue-ID: POLICY-600
Change-Id: Icb67ac587e614f663416b3ea0a03ca6e5b02c621
Signed-off-by: rb7147 <rb7147@att.com>
6 years agoMerge "JUnit additions for PAP-REST,REST,XACML"
Jorge Hernandez [Thu, 1 Mar 2018 16:36:15 +0000 (16:36 +0000)]
Merge "JUnit additions for PAP-REST,REST,XACML"

6 years agoJUnit additions for PAP-REST,REST,XACML 73/33473/3
bobbymander [Wed, 28 Feb 2018 21:31:24 +0000 (16:31 -0500)]
JUnit additions for PAP-REST,REST,XACML

Issue-ID: POLICY-603
Change-Id: I78c5e302c474613cbb22a80e0d931b4f47dd3b63
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoMerge "More junits for PDP-REST"
Jorge Hernandez [Thu, 1 Mar 2018 05:02:34 +0000 (05:02 +0000)]
Merge "More junits for PDP-REST"

6 years agoMerge "JUnit additions for ONAP-PAP-REST"
Jorge Hernandez [Wed, 28 Feb 2018 16:48:35 +0000 (16:48 +0000)]
Merge "JUnit additions for ONAP-PAP-REST"

6 years agoMerge "Added Junits for Policy PAP-REST"
Jorge Hernandez [Wed, 28 Feb 2018 16:46:59 +0000 (16:46 +0000)]
Merge "Added Junits for Policy PAP-REST"

6 years agoMore junits for PDP-REST 61/33261/2
Magnusen, Drew (dm741q) [Tue, 27 Feb 2018 20:47:22 +0000 (14:47 -0600)]
More junits for PDP-REST

More junits for the org.onap.policy.pdp.rest.impl/jmx packages.

Issue-ID: POLICY-602
Change-Id: I2af2fc3280314a8d6c1e9c352eda042c7fea7932
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
6 years agoJUnit additions for ONAP-PAP-REST 33/33433/1
bobbymander [Wed, 28 Feb 2018 13:58:56 +0000 (08:58 -0500)]
JUnit additions for ONAP-PAP-REST

Issue-ID: POLICY-600
Change-Id: I6e458335b04b88146d88fea2f6fd908779d842fc
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoMerge "remove mariadb superuser sql statements"
Pamela Dragosh [Wed, 28 Feb 2018 12:18:17 +0000 (12:18 +0000)]
Merge "remove mariadb superuser sql statements"

6 years agoMerge "JUnit additions for XACML,REST,POLICY-SDK"
Jorge Hernandez [Tue, 27 Feb 2018 21:56:08 +0000 (21:56 +0000)]
Merge "JUnit additions for XACML,REST,POLICY-SDK"

6 years agoremove mariadb superuser sql statements 59/33259/1
Jorge Hernandez [Tue, 27 Feb 2018 21:14:14 +0000 (15:14 -0600)]
remove mariadb superuser sql statements

PE installation as part of data upgrade invokes
"set global" statements that are typically used
by priviledged accounts as the "root" mariadb user.

As part of the effort to clean up the mariadb docker install,
only permissions to a regular mariadb user (policy_user by default)
are given in 3 databases: onap_sdk, log, and support.
This account cannot do changes outside those.

In any case the usage of the global timeouts is questionable.
We should keep an eye if there's any potential bad side effect,
and correct it if it doesn't.   It's preferable to keep
"policy_user" with a restricted set of privileges, instead
of being a superuser (otherwise can plainly user the root account).

Change-Id: I17b1a6a2cb62a319464e1db4b3aafbc1dbf20d78
Issue-ID: POLICY-650
Signed-off-by: Jorge Hernandez <jh1730@att.com>
6 years agoAdded Junits for Policy PAP-REST 07/33207/2
rb7147 [Tue, 27 Feb 2018 17:09:16 +0000 (12:09 -0500)]
Added Junits for Policy PAP-REST

Issue-ID: POLICY-600
Change-Id: I1d42a3a880c9d81115d48794a77fadb89562e136
Signed-off-by: rb7147 <rb7147@att.com>
6 years agoMerge "Add Junit to policy/engine LogParser package"
Pamela Dragosh [Tue, 27 Feb 2018 19:58:51 +0000 (19:58 +0000)]
Merge "Add Junit to policy/engine LogParser package"

6 years agoMerge "Policy:Major"
Pamela Dragosh [Tue, 27 Feb 2018 19:57:34 +0000 (19:57 +0000)]
Merge "Policy:Major"

6 years agoJUnit additions for XACML,REST,POLICY-SDK 33/33233/3
bobbymander [Tue, 27 Feb 2018 18:51:51 +0000 (13:51 -0500)]
JUnit additions for XACML,REST,POLICY-SDK

Issue-ID: POLICY-584
Change-Id: I4bb91b18122c7f61bb71b1a9e39d51cd65af70bd
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoCode Clean Up for Policy PAP-REST 59/32959/4
rb7147 [Mon, 26 Feb 2018 23:04:46 +0000 (18:04 -0500)]
Code Clean Up for Policy PAP-REST

Cleaned the duplicate code for all dictionary controllers and created
Utils class.

Issue-ID: POLICY-600
Change-Id: I65b8574d9f667758407515a5c55bc28f636be477
Signed-off-by: rb7147 <rb7147@att.com>
6 years agoPolicy:Major 47/33147/1
Manamohan Satapathy [Tue, 27 Feb 2018 10:49:19 +0000 (16:19 +0530)]
Policy:Major

Local variables should not shadow class field:L992 L1719
Issue-ID: POLICY-649

Link: https://sonar.onap.org/issues?myIssues=true&projectUuids=AV2blNLJ5bp_wwmIUP3L&resolved=false&severities=CRITICAL%2CMAJOR&types=CODE_SMELL
Location:POLICY-SDK-APP\src\main\java\org\onap\policy\controller\CreateDcaeMicroServiceController.java

Change-Id: I1d038829867c7d019473909650946a9539b5e736
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
6 years agoAdd Junit to policy/engine LogParser package 43/33143/1
ramverma [Tue, 27 Feb 2018 09:55:18 +0000 (09:55 +0000)]
Add Junit to policy/engine LogParser package

Test cases to improve the coverage of LogParser to 72%

Change-Id: Idbf9dbbc7254d2ba4d6953852d7847b5070dd4d4
Issue-ID: POLICY-599
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
6 years agoMerge "Added junits to increase coverage"
Pamela Dragosh [Mon, 26 Feb 2018 20:17:36 +0000 (20:17 +0000)]
Merge "Added junits to increase coverage"

6 years agoAdded junits to increase coverage 25/32925/4
MAGNUSEN [Mon, 26 Feb 2018 15:19:16 +0000 (09:19 -0600)]
Added junits to increase coverage

This commit adds some junits which touch several classes in the
notifications package in the ONAP-PDP-REST project.

Issue-ID: POLICY-602
Change-Id: Ie99ddd03841d4063aba64781bf08a38d2a25f0ed
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
6 years agoJUnit additions for BRMS,PDP-REST,REST 29/32929/4
bobbymander [Mon, 26 Feb 2018 18:11:34 +0000 (13:11 -0500)]
JUnit additions for BRMS,PDP-REST,REST

Issue-ID: POLICY-598
Change-Id: I397ed925bdb43a4b2f7a94cc4692b6506f650ede
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoJUnit additions for PDP,PDP-REST 05/32705/4
bobbymander [Fri, 23 Feb 2018 19:14:15 +0000 (14:14 -0500)]
JUnit additions for PDP,PDP-REST

Issue-ID: POLICY-600
Change-Id: Ia5584011cbd42b9b49953d714efbeb5956b9b295
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoMerge "Fix Fortify Issue - External Entity Injection"
Jorge Hernandez [Fri, 23 Feb 2018 19:48:14 +0000 (19:48 +0000)]
Merge "Fix Fortify Issue - External Entity Injection"

6 years agoMerge "Add JUnit tests policy/engine PolicyEngineAPI"
Jorge Hernandez [Fri, 23 Feb 2018 19:43:52 +0000 (19:43 +0000)]
Merge "Add JUnit tests policy/engine PolicyEngineAPI"

6 years agoFix Fortify Issue - External Entity Injection 25/32625/4
guangxingwang [Thu, 22 Feb 2018 21:13:17 +0000 (15:13 -0600)]
Fix Fortify Issue - External Entity Injection

Fix Fortify Issue by setting secure process of factory as true

Issue-ID: POLICY-551
Change-Id: I46890d2664d0ae9ed9540ba830d0f4b27136a6e9
Signed-off-by: guangxingwang <gw1218@att.com>
6 years agoAdd JUnit tests policy/engine PolicyEngineAPI 75/32675/3
waqas.ikram [Fri, 23 Feb 2018 11:17:30 +0000 (11:17 +0000)]
Add JUnit tests policy/engine PolicyEngineAPI

Change-Id: I8d7a76836759b042c83349c2b875fb77085b531c
Issue-ID: POLICY-606
Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
6 years agoJUnit small additions for PAP-REST,PDP-REST,XACML 19/32619/1
bobbymander [Thu, 22 Feb 2018 20:43:12 +0000 (15:43 -0500)]
JUnit small additions for PAP-REST,PDP-REST,XACML

Issue-ID: POLICY-600
Change-Id: I1b012dd1dbc49c10cd47b5f100e8ccef6c92f70b
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoMerge "JUnit additions for ONAP-PAP-REST xacml.rest"
Jorge Hernandez [Thu, 22 Feb 2018 19:36:06 +0000 (19:36 +0000)]
Merge "JUnit additions for ONAP-PAP-REST xacml.rest"

6 years agoMerge "Fix Fortify Path Manipulation Issue"
Jorge Hernandez [Thu, 22 Feb 2018 18:18:28 +0000 (18:18 +0000)]
Merge "Fix Fortify Path Manipulation Issue"

6 years agoFix Fortify Path Manipulation Issue 39/32439/3
guangxingwang [Wed, 21 Feb 2018 20:09:04 +0000 (14:09 -0600)]
Fix Fortify Path Manipulation Issue

Fix Fortify path manipulation issue by adding a validation on dictionary
name.

Issue-ID: POLICY-541
Change-Id: I87492b0d80bf96bebfc029d7d164cdd20ca5ef0f
Signed-off-by: guangxingwang <gw1218@att.com>
6 years agoJUnit additions for ONAP-PAP-REST xacml.rest 37/32437/3
bobbymander [Wed, 21 Feb 2018 19:59:04 +0000 (14:59 -0500)]
JUnit additions for ONAP-PAP-REST xacml.rest

Issue-ID: POLICY-600
Change-Id: Ia6ccc2904efd7c1e7ec206caaedd8552c83d92a5
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoUpdated the Policy Logging Pattern 09/32409/3
rb7147 [Wed, 21 Feb 2018 15:40:47 +0000 (10:40 -0500)]
Updated the Policy Logging Pattern

Updated the logback.xml to save logs for 30 days.

Issue-ID: POLICY-644
Change-Id: I578570fa5a7f86ba464c37cddab43a2fabcdae7f
Signed-off-by: rb7147 <rb7147@att.com>
6 years agoUpgraded SDK version in Policy 29/32429/2
rb7147 [Wed, 21 Feb 2018 18:24:04 +0000 (13:24 -0500)]
Upgraded SDK version in Policy

Issue-ID: POLICY-645
Change-Id: Ie83b4c91c8186433e582cccadf5c3d32209a88f4
Signed-off-by: rb7147 <rb7147@att.com>
6 years agoMerge "Added Junits for POLICY-SDK-APP controllers"
Jorge Hernandez [Wed, 21 Feb 2018 18:30:10 +0000 (18:30 +0000)]
Merge "Added Junits for POLICY-SDK-APP controllers"

6 years agoMerge "Fix Fortify Log Forging Issue"
Jorge Hernandez [Wed, 21 Feb 2018 18:28:11 +0000 (18:28 +0000)]
Merge "Fix Fortify Log Forging Issue"

6 years agoMerge "JUnit test for policy/engine PolicyEngineAPI"
Jorge Hernandez [Wed, 21 Feb 2018 17:50:16 +0000 (17:50 +0000)]
Merge "JUnit test for policy/engine PolicyEngineAPI"

6 years agoAdded Junits for POLICY-SDK-APP controllers 17/32417/3
uj426b [Tue, 20 Feb 2018 22:19:00 +0000 (17:19 -0500)]
Added Junits for POLICY-SDK-APP controllers

Issue-ID: POLICY-584
Change-Id: I306f3484f466accf11ca4fd59864a4b402dcb733
Signed-off-by: uj426b <uj426b@att.com>
6 years agoFix Fortify Log Forging Issue 07/32407/2
guangxingwang [Wed, 21 Feb 2018 15:22:12 +0000 (09:22 -0600)]
Fix Fortify Log Forging Issue

Fix Fortify log forging issue by removing properties info from logging.

Issue-ID: POLICY-544
Change-Id: I6e7d39abe18698f864564844963d7bbddedd2e3b
Signed-off-by: guangxingwang <gw1218@att.com>
6 years agoMerge "JUnit additions for ONAP-PAP-REST"
Pamela Dragosh [Wed, 21 Feb 2018 14:44:55 +0000 (14:44 +0000)]
Merge "JUnit additions for ONAP-PAP-REST"

6 years agoJUnit additions for ONAP-PAP-REST 15/32315/2
bobbymander [Tue, 20 Feb 2018 20:20:27 +0000 (15:20 -0500)]
JUnit additions for ONAP-PAP-REST

Issue-ID: POLICY-600
Change-Id: I2e6d0d656a9be77b038a08568d43d1bb7efefe57
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoAdded Junits for Policy PAP-REST 63/32263/8
rb7147 [Mon, 19 Feb 2018 21:02:31 +0000 (16:02 -0500)]
Added Junits for Policy PAP-REST

Clenaed the unsued code.
Cleaned the duplication of code and moved to ONAP-REST.
Added Junits for PAP-REST

Issue-ID: POLICY-600
Change-Id: I56e6e8f2f547def9eaf8624a9e0dd52dc05ad136
Signed-off-by: rb7147 <rb7147@att.com>
6 years agoFix for h2 missing from testing 95/32295/2
Pamela Dragosh [Tue, 20 Feb 2018 18:36:48 +0000 (13:36 -0500)]
Fix for h2 missing from testing

First submit for re-organizing pom.xml dependencies. H2 is ONLY
used for testing and should be loaded otherwise. We removed it
from policy/common so that is affecting these test.

Issue-ID: POLICY-626
Change-Id: Iba86e89f2cb26581b2b465091e829d6bdd66a37b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoMerge "Add Junit to policy/engine LogParser"
Jorge Hernandez [Tue, 20 Feb 2018 18:04:49 +0000 (18:04 +0000)]
Merge "Add Junit to policy/engine LogParser"

6 years agoMerge "Added Junits to ONAP-PDP-REST"
Jorge Hernandez [Tue, 20 Feb 2018 17:38:21 +0000 (17:38 +0000)]
Merge "Added Junits to ONAP-PDP-REST"

6 years agoAdd Junit to policy/engine LogParser 27/32227/6
ramverma [Mon, 19 Feb 2018 17:12:19 +0000 (17:12 +0000)]
Add Junit to policy/engine LogParser

Junits to improve the coverage of LogParser to 55%

Change-Id: Icddecd7a2904d5a679910f7d5fcac891b3698c66
Issue-ID: POLICY-599
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
6 years agoJUnit test for policy/engine PolicyEngineAPI 77/32277/2
waqas.ikram [Tue, 20 Feb 2018 15:44:50 +0000 (15:44 +0000)]
JUnit test for policy/engine PolicyEngineAPI

Change-Id: I31991245bb5cc877722f7ce14530222a102d6472
Issue-ID: POLICY-606
Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
6 years agoMerge "Fix Fortify Scan Issue:"
Pamela Dragosh [Tue, 20 Feb 2018 14:49:53 +0000 (14:49 +0000)]
Merge "Fix Fortify Scan Issue:"

6 years agoAdded Junits to ONAP-PDP-REST 49/32249/2
Michael Mokry [Tue, 20 Feb 2018 13:57:41 +0000 (07:57 -0600)]
Added Junits to ONAP-PDP-REST

Junits to cover classes in the api/services package that were at 0%
coverage

Change-Id: Ic92b9db4a8beea827b9b85de826da909b02ea1bd
Issue-ID: POLICY-338
Signed-off-by: Michael Mokry <mm117s@att.com>
6 years agoFix Fortify Scan Issue: 51/31851/8
guangxingwang [Thu, 15 Feb 2018 17:13:18 +0000 (11:13 -0600)]
Fix Fortify Scan Issue:

1) Fix Fortify Header Manipulation issue by checking the format of the
message before adding it response header.

2) Fix Fortify Hardcoded Password issue by using encryption and decryption

Issue-ID: POLICY-543
Change-Id: I16b44b9b0670b1af75094c9ae9d1f7d352fa894a
Signed-off-by: guangxingwang <gw1218@att.com>
6 years agoRename maven modules in drools-applications 19/31719/4
liamfallon [Wed, 14 Feb 2018 12:49:09 +0000 (12:49 +0000)]
Rename maven modules in drools-applications

All found references to drools-applications module names
changed to new names

Issue-ID: POLICY-238
Change-Id: I3cd453c91194699434a71c1a12d2dcccfa5df234
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoFix compilation issue due to generic Exception 19/32119/3
Jim Hahn [Mon, 19 Feb 2018 16:53:40 +0000 (11:53 -0500)]
Fix compilation issue due to generic Exception

After modifying common to remove generic Exceptions, policy/engine would
no longer compile.  Had to modify policy/engine to accomodate the
specific exception.

Change-Id: If339285235994119009a8dcf9484bc81016e2600
Issue-ID: POLICY-246
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoMerge "Added Junis for Policy ONAP-REST"
Jorge Hernandez [Sun, 18 Feb 2018 17:58:30 +0000 (17:58 +0000)]
Merge "Added Junis for Policy ONAP-REST"

6 years agoAdded Junis for Policy ONAP-REST 05/32005/1
rb7147 [Fri, 16 Feb 2018 18:46:06 +0000 (13:46 -0500)]
Added Junis for Policy ONAP-REST

Cleaned the unused constructors.
Cleaned the unused code.
Added Junits for all JPAS.
Renamed the Junit class names on removing classes.

Issue-ID: POLICY-603
Change-Id: I0709ccecd7a2f3ec49367ff85f5a6d273479493e
Signed-off-by: rb7147 <rb7147@att.com>
6 years agoResolved the POLICY-SDK-APP junit issue. 01/32001/1
uj426b [Fri, 16 Feb 2018 18:26:53 +0000 (13:26 -0500)]
Resolved the POLICY-SDK-APP junit issue.

Issue-ID: POLICY-584
Change-Id: I90aaec29e908b742f0866d2754d426f75e1b8953
Signed-off-by: uj426b <uj426b@att.com>
6 years agoMerge "New JUnit for PolicyEngineAPI"
Pamela Dragosh [Fri, 16 Feb 2018 17:34:00 +0000 (17:34 +0000)]
Merge "New JUnit for PolicyEngineAPI"

6 years agoMerge "JUnit test for policy/engine ONAP-XACML"
Pamela Dragosh [Fri, 16 Feb 2018 17:31:11 +0000 (17:31 +0000)]
Merge "JUnit test for policy/engine ONAP-XACML"

6 years agoNew JUnit for PolicyEngineAPI 91/31991/1
bobbymander [Fri, 16 Feb 2018 16:09:36 +0000 (11:09 -0500)]
New JUnit for PolicyEngineAPI

Issue-ID: POLICY-338
Change-Id: I711bb0c219534a537c3d35331b8ef8703423ad63
Signed-off-by: bobbymander <bobby.mander@att.com>
6 years agoModify sonar settings to include all sub-modules 89/31989/1
Pamela Dragosh [Fri, 16 Feb 2018 16:18:09 +0000 (11:18 -0500)]
Modify sonar settings to include all sub-modules

We are now including all the sub-modules coverage into one file.
This will now reflect correct statistics for any sub-module that
tests code located in another sub-module.

Issue-ID: POLICY-634
Change-Id: I1eeb52c893aea96b3b031fabceb92e3b07f6c02c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoJUnit test for policy/engine ONAP-XACML 51/31951/1
mmis [Fri, 16 Feb 2018 12:34:39 +0000 (12:34 +0000)]
JUnit test for policy/engine ONAP-XACML

Increased junits in package org.onap.policy.xacml.test.std.pap in policy/engine ONAP-XACML

Change-Id: Ifef6fcc36044039b2c3d0c0dbffecffd3e242434
Issue-ID: POLICY-605
Signed-off-by: mmis <michael.morris@ericsson.com>
6 years agoAdding Junits in ONAP-PDP-REST 29/31829/2
Michael Mokry [Thu, 15 Feb 2018 13:23:11 +0000 (07:23 -0600)]
Adding Junits in ONAP-PDP-REST

 - This commit adds one Junit for PAPServices
 - I needed to make a minor modification to the PAPServices class in
 order to set the PAPs

Change-Id: Ia54650307e8d9e96d40ce6e68ad18508d4030a4a
Issue-ID: POLICY-338
Signed-off-by: Michael Mokry <mm117s@att.com>
6 years agoMerge "Added Junits for Policy PAP-REST"
Jorge Hernandez [Wed, 14 Feb 2018 19:28:14 +0000 (19:28 +0000)]
Merge "Added Junits for Policy PAP-REST"

6 years agoMake drlRuleAndUIParams transient or serializable 83/31683/1
Swapnali Pode [Wed, 14 Feb 2018 07:05:30 +0000 (12:35 +0530)]
Make drlRuleAndUIParams transient or serializable

Make drlRuleAndUIParams transient or serializable
StdPAPPolicy.java:L72

Sonar Link:
https://sonar.onap.org/project/issues?assignees=swapnalipode&id=org.onap.policy.engine%3APolicyEngineSuite&open=AWF91ipr8TZzbCgU6aom&resolved=false

Location:
src/main/java/org/onap/policy/xacml/std/pap/StdPAPPolicy.java

Change-Id: I3524881e76c69518949a622a23084e0bc8ef26a2
Issue-ID: POLICY-631
Signed-off-by: Swapnali Pode <SP00501638@techmahindra.com>
6 years agoAdded Junits for Policy PAP-REST 71/31671/2
rb7147 [Tue, 13 Feb 2018 23:17:22 +0000 (18:17 -0500)]
Added Junits for Policy PAP-REST

Cleaned the unnecessary constructors and methods in onap-rest.
Added Junits for JPA Classes in ONAP-REST.

Issue-ID: POLICY-338
Change-Id: I7e4f928342315475db96d89e9ad3adac5cb7eb00
Signed-off-by: rb7147 <rb7147@att.com>
6 years agoMerge "Fix a Bug on Editor Screen"
Pamela Dragosh [Wed, 14 Feb 2018 00:30:16 +0000 (00:30 +0000)]
Merge "Fix a Bug on Editor Screen"

6 years agoMerge "Added Junits for Policy PAP-REST"
Jorge Hernandez [Tue, 13 Feb 2018 22:44:07 +0000 (22:44 +0000)]
Merge "Added Junits for Policy PAP-REST"

6 years agoFix a Bug on Editor Screen 37/31637/1
guangxingwang [Tue, 13 Feb 2018 19:25:42 +0000 (13:25 -0600)]
Fix a Bug on Editor Screen

On editor screen, sometimes click on + button only one click, it creates
more than text fields

Issue-ID: POLICY-629
Change-Id: I9acc95fa0a4a7df3828e579f994c06bfa3199eb5
Signed-off-by: guangxingwang <gw1218@att.com>
6 years agoMerge "Fix Fortify Scan Issue"
Jorge Hernandez [Tue, 13 Feb 2018 15:40:22 +0000 (15:40 +0000)]
Merge "Fix Fortify Scan Issue"

6 years agoAdded Junits for Policy PAP-REST 59/31559/1
rb7147 [Tue, 13 Feb 2018 03:46:09 +0000 (22:46 -0500)]
Added Junits for Policy PAP-REST

Resolved the sonar issues.
Added JUnits for ONAP-PAP-REST and ONAP-REST Component.

Issue-ID: POLICY-338
Change-Id: Ibec2613f4f61e9ed426583af17c2a9d5b8c8d85d
Signed-off-by: rb7147 <rb7147@att.com>
6 years agoFix Fortify Scan Issue 99/31099/4
guangxingwang [Fri, 9 Feb 2018 16:22:21 +0000 (10:22 -0600)]
Fix Fortify Scan Issue

Fix Fortify Header Manipulation Issue by checking the format of a string
before adding it to response header.

Issue-ID: POLICY-543
Change-Id: I6539d22d5f8933ea29932361b152d34dd4f8857a
Signed-off-by: guangxingwang <gw1218@att.com>
6 years agoMerge "Added Junits for ONAP-PAP-REST"
Pamela Dragosh [Sat, 10 Feb 2018 15:26:26 +0000 (15:26 +0000)]
Merge "Added Junits for ONAP-PAP-REST"

6 years agoAdded Junits for ONAP-PAP-REST 09/31109/4
rb7147 [Fri, 9 Feb 2018 19:30:14 +0000 (14:30 -0500)]
Added Junits for ONAP-PAP-REST

Cleaned up unused imports.
Cleaned up unused code.
Added Junits for Dictionary controllers.

Issue-ID: POLICY-338
Change-Id: If29b934e95fdaf60dcf82300a95a23ac3c980419
Signed-off-by: rb7147 <rb7147@att.com>
6 years agoMerge "Upgrading XACML jar"
Jorge Hernandez [Fri, 9 Feb 2018 15:53:13 +0000 (15:53 +0000)]
Merge "Upgrading XACML jar"

6 years agoMerge "Added JUNITS for ONAP-REST Component"
Jorge Hernandez [Fri, 9 Feb 2018 14:55:18 +0000 (14:55 +0000)]
Merge "Added JUNITS for ONAP-REST Component"

6 years agoUpgrading XACML jar 91/31091/1
Pamela Dragosh [Fri, 9 Feb 2018 14:50:17 +0000 (09:50 -0500)]
Upgrading XACML jar

XACML was released with minor fixes for XML files with comments. Mainly
it contained upgrade to dependencies that had fixed security issues. One
still remains but will not be able to be fixed.

Issue-ID: POLICY-617
Change-Id: Ib143c87156ed6a15cf4f0fe0ecbedb2407ca5b0d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoAdded JUNITS for ONAP-REST Component 79/30979/1
rb7147 [Fri, 9 Feb 2018 05:04:44 +0000 (00:04 -0500)]
Added JUNITS for ONAP-REST Component

Added JUnits for all Pojo classes.

Issue-ID: POLICY-338
Change-Id: I0142903899f0793a8e147a01aeea83d467e49981
Signed-off-by: rb7147 <rb7147@att.com>