From: Matthieu Cauffiez <matthieu.cauffiez@bell.ca>
Date: Mon, 1 Apr 2019 19:40:00 +0000 (-0400)
Subject: fix typo that can lead on bugs
X-Git-Tag: 1.4.0~17^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=policy%2Fengine.git;a=commitdiff_plain;h=0beaee1addfeaa0e4a8fb74e2659e890e36f1b45;hp=6da5838f43a4bf0dc8786c539f9a9aa521139e55

fix typo that can lead on bugs

string xacmlId doesn t correspond to
anything in DecisionSettings
same for shotname in functionDefinition

Issue-ID: POLICY-1250
Change-Id: I7ac457666f341b50c761dbdabf806fa7efece5a9
Signed-off-by: Matthieu Cauffiez <matthieu.cauffiez@bell.ca>
---

diff --git a/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/DecisionPolicy.java b/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/DecisionPolicy.java
index 3a18504d0..a254f7ad0 100644
--- a/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/DecisionPolicy.java
+++ b/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/DecisionPolicy.java
@@ -457,7 +457,7 @@ public class DecisionPolicy extends Policy {
     }
 
     private DecisionSettings findDecisionSettingsBySettingId(String settingId) {
-        return (DecisionSettings) commonClassDao.getEntityItem(DecisionSettings.class, "xacmlId", settingId);
+        return (DecisionSettings) commonClassDao.getEntityItem(DecisionSettings.class, "xacml_id", settingId);
     }
 
     private void createRule(PolicyType decisionPolicy, boolean permitRule) {
@@ -873,7 +873,7 @@ public class DecisionPolicy extends Policy {
 
     public String getFunctionDefinitionId(String key) {
         FunctionDefinition object =
-                (FunctionDefinition) commonClassDao.getEntityItem(FunctionDefinition.class, "shortname", key);
+                (FunctionDefinition) commonClassDao.getEntityItem(FunctionDefinition.class, "short_name", key);
         if (object != null) {
             return object.getXacmlid();
         }