Code Review / policy / engine.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 7a2924a) | patch
Addressing Technical Debt for POLICY-SDK-APP 45/28945/1
authorPamela Dragosh <pdragosh@research.att.com>
Tue, 23 Jan 2018 15:58:28 +0000 (10:58 -0500)
committerPamela Dragosh <pdragosh@research.att.com>
Tue, 23 Jan 2018 16:52:42 +0000 (11:52 -0500)
commita6b8bc8875402ab721a8529926d01b2565d0f595
treee0badb0e675eb93605b815426a9868c011440d73tree | snapshot
parent7a2924a2209bce7b0c578b67fd2310d12ccdb1f7commit | diff
Addressing Technical Debt for POLICY-SDK-APP

* Using booleans true and false
* Using already predefined static strings
* Adding private constructors to hide implicit
* Adding empty constructor comment to satisfy SONAR
* Using single quotes for indexOf to use faster method
* Preferred use of .isEmpty()
* Ordering of public static synchronized syntax
* Removing commented out code
* Using an already defined constant
* Unnecessary declaration of runtime exceptions
* Unnecessary casts
* Unused variables and imports
* Unnecessary use of toString()
* Just using return vs storing into a local var and returning that
* Extra semicolons

Issue-ID: POLICY-482
Change-Id: I6b9dcc5211dd52895a8787239b9df3059928fa45
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
27 files changed:
POLICY-SDK-APP/src/main/java/org/onap/policy/admin/CheckPDP.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyAdapter.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyManagerServlet.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyNotificationMail.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyRestController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/admin/RESTfulPAPEngine.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/components/HumanPolicyComponent.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/ActionPolicyController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/AutoPushController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSParamController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSRawController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateDcaeMicroServiceController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateFirewallController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DashboardController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PDPController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyExportAndImportController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyRolesController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/daoImp/CommonClassDaoImpl.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/daoImp/SystemLogDbDaoImpl.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/model/PDPGroupContainer.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/model/PDPPolicyContainer.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/model/Roles.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/utils/PolicyContainer.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/utils/PolicyItemSetChangeNotifier.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/utils/XACMLPolicyWriterWithPapNotify.java diff | blob | history
-- Archived 06/09/2021