Fix technical debt and reduce lines 51/29651/1
authorPamela Dragosh <pdragosh@research.att.com>
Tue, 30 Jan 2018 13:28:25 +0000 (08:28 -0500)
committerPamela Dragosh <pdragosh@research.att.com>
Tue, 30 Jan 2018 13:32:10 +0000 (08:32 -0500)
commit3ee17bad27b036a9e4ca6e50a7fbdfe2ed0a8e7f
tree3cce5097dc94fcc40ff59c57e2a3287946f72271
parentb65e96826d7339ce29ddb73e3ed6775bd4f54753
Fix technical debt and reduce lines

Focused on iterating over entrySet along with more fixes for
dead stores, unnecessary exceptions. I'm also starting to work
on reducing the number of code lines.

* Iterate using entrySet
* Remove useless assignments
* Unnecessary exceptions
* Use StringBuilder instead of StringBuffer due to synchronization
* Potential null exceptions being thrown
* Returning a empty collection vs null

Issue-ID: POLICY-482
Change-Id: If6ac8e812237f37b2b10c534535df4090a5073dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyAdapter.java
POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyRestController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/ActionPolicyController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateDcaeMicroServiceController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateFirewallController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/daoImp/CommonClassDaoImpl.java
POLICY-SDK-APP/src/main/java/org/onap/policy/utils/ConfigurableRESTUtils.java