Fixes for sonar critical issues 07/8307/4
authorTej, Tarun <tt3868@att.com>
Tue, 22 Aug 2017 00:00:50 +0000 (20:00 -0400)
committerTarun Tej Velaga <tt3868@att.com>
Wed, 23 Aug 2017 17:29:35 +0000 (17:29 +0000)
commit80f072f60509ef3a35369a60857fe05f6c2a993a
tree7dca6266b225be3f192623fdc859ca80f4d1d493
parentc53fa990ea27ec074859eb94bcb7ec6deaa2157b
Fixes for sonar critical issues

Fixes for critical and blocker issues reported in sonar.

Issue-Id: POLICY-113
Change-Id: I50969fe93a94b0497f3fb30864a6c45e63208fe6
Signed-off-by: Tej, Tarun <tt3868@att.com>
80 files changed:
BRMSGateway/src/main/java/org/onap/policy/brmsInterface/BRMSGateway.java
BRMSGateway/src/main/java/org/onap/policy/brmsInterface/BRMSHandler.java
BRMSGateway/src/main/java/org/onap/policy/brmsInterface/BRMSPush.java
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/XACMLPapServlet.java
ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/PapUrlResolver.java
ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/XACMLPdpServlet.java
ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/api/services/PAPServices.java
ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/api/services/PDPServices.java
ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/api/services/PolicyEngineImportService.java
ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/notifications/ManualNotificationUpdateThread.java
ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/notifications/NotificationController.java
ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/notifications/NotificationServer.java
ONAP-PDP-REST/src/test/java/org/onap/policy/pdp/rest/api/test/PolicyEngineServicesTest.java
ONAP-PDP-REST/src/test/resources/notification.xacml.pdp.properties [new file with mode: 0644]
ONAP-REST/src/main/java/org/onap/policy/rest/XACMLRestProperties.java
ONAP-REST/src/main/java/org/onap/policy/rest/XacmlAdminAuthorization.java
ONAP-REST/src/main/java/org/onap/policy/rest/jpa/PolicyEntity.java
ONAP-REST/src/main/java/org/onap/policy/rest/jpa/PolicyManagement.java
ONAP-REST/src/main/java/org/onap/policy/rest/util/Webapps.java
ONAP-SDK-APP/src/main/java/org/openecomp/portalapp/conf/ExternalAppConfig.java
ONAP-SDK-APP/src/main/java/org/openecomp/portalapp/login/LoginStrategyImpl.java
ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdEngine.java
ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPAPPolicy.java
ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDP.java
ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPGroup.java
ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPItemSetChangeNotifier.java
ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPStatus.java
POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyRestController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/ActionPolicyController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/AdminTabController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/AutoPushController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateClosedLoopFaultController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateDcaeMicroServiceController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreatePolicyController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PDPController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyExportAndImportController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyNotificationController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyValidationController.java
POLICY-SDK-APP/src/main/java/org/onap/policy/daoImp/CommonClassDaoImpl.java
POLICY-SDK-APP/src/main/java/org/onap/policy/model/PDPGroupContainer.java
POLICY-SDK-APP/src/main/java/org/onap/policy/model/PDPPolicyContainer.java
PolicyEngineAPI/src/main/java/org/onap/policy/std/AutoClientDMAAP.java
PolicyEngineAPI/src/main/java/org/onap/policy/std/AutoClientEnd.java
PolicyEngineAPI/src/main/java/org/onap/policy/std/AutoClientUEB.java
PolicyEngineAPI/src/main/java/org/onap/policy/std/ManualClientEnd.java
PolicyEngineAPI/src/main/java/org/onap/policy/std/ManualClientEndUEB.java
PolicyEngineAPI/src/main/java/org/onap/policy/std/NotificationUnMarshal.java
PolicyEngineAPI/src/main/java/org/onap/policy/std/StdPolicyEngine.java
PolicyEngineAPI/src/test/java/org/onap/policy/std/test/AutoClientUEBTest.java
PolicyEngineAPI/src/test/java/org/onap/policy/test/ActionPolicyApiTest.java
PolicyEngineAPI/src/test/java/org/onap/policy/test/ConfigBasePolicyTest.java
PolicyEngineAPI/src/test/java/org/onap/policy/test/ConfigFirewallPolicyTest.java
PolicyEngineAPI/src/test/java/org/onap/policy/test/DecisionPolicyApiTest.java
PolicyEngineAPI/src/test/java/org/onap/policy/test/PolicyEngineInterfaceTest.java
PolicyEngineClient/pom.xml
PolicyEngineClient/src/test/java/org/onap/policyengine/ActionPolicyClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/ActionPolicyClient.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/BrmsParamPolicyClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/BrmsParamPolicyClient.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/BrmsRawPolicyClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/BrmsRawPolicyClient.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/ClosedLoopPolicyClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/ClosedLoopPolicyClient.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/ClosedLoopPolicyPerformanceMetricClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/ClosedLoopPolicyPerformanceMetricClient.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/ConfigBasePolicyClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/ConfigBasePolicyClient.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/ConfigFirewallPolicyClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/ConfigFirewallPolicyClient.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/DecisionPolicyClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/DecisionPolicyClient.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/DeletePolicyClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/DeletePolicyClient.java with 98% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/GeneralTestClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/GeneralTestClient.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/GetConfigSample.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/GetConfigSample.java with 98% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/Handler.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/Handler.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/ImportBRMSTemplate.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/ImportBRMSTemplate.java with 97% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/ImportMicroServiceClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/ImportMicroServiceClient.java with 98% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/ListConfigPoliciesClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/ListConfigPoliciesClient.java with 98% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/MainClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/MainClient.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/MicroServicesPolicyClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/MicroServicesPolicyClient.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/PolicyEngineTestClient.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/PolicyEngineTestClient.java with 99% similarity]
PolicyEngineClient/src/test/java/org/onap/policyengine/PushPoliciesToPDP.java [moved from PolicyEngineClient/src/main/java/org/onap/policyEngine/PushPoliciesToPDP.java with 98% similarity]
PolicyEngineUtils/src/main/java/org/onap/policy/utils/BackUpMonitor.java
PolicyEngineUtils/src/main/java/org/onap/policy/utils/BackUpMonitorException.java [new file with mode: 0644]
PolicyEngineUtils/src/main/java/org/onap/policy/utils/BusConsumer.java
PolicyEngineUtils/src/main/java/org/onap/policy/utils/BusPublisher.java
PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java