X-Git-Url: https://gerrit.onap.org/r/gitweb?p=policy%2Fengine.git;a=blobdiff_plain;f=POLICY-SDK-APP%2Fsrc%2Ftest%2Fjava%2Forg%2Fonap%2Fpolicy%2Fcontroller%2FPDPControllerTest.java;h=372090fdfc644b83b8c9489dbef76ca63e0157af;hp=55a2288c70699975178550375b61dedb005f00c1;hb=dbfa1570cd26d19b346287a6fb06f2d8a03f4a06;hpb=073cc188efe9abb4c010cf674e34e2cf46ef1c52

diff --git a/POLICY-SDK-APP/src/test/java/org/onap/policy/controller/PDPControllerTest.java b/POLICY-SDK-APP/src/test/java/org/onap/policy/controller/PDPControllerTest.java
index 55a2288c7..372090fdf 100644
--- a/POLICY-SDK-APP/src/test/java/org/onap/policy/controller/PDPControllerTest.java
+++ b/POLICY-SDK-APP/src/test/java/org/onap/policy/controller/PDPControllerTest.java
@@ -2,14 +2,16 @@
  * ============LICENSE_START=======================================================
  * ONAP Policy Engine
  * ================================================================================
- * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2017, 2019 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Modifications Copyright (C) 2019 Samsung
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -17,8 +19,10 @@
  * limitations under the License.
  * ============LICENSE_END=========================================================
  */
+
 package org.onap.policy.controller;
 
+import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 
 import java.io.UnsupportedEncodingException;
@@ -40,47 +44,50 @@ import org.onap.policy.xacml.std.pap.StdPDPGroup;
 import org.onap.policy.xacml.std.pap.StdPDPGroupStatus;
 import org.springframework.mock.web.MockHttpServletResponse;
 
+public class PDPControllerTest extends Mockito {
+
+    private static Logger logger = FlexLogger.getLogger(PDPControllerTest.class);
+    private Set<OnapPDPGroup> groupsData;
+    private Set<StdPDPGroup> groups;
+    private static List<Object> rolesdata;
 
+    /**
+     * Before.
+     *
+     * @throws Exception Exception
+     */
+    @Before
+    public void setUp() throws Exception {
+        logger.info("setUp: Entering");
+        rolesdata = new ArrayList<>();
+        Roles roles = new Roles();
+        roles.setLoginId("Test");
+        roles.setRole("super-admin");
+        Roles roles1 = new Roles();
+        roles1.setLoginId("Test");
+        roles1.setRole("admin");
+        roles1.setScope("['com','Test']");
+        rolesdata.add(roles);
+        rolesdata.add(roles1);
 
-public class PDPControllerTest extends Mockito{
+        groups = new HashSet<>();
+        StdPDPGroup group = new StdPDPGroup();
+        group.setId("default");
+        group.setDefault(true);
+        group.setName("default");
+        group.setDescription("The default group where new PDP's are put.");
+        group.setStatus(new StdPDPGroupStatus());
+        groups.add(group);
+        groupsData = new HashSet<>();
+        for (OnapPDPGroup g : this.groups) {
+            groupsData.add(g);
+        }
+    }
 
-	private static Logger logger = FlexLogger.getLogger(PDPControllerTest.class);
-	private Set<OnapPDPGroup> groupsData;
-	private Set<StdPDPGroup> groups;
-	private static List<Object> rolesdata;
-	
-	@Before
-	public void setUp() throws Exception{
-		logger.info("setUp: Entering");
-		rolesdata = new ArrayList<>();
-		Roles roles = new Roles();
-		roles.setLoginId("Test");
-		roles.setRole("super-admin");
-		Roles roles1 = new Roles();
-		roles1.setLoginId("Test");
-		roles1.setRole("admin");
-		roles1.setScope("['com','Test']");
-		rolesdata.add(roles);
-		rolesdata.add(roles1);
-		
-		groups = new HashSet<>();
-		StdPDPGroup group = new StdPDPGroup();
-		group.setId("default");
-		group.setDefault(true);
-		group.setName("default");
-		group.setDescription("The default group where new PDP's are put.");
-		group.setStatus(new StdPDPGroupStatus());
-		groups.add(group);
-		groupsData = new HashSet<>();
-		for (OnapPDPGroup g : this.groups) {
-			groupsData.add(g);
-		}
-	}
-	
-	@Test
-	public void testPDPGroupData(){
-		HttpServletRequest request = mock(HttpServletRequest.class);       
-		MockHttpServletResponse response =  new MockHttpServletResponse();
+    @Test
+    public void testPdpGroupData() {
+        final HttpServletRequest request = mock(HttpServletRequest.class);
+        final MockHttpServletResponse response = new MockHttpServletResponse();
         PolicyController controller = mock(PolicyController.class);
         PDPController pdpController = new PDPController();
         pdpController.setJunit(true);;
@@ -89,10 +96,22 @@ public class PDPControllerTest extends Mockito{
         when(controller.getRoles("Test")).thenReturn(rolesdata);
         pdpController.getPDPGroupEntityData(request, response);
         try {
-			assertTrue(response.getContentAsString() != null && response.getContentAsString().contains("data"));
-		} catch (UnsupportedEncodingException e) {
-			logger.error("Exception Occured"+e);
-		}
-	}
+            assertTrue(response.getContentAsString() != null && response.getContentAsString().contains("data"));
+        } catch (UnsupportedEncodingException e) {
+            logger.error("Exception Occured" + e);
+        }
+    }
 
+    @Test
+    public void testPdpData() {
+        PdpData data = new PdpData();
+        data.setId("id");
+        assertEquals("id", data.getId());
+        data.setDescription("foo");
+        assertEquals("foo", data.getDescription());
+        data.setJmxPort(0);
+        assertEquals(0, data.getJmxPort());
+        data.setName("name");
+        assertEquals("name", data.getName());
+    }
 }