X-Git-Url: https://gerrit.onap.org/r/gitweb?p=policy%2Fengine.git;a=blobdiff_plain;f=ONAP-REST%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fpolicy%2Frest%2Futil%2FPolicyValidation.java;h=df4fbf62d14f85deff58874986df0c6509a764bf;hp=e98a41f9e0fcd68bd05558f9db8847d53f17d504;hb=401b48bc573561f097960a9ca7abe6d788456f28;hpb=9301fed7c290f52208922f780fdfe4b5a880b5aa

diff --git a/ONAP-REST/src/main/java/org/onap/policy/rest/util/PolicyValidation.java b/ONAP-REST/src/main/java/org/onap/policy/rest/util/PolicyValidation.java
index e98a41f9e..df4fbf62d 100644
--- a/ONAP-REST/src/main/java/org/onap/policy/rest/util/PolicyValidation.java
+++ b/ONAP-REST/src/main/java/org/onap/policy/rest/util/PolicyValidation.java
@@ -76,7 +76,9 @@ public class PolicyValidation {
 	/*
 	 * This is an empty constructor
 	 */
-	public PolicyValidation(){}	
+	public PolicyValidation(){
+		// Empty constructor
+	}
 	
 	
 	public StringBuilder validatePolicy(PolicyRestAdapter policyData) throws IOException{
@@ -178,17 +180,17 @@ public class PolicyValidation {
 						String configBodyData = policyData.getConfigBodyData();
 						String configType = policyData.getConfigType();
 						if (configType != null) {
-							if (configType.equals("JSON")) {
+							if ("JSON".equals(configType)) {
 								if (!PolicyUtils.isJSONValid(configBodyData)) {
 									responseString.append("Config Body: JSON Content is not valid" + "<br>");
 									valid = false;
 								}
-							} else if (configType.equals("XML")) {
+							} else if ("XML".equals(configType)) {
 								if (!PolicyUtils.isXMLValid(configBodyData)) {
 									responseString.append("Config Body: XML Content data is not valid" + "<br>");
 									valid = false;
 								}
-							} else if (configType.equals("PROPERTIES")) {
+							} else if ("PROPERTIES".equals(configType)) {
 								if (!PolicyUtils.isPropValid(configBodyData)||configBodyData.equals("")) {
 									responseString.append("Config Body: Property data is not valid" + "<br>");
 									valid = false;
@@ -384,8 +386,8 @@ public class PolicyValidation {
 					if(!Strings.isNullOrEmpty(policyData.getServiceType())){
 						pullJsonKeyPairs((JsonNode) policyData.getPolicyJSON());
 
-						String service = null;
-						String version = null;
+						String service;
+						String version;
 						if (policyData.getServiceType().contains("-v")){
 							service = policyData.getServiceType().split("-v")[0];
 							version = policyData.getServiceType().split("-v")[1];
@@ -678,15 +680,17 @@ public class PolicyValidation {
 	}
 
 	protected String emailValidation(String email, String response){
+		String res = response;
 		if(email != null){
 			String validateEmail = PolicyUtils.validateEmailAddress(email.replace("\"", ""));
 			if(!validateEmail.contains(SUCCESS)){
-				response += "<b>Email</b>:<i>" +  validateEmail + HTML_ITALICS_LNBREAK;
-			}else{
+				res  += "<b>Email</b>:<i>" +  validateEmail + HTML_ITALICS_LNBREAK;
+			}
+			else {
 				return SUCCESS;
 			}
 		}
-		return response;
+		return res;
 	}
 
 	private MicroServiceModels getAttributeObject(String name, String version) {