JUnit test for policy/engine PolicyEngineAPI

[policy/engine.git] / PolicyEngineAPI / src / main / java / org / onap / policy / api / PolicyConfigStatus.java

diff --git a/PolicyEngineAPI/src/main/java/org/onap/policy/api/PolicyConfigStatus.java b/PolicyEngineAPI/src/main/java/org/onap/policy/api/PolicyConfigStatus.java
index cee1567..f1bbea1 100644 (file)
--- a/PolicyEngineAPI/src/main/java/org/onap/policy/api/PolicyConfigStatus.java
+++ b/PolicyEngineAPI/src/main/java/org/onap/policy/api/PolicyConfigStatus.java
@@ -23,58 +23,63 @@ package org.onap.policy.api;
 import com.fasterxml.jackson.annotation.JsonCreator;
 
 /**
- * Enumeration of PolicyConfigStatus that can be returned as a part of 
+ * Enumeration of PolicyConfigStatus that can be returned as a part of
  * {@link org.onap.policy.api.PolicyConfig}.
  * 
  * @version 0.1
  */
-public enum PolicyConfigStatus {       
-       /**
-        * Indicates that the Configuration has been successfully retrieved. 
-        */
-       CONFIG_RETRIEVED("retrieved"),
-       /**
-        * Indicates that there is no Configuration Retrieved from PolicyConfig.
-        */
-       CONFIG_NOT_FOUND("not_found"),
-       ;
-       
-       private String name;
-       private PolicyConfigStatus(String name){
-               this.name = name;
-       }
-       
-       /**
-        * Get the <code>PolicyConfigStatus</code> based on <code>String</code> representation of <code>PolicyConfig</code>
-        * 
-        * @param configStatus the <code>String</code> Configuration Status
-        * @return the <code>PolicyConfigResponse</code> with the name matching <code>CONFIG_RETRIEVED</code> or <code>CONFIG_NOT_FOUND</code>
-        * if no match is found
-        */
-       public static PolicyConfigStatus getStatus(String configStatus) {
-               if("retrieved".equalsIgnoreCase(configStatus)) {
-                       return CONFIG_RETRIEVED;
-               }else {
-                       return CONFIG_NOT_FOUND;
-               }
-       }
-       
-       /**
-        * Returns the <code>String</code> name for this <code>PolicyConfigStatus</code>
-        * 
-        * @return the <code>String</code> name for this <code>PolicyConfigStatus</code>
-        */
-       @Override
-       public String toString(){
-               return this.name;
-       }
-       @JsonCreator
-    public static PolicyConfigStatus create (String value) {
-        for(PolicyConfigStatus type: values()){
-            if(type.toString().equals(value) || type.equals(PolicyConfigStatus.valueOf(value))){
+public enum PolicyConfigStatus {
+    /**
+     * Indicates that the Configuration has been successfully retrieved.
+     */
+    CONFIG_RETRIEVED("retrieved"),
+    /**
+     * Indicates that there is no Configuration Retrieved from PolicyConfig.
+     */
+    CONFIG_NOT_FOUND("not_found");
+
+    private final String name;
+
+    private PolicyConfigStatus(final String name) {
+        this.name = name;
+    }
+
+    /**
+     * Get the <code>PolicyConfigStatus</code> based on <code>String</code>
+     * representation of <code>PolicyConfig</code>
+     * 
+     * @param configStatus
+     *            the <code>String</code> Configuration Status
+     * @return the <code>PolicyConfigResponse</code> with the name matching
+     *         <code>CONFIG_RETRIEVED</code> or <code>CONFIG_NOT_FOUND</code> if
+     *         no match is found
+     */
+    public static PolicyConfigStatus getStatus(final String configStatus) {
+        if (CONFIG_RETRIEVED.name.equalsIgnoreCase(configStatus)) {
+            return CONFIG_RETRIEVED;
+        }
+        return CONFIG_NOT_FOUND;
+    }
+
+    /**
+     * Returns the <code>String</code> name for this
+     * <code>PolicyConfigStatus</code>
+     * 
+     * @return the <code>String</code> name for this
+     *         <code>PolicyConfigStatus</code>
+     */
+    @Override
+    public String toString() {
+        return this.name;
+    }
+
+    @JsonCreator
+    public static PolicyConfigStatus create(final String value) {
+        for (final PolicyConfigStatus type : values()) {
+            if (type.toString().equalsIgnoreCase(value) || type.name().equalsIgnoreCase(value)) {
                 return type;
             }
         }
-        throw new IllegalArgumentException();
+        throw new IllegalArgumentException("Invalid value: " + value);
     }
 }