New Optimization Policy
[policy/engine.git] / POLICY-SDK-APP / src / main / java / org / onap / policy / controller / CreateDcaeMicroServiceController.java
index b349ada..0f315a3 100644 (file)
@@ -2,7 +2,7 @@
  * ============LICENSE_START=======================================================
  * ONAP Policy Engine
  * ================================================================================
- * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -24,11 +24,8 @@ package org.onap.policy.controller;
 import java.io.BufferedInputStream;
 import java.io.BufferedOutputStream;
 import java.io.File;
-import java.io.FileInputStream;
-import java.io.FileNotFoundException;
 import java.io.FileOutputStream;
 import java.io.IOException;
-import java.io.InputStream;
 import java.io.OutputStream;
 import java.io.PrintWriter;
 import java.io.StringReader;
@@ -36,7 +33,6 @@ import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Enumeration;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -73,25 +69,23 @@ import org.json.JSONArray;
 import org.json.JSONObject;
 import org.onap.policy.common.logging.flexlogger.FlexLogger;
 import org.onap.policy.common.logging.flexlogger.Logger;
-import org.onap.policy.controller.PolicyController;
 import org.onap.policy.rest.XACMLRestProperties;
 import org.onap.policy.rest.adapter.PolicyRestAdapter;
 import org.onap.policy.rest.dao.CommonClassDao;
 import org.onap.policy.rest.jpa.GroupPolicyScopeList;
 import org.onap.policy.rest.jpa.MicroServiceModels;
+import org.onap.policy.rest.jpa.MicroserviceHeaderdeFaults;
 import org.onap.policy.rest.jpa.PolicyEntity;
 import org.onap.policy.rest.util.MSAttributeObject;
 import org.onap.policy.rest.util.MSModelUtils;
 import org.onap.policy.rest.util.MSModelUtils.MODEL_TYPE;
-import org.openecomp.portalsdk.core.controller.RestrictedBaseController;
-import org.openecomp.portalsdk.core.web.support.JsonMessage;
+import org.onap.portalsdk.core.controller.RestrictedBaseController;
+import org.onap.portalsdk.core.web.support.JsonMessage;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.MediaType;
 import org.springframework.stereotype.Controller;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.servlet.ModelAndView;
-import org.yaml.snakeyaml.Yaml;
-
 import com.att.research.xacml.util.XACMLProperties;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.DeserializationFeature;
@@ -130,18 +124,11 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
        private String directory;
        private List<String> modelList = new ArrayList<>();
        private List<String> dirDependencyList = new ArrayList<>();
-       private HashMap<String,MSAttributeObject > classMap = new HashMap<>();
-       //Tosca Model related Datastructure. 
+       private LinkedHashMap<String,MSAttributeObject > classMap = new LinkedHashMap<>();
        String referenceAttributes;
        String attributeString;
-       String listConstraints;
-       String subAttributeString;
-       HashMap<String, Object> retmap = new HashMap<>();
-       Set<String> uniqueKeys= new HashSet<>();
-       Set<String> uniqueDataKeys= new HashSet<>();
-       StringBuilder dataListBuffer=new StringBuilder();
-       List<String> dataConstraints= new ArrayList <>();
-       
+       Set<String> allManyTrueKeys= new HashSet <>();
+
        public static final String DATATYPE  = "data_types.policy.data.";
        public static final String PROPERTIES=".properties.";
        public static final String TYPE=".type";
@@ -150,6 +137,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
        public static final String LIST="list";
        public static final String DEFAULT=".default";
        public static final String REQUIRED=".required";
+       public static final String MATCHABLE=".matchable";
        public static final String MANYFALSE=":MANY-false";
        
        
@@ -158,7 +146,9 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                CreateDcaeMicroServiceController.commonClassDao = commonClassDao;
        }
 
-       public CreateDcaeMicroServiceController(){}
+       public CreateDcaeMicroServiceController(){
+               // Empty Constructor
+       }
 
        protected PolicyRestAdapter policyAdapter = null;
        private int priorityCount; 
@@ -175,6 +165,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                        
                        //---replace empty value with the value below before calling decodeContent method.
                        String dummyValue = "*empty-value*" + UUID.randomUUID().toString();
+                       LOGGER.info("dummyValue:" + dummyValue);
                        tempJson = StringUtils.replaceEach(tempJson, new String[]{"\"\""}, new String[]{"\""+dummyValue+"\""});
                        ObjectMapper mapper = new ObjectMapper();
                        JsonNode tempJsonNode = mapper.readTree(tempJson);
@@ -188,8 +179,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
        }
        
        private GroupPolicyScopeList getPolicyObject(String policyScope) {
-               GroupPolicyScopeList groupList= (GroupPolicyScopeList) commonClassDao.getEntityItem(GroupPolicyScopeList.class, "name", policyScope);
-               return groupList;
+               return (GroupPolicyScopeList) commonClassDao.getEntityItem(GroupPolicyScopeList.class, "name", policyScope);
        }
        
        private PolicyRestAdapter constructJson(PolicyRestAdapter policyAdapter, String jsonContent, String dummyValue) {
@@ -258,7 +248,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                return policyAdapter;
        }
        
-       private String removeNullAttributes(String cleanJson) {
+       public String removeNullAttributes(String cleanJson) {
                ObjectMapper mapper = new ObjectMapper();
 
                try {
@@ -274,13 +264,21 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                                final JsonNode value = field.getValue();
                                if("content".equalsIgnoreCase(key)){
                                        String contentStr = value.toString();
-                                   try (JsonReader jsonReader = Json.createReader(new StringReader(contentStr))) {             
-                                       JsonObject jsonContent = jsonReader.readObject();
-                                           removed = removeNull(jsonContent);
-                                           if(!jsonContent.toString().equals(removed.toString())){
-                                               contentChanged = true;  
-                                           }
-                                   }
+                                       try(JsonReader reader = Json.createReader(new StringReader(contentStr))){
+                               JsonObject jsonContent = reader.readObject();                 
+                                                       removed = removeNull(jsonContent);
+                                                       if(!jsonContent.toString().equals(removed.toString())){
+                                                       contentChanged = true;  
+                                               }
+                    }
+
+                                       if  (value==null || value.isNull()){
+                                               ((ObjectNode) returnNode).remove(key);
+                                               remove = true;
+                                       }
+                               }
+                               if (remove){
+                                       cleanJson = returnNode.toString();
                                }
                                if  (value==null || value.isNull()){
                                        ((ObjectNode) returnNode).remove(key);
@@ -375,408 +373,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
            return builder.build();
        }
        
-       // Second index of dot should be returned. 
-       public int stringBetweenDots(String str){
-               String stringToSearch=str;
-               String[]ss=stringToSearch.split("\\.");
-               if(ss!=null){
-                       int len= ss.length;
-                       if(len>2){
-                               uniqueKeys.add(ss[2]);
-                       }
-               }
-               
-               return uniqueKeys.size();
-       }
-       
-       public void stringBetweenDotsForDataFields(String str){
-               String stringToSearch=str;
-               String[]ss=stringToSearch.split("\\.");
-               if(ss!=null){
-                       int len= ss.length;
-
-                       if(len>2){
-                               uniqueDataKeys.add(ss[0]+"%"+ss[2]);
-                       }
-               }
-       }
-       
-       public Map<String, String> load(String fileName) throws IOException { 
-               File newConfiguration = new File(fileName);
-               InputStream is = null;
-               try {
-                       is = new FileInputStream(newConfiguration);
-               } catch (FileNotFoundException e) {
-                       LOGGER.error(e);
-               }
-
-               Yaml yaml = new Yaml();
-               @SuppressWarnings("unchecked")
-               Map<Object, Object> yamlMap = (Map<Object, Object>) yaml.load(is); 
-               StringBuilder sb = new StringBuilder(); 
-               Map<String, String> settings = new HashMap<>(); 
-               if (yamlMap == null) { 
-                       return settings; 
-               } 
-               List<String> path = new ArrayList <>(); 
-               serializeMap(settings, sb, path, yamlMap); 
-               return settings; 
-       } 
-
-       public Map<String, String> load(byte[] source) throws IOException { 
-               Yaml yaml = new Yaml(); 
-               @SuppressWarnings("unchecked")
-               Map<Object, Object> yamlMap = (Map<Object, Object>) yaml.load(Arrays.toString(source)); 
-               StringBuilder sb = new StringBuilder(); 
-               Map<String, String> settings = new HashMap <>(); 
-               if (yamlMap == null) { 
-                       return settings; 
-               } 
-               List<String> path = new ArrayList <>(); 
-               serializeMap(settings, sb, path, yamlMap); 
-               return settings; 
-       } 
-
-       @SuppressWarnings({ "unchecked", "rawtypes" })
-       private void serializeMap(Map<String, String> settings, StringBuilder sb, List<String> path, Map<Object, Object> yamlMap) { 
-               for (Map.Entry<Object, Object> entry : yamlMap.entrySet()) { 
-                       if (entry.getValue() instanceof Map) { 
-                               path.add((String) entry.getKey()); 
-                               serializeMap(settings, sb, path, (Map<Object, Object>) entry.getValue()); 
-                               path.remove(path.size() - 1); 
-                       } else if (entry.getValue() instanceof List) { 
-                               path.add((String) entry.getKey()); 
-                               serializeList(settings, sb, path, (List) entry.getValue()); 
-                               path.remove(path.size() - 1); 
-                       } else { 
-                               serializeValue(settings, sb, path, (String) entry.getKey(), entry.getValue()); 
-                       } 
-               } 
-       } 
-
-       @SuppressWarnings("unchecked")
-       private void serializeList(Map<String, String> settings, StringBuilder sb, List<String> path, List<String> yamlList) { 
-               int counter = 0; 
-               for (Object listEle : yamlList) { 
-                       if (listEle instanceof Map) { 
-                               path.add(Integer.toString(counter)); 
-                               serializeMap(settings, sb, path, (Map<Object, Object>) listEle); 
-                               path.remove(path.size() - 1); 
-                       } else if (listEle instanceof List) { 
-                               path.add(Integer.toString(counter)); 
-                               serializeList(settings, sb, path, (List<String>) listEle); 
-                               path.remove(path.size() - 1); 
-                       } else { 
-                               serializeValue(settings, sb, path, Integer.toString(counter), listEle); 
-                       } 
-                       counter++; 
-               } 
-       } 
-
-       private void serializeValue(Map<String, String> settings, StringBuilder sb, List<String> path, String name, Object value) { 
-               if (value == null) { 
-                       return; 
-               } 
-               sb.setLength(0); 
-               for (String pathEle : path) { 
-                       sb.append(pathEle).append('.'); 
-               } 
-               sb.append(name); 
-               settings.put(sb.toString(), value.toString()); 
-       } 
-    
-       void parseDataAndPolicyNodes(Map<String,String> map){
-               for(String key:map.keySet()){
-                       if(key.contains("policy.nodes.Root"))
-                       {
-                               continue;
-                       }
-                       else if(key.contains("policy.nodes")){
-                               String wordToFind = "policy.nodes.";
-                               int indexForPolicyNode=key.indexOf(wordToFind);
-                               String subNodeString= key.substring(indexForPolicyNode+13, key.length());
-
-                               stringBetweenDots(subNodeString);
-                       }
-                       else if(key.contains("policy.data")){
-                               String wordToFind="policy.data.";
-                               int indexForPolicyNode=key.indexOf(wordToFind);
-                               String subNodeString= key.substring(indexForPolicyNode+12, key.length());
-
-                               stringBetweenDotsForDataFields(subNodeString);
-                       }
-               }
-       }
-       
-       HashMap<String,String> parseDataNodes(Map<String,String> map){
-               HashMap<String,String> dataMapForJson=new HashMap <>(); 
-               for(String uniqueDataKey: uniqueDataKeys){
-                       if(uniqueDataKey.contains("%")){
-                               String[] uniqueDataKeySplit= uniqueDataKey.split("%");
-                               String findType=DATATYPE+uniqueDataKeySplit[0]+PROPERTIES+uniqueDataKeySplit[1]+TYPE;
-                               String typeValue=map.get(findType);
-                               LOGGER.info(typeValue);
-                               if(typeValue.equalsIgnoreCase(STRING)||
-                                               typeValue.equalsIgnoreCase(INTEGER)
-                                 )
-                               {
-                                       String findDefault=DATATYPE+uniqueDataKeySplit[0]+PROPERTIES+uniqueDataKeySplit[1]+DEFAULT;
-                                       String defaultValue= map.get(findDefault);
-                                       LOGGER.info("defaultValue is:"+ defaultValue);
-                                       
-                                       String findRequired=DATATYPE+uniqueDataKeySplit[0]+PROPERTIES+uniqueDataKeySplit[1]+REQUIRED;
-                                       String requiredValue= map.get(findRequired);
-                                       LOGGER.info("requiredValue is:"+ requiredValue);
-                                       
-                                       StringBuilder attributeIndividualStringBuilder= new StringBuilder();
-                                       attributeIndividualStringBuilder.append(typeValue+":defaultValue-");
-                                       attributeIndividualStringBuilder.append(defaultValue+":required-");
-                                       attributeIndividualStringBuilder.append(requiredValue+MANYFALSE);
-                                       dataMapForJson.put(uniqueDataKey, attributeIndividualStringBuilder.toString());         
-                               }
-                               else if(typeValue.equalsIgnoreCase(LIST)){
-                                       String findList= DATATYPE+uniqueDataKeySplit[0]+PROPERTIES+uniqueDataKeySplit[1]+".entry_schema.type";
-                                       String listValue=map.get(findList);
-                                       if(listValue!=null){
-                                               LOGGER.info("Type of list is:"+ listValue);
-                                               //Its userdefined
-                                               if(listValue.contains(".")){
-                                                       String trimValue=listValue.substring(listValue.lastIndexOf('.')+1);
-                                                       StringBuilder referenceIndividualStringBuilder= new StringBuilder();
-                                                       referenceIndividualStringBuilder.append(trimValue+":MANY-true");
-                                                       dataMapForJson.put(uniqueDataKey, referenceIndividualStringBuilder.toString());
-                                               }//Its string
-                                               else{
-                                                       StringBuilder stringListItems= new StringBuilder();
-                                                       stringListItems.append(uniqueDataKeySplit[1].toUpperCase()+":MANY-false");
-                                                       dataMapForJson.put(uniqueDataKey, stringListItems.toString());
-                                                       dataListBuffer.append(uniqueDataKeySplit[1].toUpperCase()+"=[");
-                                                       for(int i=0;i<10;i++){
-                                                               String findConstraints= DATATYPE+uniqueDataKeySplit[0]+PROPERTIES+uniqueDataKeySplit[1]+".entry_schema.constraints.0.valid_values."+i;
-                                                               String constraintsValue=map.get(findConstraints);
-                                                               LOGGER.info(constraintsValue);
-                                                               if(constraintsValue==null){
-                                                                       break;
-                                                               }
-                                                               else{
-                                                                       dataConstraints.add(constraintsValue);
-                                                                       dataListBuffer.append(constraintsValue+",");
-                                                               }
-                                                       }
-                                                       dataListBuffer.append("]#");
-                                                       
-                                                       LOGGER.info(dataListBuffer);
-                                               }
-                                       }
-                               }
-                               else{
-                                       String findUserDefined="data_types.policy.data."+uniqueDataKeySplit[0]+"."+"properties"+"."+uniqueDataKeySplit[1]+".type";
-                                       String userDefinedValue=map.get(findUserDefined);
-                                       String trimValue=userDefinedValue.substring(userDefinedValue.lastIndexOf('.')+1);
-                                       StringBuilder referenceIndividualStringBuilder= new StringBuilder();
-                                       referenceIndividualStringBuilder.append(trimValue+":MANY-false");
-                                       dataMapForJson.put(uniqueDataKey, referenceIndividualStringBuilder.toString());
-                                       
-                               }
-                       }
-               }
-               return dataMapForJson;
-       }
-       
-       void constructJsonForDataFields(HashMap<String,String> dataMapForJson){
-               HashMap<String,HashMap<String,String>> dataMapKey= new HashMap <>();
-               HashMap<String,String> hmSub;
-               for(Map.Entry<String, String> entry: dataMapForJson.entrySet()){
-                       String uniqueDataKey= entry.getKey();
-                       String[] uniqueDataKeySplit=uniqueDataKey.split("%");
-                       String value= dataMapForJson.get(uniqueDataKey);
-                       if(dataMapKey.containsKey(uniqueDataKeySplit[0])){
-                               hmSub = dataMapKey.get(uniqueDataKeySplit[0]);
-                               hmSub.put(uniqueDataKeySplit[1], value);
-                       }
-                       else{
-                               hmSub=new HashMap <>();
-                               hmSub.put(uniqueDataKeySplit[1], value);
-                       }
-                               
-                       dataMapKey.put(uniqueDataKeySplit[0], hmSub);
-               }
-                               
-               JSONObject mainObject= new JSONObject();
-               JSONObject json;
-               for(Map.Entry<String,HashMap<String,String>> entry: dataMapKey.entrySet()){
-                       String s=entry.getKey();
-                       json= new JSONObject();
-                       HashMap<String,String> jsonHm=dataMapKey.get(s);
-                       for(Map.Entry<String,String> entryMap:jsonHm.entrySet()){
-                               String key=entryMap.getKey();
-                               json.put(key, jsonHm.get(key));
-                       }
-                       mainObject.put(s,json);
-               }       
-               Iterator<String> keysItr = mainObject.keys();
-               while(keysItr.hasNext()) {
-                       String key = keysItr.next();
-                       String value = mainObject.get(key).toString();
-                       retmap.put(key, value);
-               }
-               
-               LOGGER.info("#############################################################################");
-               LOGGER.info(mainObject);
-               LOGGER.info("###############################################################################"); 
-       }
-       
-       
-       HashMap<String,HashMap<String,String>> parsePolicyNodes(Map<String,String> map){
-               HashMap<String,HashMap<String,String>> mapKey= new HashMap <>();
-               for(String uniqueKey: uniqueKeys){
-                       HashMap<String,String> hm;
-
-                       for(Map.Entry<String,String> entry:map.entrySet()){
-                               String key=entry.getKey();
-                               if(key.contains(uniqueKey) && key.contains("policy.nodes")){
-                                       if(mapKey.containsKey(uniqueKey)){
-                                               hm = mapKey.get(uniqueKey);
-                                               String keyStr= key.substring(key.lastIndexOf('.')+1);
-                                               String valueStr= map.get(key);
-                                               if(("type").equals(keyStr)){
-                                                       if(!key.contains("entry_schema"))
-                                                       {
-                                                               hm.put(keyStr,valueStr);
-                                                       }
-                                               }else{
-                                                       hm.put(keyStr,valueStr);
-                                               }
-
-                                       } else {
-                                               hm = new HashMap <>();
-                                               String keyStr= key.substring(key.lastIndexOf('.')+1);
-                                               String valueStr= map.get(key);
-                                               if(("type").equals(keyStr)){
-                                                       if(!key.contains("entry_schema"))
-                                                       {
-                                                               hm.put(keyStr,valueStr);
-                                                       }
-                                               }else{
-                                                       hm.put(keyStr,valueStr);
-                                               }
-                                               mapKey.put(uniqueKey, hm);
-                                       }
-                               }
-                       }
-               }
-               return mapKey;
-       }
-
-       void createAttributes(HashMap<String,HashMap<String,String>> mapKey){
-               StringBuilder attributeStringBuilder= new StringBuilder();
-               StringBuilder referenceStringBuilder= new StringBuilder();
-               StringBuilder listBuffer= new StringBuilder();
-               List<String> constraints= new ArrayList<>();
-               for(Map.Entry<String,HashMap<String,String>> entry: mapKey.entrySet()){
-                       String keySetString= entry.getKey();
-                       HashMap<String,String> keyValues=mapKey.get(keySetString);
-                       if(keyValues.get("type").equalsIgnoreCase(STRING)||
-                                       keyValues.get("type").equalsIgnoreCase(INTEGER)
-                                       ){
-                               StringBuilder attributeIndividualStringBuilder= new StringBuilder();
-                               attributeIndividualStringBuilder.append(keySetString+"=");
-                               attributeIndividualStringBuilder.append(keyValues.get("type")+":defaultValue-");
-                               attributeIndividualStringBuilder.append(keyValues.get("default")+":required-");
-                               attributeIndividualStringBuilder.append(keyValues.get("required")+":MANY-false");
-                               attributeStringBuilder.append(attributeIndividualStringBuilder+",");    
-
-                       }
-                       else if(keyValues.get("type").equalsIgnoreCase(LIST)){
-                               //List Datatype
-                               Set<String> keys= keyValues.keySet();
-                               Iterator<String> itr=keys.iterator();
-                               while(itr.hasNext()){
-                                       String key= itr.next();
-                                       if((!("type").equals(key) ||("required").equals(key)))
-                                       {
-                                               String value= keyValues.get(key);
-                                               //The "." in the value determines if its a string or a user defined type.  
-                                               if (!value.contains(".")){
-                                                       //This is string
-                                                       constraints.add(keyValues.get(key));
-                                               }else{
-                                                       //This is userdefined string
-                                                       String trimValue=value.substring(value.lastIndexOf('.')+1);
-                                                       StringBuilder referenceIndividualStringBuilder= new StringBuilder();
-                                                       referenceIndividualStringBuilder.append(keySetString+"="+trimValue+":MANY-true");
-                                                       referenceStringBuilder.append(referenceIndividualStringBuilder+",");
-                                               }
-                                       }
-                               }
-
-                       }else{
-                               //User defined Datatype. 
-                               String value=keyValues.get("type");
-                               String trimValue=value.substring(value.lastIndexOf('.')+1);
-                               StringBuilder referenceIndividualStringBuilder= new StringBuilder();
-                               referenceIndividualStringBuilder.append(keySetString+"="+trimValue+":MANY-false");
-                               referenceStringBuilder.append(referenceIndividualStringBuilder+",");
-
-                       }
-                       if(constraints!=null &&constraints.isEmpty()==false){
-                               //List handling. 
-                               listBuffer.append(keySetString.toUpperCase()+"=[");
-                               for(String str:constraints){
-                                       listBuffer.append(str+",");
-                               }
-                               listBuffer.append("]#");
-                               LOGGER.info(listBuffer);
-
-
-                               StringBuilder referenceIndividualStringBuilder= new StringBuilder();
-                               referenceIndividualStringBuilder.append(keySetString+"="+keySetString.toUpperCase()+":MANY-false");
-                               referenceStringBuilder.append(referenceIndividualStringBuilder+",");
-                               constraints.clear();
-                       }
-               }
-               
-               dataListBuffer.append(listBuffer);
-               
-
-               LOGGER.info("$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$");
-               LOGGER.info("Whole attribute String is:"+attributeStringBuilder);       
-               LOGGER.info("Whole reference String is:"+referenceStringBuilder);
-               LOGGER.info("List String is:"+listBuffer);
-               LOGGER.info("Data list buffer is:"+dataListBuffer);
-               LOGGER.info("$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$");
-               
-               this.listConstraints=dataListBuffer.toString();
-               this.referenceAttributes=referenceStringBuilder.toString();
-               this.attributeString=attributeStringBuilder.toString();
-       }
-       
-       
-    
-       public void parseTosca (String fileName){
-               Map<String,String> map= new HashMap<>();
-    
-       try {
-                       map=load(fileName);
-                       
-                       parseDataAndPolicyNodes(map);
-                       
-                       HashMap<String,String> dataMapForJson=parseDataNodes(map);
-                       
-                       constructJsonForDataFields(dataMapForJson);     
-                       
-                       HashMap<String,HashMap<String,String>> mapKey= parsePolicyNodes(map);
-                       
-                       createAttributes(mapKey);
-               
-       } catch (IOException e) {
-               LOGGER.error(e);
-       }
-       
-       } 
-
-       private String cleanUPJson(String json) {
+       public String cleanUPJson(String json) {
                String cleanJson = StringUtils.replaceEach(json, new String[]{"\\\\", "\\\\\\", "\\\\\\\\"}, new String[]{"\\", "\\", "\\"});
                cleanJson = StringUtils.replaceEach(cleanJson, new String[]{"\\\\\\"}, new String[]{"\\"});
                cleanJson = StringUtils.replaceEach(cleanJson, new String[]{"\\\\", "[[", "]]"}, new String[]{"\\", "[", "]"});
@@ -794,7 +391,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                return cleanJson;
        }
        
-       private JSONObject decodeContent(JsonNode jsonNode){
+       public JSONObject decodeContent(JsonNode jsonNode){
                Iterator<JsonNode> jsonElements = jsonNode.elements();
                Iterator<String> jsonKeys = jsonNode.fieldNames();
                Map<String,String> element = new TreeMap<>();
@@ -810,19 +407,21 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                JsonNodeFactory nodeFactory = JsonNodeFactory.instance;
                ObjectNode node = nodeFactory.objectNode();
                String prevKey = null;
-               String presKey = null;
-               for(String key: element.keySet()){
+               String presKey;
+               for(Entry<String, String> entry: element.entrySet()){
+                       String key = entry.getKey();
+                       String value = entry.getValue();
                        if(key.contains(".")){
-                               presKey = key.substring(0,key.indexOf("."));
+                               presKey = key.substring(0,key.indexOf('.'));
                        }else if(key.contains("@")){
-                               presKey = key.substring(0,key.indexOf("@"));
+                               presKey = key.substring(0,key.indexOf('@'));
                        }else{
                                presKey = key;
                        }
                        // first check if we are different from old.
                        LOGGER.info(key+"\n");
                        if(jsonArray!=null && jsonArray.length()>0 && key.contains("@") && !key.contains(".") && oldValue!=null){
-                               if(!oldValue.equals(key.substring(0,key.indexOf("@")))){
+                               if(!oldValue.equals(key.substring(0,key.indexOf('@')))){
                                        jsonResult.put(oldValue, jsonArray);
                                        jsonArray = new JSONArray();
                                }
@@ -836,86 +435,62 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                        // 
                        if(key.contains(".")){
                                if(nodeKey==null){
-                                       nodeKey = key.substring(0,key.indexOf("."));
+                                       nodeKey = key.substring(0,key.indexOf('.'));
                                }
-                               if(nodeKey.equals(key.substring(0,key.indexOf(".")))){
-                                       node.put(key.substring(key.indexOf(".")+1), element.get(key));
+                               if(nodeKey.equals(key.substring(0,key.indexOf('.')))){
+                                       node.put(key.substring(key.indexOf('.')+1), value);
                                }else{
                                        if(node.size()!=0){
                                                if(nodeKey.contains("@")){
                                                        if(arryKey==null){
-                                                               arryKey = nodeKey.substring(0,nodeKey.indexOf("@"));
+                                                               arryKey = nodeKey.substring(0,nodeKey.indexOf('@'));
                                                        }
                                                        if(nodeKey.endsWith("@0")){
                                                                isArray = true;
                                                                jsonArray = new JSONArray();
                                                        }
-                                                       if(jsonArray != null && arryKey.equals(nodeKey.substring(0,nodeKey.indexOf("@")))){
+                                                       if(jsonArray != null && arryKey.equals(nodeKey.substring(0,nodeKey.indexOf('@')))){
                                                                jsonArray.put(decodeContent(node));
                                                        } 
-                                                       if((key.contains("@") && !arryKey.equals(key.substring(0,nodeKey.indexOf("@")))) || !key.contains("@")){
+                                                       if((key.contains("@") && !arryKey.equals(key.substring(0,nodeKey.indexOf('@')))) || !key.contains("@")){
                                                                jsonResult.put(arryKey, jsonArray);
                                                                jsonArray = new JSONArray();
                                                        }
-                                                       arryKey = nodeKey.substring(0,nodeKey.indexOf("@"));
+                                                       arryKey = nodeKey.substring(0,nodeKey.indexOf('@'));
                                                }else{
                                                        isArray = false;
                                                        jsonResult.put(nodeKey, decodeContent(node));
                                                }
                                                node = nodeFactory.objectNode();
                                        }
-                                       nodeKey = key.substring(0,key.indexOf("."));
+                                       nodeKey = key.substring(0,key.indexOf('.'));
                                        if(nodeKey.contains("@")){
-                                               arryKey = nodeKey.substring(0,nodeKey.indexOf("@"));
+                                               arryKey = nodeKey.substring(0,nodeKey.indexOf('@'));
                                        }
-                                       node.put(key.substring(key.indexOf(".")+1), element.get(key));
+                                       node.put(key.substring(key.indexOf('.')+1), value);
                                }
-                       }else if(node.size()!=0){
-                               if(nodeKey.contains("@")){
-                                       if(arryKey==null){
-                                               arryKey = nodeKey.substring(0,nodeKey.indexOf("@"));
-                                       }
-                                       if(nodeKey.endsWith("@0")){
-                                               isArray = true;
-                                               jsonArray = new JSONArray();
-                                       }
-                                       if(jsonArray != null && arryKey.equals(nodeKey.substring(0,nodeKey.indexOf("@")))){
-                                               jsonArray.put(decodeContent(node));
-                                       }
-                                       jsonResult.put(arryKey, jsonArray);
-                                       jsonArray = new JSONArray();
-                                       arryKey = nodeKey.substring(0,nodeKey.indexOf("@"));
-                               }else{
-                                       isArray = false;
-                                       jsonResult.put(nodeKey, decodeContent(node));
-                               }
-                               node = nodeFactory.objectNode();
-                               if(key.contains("@")){
-                                       isArray = true;
-                                       if(key.endsWith("@0")|| jsonArray==null){
+                       }else {
+                               if(node.size()!=0){
+                                       if(nodeKey.contains("@")){
+                                               if(arryKey==null){
+                                                       arryKey = nodeKey.substring(0,nodeKey.indexOf('@'));
+                                               }
+                                               if(nodeKey.endsWith("@0")){
+                                                       isArray = true;
+                                                       jsonArray = new JSONArray();
+                                               }
+                                               if(jsonArray != null && arryKey.equals(nodeKey.substring(0,nodeKey.indexOf('@')))){
+                                                       jsonArray.put(decodeContent(node));
+                                               }
+                                               jsonResult.put(arryKey, jsonArray);
                                                jsonArray = new JSONArray();
-                                       }
-                               }else if(!key.contains("@")){
-                                       isArray = false;
-                               }
-                               if(isArray){
-                                       if(oldValue==null){
-                                               oldValue = key.substring(0,key.indexOf("@"));
-                                       }
-                                       if(oldValue!=prevKey){
-                                               oldValue = key.substring(0,key.indexOf("@"));
-                                       }
-                                       if(oldValue.equals(key.substring(0,key.indexOf("@")))){
-                                               jsonArray.put(element.get(key));
+                                               arryKey = nodeKey.substring(0,nodeKey.indexOf('@'));
                                        }else{
-                                               jsonResult.put(oldValue, jsonArray);
-                                               jsonArray = new JSONArray();
+                                               isArray = false;
+                                               jsonResult.put(nodeKey, decodeContent(node));
                                        }
-                                       oldValue = key.substring(0,key.indexOf("@"));
-                               }else{
-                                       jsonResult.put(key, element.get(key));
+                                       node = nodeFactory.objectNode();
                                }
-                       }else{
                                if(key.contains("@")){
                                        isArray = true;
                                        if(key.endsWith("@0")|| jsonArray==null){
@@ -926,20 +501,20 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                                }
                                if(isArray){
                                        if(oldValue==null){
-                                               oldValue = key.substring(0,key.indexOf("@"));
+                                               oldValue = key.substring(0,key.indexOf('@'));
                                        }
                                        if(oldValue!=prevKey){
-                                               oldValue = key.substring(0,key.indexOf("@"));
+                                               oldValue = key.substring(0,key.indexOf('@'));
                                        }
-                                       if(oldValue.equals(key.substring(0,key.indexOf("@")))){
-                                               jsonArray.put(element.get(key));
+                                       if(oldValue.equals(key.substring(0,key.indexOf('@')))){
+                                               jsonArray.put(value);
                                        }else{
                                                jsonResult.put(oldValue, jsonArray);
                                                jsonArray = new JSONArray();
                                        }
-                                       oldValue = key.substring(0,key.indexOf("@"));
+                                       oldValue = key.substring(0,key.indexOf('@'));
                                }else{
-                                       jsonResult.put(key, element.get(key));
+                                       jsonResult.put(key, value);
                                }
                        }
                }
@@ -949,11 +524,11 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                                        jsonArray = new JSONArray();
                                }
                                if(arryKey==null){
-                                       arryKey = nodeKey.substring(0,nodeKey.indexOf("@"));
+                                       arryKey = nodeKey.substring(0,nodeKey.indexOf('@'));
                                }
                                jsonArray.put(decodeContent(node));
                                jsonResult.put(arryKey, jsonArray);
-                               isArray = false;;
+                               isArray = false;
                        }else{
                                jsonResult.put(nodeKey, decodeContent(node));
                        }
@@ -971,14 +546,81 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                JsonNode root = mapper.readTree(request.getReader());
 
                String value = root.get("policyData").toString().replaceAll("^\"|\"$", "");
-               String  servicename = value.toString().split("-v")[0];
+               String  servicename = value.split("-v")[0];
                String version = null;
-               if (value.toString().contains("-v")){
-                       version = value.toString().split("-v")[1];
+               if (value.contains("-v")){
+                       version = value.split("-v")[1];
                }
                MicroServiceModels returnModel = getAttributeObject(servicename, version);
                
-               String jsonModel = createMicroSeriveJson(returnModel);
+               MicroserviceHeaderdeFaults returnHeaderDefauls = getHeaderDefaultsObject(value);
+               JSONObject jsonHdDefaultObj = null;
+               if(returnHeaderDefauls != null){
+                       jsonHdDefaultObj = new JSONObject();
+                       jsonHdDefaultObj.put("onapName", returnHeaderDefauls.getOnapName());
+                       jsonHdDefaultObj.put("guard", returnHeaderDefauls.getGuard());
+                       jsonHdDefaultObj.put("riskLevel", returnHeaderDefauls.getRiskLevel());
+                       jsonHdDefaultObj.put("riskType", returnHeaderDefauls.getRiskType());
+                       jsonHdDefaultObj.put("priority", returnHeaderDefauls.getPriority());
+               }
+               String headDefautlsData = "";
+               if(jsonHdDefaultObj != null){                   
+                       headDefautlsData = jsonHdDefaultObj.toString();
+               }else{
+                       headDefautlsData = "null";
+               }
+               
+               //Get all keys with "MANY-true" defined in their value from subAttribute 
+               Set<String> allkeys = null;
+               if(returnModel.getSub_attributes() != null && !returnModel.getSub_attributes().isEmpty()){
+                       JSONObject json = new JSONObject(returnModel.getSub_attributes());      
+                       getAllKeys(json); 
+                       allkeys = allManyTrueKeys;
+                       allManyTrueKeys = new  HashSet <>();
+                       LOGGER.info("allkeys : " + allkeys);
+               }
+               
+               //Get element order info 
+               String dataOrderInfo = returnModel.getDataOrderInfo();
+               
+               String allManyTrueKeys = "";
+               if(allkeys != null){
+                       allManyTrueKeys = allkeys.toString();
+               }
+               
+               String jsonModel = createMicroSeriveJson(returnModel, allkeys);
+               
+               JSONObject jsonObject = new JSONObject(jsonModel);
+               
+               JSONObject finalJsonObject = null;
+               if(allkeys != null){
+                       Iterator<String> iter = allkeys.iterator();
+                       while(iter.hasNext()){
+                               //Convert to array values for MANY-true keys
+                               finalJsonObject = convertToArrayElement(jsonObject, iter.next());
+                       }
+               }
+
+               if(finalJsonObject != null){
+                   LOGGER.info(finalJsonObject.toString());
+                   jsonModel  = finalJsonObject.toString();
+               }
+               
+               //get all properties with "MANY-true" defined in Ref_attributes
+               Set<String> manyTrueProperties = getManyTrueProperties(returnModel.getRef_attributes());
+               if(manyTrueProperties != null){
+                       JSONObject jsonObj = new JSONObject(jsonModel);
+                       for (String s : manyTrueProperties) {
+                               LOGGER.info(s);
+                               //convert to array element for MANY-true properties
+                               finalJsonObject = convertToArrayElement(jsonObj, s.trim());
+                       }
+                       
+                       if(finalJsonObject != null){
+                           LOGGER.info(finalJsonObject.toString());
+                           jsonModel = finalJsonObject.toString();
+                       }
+               }
                
                response.setCharacterEncoding("UTF-8");
                response.setContentType("application / json");
@@ -986,14 +628,21 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                List<Object>  list = new ArrayList<>();
                PrintWriter out = response.getWriter();
                String responseString = mapper.writeValueAsString(returnModel);
-               JSONObject j = new JSONObject("{dcaeModelData: " + responseString + ",jsonValue: " + jsonModel + "}");
+
+               JSONObject j = null;
+               
+               if("".equals(allManyTrueKeys)){
+                       j = new JSONObject("{dcaeModelData: " + responseString + ",jsonValue: " + jsonModel + ",dataOrderInfo:" + dataOrderInfo + ",headDefautlsData:" + headDefautlsData +"}");        
+               }else{
+                       j = new JSONObject("{dcaeModelData: " + responseString + ",jsonValue: " + jsonModel + ",allManyTrueKeys: " + allManyTrueKeys+",dataOrderInfo:" + dataOrderInfo + ",headDefautlsData:" + headDefautlsData+ "}"); 
+               }
                list.add(j);
                out.write(list.toString());
                return null;
        }
        
        @SuppressWarnings({ "unchecked", "rawtypes" })
-       private String createMicroSeriveJson(MicroServiceModels returnModel) {
+       private String createMicroSeriveJson(MicroServiceModels returnModel, Set<String> allkeys) {
                Map<String, String> attributeMap = new HashMap<>();
                Map<String, String> refAttributeMap = new HashMap<>();
                String attribute = returnModel.getAttributes();
@@ -1023,6 +672,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                }else{
                        subAttributes = "";
                }
+               
                Map gsonObject = (Map) gson.fromJson(subAttributes, Object.class);
                
                JSONObject object = new JSONObject();
@@ -1031,7 +681,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                for (Entry<String, String> keySet : attributeMap.entrySet()){
                        array = new JSONArray();
                        String value = keySet.getValue();
-                       if (keySet.getValue().split("MANY-")[1].equalsIgnoreCase("true")){
+                       if ("true".equalsIgnoreCase(keySet.getValue().split("MANY-")[1])){
                                array.put(value);
                                object.put(keySet.getKey().trim(), array);
                        }else {
@@ -1043,14 +693,14 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                        array = new JSONArray();
                        String value = keySet.getValue().split(":")[0];
                        if (gsonObject.containsKey(value)){
-                               if (keySet.getValue().split("MANY-")[1].equalsIgnoreCase("true")){
+                               if ("true".equalsIgnoreCase(keySet.getValue().split("MANY-")[1])){
                                        array.put(recursiveReference(value, gsonObject, enumAttribute));
                                        object.put(keySet.getKey().trim(), array);
                                }else {
                                        object.put(keySet.getKey().trim(), recursiveReference(value, gsonObject, enumAttribute));
                                }
                        }else {
-                               if (keySet.getValue().split("MANY-")[1].equalsIgnoreCase("true")){
+                               if ("true".equalsIgnoreCase(keySet.getValue().split("MANY-")[1])){
                                        array.put(value.trim());
                                        object.put(keySet.getKey().trim(), array);
                                }else {
@@ -1065,23 +715,23 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
        @SuppressWarnings("unchecked")
        private JSONObject recursiveReference(String name, Map<String,String> subAttributeMap, String enumAttribute) {
                JSONObject object = new JSONObject();
-               Map<String, String> map = new HashMap<>();
+               Map<String, String> map;
                Object returnClass = subAttributeMap.get(name);
                map = (Map<String, String>) returnClass; 
-               JSONArray array = new JSONArray();
+               JSONArray array;
                
                for( Entry<String, String> m:map.entrySet()){  
                        String[] splitValue = m.getValue().split(":");
                        array = new JSONArray();
                        if (subAttributeMap.containsKey(splitValue[0])){
-                               if (m.getValue().split("MANY-")[1].equalsIgnoreCase("true")){
+                               if ("true".equalsIgnoreCase(m.getValue().split("MANY-")[1])){
                                        array.put(recursiveReference(splitValue[0], subAttributeMap, enumAttribute));
                                        object.put(m.getKey().trim(), array);
                                }else {
                                        object.put(m.getKey().trim(), recursiveReference(splitValue[0], subAttributeMap, enumAttribute));
                                }
                        } else{
-                               if (m.getValue().split("MANY-")[1].equalsIgnoreCase("true")){
+                               if ("true".equalsIgnoreCase(m.getValue().split("MANY-")[1])){
                                        array.put(splitValue[0].trim());
                                        object.put(m.getKey().trim(), array);
                                }else {
@@ -1092,6 +742,89 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                
                return object;
        }
+       
+       
+       public static JSONObject convertToArrayElement(JSONObject json, String keyValue) {
+           return convertToArrayElement(json, new HashSet<>(), keyValue);
+       }
+       
+       private static JSONObject convertToArrayElement(JSONObject json, Set<String> keys, String keyValue) {
+           for (String key : json.keySet()) {
+               Object obj = json.get(key);
+               if(key.equals(keyValue.trim())){
+                       if(!(obj instanceof JSONArray)){
+                               JSONArray newJsonArray = new JSONArray();
+                               newJsonArray.put(obj);
+                               json.put(key, newJsonArray);
+                       }
+                       LOGGER.info("key : " + key);
+                       LOGGER.info("obj : " + obj);
+                       LOGGER.info("json.get(key) : " + json.get(key));
+                       LOGGER.info("keyValue : " + keyValue);
+                   keys.addAll(json.keySet());
+                   
+                   return json;
+               }
+
+               if (obj instanceof JSONObject) convertToArrayElement(json.getJSONObject(key), keyValue);            
+           }
+
+           return json;
+       }
+       
+       // call this method to get all MANY-true properties 
+       public static Set<String> getManyTrueProperties(String referAttributes){
+               LOGGER.info("referAttributes : " + referAttributes);
+               Set<String> manyTrueProperties = new HashSet<>();
+               
+               if(referAttributes != null){
+                       String[] referAarray = referAttributes.split(",");
+                       String []element= null;
+                       for(int i=0; i<referAarray.length; i++){
+                               element = referAarray[i].split("=");      
+                               if(element.length > 1 && element[1].contains("MANY-true")){
+                                       manyTrueProperties.add(element[0]);
+                               }
+                       }               
+               }
+               
+               return manyTrueProperties;
+       }
+       
+       //call this method to start the recursive
+       private Set<String> getAllKeys(JSONObject json) {
+           return getAllKeys(json, new HashSet<>());
+       }
+
+       private Set<String> getAllKeys(JSONArray arr) {
+           return getAllKeys(arr, new HashSet<>());
+       }
+
+       private Set<String> getAllKeys(JSONArray arr, Set<String> keys) {
+           for (int i = 0; i < arr.length(); i++) {
+               Object obj = arr.get(i);
+               if (obj instanceof JSONObject) keys.addAll(getAllKeys(arr.getJSONObject(i)));
+               if (obj instanceof JSONArray) keys.addAll(getAllKeys(arr.getJSONArray(i)));
+           }
+
+           return keys;
+       }
+       
+    // this method returns a set of keys with "MANY-true" defined in their value.
+       private Set<String> getAllKeys(JSONObject json, Set<String> keys) {
+           for (String key : json.keySet()) {
+               Object obj = json.get(key);
+               if(obj instanceof String && ((String) obj).contains("MANY-true")){
+                       LOGGER.info("key : " + key);
+                       LOGGER.info("obj : " + obj);
+                       allManyTrueKeys.add(key);
+               }
+               if (obj instanceof JSONObject) keys.addAll(getAllKeys(json.getJSONObject(key)));
+               if (obj instanceof JSONArray) keys.addAll(getAllKeys(json.getJSONArray(key)));
+           }
+
+           return keys;
+       }
 
        
        @RequestMapping(value={"/policyController/getModelServiceVersioneData.htm"}, method={org.springframework.web.bind.annotation.RequestMethod.POST})
@@ -1101,7 +834,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                JsonNode root = mapper.readTree(request.getReader());
 
                String value = root.get("policyData").toString().replaceAll("^\"|\"$", "");
-               String  servicename = value.toString().split("-v")[0];
+               String  servicename = value.split("-v")[0];
                Set<String> returnList = getVersionList(servicename);
                
                response.setCharacterEncoding("UTF-8");
@@ -1117,7 +850,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
        }
 
        private Set<String> getVersionList(String name) {       
-               MicroServiceModels workingModel = new MicroServiceModels();
+               MicroServiceModels workingModel;
                Set<String> list = new HashSet<>();
                List<Object> microServiceModelsData = commonClassDao.getDataById(MicroServiceModels.class, "modelName", name);
                for (int i = 0; i < microServiceModelsData.size(); i++) {
@@ -1151,6 +884,10 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                }
                return workingModel;
        }
+       
+       private MicroserviceHeaderdeFaults getHeaderDefaultsObject(String modelName) {  
+               return (MicroserviceHeaderdeFaults) commonClassDao.getEntityItem(MicroserviceHeaderdeFaults.class, "modelName", modelName);
+       }       
 
        @RequestMapping(value={"/get_DCAEPriorityValues"}, method={org.springframework.web.bind.annotation.RequestMethod.GET} , produces=MediaType.APPLICATION_JSON_VALUE)
        public void getDCAEPriorityValuesData(HttpServletRequest request, HttpServletResponse response){
@@ -1217,28 +954,28 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                                                                                AttributeDesignatorType designator = match.getAttributeDesignator();
                                                                                String attributeId = designator.getAttributeId();
                                                                                // First match in the target is OnapName, so set that value.
-                                                                               if (attributeId.equals("ONAPName")) {
+                                                                               if ("ONAPName".equals(attributeId)) {
                                                                                        policyAdapter.setOnapName(value);
                                                                                }
-                                                                               if (attributeId.equals("ConfigName")){
+                                                                               if ("ConfigName".equals(attributeId)){
                                                                                        policyAdapter.setConfigName(value);
                                                                                }
-                                                                               if (attributeId.equals("uuid")){
+                                                                               if ("uuid".equals(attributeId)){
                                                                                        policyAdapter.setUuid(value);
                                                                                }
-                                                                               if (attributeId.equals("location")){
+                                                                               if ("location".equals(attributeId)){
                                                                                        policyAdapter.setLocation(value);
                                                                                }
-                                                                               if (attributeId.equals("RiskType")){
+                                                                               if ("RiskType".equals(attributeId)){
                                                                                        policyAdapter.setRiskType(value);
                                                                                }
-                                                                               if (attributeId.equals("RiskLevel")){
+                                                                               if ("RiskLevel".equals(attributeId)){
                                                                                        policyAdapter.setRiskLevel(value);
                                                                                }
-                                                                               if (attributeId.equals("guard")){
+                                                                               if ("guard".equals(attributeId)){
                                                                                        policyAdapter.setGuard(value);
                                                                                }
-                                                                               if (attributeId.equals("TTLDate") && !value.contains("NA")){
+                                                                               if ("TTLDate".equals(attributeId) && !value.contains("NA")){
                                                                                        PolicyController controller = new PolicyController();
                                                                                        String newDate = controller.convertDate(value);
                                                                                        policyAdapter.setTtlDate(newDate);
@@ -1269,7 +1006,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                String policyScopeName = null;
                ObjectMapper mapper = new ObjectMapper();
                try {
-                       DCAEMicroServiceObject msBody = (DCAEMicroServiceObject) mapper.readValue(entity.getConfigurationData().getConfigBody(), DCAEMicroServiceObject.class);
+                       DCAEMicroServiceObject msBody = mapper.readValue(entity.getConfigurationData().getConfigBody(), DCAEMicroServiceObject.class);
                        policyScopeName = getPolicyScope(msBody.getPolicyScope());
                        policyAdapter.setPolicyScope(policyScopeName);
 
@@ -1294,16 +1031,16 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
 
        }
 
-       @SuppressWarnings({ "rawtypes", "unchecked" })
-       private void readRecursivlyJSONContent(LinkedHashMap<String, ?> map, LinkedHashMap<String, Object> data){
+       @SuppressWarnings({ "rawtypes", "unchecked" }) 
+       public void readRecursivlyJSONContent(LinkedHashMap<String, ?> map, LinkedHashMap<String, Object> data){
                for (Iterator iterator = map.keySet().iterator(); iterator.hasNext();) {
                        Object key =  iterator.next();
                        Object value = map.get(key);
                        if(value instanceof LinkedHashMap<?, ?>){
                                LinkedHashMap<String, Object> secondObjec = new LinkedHashMap<>(); 
                                readRecursivlyJSONContent((LinkedHashMap<String, ?>) value, secondObjec);
-                               for(String objKey: secondObjec.keySet()){
-                                       data.put(key+"." +objKey, secondObjec.get(objKey));
+                               for( Entry<String, Object> entry : secondObjec.entrySet()){
+                                       data.put(key+"." + entry.getKey(), entry.getValue());
                                }
                        }else if(value instanceof ArrayList){
                                ArrayList<?> jsonArrayVal = (ArrayList<?>)value;
@@ -1312,8 +1049,8 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                                        if(arrayvalue instanceof LinkedHashMap<?, ?>){
                                                LinkedHashMap<String, Object> newData = new LinkedHashMap<>();   
                                                readRecursivlyJSONContent((LinkedHashMap<String, ?>) arrayvalue, newData);
-                                               for(String objKey: newData.keySet()){
-                                                       data.put(key+"@"+i+"." +objKey, newData.get(objKey));
+                                               for(Entry<String, Object> entry: newData.entrySet()){
+                                                       data.put(key+"@"+i+"." +entry.getKey(), entry.getValue());
                                                }
                                        }else if(arrayvalue instanceof ArrayList){
                                                ArrayList<?> jsonArrayVal1 = (ArrayList<?>)value;
@@ -1331,7 +1068,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                }
        }
 
-       private String getPolicyScope(String value) {
+       public String getPolicyScope(String value) {
                List<Object> groupList= commonClassDao.getDataById(GroupPolicyScopeList.class, "groupList", value);
                if(groupList != null && !groupList.isEmpty()){
                        GroupPolicyScopeList pScope = (GroupPolicyScopeList) groupList.get(0);
@@ -1343,7 +1080,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
        //Convert the map values and set into JSON body
        public Map<String, String> convertMap(Map<String, String> attributesMap, Map<String, String> attributesRefMap) {
                Map<String, String> attribute = new HashMap<>();
-               String temp = null;
+               StringBuilder temp;
                String key;
                String value;
                for (Entry<String, String> entry : attributesMap.entrySet()) {
@@ -1353,12 +1090,12 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                }
                for (Entry<String, String> entryRef : attributesRefMap.entrySet()) {
                        key = entryRef.getKey();
-                       value = entryRef.getValue().toString();
+                       value = entryRef.getValue();
                        attribute.put(key, value);
                }
                for (Entry<String, String> entryList : attributesListRefMap.entrySet()) {
                        key = entryList.getKey();
-                       value = entryList.getValue().toString();
+                       value = entryList.getValue();
                        attribute.put(key, value);
                }
                for (Entry<String, LinkedList<String>> arrayList : arrayTextList.entrySet()){
@@ -1366,9 +1103,10 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                        temp = null;
                        for (Object textList : arrayList.getValue()){
                                if (temp == null){
-                                       temp = "[" + textList;
+                                       temp = new StringBuilder();
+                                       temp.append("[" + textList);
                                }else{
-                                       temp = temp + "," + textList;
+                                       temp.append("," + textList);
                                }
                        }
                        attribute.put(key, temp+ "]");                  
@@ -1381,15 +1119,11 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
        public void SetMSModelData(HttpServletRequest request, HttpServletResponse response) throws IOException, FileUploadException{
                modelList = new ArrayList<>();
                dirDependencyList = new ArrayList<>();
-               classMap = new HashMap<>();
-               retmap = new HashMap<>();
-               uniqueKeys= new HashSet<>();
-               uniqueDataKeys= new HashSet<>();
-               dataListBuffer=new StringBuilder();
-               dataConstraints= new ArrayList <>();
+               classMap = new LinkedHashMap<>();
                List<FileItem> items = new ServletFileUpload(new DiskFileItemFactory()).parseRequest(request);
                boolean zip = false;
                boolean yml= false;
+               String errorMsg = "";
                for (FileItem item : items) {
                        if(item.getName().endsWith(".zip") || item.getName().endsWith(".xmi")||item.getName().endsWith(".yml")){
                                this.newModel = new MicroServiceModels();
@@ -1399,43 +1133,61 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                                        IOUtils.copy(item.getInputStream(), outputStream);
                                        outputStream.close();
                                        this.newFile = file.toString();
-                                       this.newModel.setModelName(this.newFile.toString().split("-v")[0]);
+                                       this.newModel.setModelName(this.newFile.split("-v")[0]);
                                
-                                       if (this.newFile.toString().contains("-v")){
+                                       if (this.newFile.contains("-v")){
                                                if (item.getName().endsWith(".zip")){
-                                                       this.newModel.setVersion(this.newFile.toString().split("-v")[1].replace(".zip", ""));
+                                                       this.newModel.setVersion(this.newFile.split("-v")[1].replace(".zip", ""));
                                                        zip = true;
                                                }else if(item.getName().endsWith(".yml")){
-                                                       this.newModel.setVersion(this.newFile.toString().split("-v")[1].replace(".yml", ""));
+                                                       this.newModel.setVersion(this.newFile.split("-v")[1].replace(".yml", ""));
                                                        yml = true;
                                                }
                                                else {
-                                                       this.newModel.setVersion(this.newFile.toString().split("-v")[1].replace(".xmi", ""));
+                                                       this.newModel.setVersion(this.newFile.split("-v")[1].replace(".xmi", ""));
                                                }
-                                       }
-                               
+                                       }                               
                                }catch(Exception e){
-                                       LOGGER.error("Upload error : " + e);
+                                       LOGGER.error("Upload error : ", e);
+                                       errorMsg = "Upload error:" + e.getMessage();
                                }
                        }
                        
                }
-               List<File> fileList = new ArrayList<>();;
+               
+               if(!errorMsg.isEmpty()){
+                       
+                       PrintWriter out = response.getWriter();
+                       
+                       response.setCharacterEncoding("UTF-8");
+                       response.setContentType("application / json");
+                       request.setCharacterEncoding("UTF-8");
+
+                       JSONObject j = new JSONObject();
+                       j.put("errorMsg", errorMsg);
+                       out.write(j.toString());
+                       return;
+               }
+               
+               List<File> fileList = new ArrayList<>();
+               MSModelUtils msMLUtils =  new MSModelUtils();
                this.directory = "model";
                if (zip){
                        extractFolder(this.newFile);
                        fileList = listModelFiles(this.directory);
                }else if (yml==true){
-                       parseTosca(this.newFile);
+                       
+                       msMLUtils.parseTosca(this.newFile);
+                       
                }else {
                        File file = new File(this.newFile);
                        fileList.add(file);
                }
                String modelType= "";
-               if(yml==false){
+               if(!yml){
                        modelType="xmi";
                        //Process Main Model file first
-                       classMap = new HashMap<>();
+                       classMap = new LinkedHashMap<>();
                        for (File file : fileList) {
                                if(!file.isDirectory() && file.getName().endsWith(".xmi")){
                        retreiveDependency(file.toString(), true);
@@ -1453,20 +1205,22 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                        MSAttributeObject msAttributes= new MSAttributeObject();
                        msAttributes.setClassName(className);
                        
-                       HashMap<String, String> returnAttributeList =new HashMap<>();
-                       returnAttributeList.put(className, this.attributeString);
+                       LinkedHashMap<String, String> returnAttributeList =new LinkedHashMap<>();
+                       returnAttributeList.put(className, msMLUtils.getAttributeString());
                        msAttributes.setAttribute(returnAttributeList);
                        
-                       msAttributes.setSubClass(this.retmap);
+                       msAttributes.setSubClass(msMLUtils.getRetmap());
+                       
+                       msAttributes.setMatchingSet(msMLUtils.getMatchableValues());
                        
-                       HashMap<String, String> returnReferenceList =new HashMap<>();
-                       //String[] referenceArray=this.referenceAttributes.split("=");
-                       returnReferenceList.put(className, this.referenceAttributes);
+                       LinkedHashMap<String, String> returnReferenceList =new LinkedHashMap<>();
+
+                       returnReferenceList.put(className, msMLUtils.getReferenceAttributes());
                        msAttributes.setRefAttribute(returnReferenceList);
                        
-                       if(this.listConstraints!=""){
-                               HashMap<String, String> enumList =new HashMap<>();
-                               String[] listArray=this.listConstraints.split("#");
+                       if(msMLUtils.getListConstraints()!=""){
+                               LinkedHashMap<String, String> enumList =new LinkedHashMap<>();
+                               String[] listArray=msMLUtils.getListConstraints().split("#");
                 for(String str:listArray){
                     String[] strArr= str.split("=");
                     if(strArr.length>1){
@@ -1476,7 +1230,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                                msAttributes.setEnumType(enumList);
                        }
                        
-                       classMap=new HashMap<>();
+                       classMap=new LinkedHashMap<>();
                        classMap.put(className, msAttributes);
                        
                }
@@ -1492,6 +1246,8 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                j.put("classListDatas", modelList);
                j.put("modelDatas", mapper.writeValueAsString(classMap));
                j.put("modelType", modelType);
+               j.put("dataOrderInfo", msMLUtils.getDataOrderInfo());
+               
                out.write(j.toString());
        }
        
@@ -1503,9 +1259,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
            int BUFFER = 2048;
            File file = new File(zipFile);
 
-           ZipFile zip = null;
-               try {
-                       zip = new ZipFile(file);
+               try (ZipFile zip = new ZipFile(file)) {
                    String newPath =  "model" + File.separator + zipFile.substring(0, zipFile.length() - 4);
                    this.directory = "model" + File.separator + zipFile.substring(0, zipFile.length() - 4);
                    checkZipDirectory(this.directory);
@@ -1525,15 +1279,20 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                        if (!entry.isDirectory()){
                            BufferedInputStream is = new BufferedInputStream(zip.getInputStream(entry));
                            int currentByte;
-                           byte data[] = new byte[BUFFER];
-                           FileOutputStream fos = new FileOutputStream(destFile);
-                           BufferedOutputStream dest = new BufferedOutputStream(fos, BUFFER);
-                           while ((currentByte = is.read(data, 0, BUFFER)) != -1) {
-                               dest.write(data, 0, currentByte);
+                           byte[] data = new byte[BUFFER];
+                           try (FileOutputStream fos = new FileOutputStream(destFile);
+                                       BufferedOutputStream dest = new BufferedOutputStream(fos, BUFFER)) {
+                                   while ((currentByte = is.read(data, 0, BUFFER)) != -1) {
+                                       dest.write(data, 0, currentByte);
+                                   }
+                                   dest.flush();
+                           } catch (IOException e) {
+                               LOGGER.error("Failed to write zip contents to {}" + destFile + e);
+                               //
+                               // PLD should I throw e?
+                               //
+                               throw e;
                            }
-                           dest.flush();
-                           dest.close();
-                           is.close();
                        }
        
                        if (currentEntry.endsWith(".zip")){
@@ -1542,20 +1301,13 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                    }
            } catch (IOException e) {
                LOGGER.error("Failed to unzip model file " + zipFile, e);
-               }finally{
-                       try {
-                               if(zip != null)
-                               zip.close();
-                       } catch (IOException e) {
-                               LOGGER.error("Exception Occured While closing zipfile " + e);
-                       }
                }
        }
        
        private void retreiveDependency(String workingFile, Boolean modelClass) {
                
                MSModelUtils utils = new MSModelUtils(PolicyController.getMsOnapName(), PolicyController.getMsPolicyName());
-           HashMap<String, MSAttributeObject> tempMap = new HashMap<>();
+           Map<String, MSAttributeObject> tempMap;
            
            tempMap = utils.processEpackage(workingFile, MODEL_TYPE.XMI);
            
@@ -1567,9 +1319,9 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
        }
                
        private List<File> listModelFiles(String directoryName) {
-               File directory = new File(directoryName);
+               File fileDirectory = new File(directoryName);
                List<File> resultList = new ArrayList<>();
-               File[] fList = directory.listFiles();
+               File[] fList = fileDirectory.listFiles();
                for (File file : fList) {
                        if (file.isFile()) {
                                resultList.add(file);
@@ -1581,7 +1333,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
                return resultList;
        }
        
-    private void cleanUp(String path) {
+    public void cleanUp(String path) {
         if (path!=null){
             try {
                 FileUtils.forceDelete(new File(path));
@@ -1591,7 +1343,7 @@ public class CreateDcaeMicroServiceController extends RestrictedBaseController {
         }
     }
  
-    private void checkZipDirectory(String zipDirectory) {
+    public void checkZipDirectory(String zipDirectory) {
         Path path = Paths.get(zipDirectory);
  
         if (Files.exists(path)) {