Reduce technical debt

[policy/engine.git] / POLICY-SDK-APP / src / main / java / org / onap / policy / controller / CreateBRMSParamController.java

diff --git a/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSParamController.java b/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSParamController.java
index e578d91..df1ca6a 100644 (file)
--- a/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSParamController.java
+++ b/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSParamController.java
@@ -85,7 +85,9 @@ public class CreateBRMSParamController extends RestrictedBaseController {
                CreateBRMSParamController.commonClassDao = commonClassDao;
        }
 
-       public CreateBRMSParamController(){}
+       public CreateBRMSParamController(){
+               // Empty constructor
+       }
        protected PolicyRestAdapter policyAdapter = null; 
 
        private HashMap<String, String> dynamicLayoutMap;
@@ -185,7 +187,7 @@ public class CreateBRMSParamController extends RestrictedBaseController {
                                String[] components = params.toString().split(":");
                                String caption = "";
                                for (int i = 0; i < components.length; i++) {
-                                       String type = "";
+                                       String type;
                                        if (i == 0) {
                                                caption = components[i];
                                        }
@@ -415,7 +417,7 @@ public class CreateBRMSParamController extends RestrictedBaseController {
                                String[] components = params.toString().split("\\);");
                                if(components!= null && components.length > 0){
                                        for (int i = 0; i < components.length; i++) {
-                                               String value = null;
+                                               String value;
                                                components[i] = components[i]+")";
                                                String caption = components[i].substring(0,
                                                                components[i].indexOf('('));
@@ -456,7 +458,7 @@ public class CreateBRMSParamController extends RestrictedBaseController {
                                policyData.setEditPolicy(true);
                        }
 
-                       String body = "";
+                       String body;
 
                        body = "/* Autogenerated Code Please Don't change/remove this comment section. This is for the UI purpose. \n\t " +
                                        brmsTemplateVlaue + policyData.getRuleName() + "%$> \n */ \n";