Fix Sonar Issues policy/engine POLICY-SDK-APP module

[policy/engine.git] / POLICY-SDK-APP / src / main / java / org / onap / policy / admin / PolicyAdapter.java

diff --git a/POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyAdapter.java b/POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyAdapter.java
index be660c8..b7fbbdd 100644 (file)
--- a/POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyAdapter.java
+++ b/POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyAdapter.java
@@ -4,6 +4,7 @@
  * ================================================================================
  * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
  * Modified Copyright (C) 2018 Samsung Electronics Co., Ltd.
+ * Modifications Copyright (C) 2019 Bell Canada
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -40,7 +41,7 @@ import com.att.research.xacml.util.XACMLProperties;
 
 public class PolicyAdapter {
 
-    private static final Logger LOGGER = FlexLogger.getLogger(PolicyAdapter.class);
+    private static final Logger LOGGER = FlexLogger.getLogger(PolicyAdapter.class);
 
     public void configure(PolicyRestAdapter policyAdapter, PolicyEntity entity) {
         String policyNameValue = policyAdapter.getPolicyName().substring(0, policyAdapter.getPolicyName().indexOf('_'));
@@ -50,77 +51,70 @@ public class PolicyAdapter {
         if (configPolicyName != null) {
             policyAdapter.setConfigPolicyType(configPolicyName);
         }
-
-        if("Action".equalsIgnoreCase(policyAdapter.getPolicyType())){
+        if ("Action".equalsIgnoreCase(policyAdapter.getPolicyType())) {
             new ActionPolicyController().prePopulateActionPolicyData(policyAdapter, entity);
         }
-        if("Decision".equalsIgnoreCase(policyAdapter.getPolicyType())){
+        if ("Decision".equalsIgnoreCase(policyAdapter.getPolicyType())) {
             new DecisionPolicyController().prePopulateDecisionPolicyData(policyAdapter, entity);
         }
-        if("Config".equalsIgnoreCase(policyAdapter.getPolicyType())){
+        if ("Config".equalsIgnoreCase(policyAdapter.getPolicyType())) {
             prePopulatePolicyData(policyAdapter, entity);
         }
     }
 
     private String getConfigPolicyName(PolicyRestAdapter policyAdapter) {
-        String configPolicyName = null ;
-        if(policyAdapter.getPolicyName().startsWith("Config_PM")){
+        String configPolicyName = null;
+        if (policyAdapter.getPolicyName().startsWith("Config_PM")) {
             configPolicyName = "ClosedLoop_PM";
-        }else if(policyAdapter.getPolicyName().startsWith("Config_Fault")){
+        } else if (policyAdapter.getPolicyName().startsWith("Config_Fault")) {
             configPolicyName = "ClosedLoop_Fault";
-        }else if(policyAdapter.getPolicyName().startsWith("Config_FW")){
+        } else if (policyAdapter.getPolicyName().startsWith("Config_FW")) {
             configPolicyName = "Firewall Config";
-        }else if(policyAdapter.getPolicyName().startsWith("Config_BRMS_Raw")){
+        } else if (policyAdapter.getPolicyName().startsWith("Config_BRMS_Raw")) {
             configPolicyName = "BRMS_Raw";
-        }else if(policyAdapter.getPolicyName().startsWith("Config_BRMS_Param")){
+        } else if (policyAdapter.getPolicyName().startsWith("Config_BRMS_Param")) {
             configPolicyName = "BRMS_Param";
-        }else if(policyAdapter.getPolicyName().startsWith("Config_MS")){
+        } else if (policyAdapter.getPolicyName().startsWith("Config_MS")) {
             configPolicyName = "Micro Service";
-        }else if(policyAdapter.getPolicyName().startsWith("Config_OOF")){
+        } else if (policyAdapter.getPolicyName().startsWith("Config_OOF")) {
             configPolicyName = "Optimization";
-        }else if(policyAdapter.getPolicyName().startsWith("Action") || policyAdapter.getPolicyName().startsWith("Decision") ){
+        } else if (policyAdapter.getPolicyName().startsWith("Action") || policyAdapter.getPolicyName()
+            .startsWith("Decision")) {
             // No configPolicyName is applicable
-        }else{
+        } else {
             configPolicyName = "Base";
         }
         return configPolicyName;
     }
 
     private void prePopulatePolicyData(PolicyRestAdapter policyAdapter, PolicyEntity entity) {
-        if("Base".equalsIgnoreCase(policyAdapter.getConfigPolicyType())){
+        if ("Base".equalsIgnoreCase(policyAdapter.getConfigPolicyType())) {
             new CreatePolicyController().prePopulateBaseConfigPolicyData(policyAdapter, entity);
-        }
-        else if("BRMS_Raw".equalsIgnoreCase(policyAdapter.getConfigPolicyType())){
+        } else if ("BRMS_Raw".equalsIgnoreCase(policyAdapter.getConfigPolicyType())) {
             new CreateBRMSRawController().prePopulateBRMSRawPolicyData(policyAdapter, entity);
-        }
-        else if("BRMS_Param".equalsIgnoreCase(policyAdapter.getConfigPolicyType())){
+        } else if ("BRMS_Param".equalsIgnoreCase(policyAdapter.getConfigPolicyType())) {
             new CreateBRMSParamController().prePopulateBRMSParamPolicyData(policyAdapter, entity);
-        }
-        else if("ClosedLoop_Fault".equalsIgnoreCase(policyAdapter.getConfigPolicyType())){
+        } else if ("ClosedLoop_Fault".equalsIgnoreCase(policyAdapter.getConfigPolicyType())) {
             new CreateClosedLoopFaultController().prePopulateClosedLoopFaultPolicyData(policyAdapter, entity);
-        }
-        else if("ClosedLoop_PM".equalsIgnoreCase(policyAdapter.getConfigPolicyType())){
+        } else if ("ClosedLoop_PM".equalsIgnoreCase(policyAdapter.getConfigPolicyType())) {
             new CreateClosedLoopPMController().prePopulateClosedLoopPMPolicyData(policyAdapter, entity);
-        }
-        else if("Micro Service".equalsIgnoreCase(policyAdapter.getConfigPolicyType())){
+        } else if ("Micro Service".equalsIgnoreCase(policyAdapter.getConfigPolicyType())) {
             new CreateDcaeMicroServiceController().prePopulateDCAEMSPolicyData(policyAdapter, entity);
-        }
-        else if("Optimization".equalsIgnoreCase(policyAdapter.getConfigPolicyType())){
+        } else if ("Optimization".equalsIgnoreCase(policyAdapter.getConfigPolicyType())) {
             new CreateOptimizationController().prePopulatePolicyData(policyAdapter, entity);
-        }
-        else if("Firewall Config".equalsIgnoreCase(policyAdapter.getConfigPolicyType())){
+        } else if ("Firewall Config".equalsIgnoreCase(policyAdapter.getConfigPolicyType())) {
             new CreateFirewallController().prePopulateFWPolicyData(policyAdapter, entity);
         }
     }
 
     public static PolicyAdapter getInstance() {
         try {
-            Class<?> policyAdapter = Class.forName(XACMLProperties.getProperty("policyAdapter.impl.className", PolicyAdapter.class.getName()));
+            Class<?> policyAdapter = Class
+                .forName(XACMLProperties.getProperty("policyAdapter.impl.className", PolicyAdapter.class.getName()));
             return (PolicyAdapter) policyAdapter.newInstance();
         } catch (ClassNotFoundException | InstantiationException | IllegalAccessException | IllegalArgumentException e) {
-            LOGGER.error("Exception Occured"+e);
+            LOGGER.error("Exception Occurred" + e);
         }
         return null;
     }
-
-}
\ No newline at end of file
+}