FIX SONAR ISSUE NESTED TRY BLOCKS
[policy/engine.git] / POLICY-SDK-APP / src / main / java / org / onap / policy / admin / CheckPDP.java
index 6433204..be84690 100644 (file)
@@ -57,149 +57,147 @@ import com.att.research.xacml.util.XACMLProperties;
  *
  */
 public class CheckPDP {
-       private static Path pdpPath = null;
-       private static Long oldModified = null;
-       private static HashMap<String, String> pdpMap = null;
-       private static final Logger LOGGER = FlexLogger.getLogger(CheckPDP.class);
-       
-       private CheckPDP(){
-               //default constructor
-       }
-       
-       public static Map<String, String> getPdpMap() {
-               return pdpMap;
-       }
-       
-       private static void reset() {
-               pdpPath = null;
-               oldModified = null;
-               pdpMap = null;
-       }
+    private static Path pdpPath = null;
+    private static Long oldModified = null;
+    private static HashMap<String, String> pdpMap = null;
+    private static final Logger LOGGER = FlexLogger.getLogger(CheckPDP.class);
 
-       public static boolean validateID(String id) {
-               // ReadFile
-               try {
-                       readFile();
-               } catch (Exception e) {
-                       LOGGER.error(XACMLErrorConstants.ERROR_SYSTEM_ERROR + e);
-                       return false;
-               }
-               if (pdpMap == null) {
-                       return false;
-               }
-               // Check ID
-               return pdpMap.containsKey(id);
-       }
+    private CheckPDP(){
+        //default constructor
+    }
 
-       private static void readFile(){
-               String pdpFile = null;
-               try{
-                       pdpFile = XACMLProperties.getProperty(XACMLRestProperties.PROP_PDP_IDFILE);     
-               }catch (Exception e){
-                       LOGGER.error(XACMLErrorConstants.ERROR_DATA_ISSUE + "Cannot read the PDP ID File" + e);
-                       return;
-               }
-               if (pdpFile == null) {
-                       LOGGER.error(XACMLErrorConstants.ERROR_SYSTEM_ERROR + "PDP File name not Valid : " + pdpFile);
-               }
-               if (pdpPath == null) {
-                       pdpPath = Paths.get(pdpFile);
-                       if (!pdpPath.toString().endsWith(".properties") || !pdpPath.toFile().exists()) {
-                               LOGGER.error(XACMLErrorConstants.ERROR_SYSTEM_ERROR + "File doesn't exist in the specified Path : "     + pdpPath.toString());
-                               CheckPDP.reset();
-                               return;
-                       }
-                       readProps();
-               }
-               // Check if File is updated recently
-               else {
-                       Long newModified = pdpPath.toFile().lastModified();
-                       if (!newModified.equals(oldModified)) {
-                               // File has been updated.
-                               readProps();
-                       }
-               }
-       }
+    public static Map<String, String> getPdpMap() {
+        return pdpMap;
+    }
 
-       @SuppressWarnings({ "unchecked", "rawtypes" })
-       private static void readProps() {
-               Properties pdpProp;
-               pdpProp = new Properties();
-               try {
-                       InputStream in = new FileInputStream(pdpPath.toFile());
-                       oldModified = pdpPath.toFile().lastModified();
-                       pdpProp.load(in);
-                       // Read the Properties and Load the PDPs and encoding.
-                       pdpMap = new HashMap<>();
-                       // Check the Keys for PDP_URLs
-                       Collection<Object> unsorted = pdpProp.keySet();
-                       List<String> sorted = new ArrayList(unsorted);
-                       Collections.sort(sorted);
-                       for (String propKey : sorted) {
-                               loadPDPProperties(propKey, pdpProp);
-                       }
-                       in.close();
-               } catch (IOException e) {
-                       LOGGER.error(XACMLErrorConstants.ERROR_SYSTEM_ERROR + e);
-               }
-               if (pdpMap == null || pdpMap.isEmpty()) {
-                       LOGGER.debug(XACMLErrorConstants.ERROR_SYSTEM_ERROR + "Cannot Proceed without PDP_URLs");
-                       CheckPDP.reset();
-               }
-       }
-       
-       private static void loadPDPProperties(String propKey, Properties pdpProp){
-               if (propKey.startsWith("PDP_URL")) {
-                       String checkVal = pdpProp.getProperty(propKey);
-                       if (checkVal == null) {
-                               LOGGER.error("Properties file doesn't have the PDP_URL parameter");
-                       }
-                       if (checkVal != null && checkVal.contains(";")) {
-                               List<String> pdpDefault = new ArrayList<>(Arrays.asList(checkVal.split("\\s*;\\s*")));
-                               int pdpCount = 0;
-                               while (pdpCount < pdpDefault.size()) {
-                                       String pdpVal = pdpDefault.get(pdpCount);
-                                       readPDPParam(pdpVal);
-                                       pdpCount++;
-                               }
-                       }
-               }
-       }
+    private static void reset() {
+        pdpPath = null;
+        oldModified = null;
+        pdpMap = null;
+    }
 
-       private static void readPDPParam(String pdpVal){
-               if(pdpVal.contains(",")){
-                       List<String> pdpValues = new ArrayList<>(Arrays.asList(pdpVal.split("\\s*,\\s*")));
-                       if(pdpValues.size()==3){
-                               // 1:2 will be UserID:Password
-                               String userID = pdpValues.get(1);
-                               String pass = pdpValues.get(2);
-                               Base64.Encoder encoder = Base64.getEncoder();
-                               // 0 - PDPURL
-                               pdpMap.put(pdpValues.get(0), encoder.encodeToString((userID+":"+pass).getBytes(StandardCharsets.UTF_8)));
-                       }else{
-                               LOGGER.error(XACMLErrorConstants.ERROR_PERMISSIONS + "No Credentials to send Request: " + pdpValues);
-                       }
-               }else{
-                       LOGGER.error(XACMLErrorConstants.ERROR_PERMISSIONS + "No Credentials to send Request: " + pdpVal);
-               }
-       }
-       
-       public static String getEncoding(String pdpID){
-               try {
-                       readFile();
-               } catch (Exception e) {
-                       LOGGER.error(XACMLErrorConstants.ERROR_SYSTEM_ERROR + e);
-               }
-               String encoding = null;
-               if(pdpMap!=null && (!pdpMap.isEmpty())){
-                       try{
-                               encoding = pdpMap.get(pdpID);
-                       } catch(Exception e){
-                               LOGGER.error(XACMLErrorConstants.ERROR_SYSTEM_ERROR + e);
-                       }
-                       return encoding;
-               }else{
-                       return null;
-               }
-       }
+    public static boolean validateID(String id) {
+        // ReadFile
+        try {
+            readFile();
+        } catch (Exception e) {
+            LOGGER.error(XACMLErrorConstants.ERROR_SYSTEM_ERROR + e);
+            return false;
+        }
+        if (pdpMap == null) {
+            return false;
+        }
+        // Check ID
+        return pdpMap.containsKey(id);
+    }
+
+    private static void readFile(){
+        String pdpFile = null;
+        try{
+            pdpFile = XACMLProperties.getProperty(XACMLRestProperties.PROP_PDP_IDFILE);
+        }catch (Exception e){
+            LOGGER.error(XACMLErrorConstants.ERROR_DATA_ISSUE + "Cannot read the PDP ID File" + e);
+            return;
+        }
+        if (pdpFile == null) {
+            LOGGER.error(XACMLErrorConstants.ERROR_SYSTEM_ERROR + "PDP File name not Valid : " + pdpFile);
+        }
+        if (pdpPath == null) {
+            pdpPath = Paths.get(pdpFile);
+            if (!pdpPath.toString().endsWith(".properties") || !pdpPath.toFile().exists()) {
+                LOGGER.error(XACMLErrorConstants.ERROR_SYSTEM_ERROR + "File doesn't exist in the specified Path : "    + pdpPath.toString());
+                CheckPDP.reset();
+                return;
+            }
+            readProps();
+        }
+        // Check if File is updated recently
+        else {
+            Long newModified = pdpPath.toFile().lastModified();
+            if (!newModified.equals(oldModified)) {
+                // File has been updated.
+                readProps();
+            }
+        }
+    }
+
+    @SuppressWarnings({ "unchecked", "rawtypes" })
+    private static void readProps() {
+        Properties pdpProp;
+        pdpProp = new Properties();
+        try(InputStream in = new FileInputStream(pdpPath.toFile())) {
+            oldModified = pdpPath.toFile().lastModified();
+            pdpProp.load(in);
+            // Read the Properties and Load the PDPs and encoding.
+            pdpMap = new HashMap<>();
+            // Check the Keys for PDP_URLs
+            Collection<Object> unsorted = pdpProp.keySet();
+            List<String> sorted = new ArrayList(unsorted);
+            Collections.sort(sorted);
+            for (String propKey : sorted) {
+                loadPDPProperties(propKey, pdpProp);
+            }
+        } catch (IOException e) {
+            LOGGER.error(XACMLErrorConstants.ERROR_SYSTEM_ERROR + e);
+        }
+        if (pdpMap == null || pdpMap.isEmpty()) {
+            LOGGER.debug(XACMLErrorConstants.ERROR_SYSTEM_ERROR + "Cannot Proceed without PDP_URLs");
+            CheckPDP.reset();
+        }
+    }
+
+    private static void loadPDPProperties(String propKey, Properties pdpProp){
+        if (propKey.startsWith("PDP_URL")) {
+            String checkVal = pdpProp.getProperty(propKey);
+            if (checkVal == null) {
+                LOGGER.error("Properties file doesn't have the PDP_URL parameter");
+            }
+            if (checkVal != null && checkVal.contains(";")) {
+                List<String> pdpDefault = new ArrayList<>(Arrays.asList(checkVal.split("\\s*;\\s*")));
+                int pdpCount = 0;
+                while (pdpCount < pdpDefault.size()) {
+                    String pdpVal = pdpDefault.get(pdpCount);
+                    readPDPParam(pdpVal);
+                    pdpCount++;
+                }
+            }
+        }
+    }
+
+    private static void readPDPParam(String pdpVal){
+        if(pdpVal.contains(",")){
+            List<String> pdpValues = new ArrayList<>(Arrays.asList(pdpVal.split("\\s*,\\s*")));
+            if(pdpValues.size()==3){
+                // 1:2 will be UserID:Password
+                String userID = pdpValues.get(1);
+                String pass = pdpValues.get(2);
+                Base64.Encoder encoder = Base64.getEncoder();
+                // 0 - PDPURL
+                pdpMap.put(pdpValues.get(0), encoder.encodeToString((userID+":"+pass).getBytes(StandardCharsets.UTF_8)));
+            }else{
+                LOGGER.error(XACMLErrorConstants.ERROR_PERMISSIONS + "No Credentials to send Request: " + pdpValues);
+            }
+        }else{
+            LOGGER.error(XACMLErrorConstants.ERROR_PERMISSIONS + "No Credentials to send Request: " + pdpVal);
+        }
+    }
+
+    public static String getEncoding(String pdpID){
+        try {
+            readFile();
+        } catch (Exception e) {
+            LOGGER.error(XACMLErrorConstants.ERROR_SYSTEM_ERROR + e);
+        }
+        String encoding = null;
+        if(pdpMap!=null && (!pdpMap.isEmpty())){
+            try{
+                encoding = pdpMap.get(pdpID);
+            } catch(Exception e){
+                LOGGER.error(XACMLErrorConstants.ERROR_SYSTEM_ERROR + e);
+            }
+            return encoding;
+        }else{
+            return null;
+        }
+    }
 }