Format ONAP-XACML and add JUnit

[policy/engine.git] / ONAP-XACML / src / test / java / org / onap / policy / xacml / test / std / pap / StdEngineFactoryTest.java

diff --git a/ONAP-XACML/src/test/java/org/onap/policy/xacml/test/std/pap/StdEngineFactoryTest.java b/ONAP-XACML/src/test/java/org/onap/policy/xacml/test/std/pap/StdEngineFactoryTest.java
index 3fa4955..43d019d 100644 (file)
--- a/ONAP-XACML/src/test/java/org/onap/policy/xacml/test/std/pap/StdEngineFactoryTest.java
+++ b/ONAP-XACML/src/test/java/org/onap/policy/xacml/test/std/pap/StdEngineFactoryTest.java
@@ -2,14 +2,16 @@
  * ============LICENSE_START=======================================================
  * ONAP-XACML
  * ================================================================================
- * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2017-2019 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Modifications Copyright (C) 2019 Samsung
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -17,9 +19,15 @@
  * limitations under the License.
  * ============LICENSE_END=========================================================
  */
+
 package org.onap.policy.xacml.test.std.pap;
 
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+import com.att.research.xacml.api.pap.PAPException;
+import com.att.research.xacml.std.pap.StdEngine;
+import com.att.research.xacml.util.FactoryException;
 
 import java.io.IOException;
 import java.util.Properties;
@@ -27,25 +35,47 @@ import java.util.Properties;
 import org.junit.Test;
 import org.onap.policy.xacml.std.pap.StdEngineFactory;
 
-import com.att.research.xacml.api.pap.PAPException;
-import com.att.research.xacml.util.FactoryException;
-
 public class StdEngineFactoryTest {
+    @Test
+    public void testStdEngineFactory() throws FactoryException, PAPException, IOException {
+        StdEngineFactory stdFactory = new StdEngineFactory();
+        System.setProperty("xacml.pap.pdps", "src/test/resources/pdps");
+        assertTrue(stdFactory.newEngine() != null);
+        Properties properties = new Properties();
+        properties.setProperty("xacml.pap.pdps", "src/test/resources/pdps");
+        assertTrue(stdFactory.newEngine(properties) != null);
+
+        StdEngineFactory stdFactoryNew = new StdEngineFactory();
+        System.setProperty("xacml.pap.pdps", "src/test/resources/pdpstest");
+        assertTrue(stdFactoryNew.newEngine() != null);
+    }
+
+    @Test
+    public void testNegativeCase() throws Exception {
+        // Setup test data
+        Properties props = new Properties();
+        String tmpdir = System.getProperty("java.io.tmpdir");
+        props.setProperty(StdEngine.PROP_PAP_REPO, tmpdir);
+
+        // Set the system property temporarily
+        String systemKey = StdEngine.PROP_PAP_REPO;
+        String oldProperty = System.getProperty(systemKey);
+        System.setProperty(systemKey, tmpdir);
 
+        // Test factory failure cases
+        try {
+            StdEngineFactory factory = new StdEngineFactory();
+            factory.newEngine();
+            factory.newEngine(props);
+        } catch (Exception ex) {
+            fail("Not expecting any exceptions: " + ex);
+        }
 
-       @Test
-       public void testStdEngineFactory() throws FactoryException, PAPException, IOException{
-               
-               StdEngineFactory stdFactory = new StdEngineFactory();
-               System.setProperty("xacml.pap.pdps", "src/test/resources/pdps");
-               assertTrue(stdFactory.newEngine() != null);
-               Properties properties = new Properties();
-               properties.setProperty("xacml.pap.pdps", "src/test/resources/pdps");
-               assertTrue(stdFactory.newEngine(properties) != null);
-               
-               StdEngineFactory stdFactoryNew = new StdEngineFactory();
-               System.setProperty("xacml.pap.pdps", "src/test/resources/pdpstest");
-               assertTrue(stdFactoryNew.newEngine() != null);
-
-       }
+        // Restore the original system property
+        if (oldProperty != null) {
+            System.setProperty(systemKey, oldProperty);
+        } else {
+            System.clearProperty(systemKey);
+        }
+    }
 }