JUnit/SONAR/Checkstyle in ONAP-REST

[policy/engine.git] / ONAP-REST / src / test / java / org / onap / policy / rest / jpa / FwDictionaryJpaTest.java

diff --git a/ONAP-REST/src/test/java/org/onap/policy/rest/jpa/FWDictionaryJPATest.java b/ONAP-REST/src/test/java/org/onap/policy/rest/jpa/FwDictionaryJpaTest.java
similarity index 80%
rename from ONAP-REST/src/test/java/org/onap/policy/rest/jpa/FWDictionaryJPATest.java
rename to ONAP-REST/src/test/java/org/onap/policy/rest/jpa/FwDictionaryJpaTest.java
index b3b23e4..cee9dde 100644 (file)
--- a/ONAP-REST/src/test/java/org/onap/policy/rest/jpa/FWDictionaryJPATest.java
+++ b/ONAP-REST/src/test/java/org/onap/policy/rest/jpa/FwDictionaryJpaTest.java
@@ -3,13 +3,14 @@
  * ONAP-REST
  * ================================================================================
  * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
+ * Modifications Copyright (C) 2019 Nordix Foundation.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -17,6 +18,7 @@
  * limitations under the License.
  * ============LICENSE_END=========================================================
  */
+
 package org.onap.policy.rest.jpa;
 
 import static org.junit.Assert.assertTrue;
@@ -28,11 +30,19 @@ import org.junit.Test;
 import org.onap.policy.common.logging.flexlogger.FlexLogger;
 import org.onap.policy.common.logging.flexlogger.Logger;
 
-public class FWDictionaryJPATest {
+/**
+ * The Class FWDictionaryJPATest.
+ */
+public class FwDictionaryJpaTest {
 
-    private static Logger logger = FlexLogger.getLogger(FWDictionaryJPATest.class);
+    private static Logger logger = FlexLogger.getLogger(FwDictionaryJpaTest.class);
     private UserInfo userInfo;
 
+    /**
+     * Sets the up.
+     *
+     * @throws Exception the exception
+     */
     @Before
     public void setUp() throws Exception {
         logger.info("setUp: Entering");
@@ -42,8 +52,11 @@ public class FWDictionaryJPATest {
         logger.info("setUp: exit");
     }
 
+    /**
+     * Test action list.
+     */
     @Test
-    public void testActionList(){
+    public void testActionList() {
         ActionList data = new ActionList();
         data.setId(1);
         assertTrue(1 == data.getId());
@@ -53,8 +66,11 @@ public class FWDictionaryJPATest {
         assertTrue("Test".equals(data.getDescription()));
     }
 
+    /**
+     * Test port list.
+     */
     @Test
-    public void testPortList(){
+    public void testPortList() {
         PortList data = new PortList();
         data.setId(1);
         assertTrue(1 == data.getId());
@@ -64,8 +80,11 @@ public class FWDictionaryJPATest {
         assertTrue("Test".equals(data.getDescription()));
     }
 
+    /**
+     * Test protocol list.
+     */
     @Test
-    public void testProtocolList(){
+    public void testProtocolList() {
         ProtocolList data = new ProtocolList();
         data.setId(1);
         assertTrue(1 == data.getId());
@@ -75,8 +94,11 @@ public class FWDictionaryJPATest {
         assertTrue("Test".equals(data.getDescription()));
     }
 
+    /**
+     * Test security zone.
+     */
     @Test
-    public void testSecurityZone(){
+    public void testSecurityZone() {
         SecurityZone data = new SecurityZone();
         data.setId(1);
         assertTrue(1 == data.getId());
@@ -86,8 +108,11 @@ public class FWDictionaryJPATest {
         assertTrue("Test".equals(data.getZoneValue()));
     }
 
+    /**
+     * Test zone.
+     */
     @Test
-    public void testZone(){
+    public void testZone() {
         Zone data = new Zone();
         data.setId(1);
         assertTrue(1 == data.getId());
@@ -97,8 +122,11 @@ public class FWDictionaryJPATest {
         assertTrue("Test".equals(data.getZoneValue()));
     }
 
+    /**
+     * Test address group.
+     */
     @Test
-    public void testAddressGroup(){
+    public void testAddressGroup() {
         AddressGroup data = new AddressGroup();
         data.setId(1);
         assertTrue(1 == data.getId());
@@ -110,8 +138,11 @@ public class FWDictionaryJPATest {
         assertTrue("Test".equals(data.getDescription()));
     }
 
+    /**
+     * Test prefix list.
+     */
     @Test
-    public void testPrefixList(){
+    public void testPrefixList() {
         PrefixList data = new PrefixList();
         data.setId(1);
         assertTrue(1 == data.getId());
@@ -123,8 +154,11 @@ public class FWDictionaryJPATest {
         assertTrue("Test".equals(data.getDescription()));
     }
 
+    /**
+     * Test FW dictionary list.
+     */
     @Test
-    public void testFWDictionaryList(){
+    public void testFwDictionaryList() {
         FirewallDictionaryList data = new FirewallDictionaryList();
         data.setId(1);
         assertTrue(1 == data.getId());
@@ -138,9 +172,12 @@ public class FWDictionaryJPATest {
         assertTrue("Test".equals(data.getServiceList()));
     }
 
+    /**
+     * Test FW tag.
+     */
     @Test
-    public void testFWTag(){
-        FWTag data = new FWTag();
+    public void testFwTag() {
+        FwTag data = new FwTag();
         data.preUpdate();
         data.prePersist();
         data.setId(1);
@@ -152,18 +189,21 @@ public class FWDictionaryJPATest {
         data.setTagValues("Test");
         assertTrue("Test".equals(data.getTagValues()));
         data.setCreatedDate(new Date());
-        assertTrue(data.getCreatedDate()!=null);
+        assertTrue(data.getCreatedDate() != null);
         data.setModifiedDate(new Date());
-        assertTrue(data.getModifiedDate()!=null);
+        assertTrue(data.getModifiedDate() != null);
         data.setUserCreatedBy(userInfo);
-        assertTrue(data.getUserCreatedBy()!=null);
+        assertTrue(data.getUserCreatedBy() != null);
         data.setUserModifiedBy(userInfo);
-        assertTrue(data.getUserModifiedBy()!=null);
+        assertTrue(data.getUserModifiedBy() != null);
     }
 
+    /**
+     * Test FW tag picker.
+     */
     @Test
-    public void testFWTagPicker(){
-        FWTagPicker data = new FWTagPicker();
+    public void testFwTagPicker() {
+        FwTagPicker data = new FwTagPicker();
         data.preUpdate();
         data.prePersist();
         data.setId(1);
@@ -177,17 +217,20 @@ public class FWDictionaryJPATest {
         data.setTagValues("Test");
         assertTrue("Test".equals(data.getTagValues()));
         data.setCreatedDate(new Date());
-        assertTrue(data.getCreatedDate()!=null);
+        assertTrue(data.getCreatedDate() != null);
         data.setModifiedDate(new Date());
-        assertTrue(data.getModifiedDate()!=null);
+        assertTrue(data.getModifiedDate() != null);
         data.setUserCreatedBy(userInfo);
-        assertTrue(data.getUserCreatedBy()!=null);
+        assertTrue(data.getUserCreatedBy() != null);
         data.setUserModifiedBy(userInfo);
-        assertTrue(data.getUserModifiedBy()!=null);
+        assertTrue(data.getUserModifiedBy() != null);
     }
 
+    /**
+     * Test service list.
+     */
     @Test
-    public void testServiceList(){
+    public void testServiceList() {
         ServiceList data = new ServiceList();
         data.setId(1);
         assertTrue(1 == data.getId());
@@ -205,8 +248,11 @@ public class FWDictionaryJPATest {
         assertTrue("Test".equals(data.getServicePorts()));
     }
 
+    /**
+     * Test term list.
+     */
     @Test
-    public void testTermList(){
+    public void testTermList() {
         TermList data = new TermList();
         data.preUpdate();
         data.prePersist();
@@ -235,17 +281,20 @@ public class FWDictionaryJPATest {
         data.setAction("Test");
         assertTrue("Test".equals(data.getAction()));
         data.setCreatedDate(new Date());
-        assertTrue(data.getCreatedDate()!=null);
+        assertTrue(data.getCreatedDate() != null);
         data.setModifiedDate(new Date());
-        assertTrue(data.getModifiedDate()!=null);
+        assertTrue(data.getModifiedDate() != null);
         data.setUserCreatedBy(userInfo);
-        assertTrue(data.getUserCreatedBy()!=null);
+        assertTrue(data.getUserCreatedBy() != null);
         data.setUserModifiedBy(userInfo);
-        assertTrue(data.getUserModifiedBy()!=null);
+        assertTrue(data.getUserModifiedBy() != null);
     }
 
+    /**
+     * Test group service list.
+     */
     @Test
-    public void testGroupServiceList(){
+    public void testGroupServiceList() {
         GroupServiceList data = new GroupServiceList();
         data.setId(1);
         assertTrue(1 == data.getId());