Merge "Make clientAuth header optional and log request"

[policy/engine.git] / ONAP-PDP-REST / src / main / java / org / onap / policy / pdp / rest / api / services / DeletePolicyService.java

diff --git a/ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/api/services/DeletePolicyService.java b/ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/api/services/DeletePolicyService.java
index ff0ac82..a004330 100644 (file)
--- a/ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/api/services/DeletePolicyService.java
+++ b/ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/api/services/DeletePolicyService.java
@@ -43,7 +43,6 @@ import org.springframework.http.HttpStatus;
 public class DeletePolicyService extends PdpApiService {
 
     private static final Logger LOGGER = FlexLogger.getLogger(DeletePolicyService.class.getName());
-    private static final String PRINT_REQUESTID = " - RequestId - ";
     private DeletePolicyParameters deletePolicyParameters = null;
     private String result = null;
     private List<PolicyNameType> policyList = new ArrayList<>();
@@ -173,7 +172,7 @@ public class DeletePolicyService extends PdpApiService {
      */
     private boolean populateFullPolicyName(final PAPServices papServices) {
         for (PolicyNameType policyData : policyList) {
-            if (policyData.getPolicyName().contains("xml")) {
+               if (policyData.getPolicyName().endsWith("xml")) {
                 policyData.setFullPolicyName(policyData.getPolicyName());
                 continue;
             }
@@ -251,7 +250,7 @@ public class DeletePolicyService extends PdpApiService {
 
         if ("PAP".equalsIgnoreCase(deletePolicyParameters.getPolicyComponent())
                 && (deletePolicyParameters.getDeleteCondition() == null
-                        || deletePolicyParameters.getDeleteCondition().toString().trim().isEmpty())) {
+                        || StringUtils.isBlank(deletePolicyParameters.getDeleteCondition().toString()))) {
             message = XACMLErrorConstants.ERROR_DATA_ISSUE + "No Delete Condition given.";
             LOGGER.warn(message + PRINT_REQUESTID + requestId);
             return false;