Modify ONAP PAP REST classes basic checkstyle

[policy/engine.git] / ONAP-PAP-REST / src / test / java / org / onap / policy / pap / xacml / rest / controller / BRMSDictionaryControllerTest.java

diff --git a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/BRMSDictionaryControllerTest.java b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/BRMSDictionaryControllerTest.java
index 0a60e18..d34e505 100644 (file)
--- a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/BRMSDictionaryControllerTest.java
+++ b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/BRMSDictionaryControllerTest.java
@@ -46,217 +46,217 @@ import org.springframework.mock.web.MockHttpServletResponse;
 
 public class BRMSDictionaryControllerTest {
 
-       private static Logger logger = FlexLogger.getLogger(BRMSDictionaryControllerTest.class);
-       private static CommonClassDao commonClassDao;
-       private String jsonString = null;
-       private HttpServletRequest request = null;
-       private BRMSDictionaryController controller = null;
-       private MockHttpServletResponse response = null;
+    private static Logger logger = FlexLogger.getLogger(BRMSDictionaryControllerTest.class);
+    private static CommonClassDao commonClassDao;
+    private String jsonString = null;
+    private HttpServletRequest request = null;
+    private BRMSDictionaryController controller = null;
+    private MockHttpServletResponse response = null;
 
-       @Before
-       public void setUp() throws Exception {
-               logger.info("setUp: Entering");
-               commonClassDao = Mockito.mock(CommonClassDao.class);
-               UserInfo userInfo = new UserInfo();
-               userInfo.setUserLoginId("testUserId");
-               userInfo.setUserName("John");
-               when(commonClassDao.getEntityItem(UserInfo.class, "userLoginId", "testing")).thenReturn(userInfo);
-               List<String>  brms = new ArrayList<String>();
-               brms.add("BRMS-Model");
-               when(commonClassDao.getDataByColumn(BRMSParamTemplate.class, "name")).thenReturn(brms);
-               doNothing().when(commonClassDao).delete(new BRMSParamTemplate());
-               doNothing().when(commonClassDao).save(new BRMSParamTemplate());
-               controller = new BRMSDictionaryController();
-               request = Mockito.mock(HttpServletRequest.class);
-               response =  new MockHttpServletResponse();  
-               new DictionaryUtils(commonClassDao);
+    @Before
+    public void setUp() throws Exception {
+        logger.info("setUp: Entering");
+        commonClassDao = Mockito.mock(CommonClassDao.class);
+        UserInfo userInfo = new UserInfo();
+        userInfo.setUserLoginId("testUserId");
+        userInfo.setUserName("John");
+        when(commonClassDao.getEntityItem(UserInfo.class, "userLoginId", "testing")).thenReturn(userInfo);
+        List<String>  brms = new ArrayList<String>();
+        brms.add("BRMS-Model");
+        when(commonClassDao.getDataByColumn(BRMSParamTemplate.class, "name")).thenReturn(brms);
+        doNothing().when(commonClassDao).delete(new BRMSParamTemplate());
+        doNothing().when(commonClassDao).save(new BRMSParamTemplate());
+        controller = new BRMSDictionaryController();
+        request = Mockito.mock(HttpServletRequest.class);
+        response =  new MockHttpServletResponse();
+        new DictionaryUtils(commonClassDao);
         DictionaryUtils.setDictionaryUtils(new DictionaryUtils());
         mock(DictionaryUtils.class);
-               logger.info("setUp: exit");
-       }
+        logger.info("setUp: exit");
+    }
 
-       @Test
-       public void testGetBRMSParamDictionaryByNameEntityData(){
-               logger.info("testGetBRMSParamDictionaryByNameEntityData: Entering");
-               BRMSDictionaryController.setCommonClassDao(commonClassDao);     
-               controller.getBRMSParamDictionaryByNameEntityData(response);
-               try {
-                       assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsParamDictionaryDatas"));
-                       logger.info("response.getContentAsString(): " + response.getContentAsString());
-               } catch (UnsupportedEncodingException e) {
-                       fail("Exception: " + e);
-               }
-               logger.info("testGetBRMSParamDictionaryByNameEntityData: exit");
-       }
+    @Test
+    public void testGetBRMSParamDictionaryByNameEntityData(){
+        logger.info("testGetBRMSParamDictionaryByNameEntityData: Entering");
+        BRMSDictionaryController.setCommonClassDao(commonClassDao);
+        controller.getBRMSParamDictionaryByNameEntityData(response);
+        try {
+            assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsParamDictionaryDatas"));
+            logger.info("response.getContentAsString(): " + response.getContentAsString());
+        } catch (UnsupportedEncodingException e) {
+            fail("Exception: " + e);
+        }
+        logger.info("testGetBRMSParamDictionaryByNameEntityData: exit");
+    }
 
-       @Test
-       public void testGetBRMSParamDictionaryEntityData() {
-               logger.info("testGetBRMSParamDictionaryEntityData: Entering");
-               controller.getBRMSParamDictionaryEntityData(response);
-               try {
-                       assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsParamDictionaryDatas"));
-                       logger.info("response.getContentAsString(): " + response.getContentAsString());
-               } catch (UnsupportedEncodingException e) {
-                       fail("Exception: " + e);
-               }
-               logger.info("testGetBRMSParamDictionaryEntityData: exit");
-       }
+    @Test
+    public void testGetBRMSParamDictionaryEntityData() {
+        logger.info("testGetBRMSParamDictionaryEntityData: Entering");
+        controller.getBRMSParamDictionaryEntityData(response);
+        try {
+            assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsParamDictionaryDatas"));
+            logger.info("response.getContentAsString(): " + response.getContentAsString());
+        } catch (UnsupportedEncodingException e) {
+            fail("Exception: " + e);
+        }
+        logger.info("testGetBRMSParamDictionaryEntityData: exit");
+    }
 
-       @Test
-       public void testSaveBRMSParamDictionary() {
-               logger.info("testSaveBRMSParamDictionary: Entering");
-               jsonString = "{\"brmsParamDictionaryData\": {\"ruleName\": \"test\",\"rule\": \"test\"},\"userid\": \"testName\"}";
-               try(BufferedReader br = new BufferedReader(new StringReader(jsonString))){
-                       when(request.getReader()).thenReturn(br);
-                       controller.saveBRMSParamDictionary(request, response);
-                       assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsParamDictionaryData"));
-                       logger.info("response.getContentAsString(): " + response.getContentAsString());
-               }catch(Exception e){
-                       logger.error("Exception"+ e);
-               } 
-               logger.info("testSaveBRMSParamDictionary: exit");
-       }
+    @Test
+    public void testSaveBRMSParamDictionary() {
+        logger.info("testSaveBRMSParamDictionary: Entering");
+        jsonString = "{\"brmsParamDictionaryData\": {\"ruleName\": \"test\",\"rule\": \"test\"},\"userid\": \"testName\"}";
+        try(BufferedReader br = new BufferedReader(new StringReader(jsonString))){
+            when(request.getReader()).thenReturn(br);
+            controller.saveBRMSParamDictionary(request, response);
+            assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsParamDictionaryData"));
+            logger.info("response.getContentAsString(): " + response.getContentAsString());
+        }catch(Exception e){
+            logger.error("Exception"+ e);
+        }
+        logger.info("testSaveBRMSParamDictionary: exit");
+    }
 
-       @Test
-       public void testRemoveBRMSParamDictionary() {
-               logger.info("testRemoveBRMSParamDictionary: Entering");
-               jsonString = "{\"data\": {\"ruleName\": \"test\",\"rule\": \"test\"}}";
-               try(BufferedReader br = new BufferedReader(new StringReader(jsonString))){
-                       when(request.getReader()).thenReturn(br);
-                       controller.removeBRMSParamDictionary(request, response);
-                       logger.info("response.getContentAsString(): " + response.getContentAsString());
-                       assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsParamDictionaryDatas"));
-               } catch (Exception e) {
-                       fail("Exception: " + e);
-               }
-               logger.info("testRemoveBRMSParamDictionary: exit");
-       }
+    @Test
+    public void testRemoveBRMSParamDictionary() {
+        logger.info("testRemoveBRMSParamDictionary: Entering");
+        jsonString = "{\"data\": {\"ruleName\": \"test\",\"rule\": \"test\"}}";
+        try(BufferedReader br = new BufferedReader(new StringReader(jsonString))){
+            when(request.getReader()).thenReturn(br);
+            controller.removeBRMSParamDictionary(request, response);
+            logger.info("response.getContentAsString(): " + response.getContentAsString());
+            assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsParamDictionaryDatas"));
+        } catch (Exception e) {
+            fail("Exception: " + e);
+        }
+        logger.info("testRemoveBRMSParamDictionary: exit");
+    }
 
-       @Test
-       public void testGetBRMSDependencyDictionaryByNameEntityData(){
-               logger.info("testGetBRMSDependencyDictionaryByNameEntityData: Entering");
-               BRMSDictionaryController.setCommonClassDao(commonClassDao);     
-               controller.getBRMSDependencyDictionaryByNameEntityData(response);
-               try {
-                       assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsDependencyDictionaryDatas"));
-                       logger.info("response.getContentAsString(): " + response.getContentAsString());
-               } catch (UnsupportedEncodingException e) {
-                       fail("Exception: " + e);
-               }
-               logger.info("testGetBRMSDependencyDictionaryByNameEntityData: exit");
-       }
+    @Test
+    public void testGetBRMSDependencyDictionaryByNameEntityData(){
+        logger.info("testGetBRMSDependencyDictionaryByNameEntityData: Entering");
+        BRMSDictionaryController.setCommonClassDao(commonClassDao);
+        controller.getBRMSDependencyDictionaryByNameEntityData(response);
+        try {
+            assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsDependencyDictionaryDatas"));
+            logger.info("response.getContentAsString(): " + response.getContentAsString());
+        } catch (UnsupportedEncodingException e) {
+            fail("Exception: " + e);
+        }
+        logger.info("testGetBRMSDependencyDictionaryByNameEntityData: exit");
+    }
 
-       @Test
-       public void testGetBRMSDependencyDictionaryEntityData(){
-               logger.info("testGetBRMSDependencyDictionaryEntityData: Entering");
-               BRMSDictionaryController.setCommonClassDao(commonClassDao);     
-               controller.getBRMSDependencyDictionaryEntityData(response);
-               try {
-                       assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsDependencyDictionaryDatas"));
-                       logger.info("response.getContentAsString(): " + response.getContentAsString());
-               } catch (UnsupportedEncodingException e) {
-                       fail("Exception: " + e);
-               }
+    @Test
+    public void testGetBRMSDependencyDictionaryEntityData(){
+        logger.info("testGetBRMSDependencyDictionaryEntityData: Entering");
+        BRMSDictionaryController.setCommonClassDao(commonClassDao);
+        controller.getBRMSDependencyDictionaryEntityData(response);
+        try {
+            assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsDependencyDictionaryDatas"));
+            logger.info("response.getContentAsString(): " + response.getContentAsString());
+        } catch (UnsupportedEncodingException e) {
+            fail("Exception: " + e);
+        }
 
-               logger.info("testGetBRMSDependencyDictionaryEntityData: exit");
-       }
+        logger.info("testGetBRMSDependencyDictionaryEntityData: exit");
+    }
 
-       @Test
-       public void testSaveBRMSDependencyDictionary() {
-               logger.info("testSaveBRMSDependencyDictionary: Entering");
-                       jsonString = "{\"brmsDependencyDictionaryData\": {\"ruleName\": \"test\",\"rule\": \"test\"},\"userid\": \"testName\"}";
-                       try(BufferedReader br = new BufferedReader(new StringReader(jsonString))){
-                               when(request.getReader()).thenReturn(br);                   
-                               controller.saveBRMSDependencyDictionary(request, response);
-                               logger.info("response.getContentAsString(): " + response.getContentAsString());
-                               assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsDependencyDictionaryData"));
-                       } catch (Exception e) {
-                       fail("Exception: " + e);
-               }
-               logger.info("testSaveBRMSDependencyDictionary: exit");
-       }
+    @Test
+    public void testSaveBRMSDependencyDictionary() {
+        logger.info("testSaveBRMSDependencyDictionary: Entering");
+            jsonString = "{\"brmsDependencyDictionaryData\": {\"ruleName\": \"test\",\"rule\": \"test\"},\"userid\": \"testName\"}";
+            try(BufferedReader br = new BufferedReader(new StringReader(jsonString))){
+                when(request.getReader()).thenReturn(br);
+                controller.saveBRMSDependencyDictionary(request, response);
+                logger.info("response.getContentAsString(): " + response.getContentAsString());
+                assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsDependencyDictionaryData"));
+            } catch (Exception e) {
+            fail("Exception: " + e);
+        }
+        logger.info("testSaveBRMSDependencyDictionary: exit");
+    }
 
-       @Test
-       public void testRemoveBRMSDependencyDictionary() {
-               logger.info("testRemoveBRMSDependencyDictionary: Entering");
-               MockHttpServletResponse response =  new MockHttpServletResponse();
-               request = mock(HttpServletRequest.class);   
-               jsonString = "{\"data\": {\"ruleName\": \"test\",\"rule\": \"test\"}}";
-               try(BufferedReader br = new BufferedReader(new StringReader(jsonString))){
-                       when(request.getReader()).thenReturn(br);                   
-                       controller.removeBRMSDependencyDictionary(request, response);
-                       logger.info("response.getContentAsString(): " + response.getContentAsString());
-                       assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsDependencyDictionaryDatas"));
-               } catch (Exception e) {
-                       fail("Exception: " + e);
-               }
-               logger.info("testRemoveBRMSDependencyDictionary: exit");
-       }
+    @Test
+    public void testRemoveBRMSDependencyDictionary() {
+        logger.info("testRemoveBRMSDependencyDictionary: Entering");
+        MockHttpServletResponse response =  new MockHttpServletResponse();
+        request = mock(HttpServletRequest.class);
+        jsonString = "{\"data\": {\"ruleName\": \"test\",\"rule\": \"test\"}}";
+        try(BufferedReader br = new BufferedReader(new StringReader(jsonString))){
+            when(request.getReader()).thenReturn(br);
+            controller.removeBRMSDependencyDictionary(request, response);
+            logger.info("response.getContentAsString(): " + response.getContentAsString());
+            assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsDependencyDictionaryDatas"));
+        } catch (Exception e) {
+            fail("Exception: " + e);
+        }
+        logger.info("testRemoveBRMSDependencyDictionary: exit");
+    }
 
-       @Test
-       public void testGetBRMSControllerDictionaryByNameEntityData(){
-               logger.info("testGetBRMSControllerDictionaryByNameEntityData: Entering");
-               MockHttpServletResponse response =  new MockHttpServletResponse();
-               BRMSDictionaryController.setCommonClassDao(commonClassDao);     
-               controller.getBRMSControllerDictionaryByNameEntityData(response);
-               try {
-                       assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsControllerDictionaryDatas"));
-                       logger.info("response.getContentAsString(): " + response.getContentAsString());
-               } catch (UnsupportedEncodingException e) {
-                       fail("Exception: " + e);
-               }
-               logger.info("testGetBRMSControllerDictionaryByNameEntityData: exit");
-       }
+    @Test
+    public void testGetBRMSControllerDictionaryByNameEntityData(){
+        logger.info("testGetBRMSControllerDictionaryByNameEntityData: Entering");
+        MockHttpServletResponse response =  new MockHttpServletResponse();
+        BRMSDictionaryController.setCommonClassDao(commonClassDao);
+        controller.getBRMSControllerDictionaryByNameEntityData(response);
+        try {
+            assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsControllerDictionaryDatas"));
+            logger.info("response.getContentAsString(): " + response.getContentAsString());
+        } catch (UnsupportedEncodingException e) {
+            fail("Exception: " + e);
+        }
+        logger.info("testGetBRMSControllerDictionaryByNameEntityData: exit");
+    }
 
-       @Test
-       public void testGetBRMSControllerDictionaryEntityData(){
-               logger.info("testGetBRMSControllerDictionaryEntityData: Entering");
-               MockHttpServletResponse response =  new MockHttpServletResponse();
-               BRMSDictionaryController.setCommonClassDao(commonClassDao);     
-               controller.getBRMSControllerDictionaryEntityData(response);
-               try {
-                       assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsControllerDictionaryDatas"));
-                       logger.info("response.getContentAsString(): " + response.getContentAsString());
-               } catch (UnsupportedEncodingException e) {
-                       fail("Exception: " + e);
-               }
-               logger.info("testGetBRMSControllerDictionaryEntityData: exit");
-       }
+    @Test
+    public void testGetBRMSControllerDictionaryEntityData(){
+        logger.info("testGetBRMSControllerDictionaryEntityData: Entering");
+        MockHttpServletResponse response =  new MockHttpServletResponse();
+        BRMSDictionaryController.setCommonClassDao(commonClassDao);
+        controller.getBRMSControllerDictionaryEntityData(response);
+        try {
+            assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsControllerDictionaryDatas"));
+            logger.info("response.getContentAsString(): " + response.getContentAsString());
+        } catch (UnsupportedEncodingException e) {
+            fail("Exception: " + e);
+        }
+        logger.info("testGetBRMSControllerDictionaryEntityData: exit");
+    }
 
-       @Test
-       public void testSaveBRMSControllerDictionary() {
-               logger.info("testSaveBRMSControllerDictionary: Entering");
+    @Test
+    public void testSaveBRMSControllerDictionary() {
+        logger.info("testSaveBRMSControllerDictionary: Entering");
 
-               MockHttpServletResponse response =  new MockHttpServletResponse();
-               request = mock(HttpServletRequest.class);   
-               jsonString = "{\"brmsControllerDictionaryData\": {\"ruleName\": \"test\",\"rule\": \"test\"},\"userid\": \"testName\"}";
-               try(BufferedReader br = new BufferedReader(new StringReader(jsonString))){
-                       when(request.getReader()).thenReturn(br);                   
-                       controller.saveBRMSControllerDictionary(request, response);
-                       logger.info("response.getContentAsString(): " + response.getContentAsString());
-                       assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsControllerDictionaryData"));
-               } catch (Exception e) {
-                       fail("Exception: " + e);
-               }
-               logger.info("testSaveBRMSControllerDictionary: exit");
-       }
+        MockHttpServletResponse response =  new MockHttpServletResponse();
+        request = mock(HttpServletRequest.class);
+        jsonString = "{\"brmsControllerDictionaryData\": {\"ruleName\": \"test\",\"rule\": \"test\"},\"userid\": \"testName\"}";
+        try(BufferedReader br = new BufferedReader(new StringReader(jsonString))){
+            when(request.getReader()).thenReturn(br);
+            controller.saveBRMSControllerDictionary(request, response);
+            logger.info("response.getContentAsString(): " + response.getContentAsString());
+            assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsControllerDictionaryData"));
+        } catch (Exception e) {
+            fail("Exception: " + e);
+        }
+        logger.info("testSaveBRMSControllerDictionary: exit");
+    }
 
-       @Test
-       public void testRemoveBRMSControllerDictionary() {
-               logger.info("testRemoveBRMSControllerDictionary: Entering");
-               MockHttpServletResponse response =  new MockHttpServletResponse();
-               request = mock(HttpServletRequest.class);
-               jsonString = "{\"data\": {\"ruleName\": \"test\",\"rule\": \"test\"}}";
-               try(BufferedReader br = new BufferedReader(new StringReader(jsonString))){
-                       when(request.getReader()).thenReturn(br);                   
-                       controller.removeBRMSControllerDictionary(request, response);
-                       logger.info("response.getContentAsString(): " + response.getContentAsString());
-                       assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsControllerDictionaryDatas"));
+    @Test
+    public void testRemoveBRMSControllerDictionary() {
+        logger.info("testRemoveBRMSControllerDictionary: Entering");
+        MockHttpServletResponse response =  new MockHttpServletResponse();
+        request = mock(HttpServletRequest.class);
+        jsonString = "{\"data\": {\"ruleName\": \"test\",\"rule\": \"test\"}}";
+        try(BufferedReader br = new BufferedReader(new StringReader(jsonString))){
+            when(request.getReader()).thenReturn(br);
+            controller.removeBRMSControllerDictionary(request, response);
+            logger.info("response.getContentAsString(): " + response.getContentAsString());
+            assertTrue( response.getContentAsString() != null && response.getContentAsString().contains("brmsControllerDictionaryDatas"));
 
-               } catch (Exception e) {
-                       fail("Exception: " + e);
-               }
-               logger.info("testRemoveBRMSControllerDictionary: exit");
-       }
+        } catch (Exception e) {
+            fail("Exception: " + e);
+        }
+        logger.info("testRemoveBRMSControllerDictionary: exit");
+    }
 }