Modify ONAP PAP REST classes basic checkstyle

[policy/engine.git] / ONAP-PAP-REST / src / test / java / org / onap / policy / pap / xacml / rest / components / MicroServicePolicyTest.java

diff --git a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/MicroServicePolicyTest.java b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/MicroServicePolicyTest.java
index d162649..f698bc0 100644 (file)
--- a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/MicroServicePolicyTest.java
+++ b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/MicroServicePolicyTest.java
@@ -20,6 +20,7 @@
 package org.onap.policy.pap.xacml.rest.components;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.fail;
 import static org.mockito.Matchers.anyString;
@@ -35,43 +36,76 @@ import org.onap.policy.rest.adapter.PolicyRestAdapter;
 import org.powermock.api.mockito.PowerMockito;
 import org.powermock.core.classloader.annotations.PrepareForTest;
 import org.powermock.modules.junit4.PowerMockRunner;
+import java.io.File;
+import java.util.Collections;
 
 @RunWith(PowerMockRunner.class)
-@PrepareForTest(MicroServiceConfigPolicy.class)
 public class MicroServicePolicyTest {
-       @Rule
+    @Rule
     public ExpectedException thrown = ExpectedException.none();
 
-       @Test
-       public void testConstructor1() {
-               thrown.expect(NullPointerException.class);
-               MicroServiceConfigPolicy policy = new MicroServiceConfigPolicy();
-               policy.getCorrectPolicyDataObject();
-               fail("Expected an exception");
-       }
-       
-       @Test
-       public void testConstructor2() {
-               PolicyRestAdapter policyAdapter = new PolicyRestAdapter();
-               MicroServiceConfigPolicy policy = new MicroServiceConfigPolicy(policyAdapter);
-               assertNull(policy.getCorrectPolicyDataObject());
-       }
-       
-       @Test
-       public void testPrepareToSave() throws Exception {
-               // Need to mock internal dictionary retrieval
-               CommonClassDaoImpl impl = Mockito.mock(CommonClassDaoImpl.class);
-               PowerMockito.whenNew(CommonClassDaoImpl.class).withNoArguments().thenReturn(impl);
-               when(impl.getDataById(any(), anyString(), anyString())).thenReturn(null);
-               
-               PolicyRestAdapter policyAdapter = new PolicyRestAdapter();
-               MicroServiceConfigPolicy policy = new MicroServiceConfigPolicy(policyAdapter);
-               policyAdapter.setHighestVersion(1);
-               policyAdapter.setPolicyType("Config");
-               policyAdapter.setNewFileName("foo.xml");
-               policyAdapter.setJsonBody("{ \"version\": \"1.0\"}");
-               policyAdapter.setServiceType("foo");
-               policy.prepareToSave();
-               assertEquals(policy.isPreparedToSave(), true);
-       }
-}
\ No newline at end of file
+    @Test
+    public void testConstructor1() {
+        thrown.expect(NullPointerException.class);
+        MicroServiceConfigPolicy policy = new MicroServiceConfigPolicy();
+        policy.getCorrectPolicyDataObject();
+        fail("Expected an exception");
+    }
+
+    @Test
+    public void testConstructor2() {
+        PolicyRestAdapter policyAdapter = new PolicyRestAdapter();
+        MicroServiceConfigPolicy policy = new MicroServiceConfigPolicy(policyAdapter);
+        assertNull(policy.getCorrectPolicyDataObject());
+    }
+
+    @PrepareForTest({MicroServiceConfigPolicy.class})
+    @Test
+    public void testPrepareToSave() throws Exception {
+        // Need to mock internal dictionary retrieval
+        CommonClassDaoImpl impl = Mockito.mock(CommonClassDaoImpl.class);
+        PowerMockito.whenNew(CommonClassDaoImpl.class).withNoArguments().thenReturn(impl);
+        when(impl.getDataById(any(), anyString(), anyString())).thenReturn(null);
+
+        PolicyRestAdapter policyAdapter = new PolicyRestAdapter();
+        MicroServiceConfigPolicy policy = new MicroServiceConfigPolicy(policyAdapter);
+        policyAdapter.setHighestVersion(1);
+        policyAdapter.setPolicyType("Config");
+        policyAdapter.setNewFileName("foo.xml");
+        policyAdapter.setJsonBody("{ \"version\": \"1.0\"}");
+        policyAdapter.setServiceType("foo");
+        policy.prepareToSave();
+        assertEquals(policy.isPreparedToSave(), true);
+    }
+
+    @Test
+    public void testCreateConstructor1() {
+        CreateNewMicroServiceModel model = new CreateNewMicroServiceModel(null, null, null, null);
+        assertNotNull(model);
+    }
+
+    @PrepareForTest({CreateNewMicroServiceModel.class})
+    @Test
+    public void testCreateModel() throws Exception {
+        // Mock file retrieval
+        File testFile = new File("testFile");
+        File[] testList = new File[1];
+        testList[0] = testFile;
+        File impl = Mockito.mock(File.class);
+        PowerMockito.whenNew(File.class).withAnyArguments().thenReturn(impl);
+        when(impl.listFiles()).thenReturn(testList);
+        when(impl.isFile()).thenReturn(true);
+
+        // Mock internal dictionary retrieval
+        CommonClassDaoImpl daoImpl = Mockito.mock(CommonClassDaoImpl.class);
+        PowerMockito.whenNew(CommonClassDaoImpl.class).withNoArguments().thenReturn(daoImpl);
+        when(daoImpl.getDataById(any(), anyString(), anyString())).thenReturn(Collections.emptyList());
+
+        // Test create methods
+        String testFileName = "testFile.zip";
+        String testVal = "testVal";
+        CreateNewMicroServiceModel model = new CreateNewMicroServiceModel(testFileName, testVal, testVal, testVal, testVal);
+        model.addValuesToNewModel(".xmi");
+        model.saveImportService();
+    }
+}