JUnit/SONAR/Checkstyle in ONAP-REST
[policy/engine.git] / ONAP-PAP-REST / src / main / java / org / onap / policy / pap / xacml / rest / controller / BRMSDictionaryController.java
index a0044d2..d9cde35 100644 (file)
@@ -2,14 +2,14 @@
  * ============LICENSE_START=======================================================
  * ONAP-PAP-REST
  * ================================================================================
- * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2017-2019 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 
 package org.onap.policy.pap.xacml.rest.controller;
 
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
 import java.io.IOException;
 import java.io.StringWriter;
 import java.nio.charset.StandardCharsets;
@@ -36,9 +40,9 @@ import org.onap.policy.common.logging.flexlogger.Logger;
 import org.onap.policy.pap.xacml.rest.components.CreateBRMSRuleTemplate;
 import org.onap.policy.pap.xacml.rest.util.DictionaryUtils;
 import org.onap.policy.rest.dao.CommonClassDao;
-import org.onap.policy.rest.jpa.BRMSController;
-import org.onap.policy.rest.jpa.BRMSDependency;
-import org.onap.policy.rest.jpa.BRMSParamTemplate;
+import org.onap.policy.rest.jpa.BrmsController;
+import org.onap.policy.rest.jpa.BrmsDependency;
+import org.onap.policy.rest.jpa.BrmsParamTemplate;
 import org.onap.policy.rest.jpa.OnapName;
 import org.onap.policy.rest.jpa.UserInfo;
 import org.onap.policy.utils.PolicyUtils;
@@ -50,15 +54,10 @@ import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RequestMethod;
 import org.springframework.web.servlet.ModelAndView;
 
-import com.fasterxml.jackson.databind.DeserializationFeature;
-import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.ObjectMapper;
-
-
 @Controller
-public class BRMSDictionaryController{
+public class BRMSDictionaryController {
 
-    private static final Logger LOGGER  = FlexLogger.getLogger(BRMSDictionaryController.class);
+    private static final Logger LOGGER = FlexLogger.getLogger(BRMSDictionaryController.class);
 
     private static final String VALIDATIONRESPONSE = "Validation";
 
@@ -67,9 +66,9 @@ public class BRMSDictionaryController{
     private static String successMsg = "Success";
     private static String duplicateResponseString = "Duplicate";
     private static String ruleName = "ruleName";
-    private static String errorMessage = "Error";
+    private static String errorMessage = "Error";
     private static String operation = "operation";
-    private static String dictionaryFields ="dictionaryFields";
+    private static String dictionaryFields = "dictionaryFields";
     private static String userid = "userid";
     private static String dependencyName = "dependencyName";
     private static String controllerName = "controllerName";
@@ -78,7 +77,7 @@ public class BRMSDictionaryController{
     private static String brmsControllerDatas = "brmsControllerDictionaryDatas";
 
     @Autowired
-    public BRMSDictionaryController(CommonClassDao commonClassDao){
+    public BRMSDictionaryController(CommonClassDao commonClassDao) {
         BRMSDictionaryController.commonClassDao = commonClassDao;
     }
 
@@ -90,32 +89,39 @@ public class BRMSDictionaryController{
         super();
     }
 
-    private DictionaryUtils getDictionaryUtilsInstance(){
+    private DictionaryUtils getDictionaryUtilsInstance() {
         return DictionaryUtils.getDictionaryUtils();
     }
 
-    @RequestMapping(value={"/get_BRMSParamDataByName"}, method={RequestMethod.GET} , produces=MediaType.APPLICATION_JSON_VALUE)
-    public void getBRMSParamDictionaryByNameEntityData(HttpServletResponse response){
+    @RequestMapping(
+            value = {"/get_BRMSParamDataByName"},
+            method = {RequestMethod.GET},
+            produces = MediaType.APPLICATION_JSON_VALUE)
+    public void getBRMSParamDictionaryByNameEntityData(HttpServletResponse response) {
         DictionaryUtils utils = getDictionaryUtilsInstance();
-        utils.getDataByEntity(response, brmsParamDatas, ruleName, BRMSParamTemplate.class);
+        utils.getDataByEntity(response, brmsParamDatas, ruleName, BrmsParamTemplate.class);
     }
 
-    @RequestMapping(value={"/get_BRMSParamData"}, method={RequestMethod.GET} , produces=MediaType.APPLICATION_JSON_VALUE)
-    public void getBRMSParamDictionaryEntityData(HttpServletResponse response){
+    @RequestMapping(
+            value = {"/get_BRMSParamData"},
+            method = {RequestMethod.GET},
+            produces = MediaType.APPLICATION_JSON_VALUE)
+    public void getBRMSParamDictionaryEntityData(HttpServletResponse response) {
         DictionaryUtils utils = getDictionaryUtilsInstance();
-        utils.getData(response, brmsParamDatas, BRMSParamTemplate.class);
+        utils.getData(response, brmsParamDatas, BrmsParamTemplate.class);
     }
 
-    @RequestMapping(value={"/brms_dictionary/set_BRMSParamData"}, method={RequestMethod.POST})
-    public static void setRuleData(HttpServletRequest request) throws IOException{
+    @RequestMapping(value = {"/brms_dictionary/set_BRMSParamData"}, method = {RequestMethod.POST})
+    public static void setRuleData(HttpServletRequest request) throws IOException {
         StringWriter writer = new StringWriter();
-        IOUtils.copy(request.getInputStream() , writer, StandardCharsets.UTF_8);
-        String cleanStreamBoundary =  writer.toString().replaceFirst("------(.*)(?s).*octet-stream", "");
-        rule = cleanStreamBoundary.substring(0, cleanStreamBoundary.lastIndexOf("end")+4);
+        IOUtils.copy(request.getInputStream(), writer, StandardCharsets.UTF_8);
+        String cleanStreamBoundary = writer.toString().replaceFirst("------(.*)(?s).*octet-stream", "");
+        rule = cleanStreamBoundary.substring(0, cleanStreamBoundary.lastIndexOf("end") + 4);
     }
 
-    @RequestMapping(value={"/brms_dictionary/save_BRMSParam"}, method={RequestMethod.POST})
-    public ModelAndView saveBRMSParamDictionary(HttpServletRequest request, HttpServletResponse response) throws IOException {
+    @RequestMapping(value = {"/brms_dictionary/save_BRMSParam"}, method = {RequestMethod.POST})
+    public ModelAndView saveBRMSParamDictionary(HttpServletRequest request, HttpServletResponse response)
+            throws IOException {
         DictionaryUtils utils = getDictionaryUtilsInstance();
         try {
             boolean fromAPI = utils.isRequestFromAPI(request);
@@ -123,85 +129,98 @@ public class BRMSDictionaryController{
             mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
             JsonNode root = mapper.readTree(request.getReader());
 
-            BRMSParamTemplate bRMSParamTemplateData;
+            BrmsParamTemplate bRMSParamTemplateData;
             String userId = null;
-            if(fromAPI){
-                bRMSParamTemplateData = mapper.readValue(root.get(dictionaryFields).toString(), BRMSParamTemplate.class);
+            if (fromAPI) {
+                bRMSParamTemplateData =
+                        mapper.readValue(root.get(dictionaryFields).toString(), BrmsParamTemplate.class);
                 userId = "API";
-            }else{
-                bRMSParamTemplateData = mapper.readValue(root.get("brmsParamDictionaryData").toString(), BRMSParamTemplate.class);
+            } else {
+                bRMSParamTemplateData =
+                        mapper.readValue(root.get("brmsParamDictionaryData").toString(), BrmsParamTemplate.class);
                 userId = root.get(userid).textValue();
             }
             UserInfo userInfo = utils.getUserInfo(userId);
 
-            List<Object> duplicateData =  commonClassDao.checkDuplicateEntry(bRMSParamTemplateData.getRuleName(), ruleName, BRMSParamTemplate.class);
+            List<Object> duplicateData = commonClassDao.checkDuplicateEntry(bRMSParamTemplateData.getRuleName(),
+                    ruleName, BrmsParamTemplate.class);
             boolean duplicateflag = false;
-            if(!duplicateData.isEmpty()){
-                BRMSParamTemplate data = (BRMSParamTemplate) duplicateData.get(0);
-                if(request.getParameter(operation) != null && "update".equals(request.getParameter(operation))){
+            if (!duplicateData.isEmpty()) {
+                BrmsParamTemplate data = (BrmsParamTemplate) duplicateData.get(0);
+                if (request.getParameter(operation) != null && "update".equals(request.getParameter(operation))) {
                     bRMSParamTemplateData.setId(data.getId());
-                }else if((request.getParameter(operation) != null && !"update".equals(request.getParameter(operation))) ||
-                        (request.getParameter(operation) == null && (data.getId() != bRMSParamTemplateData.getId()))){
+                } else if ((request.getParameter(operation) != null
+                        && !"update".equals(request.getParameter(operation)))
+                        || (request.getParameter(operation) == null
+                                && (data.getId() != bRMSParamTemplateData.getId()))) {
                     duplicateflag = true;
                 }
             }
             String responseString = null;
             boolean validation = false;
-            if(rule != null && CreateBRMSRuleTemplate.validateRuleParams(rule)){
+            if (rule != null && CreateBRMSRuleTemplate.validateRuleParams(rule)) {
                 bRMSParamTemplateData.setRule(rule);
                 validation = true;
-                if(!duplicateflag){
-                    if(bRMSParamTemplateData.getId() == 0){
+                if (!duplicateflag) {
+                    if (bRMSParamTemplateData.getId() == 0) {
                         bRMSParamTemplateData.setUserCreatedBy(userInfo);
                         commonClassDao.save(bRMSParamTemplateData);
-                    }else{
+                    } else {
                         commonClassDao.update(bRMSParamTemplateData);
                     }
-                    responseString = mapper.writeValueAsString(commonClassDao.getData(BRMSParamTemplate.class));
-                }else{
+                    responseString = mapper.writeValueAsString(commonClassDao.getData(BrmsParamTemplate.class));
+                } else {
                     responseString = duplicateResponseString;
                 }
             }
 
-            if(!validation){
+            if (!validation) {
                 responseString = VALIDATIONRESPONSE;
             }
-            if(fromAPI){
-                if (responseString!=null && !(duplicateResponseString).equals(responseString) && !VALIDATIONRESPONSE.equals(responseString)) {
+            if (fromAPI) {
+                if (responseString != null && !(duplicateResponseString).equals(responseString)
+                        && !VALIDATIONRESPONSE.equals(responseString)) {
                     responseString = successMsg;
                 }
                 ModelAndView result = new ModelAndView();
                 result.setViewName(responseString);
                 return result;
-            }else{
+            } else {
                 utils.setResponseData(response, brmsParamDatas, responseString);
             }
-        }catch(Exception e){
+        } catch (Exception e) {
             utils.setErrorResponseData(response, e);
         }
         return null;
     }
 
-    @RequestMapping(value={"/brms_dictionary/remove_brmsParam"}, method={RequestMethod.POST})
-    public void removeBRMSParamDictionary(HttpServletRequest request, HttpServletResponse response)throws IOException {
+    @RequestMapping(value = {"/brms_dictionary/remove_brmsParam"}, method = {RequestMethod.POST})
+    public void removeBRMSParamDictionary(HttpServletRequest request, HttpServletResponse response) throws IOException {
         DictionaryUtils utils = getDictionaryUtilsInstance();
-        utils.removeData(request, response, brmsParamDatas, BRMSParamTemplate.class);
+        utils.removeData(request, response, brmsParamDatas, BrmsParamTemplate.class);
     }
 
-    @RequestMapping(value={"/get_BRMSDependencyDataByName"}, method={RequestMethod.GET} , produces=MediaType.APPLICATION_JSON_VALUE)
-    public void getBRMSDependencyDictionaryByNameEntityData(HttpServletResponse response){
+    @RequestMapping(
+            value = {"/get_BRMSDependencyDataByName"},
+            method = {RequestMethod.GET},
+            produces = MediaType.APPLICATION_JSON_VALUE)
+    public void getBRMSDependencyDictionaryByNameEntityData(HttpServletResponse response) {
         DictionaryUtils utils = getDictionaryUtilsInstance();
-        utils.getDataByEntity(response, brmsDependencyDatas, dependencyName, BRMSDependency.class);
+        utils.getDataByEntity(response, brmsDependencyDatas, dependencyName, BrmsDependency.class);
     }
-    
-    @RequestMapping(value={"/get_BRMSDependencyData"}, method={RequestMethod.GET} , produces=MediaType.APPLICATION_JSON_VALUE)
-    public void getBRMSDependencyDictionaryEntityData(HttpServletResponse response){
+
+    @RequestMapping(
+            value = {"/get_BRMSDependencyData"},
+            method = {RequestMethod.GET},
+            produces = MediaType.APPLICATION_JSON_VALUE)
+    public void getBRMSDependencyDictionaryEntityData(HttpServletResponse response) {
         DictionaryUtils utils = getDictionaryUtilsInstance();
-        utils.getData(response, brmsDependencyDatas, BRMSDependency.class);
+        utils.getData(response, brmsDependencyDatas, BrmsDependency.class);
     }
-    
-    @RequestMapping(value={"/brms_dictionary/save_BRMSDependencyData"}, method={RequestMethod.POST})
-    public ModelAndView saveBRMSDependencyDictionary(HttpServletRequest request, HttpServletResponse response) throws IOException {
+
+    @RequestMapping(value = {"/brms_dictionary/save_BRMSDependencyData"}, method = {RequestMethod.POST})
+    public ModelAndView saveBRMSDependencyDictionary(HttpServletRequest request, HttpServletResponse response)
+            throws IOException {
         DictionaryUtils utils = getDictionaryUtilsInstance();
         try {
             LOGGER.debug("DictionaryController:  saveBRMSDependencyDictionary() is called");
@@ -210,93 +229,106 @@ public class BRMSDictionaryController{
             mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
             JsonNode root = mapper.readTree(request.getReader());
 
-            BRMSDependency brmsDependency;
+            BrmsDependency brmsDependency;
             String userId = null;
-            if(fromAPI){
-                brmsDependency = mapper.readValue(root.get(dictionaryFields).toString(), BRMSDependency.class);
+            if (fromAPI) {
+                brmsDependency = mapper.readValue(root.get(dictionaryFields).toString(), BrmsDependency.class);
                 userId = "API";
-            }else{
-                brmsDependency = mapper.readValue(root.get("brmsDependencyDictionaryData").toString(), BRMSDependency.class);
+            } else {
+                brmsDependency =
+                        mapper.readValue(root.get("brmsDependencyDictionaryData").toString(), BrmsDependency.class);
                 userId = root.get(userid).textValue();
             }
             UserInfo userInfo = utils.getUserInfo(userId);
 
-            List<Object> duplicateData =  commonClassDao.checkDuplicateEntry(brmsDependency.getDependencyName(), dependencyName, BRMSDependency.class);
+            List<Object> duplicateData = commonClassDao.checkDuplicateEntry(brmsDependency.getDependencyName(),
+                    dependencyName, BrmsDependency.class);
             boolean duplicateflag = false;
-            if(!duplicateData.isEmpty()){
-                BRMSDependency data = (BRMSDependency) duplicateData.get(0);
-                if(request.getParameter(operation) != null && "update".equals(request.getParameter(operation))){
+            if (!duplicateData.isEmpty()) {
+                BrmsDependency data = (BrmsDependency) duplicateData.get(0);
+                if (request.getParameter(operation) != null && "update".equals(request.getParameter(operation))) {
                     brmsDependency.setId(data.getId());
-                }else if((request.getParameter(operation) != null && !"update".equals(request.getParameter(operation))) ||
-                        (request.getParameter(operation) == null && (data.getId() != brmsDependency.getId()))){
+                } else if ((request.getParameter(operation) != null
+                        && !"update".equals(request.getParameter(operation)))
+                        || (request.getParameter(operation) == null && (data.getId() != brmsDependency.getId()))) {
                     duplicateflag = true;
                 }
             }
             LOGGER.audit("the userId from the onap portal is: " + userId);
             String responseString = null;
-            if(brmsDependency.getDependency()!=null && !("").equals(brmsDependency.getDependency().trim())){
+            if (brmsDependency.getDependency() != null && !("").equals(brmsDependency.getDependency().trim())) {
                 PEDependency dependency = null;
-                try{
+                try {
                     dependency = PolicyUtils.jsonStringToObject(brmsDependency.getDependency(), PEDependency.class);
-                }catch(Exception e){
-                    LOGGER.error(XACMLErrorConstants.ERROR_SCHEMA_INVALID + "wrong data given for BRMS PEDependency Dictionary : " + brmsDependency.getDependency(),e);
+                } catch (Exception e) {
+                    LOGGER.error(XACMLErrorConstants.ERROR_SCHEMA_INVALID
+                            + "wrong data given for BRMS PEDependency Dictionary : " + brmsDependency.getDependency(),
+                            e);
                 }
-                if(dependency==null){
+                if (dependency == null) {
                     responseString = errorMessage;
-                }else{
-                    if(!duplicateflag){
+                } else {
+                    if (!duplicateflag) {
                         brmsDependency.setUserModifiedBy(userInfo);
-                        if(brmsDependency.getId() == 0){
+                        if (brmsDependency.getId() == 0) {
                             brmsDependency.setUserCreatedBy(userInfo);
                             commonClassDao.save(brmsDependency);
-                        }else{
+                        } else {
                             brmsDependency.setModifiedDate(new Date());
                             commonClassDao.update(brmsDependency);
                         }
-                        responseString = mapper.writeValueAsString(commonClassDao.getData(BRMSDependency.class));
-                    }else{
+                        responseString = mapper.writeValueAsString(commonClassDao.getData(BrmsDependency.class));
+                    } else {
                         responseString = duplicateResponseString;
                     }
                 }
             }
 
-            if(fromAPI){
-                if(responseString!=null && !duplicateResponseString.equals(responseString) && !errorMessage.equals(responseString)){
+            if (fromAPI) {
+                if (responseString != null && !duplicateResponseString.equals(responseString)
+                        && !errorMessage.equals(responseString)) {
                     responseString = successMsg;
                 }
                 ModelAndView result = new ModelAndView();
                 result.setViewName(responseString);
                 return result;
-            }else{
+            } else {
                 utils.setResponseData(response, brmsDependencyDatas, responseString);
             }
-        } catch (Exception e){
+        } catch (Exception e) {
             utils.setErrorResponseData(response, e);
         }
         return null;
     }
-    @RequestMapping(value={"/brms_dictionary/remove_brmsDependency"}, method={RequestMethod.POST})
-    public void removeBRMSDependencyDictionary(HttpServletRequest request, HttpServletResponse response) throws IOException {
+
+    @RequestMapping(value = {"/brms_dictionary/remove_brmsDependency"}, method = {RequestMethod.POST})
+    public void removeBRMSDependencyDictionary(HttpServletRequest request, HttpServletResponse response)
+            throws IOException {
         DictionaryUtils utils = getDictionaryUtilsInstance();
-        utils.removeData(request, response, brmsDependencyDatas, BRMSDependency.class);
+        utils.removeData(request, response, brmsDependencyDatas, BrmsDependency.class);
     }
-    
-    
-    @RequestMapping(value={"/get_BRMSControllerDataByName"}, method={RequestMethod.GET} , produces=MediaType.APPLICATION_JSON_VALUE)
-    public void getBRMSControllerDictionaryByNameEntityData(HttpServletResponse response){
+
+    @RequestMapping(
+            value = {"/get_BRMSControllerDataByName"},
+            method = {RequestMethod.GET},
+            produces = MediaType.APPLICATION_JSON_VALUE)
+    public void getBRMSControllerDictionaryByNameEntityData(HttpServletResponse response) {
         DictionaryUtils utils = getDictionaryUtilsInstance();
-        utils.getDataByEntity(response, brmsControllerDatas, controllerName, BRMSController.class);
+        utils.getDataByEntity(response, brmsControllerDatas, controllerName, BrmsController.class);
     }
-    
-    @RequestMapping(value={"/get_BRMSControllerData"}, method={RequestMethod.GET} , produces=MediaType.APPLICATION_JSON_VALUE)
-    public void getBRMSControllerDictionaryEntityData(HttpServletResponse response){
+
+    @RequestMapping(
+            value = {"/get_BRMSControllerData"},
+            method = {RequestMethod.GET},
+            produces = MediaType.APPLICATION_JSON_VALUE)
+    public void getBRMSControllerDictionaryEntityData(HttpServletResponse response) {
         DictionaryUtils utils = getDictionaryUtilsInstance();
-        utils.getData(response, brmsControllerDatas, BRMSController.class);
+        utils.getData(response, brmsControllerDatas, BrmsController.class);
     }
-    
-    @RequestMapping(value={"/brms_dictionary/save_BRMSControllerData"}, method={RequestMethod.POST})
-    public ModelAndView saveBRMSControllerDictionary(HttpServletRequest request, HttpServletResponse response) throws IOException{
+
+    @RequestMapping(value = {"/brms_dictionary/save_BRMSControllerData"}, method = {RequestMethod.POST})
+    public ModelAndView saveBRMSControllerDictionary(HttpServletRequest request, HttpServletResponse response)
+            throws IOException {
         DictionaryUtils utils = getDictionaryUtilsInstance();
         try {
             LOGGER.debug("DictionaryController:  saveBRMSControllerDictionary() is called");
@@ -304,81 +336,89 @@ public class BRMSDictionaryController{
             ObjectMapper mapper = new ObjectMapper();
             mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
             JsonNode root = mapper.readTree(request.getReader());
-            BRMSController brmsController;
+            BrmsController brmsController;
             String userId = null;
-            if(fromAPI){
-                brmsController = mapper.readValue(root.get(dictionaryFields).toString(), BRMSController.class);
+            if (fromAPI) {
+                brmsController = mapper.readValue(root.get(dictionaryFields).toString(), BrmsController.class);
                 userId = "API";
-            }else{
-                brmsController = mapper.readValue(root.get("brmsControllerDictionaryData").toString(), BRMSController.class);
+            } else {
+                brmsController =
+                        mapper.readValue(root.get("brmsControllerDictionaryData").toString(), BrmsController.class);
                 userId = root.get(userid).textValue();
             }
             UserInfo userInfo = utils.getUserInfo(userId);
 
-            List<Object> duplicateData =  commonClassDao.checkDuplicateEntry(brmsController.getControllerName(), controllerName, BRMSController.class);
+            List<Object> duplicateData = commonClassDao.checkDuplicateEntry(brmsController.getControllerName(),
+                    controllerName, BrmsController.class);
             boolean duplicateflag = false;
-            if(!duplicateData.isEmpty()){
-                BRMSController data = (BRMSController) duplicateData.get(0);
-                if(request.getParameter(operation) != null && "update".equals(request.getParameter(operation))){
+            if (!duplicateData.isEmpty()) {
+                BrmsController data = (BrmsController) duplicateData.get(0);
+                if (request.getParameter(operation) != null && "update".equals(request.getParameter(operation))) {
                     brmsController.setId(data.getId());
-                }else if((request.getParameter(operation) != null && !"update".equals(request.getParameter(operation))) ||
-                        (request.getParameter(operation) == null && (data.getId() != brmsController.getId()))){
+                } else if ((request.getParameter(operation) != null
+                        && !"update".equals(request.getParameter(operation)))
+                        || (request.getParameter(operation) == null && (data.getId() != brmsController.getId()))) {
                     duplicateflag = true;
                 }
             }
             String responseString = null;
-            if(brmsController.getController()!=null && !("").equals(brmsController.getController().trim())){
+            if (brmsController.getController() != null && !("").equals(brmsController.getController().trim())) {
                 PEDependency dependency = null;
-                try{
+                try {
                     dependency = PolicyUtils.jsonStringToObject(brmsController.getController(), PEDependency.class);
-                }catch(Exception e){
-                    LOGGER.error(XACMLErrorConstants.ERROR_SCHEMA_INVALID + "wrong data given for BRMS Controller Dictionary : " + brmsController.getController(),e);
+                } catch (Exception e) {
+                    LOGGER.error(XACMLErrorConstants.ERROR_SCHEMA_INVALID
+                            + "wrong data given for BRMS Controller Dictionary : " + brmsController.getController(), e);
                 }
-                if(dependency==null){
+                if (dependency == null) {
                     responseString = errorMessage;
-                }else{
-                    if(!duplicateflag){
+                } else {
+                    if (!duplicateflag) {
                         brmsController.setUserModifiedBy(userInfo);
-                        if(brmsController.getId() == 0){
+                        if (brmsController.getId() == 0) {
                             brmsController.setUserCreatedBy(userInfo);
                             commonClassDao.save(brmsController);
-                        }else{
+                        } else {
                             brmsController.setModifiedDate(new Date());
                             commonClassDao.update(brmsController);
                         }
                         responseString = mapper.writeValueAsString(commonClassDao.getData(OnapName.class));
-                    }else{
+                    } else {
                         responseString = duplicateResponseString;
                     }
                 }
             }
-            if(fromAPI){
-                if (responseString!=null && !(duplicateResponseString).equals(responseString) && !(errorMessage).equals(responseString)) {
+            if (fromAPI) {
+                if (responseString != null && !(duplicateResponseString).equals(responseString)
+                        && !(errorMessage).equals(responseString)) {
                     responseString = successMsg;
                 }
                 ModelAndView result = new ModelAndView();
                 result.setViewName(responseString);
                 return result;
-            }else{
+            } else {
                 utils.setResponseData(response, brmsControllerDatas, responseString);
             }
-        } catch (Exception e){
+        } catch (Exception e) {
             utils.setErrorResponseData(response, e);
         }
         return null;
     }
-    @RequestMapping(value={"/brms_dictionary/remove_brmsController"}, method={RequestMethod.POST})
-    public void removeBRMSControllerDictionary(HttpServletRequest request, HttpServletResponse response) throws IOException{
+
+    @RequestMapping(value = {"/brms_dictionary/remove_brmsController"}, method = {RequestMethod.POST})
+    public void removeBRMSControllerDictionary(HttpServletRequest request, HttpServletResponse response)
+            throws IOException {
         DictionaryUtils utils = getDictionaryUtilsInstance();
-        utils.removeData(request, response, brmsControllerDatas, BRMSController.class);
+        utils.removeData(request, response, brmsControllerDatas, BrmsController.class);
+    }
+
+    public BrmsDependency getDependencyDataByID(String dependencyName) {
+        return (BrmsDependency) commonClassDao.getEntityItem(BrmsDependency.class,
+                BRMSDictionaryController.dependencyName, dependencyName);
     }
-    
-    public BRMSDependency getDependencyDataByID(String dependencyName){
-        return (BRMSDependency) commonClassDao.getEntityItem(BRMSDependency.class, BRMSDictionaryController.dependencyName, dependencyName);
+
+    public BrmsController getControllerDataByID(String controllerName) {
+        return (BrmsController) commonClassDao.getEntityItem(BrmsController.class,
+                BRMSDictionaryController.controllerName, controllerName);
     }
-    
-    public BRMSController getControllerDataByID(String controllerName){
-        return (BRMSController) commonClassDao.getEntityItem(BRMSController.class, BRMSDictionaryController.controllerName, controllerName);
-    }  
 }