Fixed the Policy API issues and Bugfixes

[policy/engine.git] / ECOMP-PAP-REST / src / main / java / org / openecomp / policy / pap / xacml / rest / components / ActionPolicy.java

diff --git a/ECOMP-PAP-REST/src/main/java/org/openecomp/policy/pap/xacml/rest/components/ActionPolicy.java b/ECOMP-PAP-REST/src/main/java/org/openecomp/policy/pap/xacml/rest/components/ActionPolicy.java
index b6a959b..45ef01f 100644 (file)
--- a/ECOMP-PAP-REST/src/main/java/org/openecomp/policy/pap/xacml/rest/components/ActionPolicy.java
+++ b/ECOMP-PAP-REST/src/main/java/org/openecomp/policy/pap/xacml/rest/components/ActionPolicy.java
@@ -86,15 +86,15 @@ public class ActionPolicy extends Policy {
        public static final String URL_ATTRIBUTEID = "url";
        public static final String BODY_ATTRIBUTEID = "body";
        
-       public static boolean isAttribute = false;
+       private static boolean isAttribute = false;
 
        
-       List<String> dynamicLabelRuleAlgorithms = new LinkedList<String>();
-       List<String> dynamicFieldFunctionRuleAlgorithms = new LinkedList<String>();
-       List<String> dynamicFieldOneRuleAlgorithms = new LinkedList<String>();
-       List<String> dynamicFieldTwoRuleAlgorithms = new LinkedList<String>();
+       List<String> dynamicLabelRuleAlgorithms = new LinkedList<>();
+       List<String> dynamicFieldFunctionRuleAlgorithms = new LinkedList<>();
+       List<String> dynamicFieldOneRuleAlgorithms = new LinkedList<>();
+       List<String> dynamicFieldTwoRuleAlgorithms = new LinkedList<>();
        
-       protected Map<String, String> dropDownMap = new HashMap<String, String>();
+       protected Map<String, String> dropDownMap = new HashMap<>();
        
        
        public ActionPolicy() {
@@ -108,7 +108,7 @@ public class ActionPolicy extends Policy {
        @Override
        public Map<String, String> savePolicies() throws Exception {
                
-               Map<String, String> successMap = new HashMap<String,String>();
+               Map<String, String> successMap = new HashMap<>();
                if(isPolicyExists()){
                        successMap.put("EXISTS", "This Policy already exist on the PAP");
                        return successMap;
@@ -262,7 +262,7 @@ public class ActionPolicy extends Policy {
                                LOGGER.info("Action Body is succesfully saved at " + file.getAbsolutePath());
                        }
                } catch (IOException e) {
-                       e.printStackTrace();
+                       LOGGER.error("Exception Occured"+e);
                }
        }
        
@@ -328,8 +328,7 @@ public class ActionPolicy extends Policy {
 
                // Add JSON_URL Assignment:
                String actionBody = getActionPolicyDict(comboDictValue).getBody();
-               if (!actionBody.equals(null)) {
-               //if(!(actionBody==null || "".equals(actionBody))){
+               if (actionBody != null) {
                        AttributeAssignmentExpressionType assignmentJsonURL = new AttributeAssignmentExpressionType();
                        assignmentJsonURL.setAttributeId(BODY_ATTRIBUTEID);
                        assignmentJsonURL.setCategory(CATEGORY_RESOURCE);
@@ -342,7 +341,7 @@ public class ActionPolicy extends Policy {
                        obligation.getAttributeAssignmentExpression().add(assignmentJsonURL);
                }
 
-               if(!getActionPolicyDict(comboDictValue).getHeader().equals(null)){
+               if(getActionPolicyDict(comboDictValue).getHeader() != null){
                        String headerVal = getActionPolicyDict(comboDictValue).getHeader();
                        if(headerVal != null && !headerVal.equals("")){
                                // parse it on : to get number of headers
@@ -484,21 +483,23 @@ public class ActionPolicy extends Policy {
        
        private Map<String,String> createDropDownMap(){
                JPAUtils jpaUtils = null;
+               Map<String, String> dropDownMap = new HashMap<>();
                try {
                        jpaUtils = JPAUtils.getJPAUtilsInstance(XACMLPapServlet.getEmf());
                } catch (Exception e) {
-                       e.printStackTrace();
+                       LOGGER.error("Exception Occured"+e);
                }
-               Map<Datatype, List<FunctionDefinition>> functionMap = jpaUtils.getFunctionDatatypeMap();
-               Map<String, String> dropDownMap = new HashMap<String, String>();
-               for (Datatype id : functionMap.keySet()) {
-                       List<FunctionDefinition> functionDefinitions = (List<FunctionDefinition>) functionMap
-                                       .get(id);
-                       for (FunctionDefinition functionDef : functionDefinitions) {
-                               dropDownMap.put(functionDef.getShortname(),functionDef.getXacmlid());
+               if(jpaUtils != null){
+                       Map<Datatype, List<FunctionDefinition>> functionMap = jpaUtils.getFunctionDatatypeMap();
+                       
+                       for (Datatype id : functionMap.keySet()) {
+                               List<FunctionDefinition> functionDefinitions = (List<FunctionDefinition>) functionMap
+                                               .get(id);
+                               for (FunctionDefinition functionDef : functionDefinitions) {
+                                       dropDownMap.put(functionDef.getShortname(),functionDef.getXacmlid());
+                               }
                        }
                }
-               
                return dropDownMap;
        }