[COMMON] Fix "local var=XX" bashisms 16/126116/4
authorguillaume.lambert <guillaume.lambert@orange.com>
Tue, 7 Dec 2021 19:21:17 +0000 (20:21 +0100)
committerguillaume.lambert <guillaume.lambert@orange.com>
Wed, 8 Dec 2021 12:59:00 +0000 (13:59 +0100)
commitf657a816b9074f5bf2b3d300d93266269c1f05a5
treef639250c0375d2e8a7017e694342e38809155530
parent370c6dc33e55bfee7b3b79bcc21481b02a3f1e24
[COMMON] Fix "local var=XX" bashisms

Variable attribute 'local' is not POSIX but is LSB supported.
It is available in other shells such as ash or dash.
And in ksh, local is the default scope of functions vaiables.

Though, the syntax "local var=XX" is only supported and found in bash.
Sadly, this is not detected by checkbashims.

- fix "local var=XX" bashisms
- add a manual command in tox.ini to detect them in the CI

https://wiki.ubuntu.com/DashAsBinSh#local
https://wiki.ubuntu.com/DashAsBinSh#declare_or_typeset
https://stackoverflow.com/questions/12000949/scope-of-variables-in-ksh

Issue-ID: OOM-2643
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iff26e50cd352eeb760d923a4740a6f92184fe0f2
kubernetes/common/cassandra/resources/config/docker-entrypoint.sh
kubernetes/config/prepull_docker.sh
kubernetes/contrib/dns-server-for-vhost-ingress-testing/deploy_dns.sh
kubernetes/contrib/metallb-loadbalancer-inst/install-metallb-on-cluster.sh
kubernetes/portal/components/portal-mariadb/resources/config/mariadb/docker-entrypoint.sh
tox.ini